)]}'
{"openstack_health/api.py":[{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"69d134733a84d6b54517237427beb9612b21fb7f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        return abort(make_response(message, status_code))"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    if run_metadata_key \u003d\u003d \u0027node_region\u0027:"},{"line_number":250,"context_line":"        run_metadata_key \u003d \u0027build_node\u0027"},{"line_number":251,"context_line":"        value \u003d value + \u0027%\u0027"},{"line_number":252,"context_line":"        group_regions \u003d True"},{"line_number":253,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_721f505b","line":250,"updated":"2015-11-19 12:40:03.000000000","message":"Would it be possible to use a different name altogether here, so that we don\u0027t mutate the param that was passed in?","commit_id":"a4d30d16a17b62dff39ebc98fe92527d3e62e894"}],"openstack_health/run_aggregator.py":[{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"69d134733a84d6b54517237427beb9612b21fb7f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def _build_aggregated_runs(self, execution_datetime, updated_datetime,"},{"line_number":24,"context_line":"                               aggregated_runs):"},{"line_number":25,"context_line":"        if updated_datetime not in aggregated_runs:"},{"line_number":26,"context_line":"            if self.filter_to_region:"},{"line_number":27,"context_line":"                runs_dict \u003d {}"},{"line_number":28,"context_line":"                for meta_key in self.runs[execution_datetime]:"},{"line_number":29,"context_line":"                    split_key \u003d meta_key.split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_87007867","line":26,"updated":"2015-11-19 12:40:03.000000000","message":"The amount of conditionals you had to use to add the filter logic seems to indicate that this could be refactored a bit to separate out this logic.","commit_id":"a4d30d16a17b62dff39ebc98fe92527d3e62e894"},{"author":{"_account_id":18001,"name":"Caio Carrara","email":"ccarrara@thoughtworks.com","username":"caiocarrara"},"change_message_id":"d5f3565eb1b556bd1753708dc253ba44c44775ab","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    runs_dict[filtered_key] \u003d self.runs[execution_datetime]["},{"line_number":32,"context_line":"                        meta_key]"},{"line_number":33,"context_line":"                    aggregated_runs[updated_datetime] \u003d runs_dict"},{"line_number":34,"context_line":"            else:"},{"line_number":35,"context_line":"                runs_at_given_datetime \u003d self.runs[execution_datetime]"},{"line_number":36,"context_line":"                aggregated_runs[updated_datetime] \u003d runs_at_given_datetime"},{"line_number":37,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_b285b85a","line":34,"updated":"2015-11-19 12:42:41.000000000","message":"Perhaps, for someone who didn\u0027t know well the metadata key structure, isn\u0027t so clear why all this manipulation. I would suggest to put this logic in a separate function with a clear name representing its intent. And maybe this function could be used below where there is a similar process.\n\nAlso, maybe we could do not repeat the iteration over runs here, since it\u0027s already done below.\n\nI didn\u0027t understand exactly all this new flow added, but maybe we could structure it a bit better thinking about the intents of each code part.","commit_id":"a4d30d16a17b62dff39ebc98fe92527d3e62e894"}],"openstack_health/tests/test_api.py":[{"author":{"_account_id":18001,"name":"Caio Carrara","email":"ccarrara@thoughtworks.com","username":"caiocarrara"},"change_message_id":"d5f3565eb1b556bd1753708dc253ba44c44775ab","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                                         None,"},{"line_number":396,"context_line":"                                         None,"},{"line_number":397,"context_line":"                                         api.Session(),"},{"line_number":398,"context_line":"                                         relative_value_match\u003dFalse)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    @mock.patch(\u0027subunit2sql.db.api.get_time_series_runs_by_key_value\u0027,"},{"line_number":401,"context_line":"                return_value\u003d{"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_125044d3","line":398,"updated":"2015-11-19 12:42:41.000000000","message":"Instead of only keep current tests passing, wouldn\u0027t be good to add new tests to test the new flow added?","commit_id":"a4d30d16a17b62dff39ebc98fe92527d3e62e894"}]}