)]}'
{"app/js/services/view.js":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"88c6719019e9c4da1cd5ad2b357af43adfd451e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    { name: \u0027Second\u0027, key: \u0027sec\u0027, window: 0.01 },"},{"line_number":11,"context_line":"    { name: \u0027Minute\u0027, key: \u0027min\u0027, window: 0.5 },"},{"line_number":12,"context_line":"    { name: \u0027Hour\u0027, key: \u0027hour\u0027, window: 1 },"},{"line_number":13,"context_line":"    { name: \u0027Day\u0027, key: \u0027day\u0027, window: 2 }"},{"line_number":14,"context_line":"  ];"},{"line_number":15,"context_line":"  var resolution \u003d resolutionOptions[2];"},{"line_number":16,"context_line":"  var groupKey \u003d \u0027project\u0027;"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa69d971_571361b8","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":40},"updated":"2016-01-04 20:19:40.000000000","message":"If it was me I\u0027d make this 24 or something. Per day grouping lets us look at a much larger scale. But we can always adjust this in the future.\n\nAlthough playing with things locally we might have a smaller api response, but the db is slower because it\u0027s getting more data for the longer date range. (I am at a coffee shop, so it might just be the poor wifi)","commit_id":"f209fb6c3a358b07dfc12b3f147d78888d93e226"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"b0c0e5e834d5f00da791f178f613920fdf33cd35","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    { name: \u0027Second\u0027, key: \u0027sec\u0027, window: 0.01 },"},{"line_number":11,"context_line":"    { name: \u0027Minute\u0027, key: \u0027min\u0027, window: 0.5 },"},{"line_number":12,"context_line":"    { name: \u0027Hour\u0027, key: \u0027hour\u0027, window: 1 },"},{"line_number":13,"context_line":"    { name: \u0027Day\u0027, key: \u0027day\u0027, window: 2 }"},{"line_number":14,"context_line":"  ];"},{"line_number":15,"context_line":"  var resolution \u003d resolutionOptions[2];"},{"line_number":16,"context_line":"  var groupKey \u003d \u0027project\u0027;"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa69d971_3e7beff6","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":40},"in_reply_to":"fa69d971_571361b8","updated":"2016-01-05 22:27:21.000000000","message":"After playing around with values I\u0027m settling on 10 for now. This hits a ~6 month window for most views which seems to be what we want, more or less.\n\nI\u0027d like to follow up later with a much smarter implementation. Right now this is also limited to a minimum of 1 day which is still way too large a window for second resolution. If we can cleanly specify window sizes it should solve both issues at once.","commit_id":"f209fb6c3a358b07dfc12b3f147d78888d93e226"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"88c6719019e9c4da1cd5ad2b357af43adfd451e6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      var diff \u003d Math.ceil(resolution.window * days);"},{"line_number":31,"context_line":"      ret.setDate(ret.getDate() - diff);"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"      console.log(\u0027capping resolution of \u0027, days, \u0027 days to \u0027, diff);"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      return ret;"},{"line_number":36,"context_line":"    },"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa69d971_17d2c9d2","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":69},"updated":"2016-01-04 20:19:40.000000000","message":"Do we need to log this? I mean I guess theres no harm, but it seems kinda unnecessary.","commit_id":"f209fb6c3a358b07dfc12b3f147d78888d93e226"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"b0c0e5e834d5f00da791f178f613920fdf33cd35","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      var diff \u003d Math.ceil(resolution.window * days);"},{"line_number":31,"context_line":"      ret.setDate(ret.getDate() - diff);"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"      console.log(\u0027capping resolution of \u0027, days, \u0027 days to \u0027, diff);"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      return ret;"},{"line_number":36,"context_line":"    },"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa69d971_d3716c77","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":69},"in_reply_to":"fa69d971_17d2c9d2","updated":"2016-01-05 22:27:21.000000000","message":"Whoops, forgot to remove that before committing. Fixed.","commit_id":"f209fb6c3a358b07dfc12b3f147d78888d93e226"}]}