)]}'
{"app/js/controllers/tests-detail.js":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"dc8542d38dc5266889a94e3e314f76eda2c0ed6b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vm.searchTest \u003d $location.search().searchTest || \u0027\u0027;"},{"line_number":13,"context_line":"  vm.key \u003d decodeURIComponent(key);"},{"line_number":14,"context_line":"  vm.tests \u003d [];"},{"line_number":15,"context_line":"  vm.limit \u003d 100;"},{"line_number":16,"context_line":"  vm.offset \u003d 0;"},{"line_number":17,"context_line":"  vm.max \u003d 0;"},{"line_number":18,"context_line":"  vm.end \u003d false;"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_1c13c00e","line":15,"updated":"2016-03-30 05:12:00.000000000","message":"Is this 100 enough for our use case?\nI suppose users want to see whole of the tests results. So some projects(prefixes) like tempest, nova, etc have over 100 test cases. At that time, sorting and filtering is almost useless.","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"3741729c8787480b88b940ee47edc7d9e3ebfe52","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vm.searchTest \u003d $location.search().searchTest || \u0027\u0027;"},{"line_number":13,"context_line":"  vm.key \u003d decodeURIComponent(key);"},{"line_number":14,"context_line":"  vm.tests \u003d [];"},{"line_number":15,"context_line":"  vm.limit \u003d 100;"},{"line_number":16,"context_line":"  vm.offset \u003d 0;"},{"line_number":17,"context_line":"  vm.max \u003d 0;"},{"line_number":18,"context_line":"  vm.end \u003d false;"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_bdc899a9","line":15,"in_reply_to":"ba0121b8_1c13c00e","updated":"2016-03-30 20:51:12.000000000","message":"I agree, so I\u0027ve added a limit selector. That said we could even raise the default limit a fair bit without causing too much trouble, the page still feels fine at 500 results.","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9b53d1b9b1b93e3461bb3e98154628ccb0f501d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  vm.key \u003d decodeURIComponent(key);"},{"line_number":14,"context_line":"  vm.tests \u003d [];"},{"line_number":15,"context_line":"  vm.limit \u003d 100;"},{"line_number":16,"context_line":"  vm.limitOptions \u003d [100, 250, 500, 1000];"},{"line_number":17,"context_line":"  vm.offset \u003d 0;"},{"line_number":18,"context_line":"  vm.max \u003d 0;"},{"line_number":19,"context_line":"  vm.end \u003d false;"}],"source_content_type":"text/javascript","patch_set":5,"id":"ba0121b8_f5f85dc5","line":16,"updated":"2016-03-31 02:45:58.000000000","message":"People may want to higher limit like 10000 or 100000 when they would like to look at in one page.\nBut if so, we can improve it with later patches :)","commit_id":"12016682bbc8022b7253c5e529807e46fc99150c"}],"app/js/controllers/tests.js":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"dc8542d38dc5266889a94e3e314f76eda2c0ed6b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  };"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  healthService.getTestPrefixes().then(function(response) {"},{"line_number":19,"context_line":"    vm.processData(response.data);"},{"line_number":20,"context_line":"  });"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"controllersModule.controller(\u0027TestsController\u0027, TestsController);"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_3cffa468","line":19,"updated":"2016-03-30 05:12:00.000000000","message":"hmm, response data for solar is different entries by directories.. :(","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"3741729c8787480b88b940ee47edc7d9e3ebfe52","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  };"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  healthService.getTestPrefixes().then(function(response) {"},{"line_number":19,"context_line":"    vm.processData(response.data);"},{"line_number":20,"context_line":"  });"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"controllersModule.controller(\u0027TestsController\u0027, TestsController);"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_9d5dd57b","line":19,"in_reply_to":"ba0121b8_3cffa468","updated":"2016-03-30 20:51:12.000000000","message":"I updated the API methods patch to handle the \u0027/\u0027 characters properly. It\u0027s still a bit of an eyesore, but you can browse to the page without any trouble now.","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6eb87a8f44830bfcb1b4aab38d7bd0c9ee41296b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  };"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  healthService.getTestPrefixes().then(function(response) {"},{"line_number":19,"context_line":"    vm.processData(response.data);"},{"line_number":20,"context_line":"  });"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"controllersModule.controller(\u0027TestsController\u0027, TestsController);"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_95bc81dd","line":19,"in_reply_to":"ba0121b8_9d5dd57b","updated":"2016-03-31 02:44:31.000000000","message":"I can\u0027t find the patch right now. But I think it\u0027s not so big issue.","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"}],"app/views/tests-detail.html":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7acd2c31fb123a4cbcc7c1054f30d5aaee2acb81","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \u003ctable table-sort data\u003d\"testsDetail.tests\" class\u003d\"table table-hover default-cols\"\u003e"},{"line_number":45,"context_line":"                        \u003cthead\u003e"},{"line_number":46,"context_line":"                            \u003ctr\u003e"},{"line_number":47,"context_line":"                                \u003cth class\u003d\"text-center\" colspan\u003d\"5\"\u003e"},{"line_number":48,"context_line":"                                    Showing {{ testsDetail.offset + 1 }} -"},{"line_number":49,"context_line":"                                    {{ testsDetail.offset + testsDetail.tests.length }}"},{"line_number":50,"context_line":"                                    \u003cspan ng-if\u003d\"testsDetail.end\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"ba0121b8_992b6294","line":47,"updated":"2016-03-30 05:11:47.000000000","message":"This insertion seems like that makes an index of table-sort.\ne.g. when I click \u0027Test ID\u0027 column, its sort caret appears at \"Showing 1 - 100 of at least 100 tests\".","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"3741729c8787480b88b940ee47edc7d9e3ebfe52","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \u003ctable table-sort data\u003d\"testsDetail.tests\" class\u003d\"table table-hover default-cols\"\u003e"},{"line_number":45,"context_line":"                        \u003cthead\u003e"},{"line_number":46,"context_line":"                            \u003ctr\u003e"},{"line_number":47,"context_line":"                                \u003cth class\u003d\"text-center\" colspan\u003d\"5\"\u003e"},{"line_number":48,"context_line":"                                    Showing {{ testsDetail.offset + 1 }} -"},{"line_number":49,"context_line":"                                    {{ testsDetail.offset + testsDetail.tests.length }}"},{"line_number":50,"context_line":"                                    \u003cspan ng-if\u003d\"testsDetail.end\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"ba0121b8_19755c31","line":47,"in_reply_to":"ba0121b8_6f732081","updated":"2016-03-30 20:51:12.000000000","message":"Huh, good catch! For some reason just moving it to a panel-body never occurred to me, but that works much better. Fixed!","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"bc6dff980589e69a5c17731bd4ada788f00ed3bd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \u003ctable table-sort data\u003d\"testsDetail.tests\" class\u003d\"table table-hover default-cols\"\u003e"},{"line_number":45,"context_line":"                        \u003cthead\u003e"},{"line_number":46,"context_line":"                            \u003ctr\u003e"},{"line_number":47,"context_line":"                                \u003cth class\u003d\"text-center\" colspan\u003d\"5\"\u003e"},{"line_number":48,"context_line":"                                    Showing {{ testsDetail.offset + 1 }} -"},{"line_number":49,"context_line":"                                    {{ testsDetail.offset + testsDetail.tests.length }}"},{"line_number":50,"context_line":"                                    \u003cspan ng-if\u003d\"testsDetail.end\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"ba0121b8_6f732081","line":47,"in_reply_to":"ba0121b8_992b6294","updated":"2016-03-30 05:36:23.000000000","message":"So, how about moving these code to the above before/after the filter text box (not in this table)?","commit_id":"3c442ffe2e84b29ee318e597896897d7cc0f34ae"}]}