)]}'
{"openstack_health/api.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c10f9ee7aa9386c1cf089be74d3f5b236f544f50","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        elif not es_url or not query_dir:"},{"line_number":574,"context_line":"            health \u003d \u0027NotConfigured\u0027"},{"line_number":575,"context_line":"    else:"},{"line_number":576,"context_line":"        url \u003d classifier.es._url"},{"line_number":577,"context_line":"        es \u003d pyelasticsearch.ElasticSearch(url)"},{"line_number":578,"context_line":"        health \u003d {\u0027Configured\u0027: {\u0027elastic-search\u0027: es.health()[\u0027status\u0027]}}"},{"line_number":579,"context_line":"    return health"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_71071d82","line":576,"range":{"start_line":576,"start_character":28,"end_line":576,"end_character":32},"updated":"2016-05-23 08:35:03.000000000","message":"Can we access \u0027classifier.es_url\u0027 here? I think we should avoid to access \u0027_*\u0027 fields as much as possible.","commit_id":"9b1708dba665c0bc26c12018bd6104e5ec209484"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7e19cc945efcc8d1379db6ac083b699ffe414e80","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        elif not es_url or not query_dir:"},{"line_number":574,"context_line":"            health \u003d \u0027NotConfigured\u0027"},{"line_number":575,"context_line":"    else:"},{"line_number":576,"context_line":"        url \u003d classifier.es._url"},{"line_number":577,"context_line":"        es \u003d pyelasticsearch.ElasticSearch(url)"},{"line_number":578,"context_line":"        health \u003d {\u0027Configured\u0027: {\u0027elastic-search\u0027: es.health()[\u0027status\u0027]}}"},{"line_number":579,"context_line":"    return health"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_69fc3fb8","line":576,"range":{"start_line":576,"start_character":28,"end_line":576,"end_character":32},"in_reply_to":"bab6814e_71071d82","updated":"2016-05-23 14:56:23.000000000","message":"Yeah, that works too. I was just in tunnel vision mode when I wrote this and was trying to get around using our own local ElasticSearch object. When I found out it\u0027s used per method call in e-r I just used the url from there. I\u0027ll respin with a public url attr. Not that it really matters here since I\u0027m a maintainer of both projects and I can safely say private vs public is not something we actually care about in e-r.","commit_id":"9b1708dba665c0bc26c12018bd6104e5ec209484"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8fd494ea4b467410ffb043192a669bad8304f992","unresolved":false,"context_lines":[{"line_number":583,"context_line":"def get_status():"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    is_db_available \u003d _check_db_availability()"},{"line_number":586,"context_line":"    is_er_available \u003d _check_er_availability()"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    status \u003d {\u0027status\u0027: {\u0027availability\u0027: {"},{"line_number":589,"context_line":"        \u0027database\u0027: is_db_available,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d67cc2ed","line":586,"range":{"start_line":586,"start_character":4,"end_line":586,"end_character":19},"updated":"2016-05-24 07:15:55.000000000","message":"I feel \u0027is_xxxx\u0027 seems to be a boolean value but this is not. So I\u0027d prefer \u0027er_status\u0027 here.","commit_id":"3076768c6b5a58c71625c7eaa2f355eeb38ae704"}]}