)]}'
{"openstack_health/api.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7cd9bed18bbf54ce119d46f8c89ce2d7f0a66d1c","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            content \u003d \u0027Metadata page: %s\\n\u0027 % metadata_url"},{"line_number":464,"context_line":"            content +\u003d \u0027\\nJob Page %s\u0027 % job_url"},{"line_number":465,"context_line":"            entry.description(content)"},{"line_number":466,"context_line":"    response \u003d make_response(feeds[run_metadata_key][value].rss_str())"},{"line_number":467,"context_line":"    response.headers[\u0027Content-Type\u0027] \u003d \u0027application/xml; charset\u003dutf-8\u0027"},{"line_number":468,"context_line":"    return response"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_02894675","line":466,"updated":"2016-06-01 04:45:50.000000000","message":"I get that this is a flask thing, but how does this work? It\u0027s not like we import make_response() anywhere. Is the flask import modifying the global namespace to add this method?","commit_id":"f91cc92052cd0ed70f9bb7435081e73851379712"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"813709736235d86ad63f5029478086c651108a2c","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            content \u003d \u0027Metadata page: %s\\n\u0027 % metadata_url"},{"line_number":464,"context_line":"            content +\u003d \u0027\\nJob Page %s\u0027 % job_url"},{"line_number":465,"context_line":"            entry.description(content)"},{"line_number":466,"context_line":"    response \u003d make_response(feeds[run_metadata_key][value].rss_str())"},{"line_number":467,"context_line":"    response.headers[\u0027Content-Type\u0027] \u003d \u0027application/xml; charset\u003dutf-8\u0027"},{"line_number":468,"context_line":"    return response"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_45f7a0d2","line":466,"in_reply_to":"9abb7d3a_02894675","updated":"2016-06-01 22:35:18.000000000","message":"It looks like we already import make_response: https://github.com/openstack/openstack-health/blob/master/openstack_health/api.py#L33","commit_id":"f91cc92052cd0ed70f9bb7435081e73851379712"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"feaf25ad24c5a1f60bdc8224c320e11ac5ed53fb","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            content \u003d \u0027Metadata page: %s\\n\u0027 % metadata_url"},{"line_number":464,"context_line":"            content +\u003d \u0027\\nJob Page %s\u0027 % job_url"},{"line_number":465,"context_line":"            entry.description(content)"},{"line_number":466,"context_line":"    response \u003d make_response(feeds[run_metadata_key][value].rss_str())"},{"line_number":467,"context_line":"    response.headers[\u0027Content-Type\u0027] \u003d \u0027application/xml; charset\u003dutf-8\u0027"},{"line_number":468,"context_line":"    return response"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_4524c00b","line":466,"in_reply_to":"9abb7d3a_45f7a0d2","updated":"2016-06-01 22:40:37.000000000","message":"Oops missed that. That\u0027s what I get for reviewing things after midnight...","commit_id":"f91cc92052cd0ed70f9bb7435081e73851379712"}]}