)]}'
{"app/js/controllers/home.js":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b52760be588e92a195ba9542ebd19f55dba8f74c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if (vm.recentRuns[link].bugs.length \u003d\u003d\u003d 0) {"},{"line_number":151,"context_line":"          vm.recentRuns[link].bugs \u003d [];"},{"line_number":152,"context_line":"        } else {"},{"line_number":153,"context_line":"          vm.recentRuns[link].bugs \u003d vm.recentRuns[link].bugs.join().split(\u0027,\u0027);"},{"line_number":154,"context_line":"        }"},{"line_number":155,"context_line":"      }"},{"line_number":156,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_da438440","line":153,"updated":"2016-06-14 15:08:42.000000000","message":"I don\u0027t remember the data structure off the top of my head but could we just drop the .join() here and avoiding need to do a split()?","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4a4630eaf491c906b3a6d14b7b1be99077e1c534","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if (vm.recentRuns[link].bugs.length \u003d\u003d\u003d 0) {"},{"line_number":151,"context_line":"          vm.recentRuns[link].bugs \u003d [];"},{"line_number":152,"context_line":"        } else {"},{"line_number":153,"context_line":"          vm.recentRuns[link].bugs \u003d vm.recentRuns[link].bugs.join().split(\u0027,\u0027);"},{"line_number":154,"context_line":"        }"},{"line_number":155,"context_line":"      }"},{"line_number":156,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"5a9d85d2_cb6191aa","line":153,"in_reply_to":"5a9d85d2_bac46c92","updated":"2016-06-21 02:40:28.000000000","message":"Done","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"c1ba101f866d1f2fabb62c91e8d4d07d30278f02","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if (vm.recentRuns[link].bugs.length \u003d\u003d\u003d 0) {"},{"line_number":151,"context_line":"          vm.recentRuns[link].bugs \u003d [];"},{"line_number":152,"context_line":"        } else {"},{"line_number":153,"context_line":"          vm.recentRuns[link].bugs \u003d vm.recentRuns[link].bugs.join().split(\u0027,\u0027);"},{"line_number":154,"context_line":"        }"},{"line_number":155,"context_line":"      }"},{"line_number":156,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"5a9d85d2_bac46c92","line":153,"in_reply_to":"7aa08908_5236c2b4","updated":"2016-06-20 15:42:52.000000000","message":"If the goal is to explicitly flatten an array, I\u0027d recommend this instead: http://stackoverflow.com/a/10865042\n\nFlattening with `join().split(\u0027,\u0027)` uses some pretty surprising coincidental behavior and only works because the default join separator, the default array toString() behavior, and the user-specified split value all ended up being \u0027,\u0027. Behind the scenes it\u0027s running something more like\n\n    [[\u00271\u0027, \u00272\u0027], [\u00273\u0027, \u00274\u0027]].join()\n    -\u003e [\u00271\u0027, \u00272\u0027].toString() + \u0027,\u0027 + [\u00273\u0027, \u00274\u0027].toString()\n    -\u003e \u00271,2,3,4\u0027\n\n... which IMO is a bit non-obvious","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d3e8cc4c8d6f85dbd0f35ed52fe5d866b71d2186","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if (vm.recentRuns[link].bugs.length \u003d\u003d\u003d 0) {"},{"line_number":151,"context_line":"          vm.recentRuns[link].bugs \u003d [];"},{"line_number":152,"context_line":"        } else {"},{"line_number":153,"context_line":"          vm.recentRuns[link].bugs \u003d vm.recentRuns[link].bugs.join().split(\u0027,\u0027);"},{"line_number":154,"context_line":"        }"},{"line_number":155,"context_line":"      }"},{"line_number":156,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"7aa08908_5236c2b4","line":153,"in_reply_to":"7aa08908_da438440","updated":"2016-06-17 04:15:02.000000000","message":"I\u0027m actually unsure, but from the code, I guess the data structure could be nested like this\n\n [[\u0027111111111\u0027, \u002722222222\u0027],[\u002733333333\u0027,\u002744444444\u0027],[\u002755555555\u0027]]\n\nSo, I think join() and split() is easy way to be flattened.","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"}],"app/views/home.html":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"7e81853b5f69059d086a6e6407914223ba0e1220","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                              \u003cspan ng-if\u003d\"!!value.bugs\"\u003e"},{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"7aa08908_f4476cb9","line":95,"range":{"start_line":95,"start_character":58,"end_line":95,"end_character":71},"updated":"2016-06-14 17:39:01.000000000","message":"nit: this would benefit from a space (or maybe \u0026nbsp; if it doesn\u0027t take)","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4a4630eaf491c906b3a6d14b7b1be99077e1c534","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                              \u003cspan ng-if\u003d\"!!value.bugs\"\u003e"},{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"5a9d85d2_4b47611d","line":95,"range":{"start_line":95,"start_character":58,"end_line":95,"end_character":71},"in_reply_to":"5a9d85d2_66d0b054","updated":"2016-06-21 02:40:28.000000000","message":"Done","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"c1ba101f866d1f2fabb62c91e8d4d07d30278f02","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                              \u003cspan ng-if\u003d\"!!value.bugs\"\u003e"},{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"5a9d85d2_66d0b054","line":95,"range":{"start_line":95,"start_character":58,"end_line":95,"end_character":71},"in_reply_to":"7aa08908_b21a8616","updated":"2016-06-20 15:42:52.000000000","message":"I mean to say, I think \u0027Launchpad Bug: [space here] {{bug}}\u0027 would be a bit better, having no space between \u0027:\u0027 and \u0027#\u0027 in the tooltip seems a bit odd to me.","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d3e8cc4c8d6f85dbd0f35ed52fe5d866b71d2186","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                              \u003cspan ng-if\u003d\"!!value.bugs\"\u003e"},{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"7aa08908_b21a8616","line":95,"range":{"start_line":95,"start_character":58,"end_line":95,"end_character":71},"in_reply_to":"7aa08908_f4476cb9","updated":"2016-06-17 04:15:02.000000000","message":"Sorry, I don\u0027t catch your meaning. You suggest removing \u0027Bugs:#\u0027?","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"7e81853b5f69059d086a6e6407914223ba0e1220","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"},{"line_number":99,"context_line":"                              \u003cspan ng-if\u003d\"!value.bugs\"\u003e-\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"7aa08908_3414549e","line":96,"range":{"start_line":96,"start_character":51,"end_line":96,"end_character":88},"updated":"2016-06-14 17:39:01.000000000","message":"nit: same as above","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4a4630eaf491c906b3a6d14b7b1be99077e1c534","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                \u003ca ng-repeat\u003d\"bug in value.bugs\""},{"line_number":94,"context_line":"                                   href\u003d\"https://launchpad.net/bugs/{{bug}}\""},{"line_number":95,"context_line":"                                   uib-tooltip\u003d\"Launchpad Bugs:#{{bug}}\""},{"line_number":96,"context_line":"                                   target\u003d\"_blank\"\u003e{{bug}}\u003cfa name\u003d\"external-link\"\u003e\u003c/fa\u003e"},{"line_number":97,"context_line":"                                \u003c/a\u003e"},{"line_number":98,"context_line":"                              \u003c/span\u003e"},{"line_number":99,"context_line":"                              \u003cspan ng-if\u003d\"!value.bugs\"\u003e-\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"5a9d85d2_8b5149db","line":96,"range":{"start_line":96,"start_character":51,"end_line":96,"end_character":88},"in_reply_to":"7aa08908_3414549e","updated":"2016-06-21 02:40:28.000000000","message":"Done","commit_id":"813a1ffe0ef99c53c2acc46e993298d98268a917"}]}