)]}'
{"openstack_health/api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bd16336940333d348257a566ef11ac0a55e6273a","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                # NOTE(mtreinish) if no data is returned from the DB just"},{"line_number":700,"context_line":"                # return an empty set response, the test_run_aggregator"},{"line_number":701,"context_line":"                # function assumes data is present."},{"line_number":702,"context_line":"                return {\u0027numeric\u0027: {}, \u0027data\u0027: {}, \u0027failed_runs\u0027: {}}"},{"line_number":703,"context_line":"            test_runs \u003d\\"},{"line_number":704,"context_line":"                test_run_aggregator.convert_test_runs_list_to_time_series_dict("},{"line_number":705,"context_line":"                    db_test_runs, datetime_resolution)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_37b407f1","line":702,"updated":"2016-08-31 22:38:27.000000000","message":"In normal case(line 767), the returned value is jsonify-ed.\nIf the returning formats are different on the same method, that seems confused..\nCan we fix the problem on the caller side?","commit_id":"776c0a568377bb0fc531430eafc7ee584ed4a4ac"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"e63898ea0a3b6df25afb66c2a5e86df84a0ecd77","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                # NOTE(mtreinish) if no data is returned from the DB just"},{"line_number":700,"context_line":"                # return an empty set response, the test_run_aggregator"},{"line_number":701,"context_line":"                # function assumes data is present."},{"line_number":702,"context_line":"                return {\u0027numeric\u0027: {}, \u0027data\u0027: {}, \u0027failed_runs\u0027: {}}"},{"line_number":703,"context_line":"            test_runs \u003d\\"},{"line_number":704,"context_line":"                test_run_aggregator.convert_test_runs_list_to_time_series_dict("},{"line_number":705,"context_line":"                    db_test_runs, datetime_resolution)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e3de1a6c","line":702,"in_reply_to":"fa7ab95a_37b407f1","updated":"2016-09-01 22:27:48.000000000","message":"The \"normal case\" here needs to be in the inner function _get_data vs the outer function. The comparable return statement in this case is on line #764 where no \"jsonify(...)\" is used.\n\nIn other words, right now we\u0027re trying to return jsonify(jsonify(results)) on #767","commit_id":"776c0a568377bb0fc531430eafc7ee584ed4a4ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5d9b96b79026a1ab5a4e16e22f1a03fcc68dfb8c","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                # NOTE(mtreinish) if no data is returned from the DB just"},{"line_number":700,"context_line":"                # return an empty set response, the test_run_aggregator"},{"line_number":701,"context_line":"                # function assumes data is present."},{"line_number":702,"context_line":"                return {\u0027numeric\u0027: {}, \u0027data\u0027: {}, \u0027failed_runs\u0027: {}}"},{"line_number":703,"context_line":"            test_runs \u003d\\"},{"line_number":704,"context_line":"                test_run_aggregator.convert_test_runs_list_to_time_series_dict("},{"line_number":705,"context_line":"                    db_test_runs, datetime_resolution)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_69d10b57","line":702,"in_reply_to":"fa7ab95a_e3de1a6c","updated":"2016-09-01 23:44:04.000000000","message":"Ah, I missed #764. LGTM","commit_id":"776c0a568377bb0fc531430eafc7ee584ed4a4ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bd16336940333d348257a566ef11ac0a55e6273a","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        return test_runs"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"    results \u003d _get_data(test_id, start_date, stop_date)"},{"line_number":767,"context_line":"    return jsonify(results)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b71ad715","line":767,"updated":"2016-08-31 22:38:27.000000000","message":"here","commit_id":"776c0a568377bb0fc531430eafc7ee584ed4a4ac"}]}
