)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"fb9923d0ba759e66847373fe7756f4be381b99bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Show more data in terms of Totals at Job level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds Total number of Tests, Passed, Failed and % Pass"},{"line_number":10,"context_line":"for a given job in Jobs table."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes were made in two files:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_bf76e9d4","line":9,"updated":"2018-07-13 20:16:29.000000000","message":"Skipped tests too","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"},{"author":{"_account_id":27861,"name":"Mohan Seri","email":"mseri@suse.com","username":"mohanseri"},"change_message_id":"62b187f0a00b37de07c36b17f30791192932fc90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Show more data in terms of Totals at Job level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds Total number of Tests, Passed, Failed and % Pass"},{"line_number":10,"context_line":"for a given job in Jobs table."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes were made in two files:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_8140a437","line":9,"in_reply_to":"5f7c97a3_bf76e9d4","updated":"2018-08-06 18:28:16.000000000","message":"Yes. I will include skips too. Thanks","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"}],"app/js/controllers/grouped-runs.js":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"fb9923d0ba759e66847373fe7756f4be381b99bc","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            jobs[job.job_name].totalSkipped  \u003d totalTestsSkipped;"},{"line_number":120,"context_line":"            jobs[job.job_name].totalTests    \u003d totalTestsPassed + totalTestsFailed +"},{"line_number":121,"context_line":"                                                totalTestsSkipped;"},{"line_number":122,"context_line":"            jobs[job.job_name].totalPassRate \u003d ((totalTestsPassed + totalTestsSkipped) /"},{"line_number":123,"context_line":"                                                jobs[job.job_name].totalTests) * 100;"},{"line_number":124,"context_line":"          });"},{"line_number":125,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":7,"id":"5f7c97a3_1a528b13","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":44},"updated":"2018-07-13 20:16:29.000000000","message":"maybe just showing the fail rate would be better because this is hiding that skipped tests are considered as passing tests.\nor alternatively, show all 3 rates (pass, fail, skip)?","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"},{"author":{"_account_id":27861,"name":"Mohan Seri","email":"mseri@suse.com","username":"mohanseri"},"change_message_id":"62b187f0a00b37de07c36b17f30791192932fc90","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            jobs[job.job_name].totalSkipped  \u003d totalTestsSkipped;"},{"line_number":120,"context_line":"            jobs[job.job_name].totalTests    \u003d totalTestsPassed + totalTestsFailed +"},{"line_number":121,"context_line":"                                                totalTestsSkipped;"},{"line_number":122,"context_line":"            jobs[job.job_name].totalPassRate \u003d ((totalTestsPassed + totalTestsSkipped) /"},{"line_number":123,"context_line":"                                                jobs[job.job_name].totalTests) * 100;"},{"line_number":124,"context_line":"          });"},{"line_number":125,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":7,"id":"3f79a3b5_613228f4","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":44},"in_reply_to":"5f7c97a3_1a528b13","updated":"2018-08-06 18:28:16.000000000","message":"Thanks for reviewing. We can show all 3 but the table becomes crowded. I am going to exclude skips from totalPassRate and submit a new patch","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"}],"app/views/grouped-runs.html":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"fb9923d0ba759e66847373fe7756f4be381b99bc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                \u003cth sort-field\u003d\"passes\"\u003ePasses\u003c/th\u003e"},{"line_number":160,"context_line":"                                \u003cth sort-field\u003d\"failures\"\u003eFailures\u003c/th\u003e"},{"line_number":161,"context_line":"                                \u003cth sort-default sort-field\u003d\"failuresRate\"\u003e% Failures\u003c/th\u003e"},{"line_number":162,"context_line":"                                \u003cth sort-field\u003d\"totalTests\"\u003eTotal Tests\u003c/th\u003e"},{"line_number":163,"context_line":"                                \u003cth sort-field\u003d\"totalPass\"\u003eTotal Passed\u003c/th\u003e"},{"line_number":164,"context_line":"                                \u003cth sort-field\u003d\"totalFail\"\u003eTotal Failed\u003c/th\u003e"},{"line_number":165,"context_line":"                                \u003cth sort-field\u003d\"totalFail\"\u003eTotal Skipped\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"5f7c97a3_1a792b81","line":162,"updated":"2018-07-13 20:16:29.000000000","message":"should the sort-fields match the parameters on lines 176-180?\n\nI see some differences:\n  totalPass !\u003d totalPassed\n  totalFail !\u003d totalFailed\n  totalFail !\u003d totalSkipped\n  totalPass !\u003d totalPassRate","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"},{"author":{"_account_id":27861,"name":"Mohan Seri","email":"mseri@suse.com","username":"mohanseri"},"change_message_id":"62b187f0a00b37de07c36b17f30791192932fc90","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                \u003cth sort-field\u003d\"passes\"\u003ePasses\u003c/th\u003e"},{"line_number":160,"context_line":"                                \u003cth sort-field\u003d\"failures\"\u003eFailures\u003c/th\u003e"},{"line_number":161,"context_line":"                                \u003cth sort-default sort-field\u003d\"failuresRate\"\u003e% Failures\u003c/th\u003e"},{"line_number":162,"context_line":"                                \u003cth sort-field\u003d\"totalTests\"\u003eTotal Tests\u003c/th\u003e"},{"line_number":163,"context_line":"                                \u003cth sort-field\u003d\"totalPass\"\u003eTotal Passed\u003c/th\u003e"},{"line_number":164,"context_line":"                                \u003cth sort-field\u003d\"totalFail\"\u003eTotal Failed\u003c/th\u003e"},{"line_number":165,"context_line":"                                \u003cth sort-field\u003d\"totalFail\"\u003eTotal Skipped\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"3f79a3b5_e182b84f","line":162,"in_reply_to":"5f7c97a3_1a792b81","updated":"2018-08-06 18:28:16.000000000","message":"Agree. I will fix and submit new patch. Thanks!","commit_id":"aa7576d407b26a3e1056f102568c0f4b39a25765"}]}