)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4643a415d9bc1c411350531a8bc48236e88bf9e0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-05-16 09:46:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use oslo_serialization instead of the json module directly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9c7bdc4d9fdb55f07f716b2ed5204439fceceb5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_9e6b5bef","line":8,"updated":"2019-05-16 06:53:59.000000000","message":"Why should we use oslo_serialization instead of the json? Could you add the reason of that in the commit message?","commit_id":"6a716c5ee10682c73de0af14a07609fecb3f6242"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f0495b30cec0ae084536200b26d742cbbb99a000","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. oslo project provide jsonutils, and barbican use it in many place[1],"},{"line_number":10,"context_line":"this PS to update the remained json moudule to oslo jsonutils for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":"2. update the primary jsonutils to use alias json"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://github.com/openstack/barbican/search?utf8\u003d%E2%9C%93\u0026q\u003djsonutils\u0026type\u003d"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_e97bbff1","line":12,"updated":"2019-05-16 07:43:54.000000000","message":"Thanks for updating the commit message.\nBut I\u0027m still not sure the benefit of jsonutils here in openstack-health (or disadvantage of json).\n\nI feel that introducing an alias just increases complexity, basically.","commit_id":"18a1d1abc92a18b11ee9df2cfc5fd10ff0a795ee"},{"author":{"_account_id":30396,"name":"qian wang","email":"wang.qian@99cloud.net","username":"wang.qian"},"change_message_id":"3fe8f2f3d8a226c4cd4cb6037b9ff567b1fcd5a7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. oslo project provide jsonutils, and barbican use it in many place[1],"},{"line_number":10,"context_line":"this PS to update the remained json moudule to oslo jsonutils for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":"2. update the primary jsonutils to use alias json"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://github.com/openstack/barbican/search?utf8\u003d%E2%9C%93\u0026q\u003djsonutils\u0026type\u003d"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_5d837757","line":12,"in_reply_to":"bfb3d3c7_22130269","updated":"2019-05-17 02:49:23.000000000","message":"Thanks for your review.\n I think I need know more about oslo_serialization.\n I will abandon this review.\nThanks again for your review.","commit_id":"18a1d1abc92a18b11ee9df2cfc5fd10ff0a795ee"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a7695d55e4b422a22f7c60aa5dd6d78dc882842d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. oslo project provide jsonutils, and barbican use it in many place[1],"},{"line_number":10,"context_line":"this PS to update the remained json moudule to oslo jsonutils for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":"2. update the primary jsonutils to use alias json"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://github.com/openstack/barbican/search?utf8\u003d%E2%9C%93\u0026q\u003djsonutils\u0026type\u003d"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_22130269","line":12,"in_reply_to":"dfbec78f_4901ab05","updated":"2019-05-17 02:36:19.000000000","message":"Thanks. I\u0027m actually not familiar with oslo_serialization. So,\nI just wanted to know the benefit of this change. You say \u0027oslo_serialization is stronger than python\u0027s own json.\u0027 But I\u0027m not sure the concrete benefit here yet..\n\nYeah, probably, it might be able to reduce the changes in codes in the future. But this is just only one change. So, I think we will be able to fix it when it\u0027s needed.","commit_id":"18a1d1abc92a18b11ee9df2cfc5fd10ff0a795ee"},{"author":{"_account_id":30396,"name":"qian wang","email":"wang.qian@99cloud.net","username":"wang.qian"},"change_message_id":"311e6e0209206b4990bfd5b6ab969b6c4d82ea41","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. oslo project provide jsonutils, and barbican use it in many place[1],"},{"line_number":10,"context_line":"this PS to update the remained json moudule to oslo jsonutils for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":"2. update the primary jsonutils to use alias json"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://github.com/openstack/barbican/search?utf8\u003d%E2%9C%93\u0026q\u003djsonutils\u0026type\u003d"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_4901ab05","line":12,"in_reply_to":"dfbec78f_e97bbff1","updated":"2019-05-16 08:00:31.000000000","message":"Thanks for your review. \n\nI refer to other projects, they all use ‘from oslo_serialization import jsonutils’. I originally thought oslo_serialization is stronger than pyhon\u0027s own json.\n\nIntroducing an alias, could reduce the changes in codes.\n\nBut I am not very familiar with this project(openstack-health). If you feel that there is no need to modify it. I will give up this review.\n\nThank you again.","commit_id":"18a1d1abc92a18b11ee9df2cfc5fd10ff0a795ee"}]}