)]}'
{"fluent-logging/README.rst":[{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"each node and mounts the /var/lib/docker/containers directory. The Docker"},{"line_number":22,"context_line":"container runtime engine directs events posted to stdout and stderr to this"},{"line_number":23,"context_line":"directory on the host. Fluent-bit then forward the contents of that directory to"},{"line_number":24,"context_line":"Fluentd. Fluentd runs as deployment at the designated nodes and expose service"},{"line_number":25,"context_line":"for Fluent-bit to foward logs. Fluentd should then apply the Logstash format to"},{"line_number":26,"context_line":"the logs. Fluentd can also write kubernetes and OpenStack metadata to the logs."},{"line_number":27,"context_line":"Fluentd will then forward the results to Elasticsearch and to optionally kafka."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_a7be04fd","line":24,"updated":"2017-10-18 06:49:20.000000000","message":"Is it a valid scenario than someone would have more than one instance of fluentd? I\u0027m asking because of the restrictions of prometheus-fluentd plugin. Currently, we have one fluentd instance per node -  that means that (if we had prometheus-fluentd installed and configured) each instance exposes it\u0027s own REST API at ip:port/metrics with different values exposed, for example on nodeA we have 3 occurrences of \"Can\u0027t connect to MySQL\" log, and on nodeB we have no such occurrences. This in turn means that if we have a service on top of multiple fluentd instances, Prometheus will get different values for the number of occurrences of the aforementioned log depending on the actual fluentd pod that handled the request. Such a situation may improperly trigger an alarm if we watch for changes in the number of log occurrences.","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"36b70878336351275457d4698f97eeabb1222b11","unresolved":false,"context_lines":[{"line_number":21,"context_line":"each node and mounts the /var/lib/docker/containers directory. The Docker"},{"line_number":22,"context_line":"container runtime engine directs events posted to stdout and stderr to this"},{"line_number":23,"context_line":"directory on the host. Fluent-bit then forward the contents of that directory to"},{"line_number":24,"context_line":"Fluentd. Fluentd runs as deployment at the designated nodes and expose service"},{"line_number":25,"context_line":"for Fluent-bit to foward logs. Fluentd should then apply the Logstash format to"},{"line_number":26,"context_line":"the logs. Fluentd can also write kubernetes and OpenStack metadata to the logs."},{"line_number":27,"context_line":"Fluentd will then forward the results to Elasticsearch and to optionally kafka."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_6f7d5e1b","line":24,"in_reply_to":"3f4b6375_30135d10","updated":"2017-10-19 09:56:43.000000000","message":"Before addressing solution for prometheus-fluent plugin issue, I would like to discuss the design concept first. In “fluentbit-fluentd-es/kafka” design, the role of “fluentbit-fluentd” is log gathering pipeline. Especially, fluentd has aggregator role placed in the middle of pipeline here. It means someone can have a very flexible way to deploy fluentd instance(es) based on its gathering/aggregating requirements. Conceptually, if we want to generate alert, it should be either at the collecting edge (for fast alarm generation) or at the log store where all the logs are already gathered and indexed properly. In our case, it will be either at fluentbit or at elasticsearch. Having said that, putting effort to resolve the issue when using fluentd-prometheus plugin at fluentd might be not suitable for its log pipelinen design concept. \n\nI probably propose 1) making fluentbit-prometheus plugin for the fast alert generation (in this case, this alerts are solely based on logs from a single node), 2) using something like ElastAlert to generate alerts from elasticsearch (in this case, alerts can be based on a combined set of logs from different nodes).","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6f9b9834bdca177e716127aa3d059bcaca3d62f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"each node and mounts the /var/lib/docker/containers directory. The Docker"},{"line_number":22,"context_line":"container runtime engine directs events posted to stdout and stderr to this"},{"line_number":23,"context_line":"directory on the host. Fluent-bit then forward the contents of that directory to"},{"line_number":24,"context_line":"Fluentd. Fluentd runs as deployment at the designated nodes and expose service"},{"line_number":25,"context_line":"for Fluent-bit to foward logs. Fluentd should then apply the Logstash format to"},{"line_number":26,"context_line":"the logs. Fluentd can also write kubernetes and OpenStack metadata to the logs."},{"line_number":27,"context_line":"Fluentd will then forward the results to Elasticsearch and to optionally kafka."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_30135d10","line":24,"in_reply_to":"3f4b6375_a7be04fd","updated":"2017-10-18 14:58:09.000000000","message":"This assumes the service is being used as the kubernetes service discovery mechanism in Prometheus. I feel this scenario describes the use case for using the pod service discovery mechanism instead.","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"}],"fluent-logging/requirements.yaml":[{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"fa458a5a33b8d89cfd885efd47f759f6e79475aa","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"dependencies:"},{"line_number":17,"context_line":"  - name: helm-toolkit"},{"line_number":18,"context_line":"    repository: http://localhost:8879/charts/ "},{"line_number":19,"context_line":"    version: 0.1.0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_78c5143c","line":18,"range":{"start_line":18,"start_character":45,"end_line":18,"end_character":46},"updated":"2017-09-25 09:21:52.000000000","message":"pls remove trailing space","commit_id":"5c2cdad8e9c41db6b04ad64f7c17c7b83d9e226e"}],"fluent-logging/templates/configmap-bin.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: v1"},{"line_number":21,"context_line":"kind: ConfigMap"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: fluentd-bin"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  fluentd.sh: |"},{"line_number":26,"context_line":"{{ tuple \"bin/_fluentd.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_35f9a84c","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":19},"updated":"2017-09-26 19:43:22.000000000","message":"Since this chart contains multiple services, this would ideally be fluent-logging-bin instead. This would allow someone to override the fluent-bit command and entrypoint if desired.","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: v1"},{"line_number":21,"context_line":"kind: ConfigMap"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: fluentd-bin"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  fluentd.sh: |"},{"line_number":26,"context_line":"{{ tuple \"bin/_fluentd.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_19a7b40d","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":19},"in_reply_to":"7f515b1d_35f9a84c","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"}],"fluent-logging/templates/configmap-etc.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: fluentbit-etc"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  fluent-bit.conf: |+"},{"line_number":25,"context_line":"{{- tuple .Values.conf.fluentdbit \"etc/_fluent-bit.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_b5a2384a","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":21},"updated":"2017-09-26 19:43:22.000000000","message":"Similar to configmap-bin, this should be fluent-logging-bin as it contains configuration files for both services","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  name: fluentbit-etc"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  fluent-bit.conf: |+"},{"line_number":25,"context_line":"{{- tuple .Values.conf.fluentdbit \"etc/_fluent-bit.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_f99a98b6","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":21},"in_reply_to":"7f515b1d_b5a2384a","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  name: fluent-logging-etc"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  fluent-bit.conf: |+"},{"line_number":25,"context_line":"{{- tuple .Values.conf.fluentdbit \"etc/_fluent-bit.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"},{"line_number":26,"context_line":"  td-agent.conf: |+"},{"line_number":27,"context_line":"{{- tuple .Values.conf.td_agent \"etc/_td-agent.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_183019e8","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":33},"updated":"2017-10-13 13:35:24.000000000","message":"\u0027fluentbit\u0027 to match the corresponding entry in values.yaml","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  name: fluent-logging-etc"},{"line_number":23,"context_line":"data:"},{"line_number":24,"context_line":"  fluent-bit.conf: |+"},{"line_number":25,"context_line":"{{- tuple .Values.conf.fluentdbit \"etc/_fluent-bit.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"},{"line_number":26,"context_line":"  td-agent.conf: |+"},{"line_number":27,"context_line":"{{- tuple .Values.conf.td_agent \"etc/_td-agent.conf.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_87e918b8","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":33},"in_reply_to":"5f4e5783_183019e8","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"}],"fluent-logging/templates/daemonset-fluent-bit.yaml":[{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: fluentbit"},{"line_number":27,"context_line":"spec:"},{"line_number":28,"context_line":"{{ tuple $envAll \"fluentbit\" | include \"helm-toolkit.snippets.kubernetes_upgrades_daemonset\" | indent 2 }}"},{"line_number":29,"context_line":"  template:"},{"line_number":30,"context_line":"    metadata:"},{"line_number":31,"context_line":"      labels:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_ea960395","line":28,"updated":"2017-10-18 06:49:20.000000000","message":"I\u0027ve noticed that this section is not templated correctly (if you install the service with \u0027--dry-run\u0027 you\u0027ll see that there is only a new line character at this place). But I\u0027m not sure if it\u0027s your config that\u0027s incorrect or there is a bug somewhere is \u0027kubernetes_upgrades_daemonset\u0027 section","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: fluentbit"},{"line_number":27,"context_line":"spec:"},{"line_number":28,"context_line":"{{ tuple $envAll \"fluentbit\" | include \"helm-toolkit.snippets.kubernetes_upgrades_daemonset\" | indent 2 }}"},{"line_number":29,"context_line":"  template:"},{"line_number":30,"context_line":"    metadata:"},{"line_number":31,"context_line":"      labels:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_9e5b262d","line":28,"in_reply_to":"3f4b6375_ea960395","updated":"2017-10-19 13:11:45.000000000","message":"Done","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      containers:"},{"line_number":45,"context_line":"      - name: fluentbit"},{"line_number":46,"context_line":"        env:"},{"line_number":47,"context_line":"        - name: HOSTNAME12"},{"line_number":48,"context_line":"          value: fluentbit"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        image: {{ .Values.images.fluentbit }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_67d24c37","line":47,"updated":"2017-10-18 06:49:20.000000000","message":"Is it needed? :)","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      containers:"},{"line_number":45,"context_line":"      - name: fluentbit"},{"line_number":46,"context_line":"        env:"},{"line_number":47,"context_line":"        - name: HOSTNAME12"},{"line_number":48,"context_line":"          value: fluentbit"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        image: {{ .Values.images.fluentbit }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_1e3296f2","line":47,"in_reply_to":"3f4b6375_67d24c37","updated":"2017-10-19 13:11:45.000000000","message":"Done","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          mountPath: /fluent-bit/etc/fluent-bit.conf"},{"line_number":63,"context_line":"          subPath: fluent-bit.conf"},{"line_number":64,"context_line":"          readOnly: true"},{"line_number":65,"context_line":"{{ if $mounts_fluentbit.volumeMounts }}{{ toYaml $mounts_fluentbit.volumeMounts | indent 12 }}{{ end }}"},{"line_number":66,"context_line":"      volumes:"},{"line_number":67,"context_line":"      - name: config"},{"line_number":68,"context_line":"        hostPath:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_a7ef24e8","line":65,"updated":"2017-10-18 06:49:20.000000000","message":"indent 8","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":62,"context_line":"          mountPath: /fluent-bit/etc/fluent-bit.conf"},{"line_number":63,"context_line":"          subPath: fluent-bit.conf"},{"line_number":64,"context_line":"          readOnly: true"},{"line_number":65,"context_line":"{{ if $mounts_fluentbit.volumeMounts }}{{ toYaml $mounts_fluentbit.volumeMounts | indent 12 }}{{ end }}"},{"line_number":66,"context_line":"      volumes:"},{"line_number":67,"context_line":"      - name: config"},{"line_number":68,"context_line":"        hostPath:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_fe4c5a77","line":65,"in_reply_to":"3f4b6375_a7ef24e8","updated":"2017-10-19 13:11:45.000000000","message":"Done","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        configMap:"},{"line_number":78,"context_line":"          name: fluent-logging-etc"},{"line_number":79,"context_line":"          defaultMode: 0444"},{"line_number":80,"context_line":"{{ if $mounts_fluentbit.volumes }}{{ toYaml $mounts_fluentbit.volumes | indent 8 }}{{ end }}"},{"line_number":81,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_67bb6ce5","line":80,"updated":"2017-10-18 06:49:20.000000000","message":"indent 6","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"}],"fluent-logging/templates/deployment-fluentd.yaml":[{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"fa458a5a33b8d89cfd885efd47f759f6e79475aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.fluentd }}"},{"line_number":20,"context_line":"{{- $mounts_fluentd :\u003d .Values.pod.mounts.fluentd.fluentd }}"},{"line_number":21,"context_line":"{{- $mounts_fluentd_init :\u003d .Values.pod.mounts.fluentd.init_container }} "},{"line_number":22,"context_line":"--- "},{"line_number":23,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":24,"context_line":"kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_18306056","line":21,"range":{"start_line":21,"start_character":72,"end_line":21,"end_character":73},"updated":"2017-09-25 09:21:52.000000000","message":"pls remove trailing spaces","commit_id":"5c2cdad8e9c41db6b04ad64f7c17c7b83d9e226e"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":39,"context_line":"{{ tuple $envAll \"fluentd-aggregator\" \"fluentd\"  | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":40,"context_line":"      nodeSelector:"},{"line_number":41,"context_line":"        {{ .Values.labels.fluentd.node_selector_key }}: {{ .Values.labels.fluentd.node_selector_value }}"},{"line_number":42,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.metadata.timeout | default \"30\" }}"},{"line_number":43,"context_line":"      initContainers:"},{"line_number":44,"context_line":"{{ tuple $envAll $dependencies $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":45,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_e79ec3b6","line":42,"range":{"start_line":42,"start_character":87,"end_line":42,"end_character":95},"updated":"2017-09-26 19:43:22.000000000","message":"Looks like this is leftover from the nova values.yaml copy","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"{{ tuple $envAll \"fluentd-aggregator\" \"fluentd\"  | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":40,"context_line":"      nodeSelector:"},{"line_number":41,"context_line":"        {{ .Values.labels.fluentd.node_selector_key }}: {{ .Values.labels.fluentd.node_selector_value }}"},{"line_number":42,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.metadata.timeout | default \"30\" }}"},{"line_number":43,"context_line":"      initContainers:"},{"line_number":44,"context_line":"{{ tuple $envAll $dependencies $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":45,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_d9959c88","line":42,"range":{"start_line":42,"start_character":87,"end_line":42,"end_character":95},"in_reply_to":"7f515b1d_e79ec3b6","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          mountPath: /tmp/client.rb"},{"line_number":70,"context_line":"          subPath: client.rb"},{"line_number":71,"context_line":"          readOnly: true"},{"line_number":72,"context_line":"        - name: fluentd-bin"},{"line_number":73,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"},{"line_number":74,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":75,"context_line":"          readOnly: true"},{"line_number":76,"context_line":"{{ if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 12 }}{{ end }}"},{"line_number":77,"context_line":"      volumes:"},{"line_number":78,"context_line":"      - name: pod-etc-fluentd"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_07067fcf","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":24},"updated":"2017-09-26 19:43:22.000000000","message":"If kafka is being treated as optional, this mount should be optional","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4c97c2325519433a11d22e46a5300db8762a9eed","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          mountPath: /tmp/client.rb"},{"line_number":73,"context_line":"          subPath: client.rb"},{"line_number":74,"context_line":"          readOnly: true"},{"line_number":75,"context_line":"        - name: fluent-logging-bin"},{"line_number":76,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"},{"line_number":77,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":78,"context_line":"          readOnly: true"},{"line_number":79,"context_line":"{{ if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 12 }}{{ end }}"},{"line_number":80,"context_line":"      volumes:"},{"line_number":81,"context_line":"      - name: pod-etc-fluentd"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_ff021f09","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":24},"updated":"2017-10-04 17:37:36.000000000","message":"Should be conditionalized on whether kafka is enabled or not","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.deployment_fluentd }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.fluentd }}"},{"line_number":20,"context_line":"{{- $dependencies_with_kafka :\u003d .Values.dependencies.fluentd_with_kafka }}"},{"line_number":21,"context_line":"{{- $mounts_fluentd :\u003d .Values.pod.mounts.fluentd.fluentd }}"},{"line_number":22,"context_line":"{{- $mounts_fluentd_init :\u003d .Values.pod.mounts.fluentd.init_container }}"},{"line_number":23,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_58969195","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":74},"updated":"2017-10-13 13:35:24.000000000","message":"See comments wrt dependency overrides","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        {{ .Values.labels.fluentd.node_selector_key }}: {{ .Values.labels.fluentd.node_selector_value }}"},{"line_number":43,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.fluentd_aggregator.timeout | default \"30\" }}"},{"line_number":44,"context_line":"      initContainers:"},{"line_number":45,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":46,"context_line":"{{ tuple $envAll $dependencies_with_kafka $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":47,"context_line":"{{- else -}}"},{"line_number":48,"context_line":"{{ tuple $envAll $dependencies $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":49,"context_line":"{{- end }}"},{"line_number":50,"context_line":"      containers:"},{"line_number":51,"context_line":"      - name: fluentd"},{"line_number":52,"context_line":"        image: {{ .Values.images.fluentd }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_98808948","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":10},"updated":"2017-10-13 13:35:24.000000000","message":"I think this can just be handled with the standard dependencies entry, as the dependencies can be updated to include any checks for kafka via overrides for the dependency tree in values.yaml. Perhaps an example overrides file could be included to show how to update the dependencies to account for a kafka deployment.","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        {{ .Values.labels.fluentd.node_selector_key }}: {{ .Values.labels.fluentd.node_selector_value }}"},{"line_number":43,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.fluentd_aggregator.timeout | default \"30\" }}"},{"line_number":44,"context_line":"      initContainers:"},{"line_number":45,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":46,"context_line":"{{ tuple $envAll $dependencies_with_kafka $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":47,"context_line":"{{- else -}}"},{"line_number":48,"context_line":"{{ tuple $envAll $dependencies $mounts_fluentd_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":49,"context_line":"{{- end }}"},{"line_number":50,"context_line":"      containers:"},{"line_number":51,"context_line":"      - name: fluentd"},{"line_number":52,"context_line":"        image: {{ .Values.images.fluentd }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_ca2ef590","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":10},"in_reply_to":"5f4e5783_98808948","updated":"2017-10-17 07:12:46.000000000","message":"Although I can totally see your concern, I think it is better to keep this due to the following reason. Pls review my opinion and get back to me. This chart is designed to support 3rd party tools as well. I choose Kafka as a mediator for 3rd party. So Kafka is more important than other options and many values related to Kafka is already defined in Values.yaml. Value \u0027dependencies\u0027 is related to other values in Values.yaml, for example, \u0027endpoints.kafka\u0027.","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":79,"context_line":"          readOnly: true"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 12 }}{{- end }}"},{"line_number":82,"context_line":"      volumes:"},{"line_number":83,"context_line":"      - name: pod-etc-fluentd"},{"line_number":84,"context_line":"        emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_675fece5","line":81,"updated":"2017-10-18 06:49:20.000000000","message":"indent 8","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":78,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":79,"context_line":"          readOnly: true"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 12 }}{{- end }}"},{"line_number":82,"context_line":"      volumes:"},{"line_number":83,"context_line":"      - name: pod-etc-fluentd"},{"line_number":84,"context_line":"        emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_22053ec3","line":81,"in_reply_to":"3f4b6375_675fece5","updated":"2017-10-19 13:11:45.000000000","message":"Done","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        configMap:"},{"line_number":91,"context_line":"          name: fluent-logging-bin"},{"line_number":92,"context_line":"          defaultMode: 0555"},{"line_number":93,"context_line":"{{- if $mounts_fluentd.volumes }}{{ toYaml $mounts_fluentd.volumes | indent 8 }}{{- end }}"},{"line_number":94,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_2759f4fd","line":93,"updated":"2017-10-18 06:49:20.000000000","message":"indent 6","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        configMap:"},{"line_number":91,"context_line":"          name: fluent-logging-bin"},{"line_number":92,"context_line":"          defaultMode: 0555"},{"line_number":93,"context_line":"{{- if $mounts_fluentd.volumes }}{{ toYaml $mounts_fluentd.volumes | indent 8 }}{{- end }}"},{"line_number":94,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_e20e06e4","line":93,"in_reply_to":"3f4b6375_2759f4fd","updated":"2017-10-19 13:11:45.000000000","message":"Done","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"}],"fluent-logging/templates/etc/_fluent-bit.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"},{"line_number":17,"context_line":"    Match         *"},{"line_number":18,"context_line":"    Host          {{ .Values.endpoints.fluentd_aggregator.hosts.default }}"},{"line_number":19,"context_line":"    Port          {{ .Values.endpoints.fluentd_aggregator.port.fluentd.default }}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_27fe1bae","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":74},"updated":"2017-09-26 19:43:22.000000000","message":"This should be retrieved with the endpoint lookup function","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"},{"line_number":17,"context_line":"    Match         *"},{"line_number":18,"context_line":"    Host          {{ .Values.endpoints.fluentd_aggregator.hosts.default }}"},{"line_number":19,"context_line":"    Port          {{ .Values.endpoints.fluentd_aggregator.port.fluentd.default }}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_b990a096","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":74},"in_reply_to":"7f515b1d_27fe1bae","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    Flush          1"},{"line_number":3,"context_line":"    Daemon         Off"},{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"},{"line_number":8,"context_line":"    Name           tail"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_9f93ebfa","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":31},"updated":"2017-10-22 17:35:49.000000000","message":"This should be made available via a mount in the configmap so we can see which parsers are available by default, and provide the ability to override them if necessary.","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    Flush          1"},{"line_number":3,"context_line":"    Daemon         Off"},{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"},{"line_number":8,"context_line":"    Name           tail"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_45eb3ddb","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":31},"in_reply_to":"3f4b6375_9f93ebfa","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"},{"line_number":8,"context_line":"    Name           tail"},{"line_number":9,"context_line":"    Tag            kube.*"},{"line_number":10,"context_line":"    Path           /var/log/containers/*.log"},{"line_number":11,"context_line":"    Parser         docker"},{"line_number":12,"context_line":"    DB             /var/log/flb_kube.db"},{"line_number":13,"context_line":"    Mem_Buf_Limit  5MB"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_7f8eefd0","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":22},"updated":"2017-10-22 17:35:49.000000000","message":"This will provide the kube.* tag for parsing the kubernetes metadata, but we need to include the definitions for filtering on that information.  Seems the default can be found here:  https://github.com/fluent/fluent-bit-kubernetes-daemonset/blob/master/docker-image/fluent-bit.conf#L15","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"},{"line_number":8,"context_line":"    Name           tail"},{"line_number":9,"context_line":"    Tag            kube.*"},{"line_number":10,"context_line":"    Path           /var/log/containers/*.log"},{"line_number":11,"context_line":"    Parser         docker"},{"line_number":12,"context_line":"    DB             /var/log/flb_kube.db"},{"line_number":13,"context_line":"    Mem_Buf_Limit  5MB"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_86e25c9f","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":22},"in_reply_to":"3f4b6375_7f8eefd0","updated":"2017-10-24 11:48:32.000000000","message":"The filter is currently not working properly. So I send the function to the fluentd filter. We can fix it after making the plugin work properly.","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"}],"fluent-logging/templates/etc/_td-agent.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003cmatch ** \u003e"},{"line_number":25,"context_line":"  @type copy"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  \u003cstore\u003e"},{"line_number":28,"context_line":"    @type kafka_buffered"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # list of seed brokers"},{"line_number":31,"context_line":"    brokers {{ .Values.conf.fluentd.kafka.host }}:{{- .Values.conf.fluentd.kafka.port }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # buffer settings"},{"line_number":34,"context_line":"    buffer_type file"},{"line_number":35,"context_line":"    buffer_path /var/log/td-agent/buffer/td"},{"line_number":36,"context_line":"    flush_interval 3s"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # topic settings"},{"line_number":39,"context_line":"    default_topic  {{ .Values.conf.fluentd.kafka.topic }}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # data type settings"},{"line_number":42,"context_line":"    output_data_type json"},{"line_number":43,"context_line":"    compression_codec gzip"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # producer settings"},{"line_number":46,"context_line":"    max_send_retries 1"},{"line_number":47,"context_line":"    required_acks -1"},{"line_number":48,"context_line":"  \u003c/store\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  \u003cstore\u003e"},{"line_number":51,"context_line":"    @type elasticsearch"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_07bd5fd7","line":48,"range":{"start_line":27,"start_character":0,"end_line":48,"end_character":10},"updated":"2017-09-26 19:43:22.000000000","message":"With kafka being treated as optional, this should be within a conditional check. That does present concerns with the copy @type as well","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003cmatch ** \u003e"},{"line_number":25,"context_line":"  @type copy"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  \u003cstore\u003e"},{"line_number":28,"context_line":"    @type kafka_buffered"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # list of seed brokers"},{"line_number":31,"context_line":"    brokers {{ .Values.conf.fluentd.kafka.host }}:{{- .Values.conf.fluentd.kafka.port }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # buffer settings"},{"line_number":34,"context_line":"    buffer_type file"},{"line_number":35,"context_line":"    buffer_path /var/log/td-agent/buffer/td"},{"line_number":36,"context_line":"    flush_interval 3s"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # topic settings"},{"line_number":39,"context_line":"    default_topic  {{ .Values.conf.fluentd.kafka.topic }}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # data type settings"},{"line_number":42,"context_line":"    output_data_type json"},{"line_number":43,"context_line":"    compression_codec gzip"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # producer settings"},{"line_number":46,"context_line":"    max_send_retries 1"},{"line_number":47,"context_line":"    required_acks -1"},{"line_number":48,"context_line":"  \u003c/store\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  \u003cstore\u003e"},{"line_number":51,"context_line":"    @type elasticsearch"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_39f27007","line":48,"range":{"start_line":27,"start_character":0,"end_line":48,"end_character":10},"in_reply_to":"7f515b1d_07bd5fd7","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  \u003cstore\u003e"},{"line_number":51,"context_line":"    @type elasticsearch"},{"line_number":52,"context_line":"    include_tag_key true"},{"line_number":53,"context_line":"    host {{ .Values.conf.fluentd.elasticsearch.host }}"},{"line_number":54,"context_line":"    port {{ .Values.conf.fluentd.elasticsearch.port }}"},{"line_number":55,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_c7b627fb","line":53,"range":{"start_line":53,"start_character":9,"end_line":53,"end_character":54},"updated":"2017-09-26 19:43:22.000000000","message":"Should be handled with endpoint lookup functions, whether directly or through an env entry for the pod","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  \u003cstore\u003e"},{"line_number":51,"context_line":"    @type elasticsearch"},{"line_number":52,"context_line":"    include_tag_key true"},{"line_number":53,"context_line":"    host {{ .Values.conf.fluentd.elasticsearch.host }}"},{"line_number":54,"context_line":"    port {{ .Values.conf.fluentd.elasticsearch.port }}"},{"line_number":55,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f515b1d_19f574ed","line":53,"range":{"start_line":53,"start_character":9,"end_line":53,"end_character":54},"in_reply_to":"7f515b1d_c7b627fb","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # buffer settings"},{"line_number":35,"context_line":"    buffer_type file"},{"line_number":36,"context_line":"    buffer_path /var/log/td-agent/buffer/td"},{"line_number":37,"context_line":"    flush_interval 3s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # topic settings"},{"line_number":40,"context_line":"    default_topic  {{ .Values.conf.fluentd.kafka.topic_name }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_98ce49b2","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":21},"updated":"2017-10-13 13:35:24.000000000","message":"This should be configurable via values","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # buffer settings"},{"line_number":35,"context_line":"    buffer_type file"},{"line_number":36,"context_line":"    buffer_path /var/log/td-agent/buffer/td"},{"line_number":37,"context_line":"    flush_interval 3s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # topic settings"},{"line_number":40,"context_line":"    default_topic  {{ .Values.conf.fluentd.kafka.topic_name }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_47ca004e","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":21},"in_reply_to":"5f4e5783_98ce49b2","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    port {{ tuple \"elasticsearch\" \"elasticsearch\"  \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":57,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set the chunk limit the same as for fluentd-gcp."},{"line_number":60,"context_line":"    buffer_chunk_limit 2M"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Cap buffer memory usage to 2MiB/chunk * 32 chunks \u003d 64 MiB"},{"line_number":63,"context_line":"    buffer_queue_limit 32"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Flush buffer every 30s to write to Elasticsearch"},{"line_number":66,"context_line":"    flush_interval 30s"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Never wait longer than 5 minutes between retries."},{"line_number":69,"context_line":"    max_retry_wait 300"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # Disable the limit on the number of retries (retry forever)."},{"line_number":72,"context_line":"    disable_retry_limit"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # Use multiple threads for processing."},{"line_number":75,"context_line":"    num_threads 8"},{"line_number":76,"context_line":"{{ if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":77,"context_line":"  \u003c/store\u003e"},{"line_number":78,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_5849f12e","line":75,"range":{"start_line":59,"start_character":0,"end_line":75,"end_character":17},"updated":"2017-10-13 13:35:24.000000000","message":"These should also be configurable via overrides","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    port {{ tuple \"elasticsearch\" \"elasticsearch\"  \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":57,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set the chunk limit the same as for fluentd-gcp."},{"line_number":60,"context_line":"    buffer_chunk_limit 2M"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Cap buffer memory usage to 2MiB/chunk * 32 chunks \u003d 64 MiB"},{"line_number":63,"context_line":"    buffer_queue_limit 32"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Flush buffer every 30s to write to Elasticsearch"},{"line_number":66,"context_line":"    flush_interval 30s"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Never wait longer than 5 minutes between retries."},{"line_number":69,"context_line":"    max_retry_wait 300"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # Disable the limit on the number of retries (retry forever)."},{"line_number":72,"context_line":"    disable_retry_limit"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # Use multiple threads for processing."},{"line_number":75,"context_line":"    num_threads 8"},{"line_number":76,"context_line":"{{ if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":77,"context_line":"  \u003c/store\u003e"},{"line_number":78,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_07c08829","line":75,"range":{"start_line":59,"start_character":0,"end_line":75,"end_character":17},"in_reply_to":"5f4e5783_5849f12e","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  bind 0.0.0.0"},{"line_number":18,"context_line":"\u003c/source\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\u003cfilter kube.**\u003e"},{"line_number":21,"context_line":"  type kubernetes_metadata"},{"line_number":22,"context_line":"\u003c/filter\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\u003cmatch ** \u003e"},{"line_number":25,"context_line":"{{ if .Values.conf.fluentd.kafka.enabled }}"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_3fc2b7ea","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":9},"updated":"2017-10-22 17:35:49.000000000","message":"If we\u0027re using fluentd as a mechanism for forwarding the logs collected from fluent-bit, this filtering and metadata should be handled in fluent-bit. As far as I\u0027m aware, the plugin is available by default in the fluent-bit image, and not all fluentd images are guaranteed to have the kubernetes plugin","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    include_tag_key true"},{"line_number":55,"context_line":"    host {{ tuple \"elasticsearch\" \"elasticsearch\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":56,"context_line":"    port {{ tuple \"elasticsearch\" \"elasticsearch\"  \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":57,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set the chunk limit the same as for fluentd-gcp."},{"line_number":60,"context_line":"    buffer_chunk_limit {{ .Values.conf.fluentd.elasticsearch.buffer_chunk_limit }}"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_dfb28394","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":69},"updated":"2017-10-22 17:35:49.000000000","message":"Would this ever need to be anything else?","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    include_tag_key true"},{"line_number":55,"context_line":"    host {{ tuple \"elasticsearch\" \"elasticsearch\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":56,"context_line":"    port {{ tuple \"elasticsearch\" \"elasticsearch\"  \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":57,"context_line":"    logstash_format {{ .Values.conf.fluentd.elasticsearch.logstash }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set the chunk limit the same as for fluentd-gcp."},{"line_number":60,"context_line":"    buffer_chunk_limit {{ .Values.conf.fluentd.elasticsearch.buffer_chunk_limit }}"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3f4b6375_95203c4a","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":69},"in_reply_to":"3f4b6375_dfb28394","updated":"2017-10-24 11:48:32.000000000","message":"it is from the configuration file on docker image","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"}],"fluent-logging/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":35,"context_line":"  pull_policy: IfNotPresent"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"bootstrap:"},{"line_number":38,"context_line":"  enabled: false"},{"line_number":39,"context_line":"  script: null"},{"line_number":40,"context_line":"  flavors:"},{"line_number":41,"context_line":"    enabled: true"},{"line_number":42,"context_line":"    options:"},{"line_number":43,"context_line":"      m1_tiny:"},{"line_number":44,"context_line":"          name: \u0027m1.tiny\u0027"},{"line_number":45,"context_line":"          id: \u0027auto\u0027"},{"line_number":46,"context_line":"          ram: 512"},{"line_number":47,"context_line":"          disk: 1"},{"line_number":48,"context_line":"          vcpus: 1"},{"line_number":49,"context_line":"      m1_small:"},{"line_number":50,"context_line":"          name: \u0027m1.small\u0027"},{"line_number":51,"context_line":"          id: \u0027auto\u0027"},{"line_number":52,"context_line":"          ram: 2048"},{"line_number":53,"context_line":"          disk: 20"},{"line_number":54,"context_line":"          vcpus: 1"},{"line_number":55,"context_line":"      m1_medium:"},{"line_number":56,"context_line":"          name: \u0027m1.medium\u0027"},{"line_number":57,"context_line":"          id: \u0027auto\u0027"},{"line_number":58,"context_line":"          ram: 4096"},{"line_number":59,"context_line":"          disk: 40"},{"line_number":60,"context_line":"          vcpus: 2"},{"line_number":61,"context_line":"      m1_large:"},{"line_number":62,"context_line":"          name: \u0027m1.large\u0027"},{"line_number":63,"context_line":"          id: \u0027auto\u0027"},{"line_number":64,"context_line":"          ram: 8192"},{"line_number":65,"context_line":"          disk: 80"},{"line_number":66,"context_line":"          vcpus: 4"},{"line_number":67,"context_line":"      m1_xlarge:"},{"line_number":68,"context_line":"          name: \u0027m1.xlarge\u0027"},{"line_number":69,"context_line":"          id: \u0027auto\u0027"},{"line_number":70,"context_line":"          ram: 16384"},{"line_number":71,"context_line":"          disk: 160"},{"line_number":72,"context_line":"          vcpus: 8"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"dependencies:"},{"line_number":75,"context_line":"  fluentd:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_6779b32d","line":72,"range":{"start_line":37,"start_character":0,"end_line":72,"end_character":18},"updated":"2017-09-26 19:43:22.000000000","message":"This can all be removed","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":35,"context_line":"  pull_policy: IfNotPresent"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"bootstrap:"},{"line_number":38,"context_line":"  enabled: false"},{"line_number":39,"context_line":"  script: null"},{"line_number":40,"context_line":"  flavors:"},{"line_number":41,"context_line":"    enabled: true"},{"line_number":42,"context_line":"    options:"},{"line_number":43,"context_line":"      m1_tiny:"},{"line_number":44,"context_line":"          name: \u0027m1.tiny\u0027"},{"line_number":45,"context_line":"          id: \u0027auto\u0027"},{"line_number":46,"context_line":"          ram: 512"},{"line_number":47,"context_line":"          disk: 1"},{"line_number":48,"context_line":"          vcpus: 1"},{"line_number":49,"context_line":"      m1_small:"},{"line_number":50,"context_line":"          name: \u0027m1.small\u0027"},{"line_number":51,"context_line":"          id: \u0027auto\u0027"},{"line_number":52,"context_line":"          ram: 2048"},{"line_number":53,"context_line":"          disk: 20"},{"line_number":54,"context_line":"          vcpus: 1"},{"line_number":55,"context_line":"      m1_medium:"},{"line_number":56,"context_line":"          name: \u0027m1.medium\u0027"},{"line_number":57,"context_line":"          id: \u0027auto\u0027"},{"line_number":58,"context_line":"          ram: 4096"},{"line_number":59,"context_line":"          disk: 40"},{"line_number":60,"context_line":"          vcpus: 2"},{"line_number":61,"context_line":"      m1_large:"},{"line_number":62,"context_line":"          name: \u0027m1.large\u0027"},{"line_number":63,"context_line":"          id: \u0027auto\u0027"},{"line_number":64,"context_line":"          ram: 8192"},{"line_number":65,"context_line":"          disk: 80"},{"line_number":66,"context_line":"          vcpus: 4"},{"line_number":67,"context_line":"      m1_xlarge:"},{"line_number":68,"context_line":"          name: \u0027m1.xlarge\u0027"},{"line_number":69,"context_line":"          id: \u0027auto\u0027"},{"line_number":70,"context_line":"          ram: 16384"},{"line_number":71,"context_line":"          disk: 160"},{"line_number":72,"context_line":"          vcpus: 8"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"dependencies:"},{"line_number":75,"context_line":"  fluentd:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_b9e5403a","line":72,"range":{"start_line":37,"start_character":0,"end_line":72,"end_character":18},"in_reply_to":"7f515b1d_6779b32d","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    services:"},{"line_number":77,"context_line":"    - service: elasticsearch-logging"},{"line_number":78,"context_line":"      endpoint: default"},{"line_number":79,"context_line":"    - service: kafka-logging"},{"line_number":80,"context_line":"      endpoint: default"},{"line_number":81,"context_line":"  fluentbit:"},{"line_number":82,"context_line":"    services:"},{"line_number":83,"context_line":"    - service: fluentd-aggregator"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_47ad9786","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":23},"updated":"2017-09-26 19:43:22.000000000","message":"Shouldnt be a dependency if kafka is optional","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    services:"},{"line_number":77,"context_line":"    - service: elasticsearch-logging"},{"line_number":78,"context_line":"      endpoint: default"},{"line_number":79,"context_line":"    - service: kafka-logging"},{"line_number":80,"context_line":"      endpoint: default"},{"line_number":81,"context_line":"  fluentbit:"},{"line_number":82,"context_line":"    services:"},{"line_number":83,"context_line":"    - service: fluentd-aggregator"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_59d88c79","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":23},"in_reply_to":"7f515b1d_47ad9786","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    services:"},{"line_number":87,"context_line":"    - service: elasticsearch-logging"},{"line_number":88,"context_line":"      endpoint: default"},{"line_number":89,"context_line":"    - service: kafka-logging"},{"line_number":90,"context_line":"      endpoint: default"},{"line_number":91,"context_line":"    - service: fluentd-aggregator"},{"line_number":92,"context_line":"      endpoint: default"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_c7e747e4","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":23},"updated":"2017-09-26 19:43:22.000000000","message":"Same","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    services:"},{"line_number":87,"context_line":"    - service: elasticsearch-logging"},{"line_number":88,"context_line":"      endpoint: default"},{"line_number":89,"context_line":"    - service: kafka-logging"},{"line_number":90,"context_line":"      endpoint: default"},{"line_number":91,"context_line":"    - service: fluentd-aggregator"},{"line_number":92,"context_line":"      endpoint: default"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_19ce94b3","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":23},"in_reply_to":"7f515b1d_c7e747e4","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    node_port:"},{"line_number":147,"context_line":"      enabled: false"},{"line_number":148,"context_line":"      port: 12923"},{"line_number":149,"context_line":"pod:"},{"line_number":150,"context_line":"  affinity:"},{"line_number":151,"context_line":"      anti:"},{"line_number":152,"context_line":"        type:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_87fa6f72","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":4},"updated":"2017-09-26 19:43:22.000000000","message":"Need whitespace to separate the value trees","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    node_port:"},{"line_number":147,"context_line":"      enabled: false"},{"line_number":148,"context_line":"      port: 12923"},{"line_number":149,"context_line":"pod:"},{"line_number":150,"context_line":"  affinity:"},{"line_number":151,"context_line":"      anti:"},{"line_number":152,"context_line":"        type:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_99b96416","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":4},"in_reply_to":"7f515b1d_87fa6f72","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":162,"context_line":"          min_ready_seconds: 0"},{"line_number":163,"context_line":"          max_unavailable: 1"},{"line_number":164,"context_line":"    termination_grace_period:"},{"line_number":165,"context_line":"      metadata:"},{"line_number":166,"context_line":"        timeout: 30"},{"line_number":167,"context_line":"      osapi:"},{"line_number":168,"context_line":"        timeout: 30"},{"line_number":169,"context_line":"  resources:"},{"line_number":170,"context_line":"    fluentbit:"},{"line_number":171,"context_line":"      enabled: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_47f47786","line":168,"range":{"start_line":165,"start_character":0,"end_line":168,"end_character":19},"updated":"2017-09-26 19:43:22.000000000","message":"Need to be replaced with appropriate service names","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"          min_ready_seconds: 0"},{"line_number":163,"context_line":"          max_unavailable: 1"},{"line_number":164,"context_line":"    termination_grace_period:"},{"line_number":165,"context_line":"      metadata:"},{"line_number":166,"context_line":"        timeout: 30"},{"line_number":167,"context_line":"      osapi:"},{"line_number":168,"context_line":"        timeout: 30"},{"line_number":169,"context_line":"  resources:"},{"line_number":170,"context_line":"    fluentbit:"},{"line_number":171,"context_line":"      enabled: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_793a2899","line":168,"range":{"start_line":165,"start_character":0,"end_line":168,"end_character":19},"in_reply_to":"7f515b1d_47f47786","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          memory: \"1024Mi\""},{"line_number":192,"context_line":"          cpu: \"2000m\""},{"line_number":193,"context_line":"  replicas:"},{"line_number":194,"context_line":"    fluentd: 1"},{"line_number":195,"context_line":"  mounts:"},{"line_number":196,"context_line":"    fluentd:"},{"line_number":197,"context_line":"      init_container: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_2744dbb6","line":194,"range":{"start_line":194,"start_character":13,"end_line":194,"end_character":14},"updated":"2017-09-26 19:43:22.000000000","message":"Can we make this at least 3 to verify multiple replicas function?","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":191,"context_line":"          memory: \"1024Mi\""},{"line_number":192,"context_line":"          cpu: \"2000m\""},{"line_number":193,"context_line":"  replicas:"},{"line_number":194,"context_line":"    fluentd: 1"},{"line_number":195,"context_line":"  mounts:"},{"line_number":196,"context_line":"    fluentd:"},{"line_number":197,"context_line":"      init_container: null"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_593d2c8d","line":194,"range":{"start_line":194,"start_character":13,"end_line":194,"end_character":14},"in_reply_to":"7f515b1d_2744dbb6","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      fluentbit:"},{"line_number":202,"context_line":"    fluent_tests:"},{"line_number":203,"context_line":"      init_container: null"},{"line_number":204,"context_line":"      fluentbit:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"manifests:"},{"line_number":207,"context_line":"  service_fluentd: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_47223702","line":204,"range":{"start_line":204,"start_character":6,"end_line":204,"end_character":15},"updated":"2017-09-26 19:43:22.000000000","message":"fluent_tests","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      fluentbit:"},{"line_number":202,"context_line":"    fluent_tests:"},{"line_number":203,"context_line":"      init_container: null"},{"line_number":204,"context_line":"      fluentbit:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"manifests:"},{"line_number":207,"context_line":"  service_fluentd: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_39403007","line":204,"range":{"start_line":204,"start_character":6,"end_line":204,"end_character":15},"in_reply_to":"7f515b1d_47223702","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7ee04867a398da36c0bbc3708736fdc3dd8fa793","unresolved":false,"context_lines":[{"line_number":206,"context_line":"manifests:"},{"line_number":207,"context_line":"  service_fluentd: true"},{"line_number":208,"context_line":"  deployment_fluentd: true"},{"line_number":209,"context_line":"  daemonset_fluentd: false"},{"line_number":210,"context_line":"  daemonset_fluentbit: true"},{"line_number":211,"context_line":"  liteweight_daemonset: true"},{"line_number":212,"context_line":"  configmap_bin: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_c783c7cb","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":26},"updated":"2017-09-26 19:43:22.000000000","message":"This can be removed","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"manifests:"},{"line_number":207,"context_line":"  service_fluentd: true"},{"line_number":208,"context_line":"  deployment_fluentd: true"},{"line_number":209,"context_line":"  daemonset_fluentd: false"},{"line_number":210,"context_line":"  daemonset_fluentbit: true"},{"line_number":211,"context_line":"  liteweight_daemonset: true"},{"line_number":212,"context_line":"  configmap_bin: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_19433415","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":26},"in_reply_to":"7f515b1d_c783c7cb","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"374b4956a686cf9dce91db0b869e6d4c8eaca3c8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4c97c2325519433a11d22e46a5300db8762a9eed","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  test: docker.io/kolla/ubuntu-binary-rally:4.0.0"},{"line_number":31,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":33,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_e48172c5","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":49},"updated":"2017-10-04 17:37:36.000000000","message":"This isn\u0027t required for fluent-logging. Should be replaced with an image for testing the fluent-logging stack appropriately","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  test: docker.io/kolla/ubuntu-binary-rally:4.0.0"},{"line_number":31,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":33,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_02701b72","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":49},"in_reply_to":"7f515b1d_e48172c5","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4c97c2325519433a11d22e46a5300db8762a9eed","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"endpoints:"},{"line_number":72,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":73,"context_line":"  logging:"},{"line_number":74,"context_line":"    hosts:"},{"line_number":75,"context_line":"      default: elasticsearch-logging"},{"line_number":76,"context_line":"      elasticsearch: elasticsearch-logging"},{"line_number":77,"context_line":"      kafka: kafka-logging"},{"line_number":78,"context_line":"    scheme:"},{"line_number":79,"context_line":"      default: http"},{"line_number":80,"context_line":"      elasticsearch: http"},{"line_number":81,"context_line":"      kafka: kafka"},{"line_number":82,"context_line":"    port:"},{"line_number":83,"context_line":"      service:"},{"line_number":84,"context_line":"        kafka: 9092"},{"line_number":85,"context_line":"        elasticsearch: 9200"},{"line_number":86,"context_line":"  aggregator:"},{"line_number":87,"context_line":"    hosts:"},{"line_number":88,"context_line":"      default: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_a4549a55","line":85,"range":{"start_line":73,"start_character":0,"end_line":85,"end_character":27},"updated":"2017-10-04 17:37:36.000000000","message":"There should be a separate entry for elasticsearch and kafka endpoints","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"endpoints:"},{"line_number":72,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":73,"context_line":"  logging:"},{"line_number":74,"context_line":"    hosts:"},{"line_number":75,"context_line":"      default: elasticsearch-logging"},{"line_number":76,"context_line":"      elasticsearch: elasticsearch-logging"},{"line_number":77,"context_line":"      kafka: kafka-logging"},{"line_number":78,"context_line":"    scheme:"},{"line_number":79,"context_line":"      default: http"},{"line_number":80,"context_line":"      elasticsearch: http"},{"line_number":81,"context_line":"      kafka: kafka"},{"line_number":82,"context_line":"    port:"},{"line_number":83,"context_line":"      service:"},{"line_number":84,"context_line":"        kafka: 9092"},{"line_number":85,"context_line":"        elasticsearch: 9200"},{"line_number":86,"context_line":"  aggregator:"},{"line_number":87,"context_line":"    hosts:"},{"line_number":88,"context_line":"      default: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_a204a7c7","line":85,"range":{"start_line":73,"start_character":0,"end_line":85,"end_character":27},"in_reply_to":"7f515b1d_a4549a55","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4c97c2325519433a11d22e46a5300db8762a9eed","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    fluentbit:"},{"line_number":122,"context_line":"      enabled: false"},{"line_number":123,"context_line":"      limits:"},{"line_number":124,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":125,"context_line":"      requests:"},{"line_number":126,"context_line":"        cpu: \u0027100m\u0027"},{"line_number":127,"context_line":"        memory: \u0027100Mi\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_e43972f2","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":23},"updated":"2017-10-04 17:37:36.000000000","message":"missing an entry for cpu","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    fluentbit:"},{"line_number":122,"context_line":"      enabled: false"},{"line_number":123,"context_line":"      limits:"},{"line_number":124,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":125,"context_line":"      requests:"},{"line_number":126,"context_line":"        cpu: \u0027100m\u0027"},{"line_number":127,"context_line":"        memory: \u0027100Mi\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_620eafe6","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":23},"in_reply_to":"7f515b1d_e43972f2","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"4c97c2325519433a11d22e46a5300db8762a9eed","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":136,"context_line":"    jobs:"},{"line_number":137,"context_line":"      tests:"},{"line_number":138,"context_line":"        requests:"},{"line_number":139,"context_line":"          memory: \"128Mi\""},{"line_number":140,"context_line":"          cpu: \"100m\""},{"line_number":141,"context_line":"        limits:"},{"line_number":142,"context_line":"          memory: \"1024Mi\""},{"line_number":143,"context_line":"          cpu: \"2000m\""},{"line_number":144,"context_line":"  replicas:"},{"line_number":145,"context_line":"    fluentd: 3"},{"line_number":146,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f515b1d_442a8690","line":143,"range":{"start_line":138,"start_character":0,"end_line":143,"end_character":22},"updated":"2017-10-04 17:37:36.000000000","message":"All of the jobs can share the same resource limits and requests, no need to create a separate tree for each","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":136,"context_line":"    jobs:"},{"line_number":137,"context_line":"      tests:"},{"line_number":138,"context_line":"        requests:"},{"line_number":139,"context_line":"          memory: \"128Mi\""},{"line_number":140,"context_line":"          cpu: \"100m\""},{"line_number":141,"context_line":"        limits:"},{"line_number":142,"context_line":"          memory: \"1024Mi\""},{"line_number":143,"context_line":"          cpu: \"2000m\""},{"line_number":144,"context_line":"  replicas:"},{"line_number":145,"context_line":"    fluentd: 3"},{"line_number":146,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_22f8b7c2","line":143,"range":{"start_line":138,"start_character":0,"end_line":143,"end_character":22},"in_reply_to":"7f515b1d_442a8690","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"724ec5ea8957024e7f8c885907dd10b6a5ef40b0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"dependencies:"},{"line_number":37,"context_line":"  fluentd:"},{"line_number":38,"context_line":"    services:"},{"line_number":39,"context_line":"    - service: elasticsearch"},{"line_number":40,"context_line":"      endpoint: elasticsearch"},{"line_number":41,"context_line":"  fluentd_with_kafka:"},{"line_number":42,"context_line":"    services:"},{"line_number":43,"context_line":"    - service: elasticsearch"},{"line_number":44,"context_line":"      endpoint: elasticsearch"},{"line_number":45,"context_line":"    - service: kafka"},{"line_number":46,"context_line":"      endpoint: kafka"},{"line_number":47,"context_line":"  fluentbit:"},{"line_number":48,"context_line":"    services:"},{"line_number":49,"context_line":"    - service: aggregator"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_184ff934","line":46,"range":{"start_line":38,"start_character":0,"end_line":46,"end_character":21},"updated":"2017-10-13 13:35:24.000000000","message":"See comments wrt dependency overrides","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      enabled: true"},{"line_number":64,"context_line":"      topic_name: logs"},{"line_number":65,"context_line":"    elasticsearch:"},{"line_number":66,"context_line":"      port: 9200"},{"line_number":67,"context_line":"      logstash: true"},{"line_number":68,"context_line":"    override:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_b857c5ca","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":16},"updated":"2017-10-13 13:35:24.000000000","message":"This entry can likely be removed, and can be referenced via the endpoints entry for elasticsearch instead","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      enabled: true"},{"line_number":64,"context_line":"      topic_name: logs"},{"line_number":65,"context_line":"    elasticsearch:"},{"line_number":66,"context_line":"      port: 9200"},{"line_number":67,"context_line":"      logstash: true"},{"line_number":68,"context_line":"    override:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_07d528e5","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":16},"in_reply_to":"5f4e5783_b857c5ca","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"103b3e57abb22680a13abf38c23251b31de5445c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":145,"context_line":"    jobs:"},{"line_number":146,"context_line":"      tests:"},{"line_number":147,"context_line":"        requests:"},{"line_number":148,"context_line":"          memory: \"128Mi\""},{"line_number":149,"context_line":"          cpu: \"100m\""},{"line_number":150,"context_line":"        limits:"},{"line_number":151,"context_line":"          memory: \"1024Mi\""},{"line_number":152,"context_line":"          cpu: \"2000m\""},{"line_number":153,"context_line":"  replicas:"},{"line_number":154,"context_line":"    fluentd: 3"},{"line_number":155,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_18681985","line":152,"range":{"start_line":147,"start_character":0,"end_line":152,"end_character":22},"updated":"2017-10-13 13:35:24.000000000","message":"Can these be reordered to match the other resource entries? (limits then resources)","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"4256a299ce05be0cecf0f9518cec53059dc2f1b9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":145,"context_line":"    jobs:"},{"line_number":146,"context_line":"      tests:"},{"line_number":147,"context_line":"        requests:"},{"line_number":148,"context_line":"          memory: \"128Mi\""},{"line_number":149,"context_line":"          cpu: \"100m\""},{"line_number":150,"context_line":"        limits:"},{"line_number":151,"context_line":"          memory: \"1024Mi\""},{"line_number":152,"context_line":"          cpu: \"2000m\""},{"line_number":153,"context_line":"  replicas:"},{"line_number":154,"context_line":"    fluentd: 3"},{"line_number":155,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_e707ac81","line":152,"range":{"start_line":147,"start_character":0,"end_line":152,"end_character":22},"in_reply_to":"5f4e5783_18681985","updated":"2017-10-17 07:12:46.000000000","message":"Done","commit_id":"4fd3a6143a29405f5b8ad6fa12cbee4be0e99092"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"b54d975c5cd27b05b90b0ebf03e520716be3cf4f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"          default: kubernetes.io/hostname"},{"line_number":128,"context_line":"  lifecycle:"},{"line_number":129,"context_line":"    upgrades:"},{"line_number":130,"context_line":"      daemonsets:"},{"line_number":131,"context_line":"        pod_replacement_strategy: RollingUpdate"},{"line_number":132,"context_line":"        fluentbit:"},{"line_number":133,"context_line":"          enabled: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_a74e04bf","line":130,"updated":"2017-10-18 06:49:20.000000000","message":"\u0027deployments\u0027 section is missing","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a62118f90349d7a01e264e2cebe8b66ed3c8ac67","unresolved":false,"context_lines":[{"line_number":127,"context_line":"          default: kubernetes.io/hostname"},{"line_number":128,"context_line":"  lifecycle:"},{"line_number":129,"context_line":"    upgrades:"},{"line_number":130,"context_line":"      daemonsets:"},{"line_number":131,"context_line":"        pod_replacement_strategy: RollingUpdate"},{"line_number":132,"context_line":"        fluentbit:"},{"line_number":133,"context_line":"          enabled: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_6d2d8d45","line":130,"in_reply_to":"3f4b6375_a74e04bf","updated":"2017-10-19 13:11:45.000000000","message":"It\u0027s mistake. I\u0027ll add deployments tree.thx","commit_id":"fb0c015adbf0bc9c3697c6ab93452d3687677802"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_3f675728","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":56},"updated":"2017-10-22 17:35:49.000000000","message":"Needs to be prefixed with docker.io","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_ef48c387","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":56},"in_reply_to":"3f4b6375_3f675728","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_bfad8732","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":45},"updated":"2017-10-22 17:35:49.000000000","message":"This needs to match the same format as the other kolla images:  prefixed with docker.io and a release tag preferably","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_0f443f73","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":45},"in_reply_to":"3f4b6375_bfad8732","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"dependencies:"},{"line_number":37,"context_line":"  fluentd:"},{"line_number":38,"context_line":"    services:"},{"line_number":39,"context_line":"    - service: elasticsearch"},{"line_number":40,"context_line":"      endpoint: elasticsearch"},{"line_number":41,"context_line":"  fluentd_with_kafka:"},{"line_number":42,"context_line":"    services:"},{"line_number":43,"context_line":"    - service: elasticsearch"},{"line_number":44,"context_line":"      endpoint: elasticsearch"},{"line_number":45,"context_line":"    - service: kafka"},{"line_number":46,"context_line":"      endpoint: kafka"},{"line_number":47,"context_line":"  fluentbit:"},{"line_number":48,"context_line":"    services:"},{"line_number":49,"context_line":"    - service: aggregator"},{"line_number":50,"context_line":"      endpoint: fluentd"},{"line_number":51,"context_line":"  tests:"},{"line_number":52,"context_line":"    services:"},{"line_number":53,"context_line":"    - service: elasticsearch"},{"line_number":54,"context_line":"      endpoint: elasticsearch"},{"line_number":55,"context_line":"    - service: aggregator"},{"line_number":56,"context_line":"      endpoint: fluentd"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"conf:"},{"line_number":59,"context_line":"  fluentbit:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_ff49bf8a","line":56,"range":{"start_line":38,"start_character":0,"end_line":56,"end_character":23},"updated":"2017-10-22 17:35:49.000000000","message":"These should be changed to reflect the service discovery mechanisms used for other charts once the endpoint entries are updated","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"dependencies:"},{"line_number":37,"context_line":"  fluentd:"},{"line_number":38,"context_line":"    services:"},{"line_number":39,"context_line":"    - service: elasticsearch"},{"line_number":40,"context_line":"      endpoint: elasticsearch"},{"line_number":41,"context_line":"  fluentd_with_kafka:"},{"line_number":42,"context_line":"    services:"},{"line_number":43,"context_line":"    - service: elasticsearch"},{"line_number":44,"context_line":"      endpoint: elasticsearch"},{"line_number":45,"context_line":"    - service: kafka"},{"line_number":46,"context_line":"      endpoint: kafka"},{"line_number":47,"context_line":"  fluentbit:"},{"line_number":48,"context_line":"    services:"},{"line_number":49,"context_line":"    - service: aggregator"},{"line_number":50,"context_line":"      endpoint: fluentd"},{"line_number":51,"context_line":"  tests:"},{"line_number":52,"context_line":"    services:"},{"line_number":53,"context_line":"    - service: elasticsearch"},{"line_number":54,"context_line":"      endpoint: elasticsearch"},{"line_number":55,"context_line":"    - service: aggregator"},{"line_number":56,"context_line":"      endpoint: fluentd"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"conf:"},{"line_number":59,"context_line":"  fluentbit:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_d5ad949b","line":56,"range":{"start_line":38,"start_character":0,"end_line":56,"end_character":23},"in_reply_to":"3f4b6375_ff49bf8a","updated":"2017-10-24 11:48:32.000000000","message":"Can you explain more? It is used for generating uri on a dependency check init-container with \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\". are there more mechanisms?","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      topic_name: logs"},{"line_number":65,"context_line":"      flush_interval: 3s"},{"line_number":66,"context_line":"      output_data_type: json"},{"line_number":67,"context_line":"      add_dependencies:"},{"line_number":68,"context_line":"        services:"},{"line_number":69,"context_line":"        - service: kafka"},{"line_number":70,"context_line":"          endpoint: kafka"},{"line_number":71,"context_line":"    elasticsearch:"},{"line_number":72,"context_line":"      logstash: true"},{"line_number":73,"context_line":"      buffer_chunk_limit: 2M"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_9f5acb4c","line":70,"range":{"start_line":67,"start_character":0,"end_line":70,"end_character":25},"updated":"2017-10-22 17:35:49.000000000","message":"Is this required?","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      topic_name: logs"},{"line_number":65,"context_line":"      flush_interval: 3s"},{"line_number":66,"context_line":"      output_data_type: json"},{"line_number":67,"context_line":"      add_dependencies:"},{"line_number":68,"context_line":"        services:"},{"line_number":69,"context_line":"        - service: kafka"},{"line_number":70,"context_line":"          endpoint: kafka"},{"line_number":71,"context_line":"    elasticsearch:"},{"line_number":72,"context_line":"      logstash: true"},{"line_number":73,"context_line":"      buffer_chunk_limit: 2M"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_4f4eb797","line":70,"range":{"start_line":67,"start_character":0,"end_line":70,"end_character":25},"in_reply_to":"3f4b6375_9f5acb4c","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"endpoints:"},{"line_number":82,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":83,"context_line":"  elasticsearch:"},{"line_number":84,"context_line":"    hosts:"},{"line_number":85,"context_line":"      default: elasticsearch-logging"},{"line_number":86,"context_line":"      elasticsearch: elasticsearch-logging"},{"line_number":87,"context_line":"    scheme:"},{"line_number":88,"context_line":"      default: http"},{"line_number":89,"context_line":"      elasticsearch: http"},{"line_number":90,"context_line":"    port:"},{"line_number":91,"context_line":"      service:"},{"line_number":92,"context_line":"        default: 9200"},{"line_number":93,"context_line":"        elasticsearch: 9200"},{"line_number":94,"context_line":"  kafka:"},{"line_number":95,"context_line":"    hosts:"},{"line_number":96,"context_line":"      default: kafka-logging"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_5f321312","line":93,"range":{"start_line":83,"start_character":0,"end_line":93,"end_character":27},"updated":"2017-10-22 17:35:49.000000000","message":"Can you update the entries here to match the naming conventions found here?  https://review.openstack.org/#/c/512881/20/elasticsearch/values.yaml\n\nThe endpoint entries should be the same across all charts to better allow orchestration tools to handle the same endpoint uniformly","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"endpoints:"},{"line_number":82,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":83,"context_line":"  elasticsearch:"},{"line_number":84,"context_line":"    hosts:"},{"line_number":85,"context_line":"      default: elasticsearch-logging"},{"line_number":86,"context_line":"      elasticsearch: elasticsearch-logging"},{"line_number":87,"context_line":"    scheme:"},{"line_number":88,"context_line":"      default: http"},{"line_number":89,"context_line":"      elasticsearch: http"},{"line_number":90,"context_line":"    port:"},{"line_number":91,"context_line":"      service:"},{"line_number":92,"context_line":"        default: 9200"},{"line_number":93,"context_line":"        elasticsearch: 9200"},{"line_number":94,"context_line":"  kafka:"},{"line_number":95,"context_line":"    hosts:"},{"line_number":96,"context_line":"      default: kafka-logging"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_3a78578e","line":93,"range":{"start_line":83,"start_character":0,"end_line":93,"end_character":27},"in_reply_to":"3f4b6375_5f321312","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      kafka: kafka"},{"line_number":101,"context_line":"    port:"},{"line_number":102,"context_line":"      service:"},{"line_number":103,"context_line":"        default: 9092"},{"line_number":104,"context_line":"        kafka: 9092"},{"line_number":105,"context_line":"  aggregator:"},{"line_number":106,"context_line":"    hosts:"},{"line_number":107,"context_line":"      default: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_1f3c9be0","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":19},"updated":"2017-10-22 17:35:49.000000000","message":"Should just need one port definition","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      kafka: kafka"},{"line_number":101,"context_line":"    port:"},{"line_number":102,"context_line":"      service:"},{"line_number":103,"context_line":"        default: 9092"},{"line_number":104,"context_line":"        kafka: 9092"},{"line_number":105,"context_line":"  aggregator:"},{"line_number":106,"context_line":"    hosts:"},{"line_number":107,"context_line":"      default: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_7a612fd3","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":19},"in_reply_to":"3f4b6375_1f3c9be0","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        kafka: 9092"},{"line_number":105,"context_line":"  aggregator:"},{"line_number":106,"context_line":"    hosts:"},{"line_number":107,"context_line":"      default: fluentd-logging"},{"line_number":108,"context_line":"      fluentd: fluentd-logging"},{"line_number":109,"context_line":"    scheme:"},{"line_number":110,"context_line":"      default: http"},{"line_number":111,"context_line":"    port:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_ff3e5fd8","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":30},"updated":"2017-10-22 17:35:49.000000000","message":"Should have different host names","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        kafka: 9092"},{"line_number":105,"context_line":"  aggregator:"},{"line_number":106,"context_line":"    hosts:"},{"line_number":107,"context_line":"      default: fluentd-logging"},{"line_number":108,"context_line":"      fluentd: fluentd-logging"},{"line_number":109,"context_line":"    scheme:"},{"line_number":110,"context_line":"      default: http"},{"line_number":111,"context_line":"    port:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_9aad0beb","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":30},"in_reply_to":"3f4b6375_ff3e5fd8","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  fluentd:"},{"line_number":117,"context_line":"    node_port:"},{"line_number":118,"context_line":"      enabled: false"},{"line_number":119,"context_line":"      port: 12923"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"pod:"},{"line_number":122,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_df25e3c3","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":17},"updated":"2017-10-22 17:35:49.000000000","message":"Node ports are typically allocated from 30000-32767. Can you update this to be within that range?","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  fluentd:"},{"line_number":117,"context_line":"    node_port:"},{"line_number":118,"context_line":"      enabled: false"},{"line_number":119,"context_line":"      port: 12923"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"pod:"},{"line_number":122,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_3a0737cd","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":17},"in_reply_to":"3f4b6375_df25e3c3","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    fluentbit:"},{"line_number":147,"context_line":"      enabled: false"},{"line_number":148,"context_line":"      limits:"},{"line_number":149,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":150,"context_line":"        cpu: \u0027400m\u0027"},{"line_number":151,"context_line":"      requests:"},{"line_number":152,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":153,"context_line":"        cpu: \u0027100m\u0027"},{"line_number":154,"context_line":"    fluentd:"},{"line_number":155,"context_line":"      enabled: false"},{"line_number":156,"context_line":"      limits:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_7f2a6f90","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":19},"updated":"2017-10-22 17:35:49.000000000","message":"Memory limits and requests here are the same. Memory limits should be updated to match the other entries","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    fluentbit:"},{"line_number":147,"context_line":"      enabled: false"},{"line_number":148,"context_line":"      limits:"},{"line_number":149,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":150,"context_line":"        cpu: \u0027400m\u0027"},{"line_number":151,"context_line":"      requests:"},{"line_number":152,"context_line":"        memory: \u0027100Mi\u0027"},{"line_number":153,"context_line":"        cpu: \u0027100m\u0027"},{"line_number":154,"context_line":"    fluentd:"},{"line_number":155,"context_line":"      enabled: false"},{"line_number":156,"context_line":"      limits:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_da2a632a","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":19},"in_reply_to":"3f4b6375_7f2a6f90","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    fluentd:"},{"line_number":155,"context_line":"      enabled: false"},{"line_number":156,"context_line":"      limits:"},{"line_number":157,"context_line":"        memory: \u00271024Mi\u0027"},{"line_number":158,"context_line":"        cpu: \u00272000m\u0027"},{"line_number":159,"context_line":"      requests:"},{"line_number":160,"context_line":"        memory: \u0027128Mi\u0027"},{"line_number":161,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":162,"context_line":"    jobs:"},{"line_number":163,"context_line":"      tests:"},{"line_number":164,"context_line":"        limits:"},{"line_number":165,"context_line":"          memory: \"1024Mi\""},{"line_number":166,"context_line":"          cpu: \"2000m\""},{"line_number":167,"context_line":"        requests:"},{"line_number":168,"context_line":"          memory: \"128Mi\""},{"line_number":169,"context_line":"          cpu: \"100m\""},{"line_number":170,"context_line":"  replicas:"},{"line_number":171,"context_line":"    fluentd: 3"},{"line_number":172,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_5f1b3380","line":169,"range":{"start_line":157,"start_character":0,"end_line":169,"end_character":21},"updated":"2017-10-22 17:35:49.000000000","message":"Varying use of single and double quotes.","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    fluentd:"},{"line_number":155,"context_line":"      enabled: false"},{"line_number":156,"context_line":"      limits:"},{"line_number":157,"context_line":"        memory: \u00271024Mi\u0027"},{"line_number":158,"context_line":"        cpu: \u00272000m\u0027"},{"line_number":159,"context_line":"      requests:"},{"line_number":160,"context_line":"        memory: \u0027128Mi\u0027"},{"line_number":161,"context_line":"        cpu: \u0027500m\u0027"},{"line_number":162,"context_line":"    jobs:"},{"line_number":163,"context_line":"      tests:"},{"line_number":164,"context_line":"        limits:"},{"line_number":165,"context_line":"          memory: \"1024Mi\""},{"line_number":166,"context_line":"          cpu: \"2000m\""},{"line_number":167,"context_line":"        requests:"},{"line_number":168,"context_line":"          memory: \"128Mi\""},{"line_number":169,"context_line":"          cpu: \"100m\""},{"line_number":170,"context_line":"  replicas:"},{"line_number":171,"context_line":"    fluentd: 3"},{"line_number":172,"context_line":"  mounts:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_3abe17d5","line":169,"range":{"start_line":157,"start_character":0,"end_line":169,"end_character":21},"in_reply_to":"3f4b6375_5f1b3380","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c77a1124b2d7b2b0991967114d9d0326c3b1dc3a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  service_fluentd: true"},{"line_number":185,"context_line":"  deployment_fluentd: true"},{"line_number":186,"context_line":"  daemonset_fluentbit: true"},{"line_number":187,"context_line":"  liteweight_daemonset: true"},{"line_number":188,"context_line":"  configmap_bin: true"},{"line_number":189,"context_line":"  configmap_etc: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_3f1e3770","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":28},"updated":"2017-10-22 17:35:49.000000000","message":"What does this flag correspond with?","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9b5f93c44cd25974f0f0066529ce1d0a03fa9457","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  service_fluentd: true"},{"line_number":185,"context_line":"  deployment_fluentd: true"},{"line_number":186,"context_line":"  daemonset_fluentbit: true"},{"line_number":187,"context_line":"  liteweight_daemonset: true"},{"line_number":188,"context_line":"  configmap_bin: true"},{"line_number":189,"context_line":"  configmap_etc: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4b6375_fab3df08","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":28},"in_reply_to":"3f4b6375_3f1e3770","updated":"2017-10-24 11:48:32.000000000","message":"Done","commit_id":"bdd8c4580a302cf7299fc8c60702271b45aba0d6"}]}