)]}'
{"ranger-agent/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fd351e5310144f5f9548c82992ad7442b0dd14a2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    user: ranger_agent"},{"line_number":88,"context_line":"    user_home: /home/ranger_agent"},{"line_number":89,"context_line":"    ssh_key_file: ranger_agent"},{"line_number":90,"context_line":"    ssh_key: |-"},{"line_number":91,"context_line":"    ssh_config: |-"},{"line_number":92,"context_line":"network:"},{"line_number":93,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_701a7b6f","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":15},"updated":"2018-05-21 17:37:59.000000000","message":"this can probably be just null","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fd351e5310144f5f9548c82992ad7442b0dd14a2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    user_home: /home/ranger_agent"},{"line_number":89,"context_line":"    ssh_key_file: ranger_agent"},{"line_number":90,"context_line":"    ssh_key: |-"},{"line_number":91,"context_line":"    ssh_config: |-"},{"line_number":92,"context_line":"network:"},{"line_number":93,"context_line":"  api:"},{"line_number":94,"context_line":"    ingress:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_90171746","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":18},"updated":"2018-05-21 17:37:59.000000000","message":"ditto","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"09763bcd73b4cc1b7a353bbefa2ee9f3f4663078","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  ranger_rds:"},{"line_number":226,"context_line":"    name: rds-url"},{"line_number":227,"context_line":"    hosts:"},{"line_number":228,"context_line":"      default: internal.ranger.com"},{"line_number":229,"context_line":"    host_fqdn_override:"},{"line_number":230,"context_line":"      default: internal.ranger.com"},{"line_number":231,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_6b673853","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":34},"updated":"2018-05-21 17:36:25.000000000","message":"This should be set to something a bit more simple and sane, as this represents a fqdn override. This value is used to set the name of the kubernetes service object for range-agent. In this case, the standard kubernetes service that\u0027s serving traffic to the ranger-agent pods inside the cluster seems to represent a fqdn. An example of a default host here could be something simple, like ranger-agent.  For other examples, see: https://github.com/openstack/openstack-helm/blob/master/keystone/values.yaml#L827","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5cb1dd508c26a6d89099285154b7c2b1c1f0acfc","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  ranger_rds:"},{"line_number":226,"context_line":"    name: rds-url"},{"line_number":227,"context_line":"    hosts:"},{"line_number":228,"context_line":"      default: internal.ranger.com"},{"line_number":229,"context_line":"    host_fqdn_override:"},{"line_number":230,"context_line":"      default: internal.ranger.com"},{"line_number":231,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_eea11597","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":34},"in_reply_to":"5f7c97a3_0bc6c34a","updated":"2018-05-21 20:03:52.000000000","message":"If ranger is to be running inside the kubernetes cluster, I feel the comment is still relevant. It needs to match the service name that will be used for ranger in this chart: https://review.openstack.org/#/c/569797/1","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"43f1be01e836f6c29bbfdd3a208800d5c03da737","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  ranger_rds:"},{"line_number":226,"context_line":"    name: rds-url"},{"line_number":227,"context_line":"    hosts:"},{"line_number":228,"context_line":"      default: internal.ranger.com"},{"line_number":229,"context_line":"    host_fqdn_override:"},{"line_number":230,"context_line":"      default: internal.ranger.com"},{"line_number":231,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_0bc6c34a","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":34},"in_reply_to":"5f7c97a3_6b673853","updated":"2018-05-21 18:38:03.000000000","message":"This is external url to access ranger(not ranger-agent). This need to be overridden at time of deployment. In case we don\u0027t pass it ranger_rds url will not be generated.I can add some comment if you think it would be more descriptive","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"09763bcd73b4cc1b7a353bbefa2ee9f3f4663078","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    hosts:"},{"line_number":228,"context_line":"      default: internal.ranger.com"},{"line_number":229,"context_line":"    host_fqdn_override:"},{"line_number":230,"context_line":"      default: internal.ranger.com"},{"line_number":231,"context_line":"    path:"},{"line_number":232,"context_line":"      default: /v1/rds/status"},{"line_number":233,"context_line":"    scheme:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_2b71400d","line":230,"range":{"start_line":230,"start_character":14,"end_line":230,"end_character":34},"updated":"2018-05-21 17:36:25.000000000","message":"This should be set to null to maintain consistency with the other charts","commit_id":"efa0e30d80310a66843ccf277bfc2f4c33612a39"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"6d26979da840bccd2fdb164715a949e0e2926e15","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    user: ranger_agent"},{"line_number":94,"context_line":"    user_home: /home/ranger_agent"},{"line_number":95,"context_line":"    ssh_key_file: ranger_agent"},{"line_number":96,"context_line":"    ssh_key: |-"},{"line_number":97,"context_line":"    ssh_config: |-"},{"line_number":98,"context_line":"network:"},{"line_number":99,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_d8cdc4b7","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":15},"updated":"2018-05-25 18:10:15.000000000","message":"Tin, Using null here gives error:\nwrong number of args for b64enc: want 1 got 0","commit_id":"91194632486abcd1eaf0f00fb03db7db991cfc38"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"abf49d74e83973875a102f878af4779e78454694","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    user: ranger_agent"},{"line_number":94,"context_line":"    user_home: /home/ranger_agent"},{"line_number":95,"context_line":"    ssh_key_file: ranger_agent"},{"line_number":96,"context_line":"    ssh_key: |-"},{"line_number":97,"context_line":"    ssh_config: |-"},{"line_number":98,"context_line":"network:"},{"line_number":99,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_535d1713","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":15},"in_reply_to":"5f7c97a3_d8cdc4b7","updated":"2018-05-25 19:37:21.000000000","message":"you can use default \"\" in the template - see https://github.com/openstack/openstack-helm-infra/blob/27c46b56032abaea47fa7e7424fb6ead55061137/calico/templates/secret-certificates.yaml#L27","commit_id":"91194632486abcd1eaf0f00fb03db7db991cfc38"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8f326c807f72e009ba74c9940545721a30f1196","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  ranger_rds:"},{"line_number":240,"context_line":"    name: rds-url"},{"line_number":241,"context_line":"    hosts:"},{"line_number":242,"context_line":"      default: rds.ranger.com"},{"line_number":243,"context_line":"    host_fqdn_override:"},{"line_number":244,"context_line":"      default: null"},{"line_number":245,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_738933c8","line":242,"range":{"start_line":242,"start_character":14,"end_line":242,"end_character":29},"updated":"2018-05-25 21:12:54.000000000","message":"I think Steve\u0027s previous comments still stands. External url or not, would this not result in a hostname: like rds.ranger.com.openstack.svc.cluster.local?  While this value is going to be overridden, can we not make this something more sensible - like \"rds-server\" without creating additional levels in the URL?","commit_id":"91194632486abcd1eaf0f00fb03db7db991cfc38"}]}