)]}'
{"sonobuoy/templates/bin/_run_master.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"04d338cdda8ff8503c242af1c5b63cd4f0769a10","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -xe"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":22,"context_line":"# It\u0027s ok for these env vars to be unbound"},{"line_number":23,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":24,"context_line":"echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"3f79a3b5_b374569d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":43},"updated":"2018-10-03 13:37:55.000000000","message":"Does it make sense to instead define this environment variable in the pod spec, and make the directory configurable via values?","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"79315d1488620cd218ef466876c247e9627b013e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -xe"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":22,"context_line":"# It\u0027s ok for these env vars to be unbound"},{"line_number":23,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":24,"context_line":"echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"3f79a3b5_591e4374","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":43},"in_reply_to":"3f79a3b5_b374569d","updated":"2018-10-03 15:54:07.000000000","message":"I ended up removing this RESULTS_DIR entirely. https://review.openstack.org/#/c/604833/19/sonobuoy/values.yaml@38","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"04d338cdda8ff8503c242af1c5b63cd4f0769a10","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":22,"context_line":"# It\u0027s ok for these env vars to be unbound"},{"line_number":23,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":24,"context_line":"echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"3f79a3b5_937b5a78","line":23,"range":{"start_line":23,"start_character":29,"end_line":23,"end_character":65},"updated":"2018-10-03 13:37:55.000000000","message":"Just curious - what configuration does this point to? If its meant to point to config.json, should we just explicitly point this to where we mount the config.json file in the pod?","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"79315d1488620cd218ef466876c247e9627b013e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":22,"context_line":"# It\u0027s ok for these env vars to be unbound"},{"line_number":23,"context_line":"RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":24,"context_line":"echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"3f79a3b5_641b561b","line":23,"range":{"start_line":23,"start_character":29,"end_line":23,"end_character":65},"in_reply_to":"3f79a3b5_937b5a78","updated":"2018-10-03 15:54:07.000000000","message":"I think it\u0027s the config.json. I removed the SONOBUOY_CONFIG usage because by mounting the config.json in /etc/sonobuoy Sonobuoy knows to look there already.\n\nI also removed the passing of RESULTS_DIR. It doesn\u0027t seem to add anything, other than overriding the ResultsDir listed in .Values.conf.sonobuoy.ResultsDir.\n\nAlso, noticed the last line of doing the echo into done file is completely useless. Only Sonobuoy plugins are expected to create a done file in their containers.","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"}],"sonobuoy/templates/configmap-bin.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: sonobuoy-bin"},{"line_number":5,"context_line":"data:"},{"line_number":6,"context_line":"  run_master.sh: |"},{"line_number":7,"context_line":"    #!/bin/bash"},{"line_number":8,"context_line":"    set -xe"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":11,"context_line":"    # It\u0027s ok for these env vars to be unbound"},{"line_number":12,"context_line":"    RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":13,"context_line":"    echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_1b4e436e","line":13,"range":{"start_line":6,"start_character":0,"end_line":13,"end_character":105},"updated":"2018-09-24 20:57:25.000000000","message":"This needs to be handled similar to other charts instead of being defined directly in the configmap","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: sonobuoy-bin"},{"line_number":5,"context_line":"data:"},{"line_number":6,"context_line":"  run_master.sh: |"},{"line_number":7,"context_line":"    #!/bin/bash"},{"line_number":8,"context_line":"    set -xe"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    RESULTS_DIR\u003d\"${RESULTS_DIR:-/tmp/sonobuoy}\""},{"line_number":11,"context_line":"    # It\u0027s ok for these env vars to be unbound"},{"line_number":12,"context_line":"    RESULTS_DIR\u003d\"${RESULTS_DIR}\" SONOBUOY_CONFIG\u003d\"${SONOBUOY_CONFIG}\" SONOBUOY_ADVERTISE_IP\u003d\"${SONOBUOY_ADVERTISE_IP}\" /sonobuoy master --v 3 --logtostderr"},{"line_number":13,"context_line":"    echo -n \"${RESULTS_DIR}/$(ls -t \"${RESULTS_DIR}\" | grep -v done | head -n 1)\" \u003e \"${RESULTS_DIR}\"/done"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_bbadcf85","line":13,"range":{"start_line":6,"start_character":0,"end_line":13,"end_character":105},"in_reply_to":"3f79a3b5_1b4e436e","updated":"2018-09-25 20:36:34.000000000","message":"Done!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"}],"sonobuoy/templates/configmap-etc.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"8582534bc55ae856ccfa44f64adde043eca4212c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  name: sonobuoy-etc"},{"line_number":6,"context_line":"data:"},{"line_number":7,"context_line":"  config.json: |"},{"line_number":8,"context_line":"{{ .Values.conf | toJson | indent 4}}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_061d91bd","line":8,"updated":"2018-09-24 16:17:38.000000000","message":"Question: Is it possible to override $templateRendered here: https://github.com/openstack/openstack-helm-infra/blob/master/helm-toolkit/templates/snippets/_values_template_renderer.tpl#L72 to be able to move the WorkerImage value https://review.openstack.org/#/c/604833/1/sonobuoy/values.yaml@51 to images dictionary?","commit_id":"6aece290276d3027473089d6c986e2786c793732"}],"sonobuoy/templates/deployment-api.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"c6ff3b79eaa3352de808d9c1ec0437352b0baffd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d8f3f108","line":3,"updated":"2018-09-24 20:04:49.000000000","message":"Since this is a Pod, should we follow the naming convention \"pod-api.yaml\"?\n\nOTOH, is this pod something that would benefit from being managed by a Deployment replication controller?\n\nI know sonobuoy does some creative things with spawning other jobs and such, so I\u0027m not 100% sure of its lifecycle or whether it\u0027s something long-lived that we\u0027d want a Deployment to restart in case of failure.","commit_id":"db0ab2a67760219b36a7c323186884a0b4d09c0e"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d4d53be86daab82f9e71cc4066e41ae9ce736abb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_7b5bb754","line":3,"in_reply_to":"3f79a3b5_9ba7b30a","updated":"2018-09-25 17:55:09.000000000","message":"You\u0027re right, the Pod is the best fit for a helm test; if we went with a Deployment for the API then the test might need to be a different object.  Let\u0027s start with pod and we can revisit after a discussion if appropriate.","commit_id":"db0ab2a67760219b36a7c323186884a0b4d09c0e"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"522aa5abfc4b70938c56903b1d08e28d639311f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_9ba7b30a","line":3,"in_reply_to":"3f79a3b5_d8f3f108","updated":"2018-09-24 20:53:02.000000000","message":"Agreed with the file name - done!\n\nI don\u0027t know enough to know if Deployment makes sense. With how I\u0027m executing this as of now, I\u0027m expecting the Pod to terminate as it\u0027s a helm test.","commit_id":"db0ab2a67760219b36a7c323186884a0b4d09c0e"}],"sonobuoy/templates/pod-api.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_9b6253d9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2018-09-24 20:57:25.000000000","message":"This should also be wrapped similar to other charts, ie: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L17-L24","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e4d394d2","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"3f79a3b5_9b6253d9","updated":"2018-09-25 20:36:34.000000000","message":"I don\u0027t think this is going to work out of the box for this chart. The service account here needs labels that helm-toolkit doesn\u0027t provide.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"08610735ba05c0501c00075cad81bd2f7da062c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0a5b36f6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"3f79a3b5_c7aa1719","updated":"2018-09-25 21:17:03.000000000","message":"Ah, thank you for the clarification! Fixed!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"9f5788042880c8ce63139ab8bf1be7928062cf31","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_c7aa1719","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"3f79a3b5_e4d394d2","updated":"2018-09-25 21:01:21.000000000","message":"I don\u0027t think that\u0027s all Steve\u0027s referring to here -- i.e. we make every manifest turn-offable like so:\nhttps://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L17","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"    tier: analysis"},{"line_number":9,"context_line":"  name: sonobuoy"},{"line_number":10,"context_line":"  annotations:"},{"line_number":11,"context_line":"    \"helm.sh/hook\": test-success"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5b435b40","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":18},"updated":"2018-09-24 20:57:25.000000000","message":"Can we handle these with helm-toolkit?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"    tier: analysis"},{"line_number":9,"context_line":"  name: sonobuoy"},{"line_number":10,"context_line":"  annotations:"},{"line_number":11,"context_line":"    \"helm.sh/hook\": test-success"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_04581088","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":18},"in_reply_to":"3f79a3b5_04d9f054","updated":"2018-09-25 20:36:34.000000000","message":"run and tier are Sonobuoy specific.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"    tier: analysis"},{"line_number":9,"context_line":"  name: sonobuoy"},{"line_number":10,"context_line":"  annotations:"},{"line_number":11,"context_line":"    \"helm.sh/hook\": test-success"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_64aa2bd4","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":18},"in_reply_to":"3f79a3b5_5b435b40","updated":"2018-09-25 20:36:34.000000000","message":"I\u0027m able to do that for component. I don\u0027t understand how to use that for run and tier.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d4d53be86daab82f9e71cc4066e41ae9ce736abb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Pod"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"    tier: analysis"},{"line_number":9,"context_line":"  name: sonobuoy"},{"line_number":10,"context_line":"  annotations:"},{"line_number":11,"context_line":"    \"helm.sh/hook\": test-success"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_04d9f054","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":18},"in_reply_to":"3f79a3b5_5b435b40","updated":"2018-09-25 17:55:09.000000000","message":"I\u0027m not familiar with the `run` and `tier` labels.  Are these sonobuoy specific or general purpose?  If general purpose we could add them into HTK potentially, but since it doesn\u0027t support them today I\u0027d say it could be a follow-on enhancement.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      valueFrom:"},{"line_number":19,"context_line":"        fieldRef:"},{"line_number":20,"context_line":"          fieldPath: status.podIP"},{"line_number":21,"context_line":"    image: {{ .Values.images.tags.sonobuoy_api }}"},{"line_number":22,"context_line":"    imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":23,"context_line":"    name: kube-sonobuoy"},{"line_number":24,"context_line":"    volumeMounts:"},{"line_number":25,"context_line":"    - mountPath: /etc/sonobuoy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5b5cbb18","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":53},"updated":"2018-09-24 20:57:25.000000000","message":"These items are also handled via helm-toolkit: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L58","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      valueFrom:"},{"line_number":19,"context_line":"        fieldRef:"},{"line_number":20,"context_line":"          fieldPath: status.podIP"},{"line_number":21,"context_line":"    image: {{ .Values.images.tags.sonobuoy_api }}"},{"line_number":22,"context_line":"    imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":23,"context_line":"    name: kube-sonobuoy"},{"line_number":24,"context_line":"    volumeMounts:"},{"line_number":25,"context_line":"    - mountPath: /etc/sonobuoy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_044ed76d","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":53},"in_reply_to":"3f79a3b5_5b5cbb18","updated":"2018-09-25 20:36:34.000000000","message":"Done! Thanks for the example.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          fieldPath: status.podIP"},{"line_number":21,"context_line":"    image: {{ .Values.images.tags.sonobuoy_api }}"},{"line_number":22,"context_line":"    imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":23,"context_line":"    name: kube-sonobuoy"},{"line_number":24,"context_line":"    volumeMounts:"},{"line_number":25,"context_line":"    - mountPath: /etc/sonobuoy"},{"line_number":26,"context_line":"      name: sonobuoy-config-volume"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_1b85e359","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":23},"updated":"2018-09-24 20:57:25.000000000","message":"Can we keep the same structure as other templates, and include the container name as the first item?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          fieldPath: status.podIP"},{"line_number":21,"context_line":"    image: {{ .Values.images.tags.sonobuoy_api }}"},{"line_number":22,"context_line":"    imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":23,"context_line":"    name: kube-sonobuoy"},{"line_number":24,"context_line":"    volumeMounts:"},{"line_number":25,"context_line":"    - mountPath: /etc/sonobuoy"},{"line_number":26,"context_line":"      name: sonobuoy-config-volume"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_bbfb8f79","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":23},"in_reply_to":"3f79a3b5_1b85e359","updated":"2018-09-25 20:36:34.000000000","message":"Done!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      mountPath: /run_master.sh"},{"line_number":33,"context_line":"      subPath: run_master.sh"},{"line_number":34,"context_line":"      readOnly: true"},{"line_number":35,"context_line":"    command:"},{"line_number":36,"context_line":"      - /run_master.sh"},{"line_number":37,"context_line":"  restartPolicy: Never"},{"line_number":38,"context_line":"  serviceAccountName: sonobuoy-serviceaccount"},{"line_number":39,"context_line":"  volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_db7e8b69","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":22},"updated":"2018-09-24 20:57:25.000000000","message":"Can we move this above volumeMounts?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      mountPath: /run_master.sh"},{"line_number":33,"context_line":"      subPath: run_master.sh"},{"line_number":34,"context_line":"      readOnly: true"},{"line_number":35,"context_line":"    command:"},{"line_number":36,"context_line":"      - /run_master.sh"},{"line_number":37,"context_line":"  restartPolicy: Never"},{"line_number":38,"context_line":"  serviceAccountName: sonobuoy-serviceaccount"},{"line_number":39,"context_line":"  volumes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_896f62f9","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":22},"in_reply_to":"3f79a3b5_db7e8b69","updated":"2018-09-25 20:36:34.000000000","message":"Done!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    command:"},{"line_number":36,"context_line":"      - /run_master.sh"},{"line_number":37,"context_line":"  restartPolicy: Never"},{"line_number":38,"context_line":"  serviceAccountName: sonobuoy-serviceaccount"},{"line_number":39,"context_line":"  volumes:"},{"line_number":40,"context_line":"  - name: sonobuoy-bin"},{"line_number":41,"context_line":"    configMap:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_9b901399","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":45},"updated":"2018-09-24 20:57:25.000000000","message":"Can we handle this like we do other charts?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    command:"},{"line_number":36,"context_line":"      - /run_master.sh"},{"line_number":37,"context_line":"  restartPolicy: Never"},{"line_number":38,"context_line":"  serviceAccountName: sonobuoy-serviceaccount"},{"line_number":39,"context_line":"  volumes:"},{"line_number":40,"context_line":"  - name: sonobuoy-bin"},{"line_number":41,"context_line":"    configMap:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_64d6abc7","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":45},"in_reply_to":"3f79a3b5_9b901399","updated":"2018-09-25 20:36:34.000000000","message":"Same as above.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    configMap:"},{"line_number":42,"context_line":"      name: sonobuoy-bin"},{"line_number":43,"context_line":"      defaultMode: 0555"},{"line_number":44,"context_line":"  - configMap:"},{"line_number":45,"context_line":"      name: sonobuoy-etc"},{"line_number":46,"context_line":"    name: sonobuoy-config-volume"},{"line_number":47,"context_line":"  - configMap:"},{"line_number":48,"context_line":"      name: sonobuoy-plugins"},{"line_number":49,"context_line":"    name: sonobuoy-plugins-volume"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_bbee2f1f","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":32},"updated":"2018-09-24 20:57:25.000000000","message":"We\u0027ve moved the other charts to use secrets for storing configuration.  Can we do the same with Sonobuoy?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    configMap:"},{"line_number":42,"context_line":"      name: sonobuoy-bin"},{"line_number":43,"context_line":"      defaultMode: 0555"},{"line_number":44,"context_line":"  - configMap:"},{"line_number":45,"context_line":"      name: sonobuoy-etc"},{"line_number":46,"context_line":"    name: sonobuoy-config-volume"},{"line_number":47,"context_line":"  - configMap:"},{"line_number":48,"context_line":"      name: sonobuoy-plugins"},{"line_number":49,"context_line":"    name: sonobuoy-plugins-volume"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_14b91b78","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":32},"in_reply_to":"3f79a3b5_bbee2f1f","updated":"2018-09-25 20:36:34.000000000","message":"Done!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f51c09bb32979dd4dac074ec91441f7e66d553d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    name: sonobuoy-plugins-volume"},{"line_number":50,"context_line":"  - emptyDir: {}"},{"line_number":51,"context_line":"    name: sonobuoy-output"},{"line_number":52,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7faabc1a","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":3},"updated":"2018-09-25 07:13:35.000000000","message":"not needed","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    name: sonobuoy-plugins-volume"},{"line_number":50,"context_line":"  - emptyDir: {}"},{"line_number":51,"context_line":"    name: sonobuoy-output"},{"line_number":52,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e9b9367c","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":3},"in_reply_to":"3f79a3b5_7faabc1a","updated":"2018-09-25 20:36:34.000000000","message":"Fixed!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1893e5f178ebc47f102c22ae1b89105249cecf30","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        fieldRef:"},{"line_number":67,"context_line":"          fieldPath: status.podIP"},{"line_number":68,"context_line":"{{ tuple $envAll \"sonobuoy_api\" | include \"helm-toolkit.snippets.image\" | indent 4 }}"},{"line_number":69,"context_line":"    name: kube-sonobuoy"},{"line_number":70,"context_line":"    command:"},{"line_number":71,"context_line":"      - /run_master.sh"},{"line_number":72,"context_line":"    volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_959bba71","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":23},"updated":"2018-09-27 13:27:18.000000000","message":"Duplicate entry","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"c32b6542964b9d9be8231b536307b295ff34289f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        fieldRef:"},{"line_number":67,"context_line":"          fieldPath: status.podIP"},{"line_number":68,"context_line":"{{ tuple $envAll \"sonobuoy_api\" | include \"helm-toolkit.snippets.image\" | indent 4 }}"},{"line_number":69,"context_line":"    name: kube-sonobuoy"},{"line_number":70,"context_line":"    command:"},{"line_number":71,"context_line":"      - /run_master.sh"},{"line_number":72,"context_line":"    volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_b5d276fc","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":23},"in_reply_to":"3f79a3b5_959bba71","updated":"2018-09-27 13:40:35.000000000","message":"Wow. Good eye. Fixed.","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1893e5f178ebc47f102c22ae1b89105249cecf30","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      name: sonobuoy-bin"},{"line_number":89,"context_line":"      defaultMode: 0555"},{"line_number":90,"context_line":"  - secret:"},{"line_number":91,"context_line":"      secretName: sonobuoy-etc"},{"line_number":92,"context_line":"    name: sonobuoy-config-volume"},{"line_number":93,"context_line":"  - configMap:"},{"line_number":94,"context_line":"      name: sonobuoy-plugins"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_558c422d","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":30},"updated":"2018-09-27 13:27:18.000000000","message":"This should have the default mode set to 0444: https://github.com/openstack/openstack-helm-infra/blob/master/prometheus/templates/statefulset.yaml#L196","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"c32b6542964b9d9be8231b536307b295ff34289f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      name: sonobuoy-bin"},{"line_number":89,"context_line":"      defaultMode: 0555"},{"line_number":90,"context_line":"  - secret:"},{"line_number":91,"context_line":"      secretName: sonobuoy-etc"},{"line_number":92,"context_line":"    name: sonobuoy-config-volume"},{"line_number":93,"context_line":"  - configMap:"},{"line_number":94,"context_line":"      name: sonobuoy-plugins"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_f5f1ce97","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":30},"in_reply_to":"3f79a3b5_558c422d","updated":"2018-09-27 13:40:35.000000000","message":"Fixed! Thank you for the link.","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1893e5f178ebc47f102c22ae1b89105249cecf30","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      secretName: sonobuoy-etc"},{"line_number":92,"context_line":"    name: sonobuoy-config-volume"},{"line_number":93,"context_line":"  - configMap:"},{"line_number":94,"context_line":"      name: sonobuoy-plugins"},{"line_number":95,"context_line":"    name: sonobuoy-plugins-volume"},{"line_number":96,"context_line":"  - emptyDir: {}"},{"line_number":97,"context_line":"    name: sonobuoy-output"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_3599866c","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":28},"updated":"2018-09-27 13:27:18.000000000","message":"I think this should also have a default mode set","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"c32b6542964b9d9be8231b536307b295ff34289f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      secretName: sonobuoy-etc"},{"line_number":92,"context_line":"    name: sonobuoy-config-volume"},{"line_number":93,"context_line":"  - configMap:"},{"line_number":94,"context_line":"      name: sonobuoy-plugins"},{"line_number":95,"context_line":"    name: sonobuoy-plugins-volume"},{"line_number":96,"context_line":"  - emptyDir: {}"},{"line_number":97,"context_line":"    name: sonobuoy-output"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_b5eb56a2","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":28},"in_reply_to":"3f79a3b5_3599866c","updated":"2018-09-27 13:40:35.000000000","message":"Fixed! I went ahead and did 0444 again here too. Read only makes sense.","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"}],"sonobuoy/templates/service-account.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: ServiceAccount"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":8,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":9,"context_line":"---"},{"line_number":10,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":11,"context_line":"kind: ClusterRoleBinding"},{"line_number":12,"context_line":"metadata:"},{"line_number":13,"context_line":"  labels:"},{"line_number":14,"context_line":"    component: sonobuoy"},{"line_number":15,"context_line":"  name: sonobuoy-serviceaccount-heptio-sonobuoy"},{"line_number":16,"context_line":"roleRef:"},{"line_number":17,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":18,"context_line":"  kind: ClusterRole"},{"line_number":19,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":20,"context_line":"subjects:"},{"line_number":21,"context_line":"- kind: ServiceAccount"},{"line_number":22,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":23,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":26,"context_line":"kind: ClusterRole"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  labels:"},{"line_number":29,"context_line":"    component: sonobuoy"},{"line_number":30,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":31,"context_line":"rules:"},{"line_number":32,"context_line":"- apiGroups:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"  resources:"},{"line_number":35,"context_line":"  - \u0027*\u0027"},{"line_number":36,"context_line":"  verbs:"},{"line_number":37,"context_line":"  - \u0027*\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_9bd5734a","line":37,"range":{"start_line":1,"start_character":0,"end_line":37,"end_character":7},"updated":"2018-09-24 20:57:25.000000000","message":"This can all be generated with helm-toolkit. For reference: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L23-L24","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: ServiceAccount"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":8,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":9,"context_line":"---"},{"line_number":10,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":11,"context_line":"kind: ClusterRoleBinding"},{"line_number":12,"context_line":"metadata:"},{"line_number":13,"context_line":"  labels:"},{"line_number":14,"context_line":"    component: sonobuoy"},{"line_number":15,"context_line":"  name: sonobuoy-serviceaccount-heptio-sonobuoy"},{"line_number":16,"context_line":"roleRef:"},{"line_number":17,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":18,"context_line":"  kind: ClusterRole"},{"line_number":19,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":20,"context_line":"subjects:"},{"line_number":21,"context_line":"- kind: ServiceAccount"},{"line_number":22,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":23,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":26,"context_line":"kind: ClusterRole"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  labels:"},{"line_number":29,"context_line":"    component: sonobuoy"},{"line_number":30,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":31,"context_line":"rules:"},{"line_number":32,"context_line":"- apiGroups:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"  resources:"},{"line_number":35,"context_line":"  - \u0027*\u0027"},{"line_number":36,"context_line":"  verbs:"},{"line_number":37,"context_line":"  - \u0027*\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_1447db79","line":37,"range":{"start_line":1,"start_character":0,"end_line":37,"end_character":7},"in_reply_to":"3f79a3b5_8473c04e","updated":"2018-09-25 20:36:34.000000000","message":"As Matt said I don\u0027t think that helm-toolkit template is applicable. Debated using replace to add ClusterRole/Binding, but I also have additional labels needed.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d4d53be86daab82f9e71cc4066e41ae9ce736abb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: ServiceAccount"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":8,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":9,"context_line":"---"},{"line_number":10,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":11,"context_line":"kind: ClusterRoleBinding"},{"line_number":12,"context_line":"metadata:"},{"line_number":13,"context_line":"  labels:"},{"line_number":14,"context_line":"    component: sonobuoy"},{"line_number":15,"context_line":"  name: sonobuoy-serviceaccount-heptio-sonobuoy"},{"line_number":16,"context_line":"roleRef:"},{"line_number":17,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":18,"context_line":"  kind: ClusterRole"},{"line_number":19,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":20,"context_line":"subjects:"},{"line_number":21,"context_line":"- kind: ServiceAccount"},{"line_number":22,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":23,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":26,"context_line":"kind: ClusterRole"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  labels:"},{"line_number":29,"context_line":"    component: sonobuoy"},{"line_number":30,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":31,"context_line":"rules:"},{"line_number":32,"context_line":"- apiGroups:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"  resources:"},{"line_number":35,"context_line":"  - \u0027*\u0027"},{"line_number":36,"context_line":"  verbs:"},{"line_number":37,"context_line":"  - \u0027*\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_8473c04e","line":37,"range":{"start_line":1,"start_character":0,"end_line":37,"end_character":7},"in_reply_to":"3f79a3b5_9bd5734a","updated":"2018-09-25 17:55:09.000000000","message":"ServiceAccount can be generated by HTK, but not (yet) ClusterRole/ClusterRoleBinding I believe","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"08610735ba05c0501c00075cad81bd2f7da062c7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.service_account }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ServiceAccount"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_8afbc6bc","line":17,"updated":"2018-09-25 21:17:03.000000000","message":"Should each resource in this file have its own manifest entry? Or should each resource be a separate file? I left this how Alan prototyped it and I haven\u0027t thought anything of it.","commit_id":"cb7ffe2d4e3a51aeefaa89a11615ff230f06e3de"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"2748b822ac7dd5a4495d28cfaa130d3c33fe0d7d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.service_account }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ServiceAccount"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_2a02b273","line":17,"in_reply_to":"3f79a3b5_8afbc6bc","updated":"2018-09-25 21:29:26.000000000","message":"Yep typically each resource should have its own, e.g. \nhttps://github.com/openstack/openstack-helm/blob/master/keystone/values.yaml#L1061-L1086","commit_id":"cb7ffe2d4e3a51aeefaa89a11615ff230f06e3de"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"fd233c935f53680e8e8310e89e1ad29e2035e710","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.service_account }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ServiceAccount"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  labels:"},{"line_number":23,"context_line":"    component: sonobuoy"},{"line_number":24,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":25,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":26,"context_line":"---"},{"line_number":27,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":28,"context_line":"kind: ClusterRoleBinding"},{"line_number":29,"context_line":"metadata:"},{"line_number":30,"context_line":"  labels:"},{"line_number":31,"context_line":"    component: sonobuoy"},{"line_number":32,"context_line":"  name: sonobuoy-serviceaccount-heptio-sonobuoy"},{"line_number":33,"context_line":"roleRef:"},{"line_number":34,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":35,"context_line":"  kind: ClusterRole"},{"line_number":36,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":37,"context_line":"subjects:"},{"line_number":38,"context_line":"- kind: ServiceAccount"},{"line_number":39,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":40,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":41,"context_line":"---"},{"line_number":42,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":43,"context_line":"kind: ClusterRole"},{"line_number":44,"context_line":"metadata:"},{"line_number":45,"context_line":"  labels:"},{"line_number":46,"context_line":"    component: sonobuoy"},{"line_number":47,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":48,"context_line":"rules:"},{"line_number":49,"context_line":"- apiGroups:"},{"line_number":50,"context_line":"  - \u0027*\u0027"},{"line_number":51,"context_line":"  resources:"},{"line_number":52,"context_line":"  - \u0027*\u0027"},{"line_number":53,"context_line":"  verbs:"},{"line_number":54,"context_line":"  - \u0027*\u0027"},{"line_number":55,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_376c40cf","line":54,"range":{"start_line":18,"start_character":0,"end_line":54,"end_character":7},"updated":"2018-09-26 18:05:33.000000000","message":"just add these to the pod, eg: \n * https://github.com/openstack/openstack-helm-infra/blob/master/ceph-provisioners/templates/deployment-rbd-provisioner.yaml#L23-L105","commit_id":"cb7ffe2d4e3a51aeefaa89a11615ff230f06e3de"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"16d4105b3cfc6c1370add210530e822d9fdddaf9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.service_account }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ServiceAccount"},{"line_number":21,"context_line":"metadata:"},{"line_number":22,"context_line":"  labels:"},{"line_number":23,"context_line":"    component: sonobuoy"},{"line_number":24,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":25,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":26,"context_line":"---"},{"line_number":27,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":28,"context_line":"kind: ClusterRoleBinding"},{"line_number":29,"context_line":"metadata:"},{"line_number":30,"context_line":"  labels:"},{"line_number":31,"context_line":"    component: sonobuoy"},{"line_number":32,"context_line":"  name: sonobuoy-serviceaccount-heptio-sonobuoy"},{"line_number":33,"context_line":"roleRef:"},{"line_number":34,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":35,"context_line":"  kind: ClusterRole"},{"line_number":36,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":37,"context_line":"subjects:"},{"line_number":38,"context_line":"- kind: ServiceAccount"},{"line_number":39,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":40,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":41,"context_line":"---"},{"line_number":42,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":43,"context_line":"kind: ClusterRole"},{"line_number":44,"context_line":"metadata:"},{"line_number":45,"context_line":"  labels:"},{"line_number":46,"context_line":"    component: sonobuoy"},{"line_number":47,"context_line":"  name: sonobuoy-serviceaccount"},{"line_number":48,"context_line":"rules:"},{"line_number":49,"context_line":"- apiGroups:"},{"line_number":50,"context_line":"  - \u0027*\u0027"},{"line_number":51,"context_line":"  resources:"},{"line_number":52,"context_line":"  - \u0027*\u0027"},{"line_number":53,"context_line":"  verbs:"},{"line_number":54,"context_line":"  - \u0027*\u0027"},{"line_number":55,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_b79a906c","line":54,"range":{"start_line":18,"start_character":0,"end_line":54,"end_character":7},"in_reply_to":"3f79a3b5_376c40cf","updated":"2018-09-26 18:28:18.000000000","message":"Adjusted, thanks!","commit_id":"cb7ffe2d4e3a51aeefaa89a11615ff230f06e3de"}],"sonobuoy/templates/service-api.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fa0c9cb8a630f1b669ca6efb6f62571ff89ec712","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Service"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"  name: sonobuoy-master"},{"line_number":9,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":10,"context_line":"spec:"},{"line_number":11,"context_line":"  ports:"},{"line_number":12,"context_line":"  - port: 8080"},{"line_number":13,"context_line":"    protocol: TCP"},{"line_number":14,"context_line":"    targetPort: 8080"},{"line_number":15,"context_line":"  selector:"},{"line_number":16,"context_line":"    run: sonobuoy-master"},{"line_number":17,"context_line":"  type: ClusterIP"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_fbcd87ba","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":17},"updated":"2018-09-24 20:57:25.000000000","message":"Can we structure this template similar to other charts?\nhttps://github.com/openstack/openstack-helm/blob/master/keystone/templates/service-api.yaml","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: v1"},{"line_number":3,"context_line":"kind: Service"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  labels:"},{"line_number":6,"context_line":"    component: sonobuoy"},{"line_number":7,"context_line":"    run: sonobuoy-master"},{"line_number":8,"context_line":"  name: sonobuoy-master"},{"line_number":9,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":10,"context_line":"spec:"},{"line_number":11,"context_line":"  ports:"},{"line_number":12,"context_line":"  - port: 8080"},{"line_number":13,"context_line":"    protocol: TCP"},{"line_number":14,"context_line":"    targetPort: 8080"},{"line_number":15,"context_line":"  selector:"},{"line_number":16,"context_line":"    run: sonobuoy-master"},{"line_number":17,"context_line":"  type: ClusterIP"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_67e22333","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":17},"in_reply_to":"3f79a3b5_fbcd87ba","updated":"2018-09-25 20:36:34.000000000","message":"I fixed what seemed applicable.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1893e5f178ebc47f102c22ae1b89105249cecf30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- if .Values.manifests.service_api }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Service"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  labels:"},{"line_number":25,"context_line":"    component: sonobuoy"},{"line_number":26,"context_line":"    run: sonobuoy-master"},{"line_number":27,"context_line":"  name: {{ tuple \"sonobuoy\" \"internal\" $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":28,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  ports:"},{"line_number":31,"context_line":"  - port: {{ tuple \"sonobuoy\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":32,"context_line":"    protocol: TCP"},{"line_number":33,"context_line":"    targetPort: {{ tuple \"sonobuoy\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":34,"context_line":"  selector:"},{"line_number":35,"context_line":"    run: sonobuoy-master"},{"line_number":36,"context_line":"  type: ClusterIP"},{"line_number":37,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_55b522cf","line":37,"range":{"start_line":1,"start_character":0,"end_line":37,"end_character":10},"updated":"2018-09-27 13:27:18.000000000","message":"If we\u0027re just launching sonobuoy as a helm test, I dont think we need a service after all","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"c32b6542964b9d9be8231b536307b295ff34289f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- if .Values.manifests.service_api }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Service"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  labels:"},{"line_number":25,"context_line":"    component: sonobuoy"},{"line_number":26,"context_line":"    run: sonobuoy-master"},{"line_number":27,"context_line":"  name: {{ tuple \"sonobuoy\" \"internal\" $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":28,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  ports:"},{"line_number":31,"context_line":"  - port: {{ tuple \"sonobuoy\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":32,"context_line":"    protocol: TCP"},{"line_number":33,"context_line":"    targetPort: {{ tuple \"sonobuoy\" \"internal\" \"api\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":34,"context_line":"  selector:"},{"line_number":35,"context_line":"    run: sonobuoy-master"},{"line_number":36,"context_line":"  type: ClusterIP"},{"line_number":37,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_b54036a4","line":37,"range":{"start_line":1,"start_character":0,"end_line":37,"end_character":10},"in_reply_to":"3f79a3b5_55b522cf","updated":"2018-09-27 13:40:35.000000000","message":"I was wondering that. I had tried removing it and helm test still passed. Wasn\u0027t sure if Alan had something in mind when he added it. But originally Sonobuoy pod wasn\u0027t a helm test, so a service would have made sense back then.\n\nI removed it. We can always add back later if Alan wants it.","commit_id":"4c50d2e749b70638edb27123a25f7ce75659d51a"}],"sonobuoy/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f51c09bb32979dd4dac074ec91441f7e66d553d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    timeoutseconds: 8000"},{"line_number":46,"context_line":"  Plugins:"},{"line_number":47,"context_line":"    - name: e2e"},{"line_number":48,"context_line":"  Limits:"},{"line_number":49,"context_line":"    PodLogs:"},{"line_number":50,"context_line":"      SizeLimitBytes: 10000"},{"line_number":51,"context_line":"  # NOTE: the workerImage should not be defined and is set in sonobuoy-etc"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7f6f1cfa","line":48,"range":{"start_line":48,"start_character":1,"end_line":48,"end_character":3},"updated":"2018-09-25 07:13:35.000000000","message":"are these keys uppercase?  the casing looks inconsistent.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    timeoutseconds: 8000"},{"line_number":46,"context_line":"  Plugins:"},{"line_number":47,"context_line":"    - name: e2e"},{"line_number":48,"context_line":"  Limits:"},{"line_number":49,"context_line":"    PodLogs:"},{"line_number":50,"context_line":"      SizeLimitBytes: 10000"},{"line_number":51,"context_line":"  # NOTE: the workerImage should not be defined and is set in sonobuoy-etc"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e99056f6","line":48,"range":{"start_line":48,"start_character":1,"end_line":48,"end_character":3},"in_reply_to":"3f79a3b5_7f6f1cfa","updated":"2018-09-25 20:36:34.000000000","message":"I uppercased WorkerImage and ImagePullPolicy. This matches what Sonobuoy generates via `sonobuoy gen`.","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f51c09bb32979dd4dac074ec91441f7e66d553d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      SizeLimitBytes: 10000"},{"line_number":51,"context_line":"  # NOTE: the workerImage should not be defined and is set in sonobuoy-etc"},{"line_number":52,"context_line":"  workerImage: null"},{"line_number":53,"context_line":"  imagepullpolocy: ifnotpresent"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"plugins:"},{"line_number":56,"context_line":"  - name: e2e.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_ffbecc62","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":17},"updated":"2018-09-25 07:13:35.000000000","message":"typo?","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"d4d53be86daab82f9e71cc4066e41ae9ce736abb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      SizeLimitBytes: 10000"},{"line_number":51,"context_line":"  # NOTE: the workerImage should not be defined and is set in sonobuoy-etc"},{"line_number":52,"context_line":"  workerImage: null"},{"line_number":53,"context_line":"  imagepullpolocy: ifnotpresent"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"plugins:"},{"line_number":56,"context_line":"  - name: e2e.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_04957032","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":17},"in_reply_to":"3f79a3b5_ffbecc62","updated":"2018-09-25 17:55:09.000000000","message":"Eagle Eye Tin!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7cc13f90560ac1ce1affd6b6669be6a46392e5a1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      SizeLimitBytes: 10000"},{"line_number":51,"context_line":"  # NOTE: the workerImage should not be defined and is set in sonobuoy-etc"},{"line_number":52,"context_line":"  workerImage: null"},{"line_number":53,"context_line":"  imagepullpolocy: ifnotpresent"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"plugins:"},{"line_number":56,"context_line":"  - name: e2e.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0996f2f0","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":17},"in_reply_to":"3f79a3b5_ffbecc62","updated":"2018-09-25 20:36:34.000000000","message":"Fixed!","commit_id":"d2e6e20376bed7fdd32f0d229440d21626bf7786"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6275504630460f7b191c2a016b11ffdcdfa811dc","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"images:"},{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    e2e: gcr.io/heptio-images/kube-conformance:latest"},{"line_number":28,"context_line":"    sonobuoy_api: gcr.io/heptio-images/sonobuoy:v0.11.4"},{"line_number":29,"context_line":"  pull_policy: IfNotPresent"},{"line_number":30,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_632b8532","line":27,"range":{"start_line":27,"start_character":47,"end_line":27,"end_character":53},"updated":"2018-10-01 13:17:19.000000000","message":"Is there a tag other than latest we can use?","commit_id":"e2a0e2fd5b208d6fcc0035095ed93682f6f1bff6"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"b08e4d37a5d2204fffe914f184c312f4c8acd2eb","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"images:"},{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    e2e: gcr.io/heptio-images/kube-conformance:latest"},{"line_number":28,"context_line":"    sonobuoy_api: gcr.io/heptio-images/sonobuoy:v0.11.4"},{"line_number":29,"context_line":"  pull_policy: IfNotPresent"},{"line_number":30,"context_line":"  local_registry:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_daeb570f","line":27,"range":{"start_line":27,"start_character":47,"end_line":27,"end_character":53},"in_reply_to":"3f79a3b5_632b8532","updated":"2018-10-01 16:09:25.000000000","message":"Fixed - sort of. Ended up switching out the e2e plugin for the systemd-logs plugin. The systemd-logs plugin takes less than a minute to complete. The e2e plugin takes over an hour to complete, so I just swapped them.\n\nBut not using latest tag on systemd-logs image.","commit_id":"e2a0e2fd5b208d6fcc0035095ed93682f6f1bff6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1c8581678c417c471b7cdb10f7eab326be09aa27","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  WorkerImage: null"},{"line_number":56,"context_line":"  ImagePullPolicy: IfNotPresent"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"plugins:"},{"line_number":59,"context_line":"  - name: e2e.yaml"},{"line_number":60,"context_line":"    data: |"},{"line_number":61,"context_line":"      sonobuoy-config:"},{"line_number":62,"context_line":"        driver: Job"},{"line_number":63,"context_line":"        plugin-name: e2e"},{"line_number":64,"context_line":"        result-type: e2e"},{"line_number":65,"context_line":"      spec:"},{"line_number":66,"context_line":"        env:"},{"line_number":67,"context_line":"        - name: E2E_FOCUS"},{"line_number":68,"context_line":"          value: \u0027\\[Conformance\\]\u0027"},{"line_number":69,"context_line":"        - name: E2E_SKIP"},{"line_number":70,"context_line":"          value: \u0027Alpha|Kubectl|\\[(Disruptive|Feature:[^\\]]+|Flaky)\\]\u0027"},{"line_number":71,"context_line":"        - name: E2E_PARALLEL"},{"line_number":72,"context_line":"          value: \u00271\u0027"},{"line_number":73,"context_line":"        command: [\"/run_e2e.sh\"]"},{"line_number":74,"context_line":"        image: {{ .Values.images.tags.e2e }}"},{"line_number":75,"context_line":"        imagePullPolicy: Always"},{"line_number":76,"context_line":"        name: e2e"},{"line_number":77,"context_line":"        volumeMounts:"},{"line_number":78,"context_line":"        - mountPath: /tmp/results"},{"line_number":79,"context_line":"          name: results"},{"line_number":80,"context_line":"          readOnly: false"},{"line_number":81,"context_line":"        tolerations:"},{"line_number":82,"context_line":"          - operator: \"Exists\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"dependencies:"},{"line_number":85,"context_line":"  dynamic: {}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_03f41186","line":82,"range":{"start_line":58,"start_character":0,"end_line":82,"end_character":30},"updated":"2018-10-01 13:23:20.000000000","message":"It\u0027d be nice to somehow get this under the conf: key to reduce top-level key sprawl.","commit_id":"e2a0e2fd5b208d6fcc0035095ed93682f6f1bff6"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"b08e4d37a5d2204fffe914f184c312f4c8acd2eb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  WorkerImage: null"},{"line_number":56,"context_line":"  ImagePullPolicy: IfNotPresent"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"plugins:"},{"line_number":59,"context_line":"  - name: e2e.yaml"},{"line_number":60,"context_line":"    data: |"},{"line_number":61,"context_line":"      sonobuoy-config:"},{"line_number":62,"context_line":"        driver: Job"},{"line_number":63,"context_line":"        plugin-name: e2e"},{"line_number":64,"context_line":"        result-type: e2e"},{"line_number":65,"context_line":"      spec:"},{"line_number":66,"context_line":"        env:"},{"line_number":67,"context_line":"        - name: E2E_FOCUS"},{"line_number":68,"context_line":"          value: \u0027\\[Conformance\\]\u0027"},{"line_number":69,"context_line":"        - name: E2E_SKIP"},{"line_number":70,"context_line":"          value: \u0027Alpha|Kubectl|\\[(Disruptive|Feature:[^\\]]+|Flaky)\\]\u0027"},{"line_number":71,"context_line":"        - name: E2E_PARALLEL"},{"line_number":72,"context_line":"          value: \u00271\u0027"},{"line_number":73,"context_line":"        command: [\"/run_e2e.sh\"]"},{"line_number":74,"context_line":"        image: {{ .Values.images.tags.e2e }}"},{"line_number":75,"context_line":"        imagePullPolicy: Always"},{"line_number":76,"context_line":"        name: e2e"},{"line_number":77,"context_line":"        volumeMounts:"},{"line_number":78,"context_line":"        - mountPath: /tmp/results"},{"line_number":79,"context_line":"          name: results"},{"line_number":80,"context_line":"          readOnly: false"},{"line_number":81,"context_line":"        tolerations:"},{"line_number":82,"context_line":"          - operator: \"Exists\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"dependencies:"},{"line_number":85,"context_line":"  dynamic: {}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_3ada8b78","line":82,"range":{"start_line":58,"start_character":0,"end_line":82,"end_character":30},"in_reply_to":"3f79a3b5_03f41186","updated":"2018-10-01 16:09:25.000000000","message":"Changed.","commit_id":"e2a0e2fd5b208d6fcc0035095ed93682f6f1bff6"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"04d338cdda8ff8503c242af1c5b63cd4f0769a10","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  sonobuoy:"},{"line_number":36,"context_line":"    Description: \"sonobuoy run for scanner.heptio.com\""},{"line_number":37,"context_line":"    Version: v0.11.4"},{"line_number":38,"context_line":"    ResultsDir: /tmp/resultshost"},{"line_number":39,"context_line":"    Resources:"},{"line_number":40,"context_line":"      - Nodes"},{"line_number":41,"context_line":"      - ServerVersion"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_53bf02fb","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":32},"updated":"2018-10-03 13:37:55.000000000","message":"Is this meant to be the same as the ResultsDir used in the entrypoint we\u0027re defining? If so, we could use this values entry to define a pod environment variable in the pod spec. That is, unless Sonobuoy is smart enough to override that value at start up with the value of this configuration entry","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"79315d1488620cd218ef466876c247e9627b013e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  sonobuoy:"},{"line_number":36,"context_line":"    Description: \"sonobuoy run for scanner.heptio.com\""},{"line_number":37,"context_line":"    Version: v0.11.4"},{"line_number":38,"context_line":"    ResultsDir: /tmp/resultshost"},{"line_number":39,"context_line":"    Resources:"},{"line_number":40,"context_line":"      - Nodes"},{"line_number":41,"context_line":"      - ServerVersion"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_c4602a38","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":32},"in_reply_to":"3f79a3b5_53bf02fb","updated":"2018-10-03 15:54:07.000000000","message":"Good catch! This was being overridden by the RESULTS_DIR env var.\n\nI made it so the sonobuoy-output volume is mounted at the location listed at this field.","commit_id":"a2fd8c9949480c9df002001a82ce8ef3785dd452"}],"tools/gate/playbooks/osh-addons-sonobuoy.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9e29204499b0ad2abec3cb7cd96b724261f58c12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: primary"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Install and Test Sonobuoy Chart"},{"line_number":4,"context_line":"      shell: |"},{"line_number":5,"context_line":"        set -xe;"},{"line_number":6,"context_line":"        ./tools/gate/scripts/sonobuoy.sh"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_966da168","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":40},"updated":"2018-10-02 15:59:17.000000000","message":"You\u0027ll need to add the args for changing to the project\u0027s root directory. Can use:https://github.com/openstack/openstack-helm-infra/blob/master/playbooks/osh-infra-dev-deploy-ceph.yaml#L21-L22","commit_id":"d9e231c1cc7e43a3211bedd6e27299ae85d18aca"}]}