)]}'
{"artifactory/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bffcbd1ef84fba30d5c6fb351561c7ec7a36fb90","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    env:"},{"line_number":167,"context_line":"      java_opts: \"-Xms512m -Xmx2g\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"chown_on_start: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_eab5c81a","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":20},"updated":"2018-10-17 15:06:17.000000000","message":"This should ideally be placed under conf, as we don\u0027t want to add a new top level key here to align with the values ordering spec","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"054e8bb8b600c2beb88427f430068748574cc71a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    env:"},{"line_number":167,"context_line":"      java_opts: \"-Xms512m -Xmx2g\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"chown_on_start: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_761c0866","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":20},"in_reply_to":"3f79a3b5_eab5c81a","updated":"2018-10-19 17:44:36.000000000","message":"I removed it because I didn\u0027t see it being used.","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bffcbd1ef84fba30d5c6fb351561c7ec7a36fb90","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"chown_on_start: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"storage: pvc"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_aa3590a9","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":19},"updated":"2018-10-17 15:06:17.000000000","message":"This can likely just be removed","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"054e8bb8b600c2beb88427f430068748574cc71a","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"chown_on_start: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"storage: pvc"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_961f6459","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":19},"in_reply_to":"3f79a3b5_aa3590a9","updated":"2018-10-19 17:44:36.000000000","message":"Done.","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"d77bc32b1e3344bfe9f057b0f46a8177597c2b1a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    env:"},{"line_number":167,"context_line":"      java_opts: \"-Xms512m -Xmx2g\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"chown_on_start: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"storage: pvc"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"volume:"},{"line_number":176,"context_line":"  size: 100Gi"},{"line_number":177,"context_line":"  class_name: general"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_8b3473ad","line":177,"range":{"start_line":169,"start_character":0,"end_line":177,"end_character":21},"updated":"2018-10-16 16:46:39.000000000","message":"I don\u0027t know the best place for these. I think ideally these would be under conf, but I\u0027m trying to avoid changing functionality of the chart.","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bffcbd1ef84fba30d5c6fb351561c7ec7a36fb90","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"storage: pvc"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"volume:"},{"line_number":176,"context_line":"  size: 100Gi"},{"line_number":177,"context_line":"  class_name: general"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_8acbf4a5","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":21},"updated":"2018-10-17 15:06:17.000000000","message":"These should be combined into one key, similar to: https://github.com/openstack/openstack-helm-infra/blob/master/prometheus/values.yaml#L219-L226","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"054e8bb8b600c2beb88427f430068748574cc71a","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"release_group: null"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"storage: pvc"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"volume:"},{"line_number":176,"context_line":"  size: 100Gi"},{"line_number":177,"context_line":"  class_name: general"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_363690ea","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":21},"in_reply_to":"3f79a3b5_8acbf4a5","updated":"2018-10-19 17:44:36.000000000","message":"I removed `storage: pvc` because I didn\u0027t see it being used.\n\nI changed volume to match your example.","commit_id":"df1890a1dfc2661e12de7d6ce7ecfe7ffbd81be3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"60d59bd49d2cd02d59df9dbcd7fa2fb6d11f4032","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    artifactory: quay.io/attcomdev/artifactory-pro-mysql:5.11.1"},{"line_number":18,"context_line":"    db_drop: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":19,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":20,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":21,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":22,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_498a7513","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":60},"updated":"2018-10-22 14:45:20.000000000","message":"I know it\u0027s unrelated to this change overall, but while we\u0027re here could we update these images to use the LOCI heat images instead? This helps bring the charts to a more consistent state: https://github.com/openstack/openstack-helm-infra/blob/master/fluent-logging/values.yaml#L46","commit_id":"0dfbd081d7f3adb25edeb97eae2da3de7a3aff59"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"f256e3c136139377e064906b81295e067d1d602a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    artifactory: quay.io/attcomdev/artifactory-pro-mysql:5.11.1"},{"line_number":18,"context_line":"    db_drop: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":19,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":20,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":21,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":22,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e96ca106","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":60},"in_reply_to":"3f79a3b5_498a7513","updated":"2018-10-22 14:58:20.000000000","message":"Done!","commit_id":"0dfbd081d7f3adb25edeb97eae2da3de7a3aff59"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"60d59bd49d2cd02d59df9dbcd7fa2fb6d11f4032","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  master_key: null"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"network:"},{"line_number":140,"context_line":"  node_ports:"},{"line_number":141,"context_line":"    enabled: false"},{"line_number":142,"context_line":"  http:"},{"line_number":143,"context_line":"    port: 8081"},{"line_number":144,"context_line":"    node_port: 31672"},{"line_number":145,"context_line":"  docker:"},{"line_number":146,"context_line":"    port: 5050"},{"line_number":147,"context_line":"    node_port: 31777"},{"line_number":148,"context_line":"  secure:"},{"line_number":149,"context_line":"    port: 5052"},{"line_number":150,"context_line":"    node_port: 31776"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"storage:"},{"line_number":153,"context_line":"  requests:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_89c08d2d","line":150,"range":{"start_line":140,"start_character":0,"end_line":150,"end_character":20},"updated":"2018-10-22 14:45:20.000000000","message":"Can we order these as well?","commit_id":"0dfbd081d7f3adb25edeb97eae2da3de7a3aff59"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"f256e3c136139377e064906b81295e067d1d602a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  master_key: null"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"network:"},{"line_number":140,"context_line":"  node_ports:"},{"line_number":141,"context_line":"    enabled: false"},{"line_number":142,"context_line":"  http:"},{"line_number":143,"context_line":"    port: 8081"},{"line_number":144,"context_line":"    node_port: 31672"},{"line_number":145,"context_line":"  docker:"},{"line_number":146,"context_line":"    port: 5050"},{"line_number":147,"context_line":"    node_port: 31777"},{"line_number":148,"context_line":"  secure:"},{"line_number":149,"context_line":"    port: 5052"},{"line_number":150,"context_line":"    node_port: 31776"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"storage:"},{"line_number":153,"context_line":"  requests:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_692f31a6","line":150,"range":{"start_line":140,"start_character":0,"end_line":150,"end_character":20},"in_reply_to":"3f79a3b5_89c08d2d","updated":"2018-10-22 14:58:20.000000000","message":"Yep, good catch. I alphabetized node_ports as well. Should that be first/last? Looks different than the other data. Happy to move it.","commit_id":"0dfbd081d7f3adb25edeb97eae2da3de7a3aff59"}]}