)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tony Sorrentino \u003cas1413@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-23 08:24:36 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Deploymnet of MySQL 5.6 instance for use by Ozone as ozone-db service."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I06738987169506af709092d1ab0b7cc03879fce2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_c8542600","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":16},"updated":"2018-10-23 13:38:20.000000000","message":"nitpick: spelling","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"}],"ozone-db/Chart.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":"icon: https://www.mysql.com/common/logos/logo-mysql-170x115.png"},{"line_number":21,"context_line":"sources:"},{"line_number":22,"context_line":"  - https://github.com/mysql/mysql-server"},{"line_number":23,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm"},{"line_number":24,"context_line":"maintainers:"},{"line_number":25,"context_line":"  - name: OpenStack-Helm Authors"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0d779009","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":59},"updated":"2018-10-23 13:38:20.000000000","message":"I\u0027d point to openstack-helm-addons.","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":20,"context_line":"icon: https://www.mysql.com/common/logos/logo-mysql-170x115.png"},{"line_number":21,"context_line":"sources:"},{"line_number":22,"context_line":"  - https://github.com/mysql/mysql-server"},{"line_number":23,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm-addon"},{"line_number":24,"context_line":"maintainers:"},{"line_number":25,"context_line":"  - name: OpenStack-Helm Authors"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_8dd4f91f","line":23,"range":{"start_line":23,"start_character":60,"end_line":23,"end_character":65},"updated":"2018-10-23 17:37:37.000000000","message":"addons","commit_id":"692b85cc3ce786f13f8654fc6fc1925244a68969"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":20,"context_line":"icon: https://www.mysql.com/common/logos/logo-mysql-170x115.png"},{"line_number":21,"context_line":"sources:"},{"line_number":22,"context_line":"  - https://github.com/mysql/mysql-server"},{"line_number":23,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm-addon"},{"line_number":24,"context_line":"maintainers:"},{"line_number":25,"context_line":"  - name: OpenStack-Helm Authors"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_adb45582","line":23,"range":{"start_line":23,"start_character":60,"end_line":23,"end_character":65},"updated":"2018-10-23 17:37:37.000000000","message":"addons","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"}],"ozone-db/templates/configmap-bin.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $configMapBinName :\u003d printf \"%s-%s\" $envAll.Release.Name \"etcd-bin\"  }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ad569c5d","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":21},"updated":"2018-10-23 13:38:20.000000000","message":"This doesn\u0027t look like it\u0027s being used. I\u0027d remove or use.","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"}],"ozone-db/templates/statefulset.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - apiGroups:"},{"line_number":30,"context_line":"      - \"\""},{"line_number":31,"context_line":"    resources:"},{"line_number":32,"context_line":"      - configmaps"},{"line_number":33,"context_line":"    verbs:"},{"line_number":34,"context_line":"      - create"},{"line_number":35,"context_line":"      - get"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0d61d010","line":32,"updated":"2018-10-23 13:38:20.000000000","message":"For my own curiosity: why is ozone creating, deleting configmaps, etc?","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - patch"},{"line_number":38,"context_line":"      - update"},{"line_number":39,"context_line":"      - watch"},{"line_number":40,"context_line":"      # delete is required only for"},{"line_number":41,"context_line":"      - delete"},{"line_number":42,"context_line":"  - apiGroups:"},{"line_number":43,"context_line":"      - \"\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_cd9c380f","line":40,"updated":"2018-10-23 13:38:20.000000000","message":"?","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - apiGroups:"},{"line_number":43,"context_line":"      - \"\""},{"line_number":44,"context_line":"    resources:"},{"line_number":45,"context_line":"      - endpoints"},{"line_number":46,"context_line":"    verbs:"},{"line_number":47,"context_line":"      - get"},{"line_number":48,"context_line":"      - patch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ed2b3498","line":45,"updated":"2018-10-23 13:38:20.000000000","message":"For my own curiosity: why is ozone creating, deleting endpoints, etc?","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      - get"},{"line_number":48,"context_line":"      - patch"},{"line_number":49,"context_line":"      - update"},{"line_number":50,"context_line":"      # the following three privileges are necessary only when using endpoints"},{"line_number":51,"context_line":"      - create"},{"line_number":52,"context_line":"      - list"},{"line_number":53,"context_line":"      - watch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_8d55e021","line":50,"updated":"2018-10-23 13:38:20.000000000","message":"Should this be an if condition that is configured by values.yaml?","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      - create"},{"line_number":52,"context_line":"      - list"},{"line_number":53,"context_line":"      - watch"},{"line_number":54,"context_line":"      # delete is required only for for"},{"line_number":55,"context_line":"      - delete"},{"line_number":56,"context_line":"  - apiGroups:"},{"line_number":57,"context_line":"      - \"\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_4d8828c2","line":54,"updated":"2018-10-23 13:38:20.000000000","message":"?","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":27,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":28,"context_line":"rules:"},{"line_number":29,"context_line":"  - apiGroups:"},{"line_number":30,"context_line":"      - \"\""},{"line_number":31,"context_line":"    resources:"},{"line_number":32,"context_line":"      - pods"},{"line_number":33,"context_line":"    verbs:"},{"line_number":34,"context_line":"      - get"},{"line_number":35,"context_line":"      - list"},{"line_number":36,"context_line":"      - patch"},{"line_number":37,"context_line":"      - update"},{"line_number":38,"context_line":"      - watch"},{"line_number":39,"context_line":"---"},{"line_number":40,"context_line":"apiVersion: rbac.authorization.k8s.io/v1beta1"},{"line_number":41,"context_line":"kind: RoleBinding"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_cd2c31b4","line":38,"range":{"start_line":28,"start_character":0,"end_line":38,"end_character":13},"updated":"2018-10-23 17:37:37.000000000","message":"After seeing the configmaps and endpoints removed. Does this need to create pods? These roles, etc. are for a container to create kubernetes resources. If ozone is not creating resources dynamically from a container then this Role, RoleBinding, and ServiceAccount are not needed in my understanding.","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"}],"ozone-db/values.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"6bf9357005fdaef780a92fc3b95625ab0a9e67ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f79a3b5_482b367b","updated":"2018-10-23 13:38:20.000000000","message":"Do you mind re-organizing this file to match examples in: https://review.openstack.org/#/c/610963/\n\nThat changeset links to proposed specs for values.yaml.","commit_id":"8a52d1c526ad5a9cc0d19e4b86cfa19571e4b5ba"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare variables to be passed into your templates."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"release_group: null"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"images:"},{"line_number":22,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_ad3775fd","line":19,"updated":"2018-10-23 17:37:37.000000000","message":"This can be removed.","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"images:"},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    ozone-db: \"docker.io/as1413/ozone-db:v5.6\""},{"line_number":24,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":25,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":26,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_1814a541","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":46},"updated":"2018-10-23 17:37:37.000000000","message":"I don\u0027t know if this will get accepted. Is it possible to move this image under one of the AT\u0026T namespaces, etc? instead of a personal account?\n\nI don\u0027t know if  this is considered an issue.\n\nI also don\u0027t know what this ozone-db image is doing. Is it possible to use an existing public image and provide a conf?","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          - endpoint: node"},{"line_number":46,"context_line":"            service: local_image_registry"},{"line_number":47,"context_line":"  static:"},{"line_number":48,"context_line":"    ozone-db:"},{"line_number":49,"context_line":"      jobs: null"},{"line_number":50,"context_line":"    image_repo_sync:"},{"line_number":51,"context_line":"      services:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_98199577","line":48,"updated":"2018-10-23 17:37:37.000000000","message":"ozone-db should be after image_repo_sync.","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  job_image_repo_sync: true"},{"line_number":58,"context_line":"  secret_admin: true"},{"line_number":59,"context_line":"  service: true"},{"line_number":60,"context_line":"  monitoring:"},{"line_number":61,"context_line":"    prometheus:"},{"line_number":62,"context_line":"      enabled: false"},{"line_number":63,"context_line":"      service_exporter: false"},{"line_number":64,"context_line":"  statefulset: true"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"pod:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_1842653d","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":29},"updated":"2018-10-23 17:37:37.000000000","message":"Is monitoring being used?","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"190153c44b74133a14958ff9c87e9e3bb255c621","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      ozone-db:"},{"line_number":139,"context_line":"        default: 3306"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"monitoring:"},{"line_number":142,"context_line":"  prometheus:"},{"line_number":143,"context_line":"    enabled: false"},{"line_number":144,"context_line":"    ozonedb_exporter:"},{"line_number":145,"context_line":"      scrape: true"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_182d858f","line":145,"range":{"start_line":141,"start_character":0,"end_line":145,"end_character":18},"updated":"2018-10-23 17:37:37.000000000","message":"Can we remove this since this also exists in manifests?","commit_id":"94d6cfa7ac70f2097fdc6602bb9510986232c948"}]}