)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0a8d15414662203d01c38a343acd24bc491239fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The reason the secret is used to mount the service account token because"},{"line_number":18,"context_line":"there is not a way to specify a service account from just a container"},{"line_number":19,"context_line":"spec [1]. Sonobuoy doesn\u0027t provide access to the pod spec for plugins, so"},{"line_number":20,"context_line":"we are limited to the container spec."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/kubernetes/kubernetes/issues/66020"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fdfeff1_5a18451c","line":19,"range":{"start_line":19,"start_character":67,"end_line":19,"end_character":73},"updated":"2019-01-22 04:30:23.000000000","message":"wrap / M-q","commit_id":"61051cd8f58e4b767a7fa24488679aa112b1dc48"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"31e555d9994044d658d6b3c953dee10c1662730b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The reason the secret is used to mount the service account token because"},{"line_number":18,"context_line":"there is not a way to specify a service account from just a container"},{"line_number":19,"context_line":"spec [1]. Sonobuoy doesn\u0027t provide access to the pod spec for plugins, so"},{"line_number":20,"context_line":"we are limited to the container spec."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/kubernetes/kubernetes/issues/66020"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fdfeff1_39ff86ab","line":19,"range":{"start_line":19,"start_character":67,"end_line":19,"end_character":73},"in_reply_to":"9fdfeff1_5a18451c","updated":"2019-01-22 14:27:46.000000000","message":"Thanks, done!","commit_id":"61051cd8f58e4b767a7fa24488679aa112b1dc48"}],"sonobuoy/templates/serviceaccount-readonly.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"371e476641d07a2d5fe0dfba613a5fe63ad924d0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"kind: ClusterRole"},{"line_number":67,"context_line":"metadata:"},{"line_number":68,"context_line":"  name: sonobuoy-readonly-clusterrole"},{"line_number":69,"context_line":"rules:"},{"line_number":70,"context_line":"- apiGroups:"},{"line_number":71,"context_line":"  - \"\""},{"line_number":72,"context_line":"  resources:"},{"line_number":73,"context_line":"  - \"pods\""},{"line_number":74,"context_line":"  verbs:"},{"line_number":75,"context_line":"  - \"get\""},{"line_number":76,"context_line":"  - \"list\""},{"line_number":77,"context_line":"---"},{"line_number":78,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":79,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_83994c7b","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":10},"updated":"2018-10-22 13:37:30.000000000","message":"Should I make this configurable via values.yaml? If so, I think I should also rename this service account because it is no longer guaranteed to be read only.\n\nI\u0027m limiting to pods get/list for now because we do not have a need for anything else, yet.","commit_id":"ac829a8cb20575c56272978d442322d56c4bfb57"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"e5bc43197895595cf4c863623d101a42d8172c68","unresolved":false,"context_lines":[{"line_number":66,"context_line":"kind: ClusterRole"},{"line_number":67,"context_line":"metadata:"},{"line_number":68,"context_line":"  name: sonobuoy-readonly-clusterrole"},{"line_number":69,"context_line":"rules:"},{"line_number":70,"context_line":"- apiGroups:"},{"line_number":71,"context_line":"  - \"\""},{"line_number":72,"context_line":"  resources:"},{"line_number":73,"context_line":"  - \"pods\""},{"line_number":74,"context_line":"  verbs:"},{"line_number":75,"context_line":"  - \"get\""},{"line_number":76,"context_line":"  - \"list\""},{"line_number":77,"context_line":"---"},{"line_number":78,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":79,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e3c12032","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":10},"updated":"2018-10-22 13:40:19.000000000","message":"Should I make this configurable via values.yaml? If so, I think I should also rename this service account because it is no longer guaranteed to be read only.\n\nI\u0027m limiting to pods get/list for now because we do not have a need for anything else, yet.","commit_id":"9a8ea386476f072124f8603031577f3d3681ff07"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"68182cc48ec5f72222cbbb0902017f0474f225d0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"kind: ClusterRole"},{"line_number":67,"context_line":"metadata:"},{"line_number":68,"context_line":"  name: sonobuoy-readonly-clusterrole"},{"line_number":69,"context_line":"rules:"},{"line_number":70,"context_line":"- apiGroups:"},{"line_number":71,"context_line":"  - \"\""},{"line_number":72,"context_line":"  resources:"},{"line_number":73,"context_line":"  - \"pods\""},{"line_number":74,"context_line":"  verbs:"},{"line_number":75,"context_line":"  - \"get\""},{"line_number":76,"context_line":"  - \"list\""},{"line_number":77,"context_line":"---"},{"line_number":78,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":79,"context_line":"kind: ClusterRoleBinding"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_86b39a4e","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":10},"in_reply_to":"3f79a3b5_e3c12032","updated":"2018-10-22 13:56:11.000000000","message":"I was thinking about making this get/list/watch for all resources to prevent needing to configure this in most cases, but I think that lets clients access secrets and that doesn\u0027t always seem desirable. Opinions?","commit_id":"9a8ea386476f072124f8603031577f3d3681ff07"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0a8d15414662203d01c38a343acd24bc491239fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_fad25934","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2019-01-22 04:30:23.000000000","message":"2019","commit_id":"61051cd8f58e4b767a7fa24488679aa112b1dc48"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"31e555d9994044d658d6b3c953dee10c1662730b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_d92d1a47","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"in_reply_to":"9fdfeff1_fad25934","updated":"2019-01-22 14:27:46.000000000","message":"Thanks, done!","commit_id":"61051cd8f58e4b767a7fa24488679aa112b1dc48"}]}