)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"daa0bc8fbaacbac5920ef2ee1b82d1092379351b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hosingh000 \u003chosingh000@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-30 12:04:19 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tls service configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifa2a97334c83901af705a061a0d8fd9cc1753651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_975469ff","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2018-10-31 14:06:08.000000000","message":"Can we get a more thorough commit message here? We should realistically call out all changes made here, namely:\n1. Corrected the tls secret keys\n2. Removed ingress definitions that arent required\n3. Added the backendService to the ingress definitions","commit_id":"320e4790ddd5f500192a248c1c334200b2716f27"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"802449ebbac7ca100ee4d7889029000ea8d43c37","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-10-31 09:41:18 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tls, services chart configurations"},{"line_number":8,"context_line":"1. Fix tls secret keys identification for services"},{"line_number":9,"context_line":"2. Removed ingress definitions for uuid and audit which are not required for now"},{"line_number":10,"context_line":"3. Fix flag for ingress definitions in rds"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifa2a97334c83901af705a061a0d8fd9cc1753651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_0e26f8ba","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":4},"updated":"2018-11-01 04:17:25.000000000","message":"nit: blank line after first line to make short git log pretty","commit_id":"ca2878611e90f389f88400b5beab4a9344086e34"}],"ranger/templates/secret-ingress-tls.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"abd3f81168db195ba5fe1ef5304c43bf0d9ea208","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_ingress_tls }}"},{"line_number":18,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendService\" \"cms\" \"backendServiceType\" \"cms\" ) }}"},{"line_number":19,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendService\" \"fms\" \"backendServiceType\" \"fms\" ) }}"},{"line_number":20,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendService\" \"ims\" \"backendServiceType\" \"ims\" ) }}"},{"line_number":21,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendService\" \"rms\" \"backendServiceType\" \"rms\" ) }}"},{"line_number":22,"context_line":"{{- include \"helm-toolkit.manifests.secret_ingress_tls\" ( dict \"envAll\" . \"backendService\" \"rds\" \"backendServiceType\" \"rds\" ) }}"},{"line_number":23,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d91e0874","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":10},"updated":"2018-11-07 16:45:12.000000000","message":"As a follow up, I\u0027d like to see each of these individual entries wrapped in a conditional check on whether the associated ingress is enabled. This is the only chart that has multiple ingresses defined in a single template, so want to make sure we\u0027re only creating secret entries for the ingresses that are explicitly enabled","commit_id":"ca2878611e90f389f88400b5beab4a9344086e34"}]}