)]}'
{"sonobuoy/templates/pod-api.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"812edc3806d95907a8bbfad74024249a6b990601","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.pod_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":24,"context_line":"kind: ClusterRole"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":27,"context_line":"rules:"},{"line_number":28,"context_line":"- apiGroups:"},{"line_number":29,"context_line":"  - \u0027*\u0027"},{"line_number":30,"context_line":"  resources:"},{"line_number":31,"context_line":"  - \u0027*\u0027"},{"line_number":32,"context_line":"  verbs:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"---"},{"line_number":35,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":36,"context_line":"kind: ClusterRoleBinding"},{"line_number":37,"context_line":"metadata:"},{"line_number":38,"context_line":"  name: {{ $serviceAccountName }}-heptio-sonobuoy-{{ .Release.Namespace }}"},{"line_number":39,"context_line":"roleRef:"},{"line_number":40,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":41,"context_line":"  kind: ClusterRole"},{"line_number":42,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":43,"context_line":"subjects:"},{"line_number":44,"context_line":"- kind: ServiceAccount"},{"line_number":45,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":46,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":47,"context_line":"---"},{"line_number":48,"context_line":"apiVersion: v1"},{"line_number":49,"context_line":"kind: Pod"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_6b74ef36","line":46,"range":{"start_line":20,"start_character":1,"end_line":46,"end_character":44},"updated":"2019-02-12 19:18:16.000000000","message":"We can handle this similar to how we do with the rabbitmq chart -- it\u0027s a pretty good pattern for multiple releases of a chart in the same namespace: https://github.com/openstack/openstack-helm-infra/blob/master/rabbitmq/templates/statefulset.yaml#L24-L58","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"702d9d38993055a66a9fe593e9cae728e1bdab87","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.pod_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":24,"context_line":"kind: ClusterRole"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":27,"context_line":"rules:"},{"line_number":28,"context_line":"- apiGroups:"},{"line_number":29,"context_line":"  - \u0027*\u0027"},{"line_number":30,"context_line":"  resources:"},{"line_number":31,"context_line":"  - \u0027*\u0027"},{"line_number":32,"context_line":"  verbs:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"---"},{"line_number":35,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":36,"context_line":"kind: ClusterRoleBinding"},{"line_number":37,"context_line":"metadata:"},{"line_number":38,"context_line":"  name: {{ $serviceAccountName }}-heptio-sonobuoy-{{ .Release.Namespace }}"},{"line_number":39,"context_line":"roleRef:"},{"line_number":40,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":41,"context_line":"  kind: ClusterRole"},{"line_number":42,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":43,"context_line":"subjects:"},{"line_number":44,"context_line":"- kind: ServiceAccount"},{"line_number":45,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":46,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":47,"context_line":"---"},{"line_number":48,"context_line":"apiVersion: v1"},{"line_number":49,"context_line":"kind: Pod"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_e6249662","line":46,"range":{"start_line":20,"start_character":1,"end_line":46,"end_character":44},"in_reply_to":"9fdfeff1_06f51aed","updated":"2019-02-12 19:56:58.000000000","message":"Actually, looks like the tls certs have a random generated id at the end.","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"d96107efe7eb5057981bcb74a5e345ffac32d8fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.pod_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":24,"context_line":"kind: ClusterRole"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":27,"context_line":"rules:"},{"line_number":28,"context_line":"- apiGroups:"},{"line_number":29,"context_line":"  - \u0027*\u0027"},{"line_number":30,"context_line":"  resources:"},{"line_number":31,"context_line":"  - \u0027*\u0027"},{"line_number":32,"context_line":"  verbs:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"---"},{"line_number":35,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":36,"context_line":"kind: ClusterRoleBinding"},{"line_number":37,"context_line":"metadata:"},{"line_number":38,"context_line":"  name: {{ $serviceAccountName }}-heptio-sonobuoy-{{ .Release.Namespace }}"},{"line_number":39,"context_line":"roleRef:"},{"line_number":40,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":41,"context_line":"  kind: ClusterRole"},{"line_number":42,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":43,"context_line":"subjects:"},{"line_number":44,"context_line":"- kind: ServiceAccount"},{"line_number":45,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":46,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":47,"context_line":"---"},{"line_number":48,"context_line":"apiVersion: v1"},{"line_number":49,"context_line":"kind: Pod"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_06f51aed","line":46,"range":{"start_line":20,"start_character":1,"end_line":46,"end_character":44},"in_reply_to":"9fdfeff1_6b74ef36","updated":"2019-02-12 19:51:43.000000000","message":"Thanks! That example looks much cleaner.\n\nAre we fine using .Release.Namespace instead of .Release.Name?\n\nWe were aiming towards installing each Sonobuoy helm chart into a different namespace because of issues around ks-user. I have concerns that folks using this will miss changing the secret name, etc. in Values.yaml for ks-user.\n\nThere are additional concerns when running Sonobuoy tests in parallel in the same namespace. The Sonobuoy pod creates additional Kubernetes resources at test time (tls certs, etc.) and I don\u0027t know if those have dynamic names to avoid name collision.","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"aa62e41ba27b2c58840c7b3547791899ec29f08b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.pod_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":24,"context_line":"kind: ClusterRole"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":27,"context_line":"rules:"},{"line_number":28,"context_line":"- apiGroups:"},{"line_number":29,"context_line":"  - \u0027*\u0027"},{"line_number":30,"context_line":"  resources:"},{"line_number":31,"context_line":"  - \u0027*\u0027"},{"line_number":32,"context_line":"  verbs:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"---"},{"line_number":35,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":36,"context_line":"kind: ClusterRoleBinding"},{"line_number":37,"context_line":"metadata:"},{"line_number":38,"context_line":"  name: {{ $serviceAccountName }}-heptio-sonobuoy-{{ .Release.Namespace }}"},{"line_number":39,"context_line":"roleRef:"},{"line_number":40,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":41,"context_line":"  kind: ClusterRole"},{"line_number":42,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":43,"context_line":"subjects:"},{"line_number":44,"context_line":"- kind: ServiceAccount"},{"line_number":45,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":46,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":47,"context_line":"---"},{"line_number":48,"context_line":"apiVersion: v1"},{"line_number":49,"context_line":"kind: Pod"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_3dadc89a","line":46,"range":{"start_line":20,"start_character":1,"end_line":46,"end_character":44},"in_reply_to":"9fdfeff1_da9842c1","updated":"2019-02-12 21:29:27.000000000","message":"https://github.com/heptio/sonobuoy/blob/master/pkg/plugin/driver/daemonset/template.go#L88\n\nYeah, Sonobuoy requires a sonobuoy-serviceaccount to exist.","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"d589a2b709c5e2bd41ea35066c0cc071586942a9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.pod_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-serviceaccount\" }}"},{"line_number":21,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":24,"context_line":"kind: ClusterRole"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":27,"context_line":"rules:"},{"line_number":28,"context_line":"- apiGroups:"},{"line_number":29,"context_line":"  - \u0027*\u0027"},{"line_number":30,"context_line":"  resources:"},{"line_number":31,"context_line":"  - \u0027*\u0027"},{"line_number":32,"context_line":"  verbs:"},{"line_number":33,"context_line":"  - \u0027*\u0027"},{"line_number":34,"context_line":"---"},{"line_number":35,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":36,"context_line":"kind: ClusterRoleBinding"},{"line_number":37,"context_line":"metadata:"},{"line_number":38,"context_line":"  name: {{ $serviceAccountName }}-heptio-sonobuoy-{{ .Release.Namespace }}"},{"line_number":39,"context_line":"roleRef:"},{"line_number":40,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":41,"context_line":"  kind: ClusterRole"},{"line_number":42,"context_line":"  name: {{ $serviceAccountName }}-{{ .Release.Namespace }}"},{"line_number":43,"context_line":"subjects:"},{"line_number":44,"context_line":"- kind: ServiceAccount"},{"line_number":45,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":46,"context_line":"  namespace: {{ $envAll.Release.Namespace }}"},{"line_number":47,"context_line":"---"},{"line_number":48,"context_line":"apiVersion: v1"},{"line_number":49,"context_line":"kind: Pod"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_da9842c1","line":46,"range":{"start_line":20,"start_character":1,"end_line":46,"end_character":44},"in_reply_to":"9fdfeff1_e6249662","updated":"2019-02-12 20:37:49.000000000","message":"Just found out Sonobuoy explicitly looks for sonobuoy-serviceaccount when creating new pod daemonsets/pods, so I think we\u0027re stuck keeping sonobuoy-serviceaccount.\n\nWe will work on cleaning this code up a bit, but I\u0027d want to limit us to different namespaces because of this ServiceAccount being required to have the same name for each chart.","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"}],"sonobuoy/templates/serviceaccount-readonly.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"812edc3806d95907a8bbfad74024249a6b990601","unresolved":false,"context_lines":[{"line_number":59,"context_line":"{{- if .Values.manifests.serviceaccount_readonly }}"},{"line_number":60,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"{{- $serviceAccountName :\u003d \"sonobuoy-readonly-serviceaccount\" }}"},{"line_number":63,"context_line":"{{ tuple $envAll \"sonobuoy\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":64,"context_line":"---"},{"line_number":65,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":66,"context_line":"kind: ClusterRole"},{"line_number":67,"context_line":"metadata:"},{"line_number":68,"context_line":"  name: sonobuoy-readonly-clusterrole-{{ .Release.Namespace }}"},{"line_number":69,"context_line":"rules:"},{"line_number":70,"context_line":"- apiGroups:"},{"line_number":71,"context_line":"  - \"*\""},{"line_number":72,"context_line":"  resources:"},{"line_number":73,"context_line":"  - \"*\""},{"line_number":74,"context_line":"  verbs:"},{"line_number":75,"context_line":"  - \"get\""},{"line_number":76,"context_line":"  - \"list\""},{"line_number":77,"context_line":"  - \"watch\""},{"line_number":78,"context_line":"---"},{"line_number":79,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":80,"context_line":"kind: ClusterRoleBinding"},{"line_number":81,"context_line":"metadata:"},{"line_number":82,"context_line":"  name: sonobuoy-readonly-clusterrolebinding-{{ .Release.Namespace }}"},{"line_number":83,"context_line":"roleRef:"},{"line_number":84,"context_line":"  apiGroup: rbac.authorization.k8s.io"},{"line_number":85,"context_line":"  kind: ClusterRole"},{"line_number":86,"context_line":"  name: sonobuoy-readonly-clusterrole-{{ .Release.Namespace }}"},{"line_number":87,"context_line":"subjects:"},{"line_number":88,"context_line":"- kind: ServiceAccount"},{"line_number":89,"context_line":"  name: {{ $serviceAccountName }}"},{"line_number":90,"context_line":"  namespace: {{ .Release.Namespace }}"},{"line_number":91,"context_line":"---"},{"line_number":92,"context_line":"apiVersion: v1"},{"line_number":93,"context_line":"kind: Secret"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_eb953f33","line":90,"range":{"start_line":62,"start_character":0,"end_line":90,"end_character":37},"updated":"2019-02-12 19:18:16.000000000","message":"Same comment as the previous wrt rabbitmq as inspiration","commit_id":"99bc5c03e6ca8989193c8a264489a641831e2f58"}]}
