)]}'
{"sonobuoy/templates/secret-plugin-values.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"9b9596e2adf272866f8381f1d6061d22ba99c999","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_plugin_values }}"},{"line_number":18,"context_line":"{{- if empty .Values.conf.sonobuoy.WorkerImage -}}"},{"line_number":19,"context_line":"{{- $_ :\u003d set .Values.conf.sonobuoy \"WorkerImage\" .Values.images.tags.sonobuoy_api -}}"},{"line_number":20,"context_line":"{{- end -}}"},{"line_number":21,"context_line":"{{- if empty .Values.conf.sonobuoy.Namespace -}}"},{"line_number":22,"context_line":"{{- $_ :\u003d set .Values.conf.sonobuoy \"Namespace\" .Release.Namespace -}}"},{"line_number":23,"context_line":"{{- end -}}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: v1"},{"line_number":26,"context_line":"kind: Secret"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_f9fe2bad","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":11},"updated":"2019-04-10 18:06:20.000000000","message":"Why is this needed here?","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"c7e185156a7540588356119b208d6848ee635385","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_plugin_values }}"},{"line_number":18,"context_line":"{{- if empty .Values.conf.sonobuoy.WorkerImage -}}"},{"line_number":19,"context_line":"{{- $_ :\u003d set .Values.conf.sonobuoy \"WorkerImage\" .Values.images.tags.sonobuoy_api -}}"},{"line_number":20,"context_line":"{{- end -}}"},{"line_number":21,"context_line":"{{- if empty .Values.conf.sonobuoy.Namespace -}}"},{"line_number":22,"context_line":"{{- $_ :\u003d set .Values.conf.sonobuoy \"Namespace\" .Release.Namespace -}}"},{"line_number":23,"context_line":"{{- end -}}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: v1"},{"line_number":26,"context_line":"kind: Secret"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_99b127e3","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":11},"in_reply_to":"5fc1f717_f9fe2bad","updated":"2019-04-10 18:11:34.000000000","message":"Done","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"68d8be9eebe05382d8323659ee06fdf32e0ae430","unresolved":false,"context_lines":[{"line_number":23,"context_line":"type: Opaque"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  plugin-values.yaml: |-"},{"line_number":26,"context_line":"  {{ .Values.conf.plugin_values | toYaml -}}"},{"line_number":27,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_ec5bab51","line":26,"updated":"2019-04-10 19:46:57.000000000","message":"I think job is failing because we need base64 here - like: https://github.com/openstack/openstack-helm-addons/blob/master/sonobuoy/templates/secret-etc.yaml#L31","commit_id":"5ddb8a2eb19b71f9102c74b878d16182b4181b25"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"13b375d2b9343af1c470e0c39247cf63ac33c4a9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"type: Opaque"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  plugin-values.yaml: |-"},{"line_number":26,"context_line":"  {{ .Values.conf.plugin_values | toYaml -}}"},{"line_number":27,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_0fe9497f","line":26,"in_reply_to":"3fce034c_ec5bab51","updated":"2019-04-10 20:25:15.000000000","message":"Done","commit_id":"5ddb8a2eb19b71f9102c74b878d16182b4181b25"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"bf5f2edce423ce09dcff407f1bf26f29582dc848","unresolved":false,"context_lines":[{"line_number":23,"context_line":"type: Opaque"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  plugin-values.yaml: |-"},{"line_number":26,"context_line":"  {{ .Values.conf.plugin_values | toYaml | b64enc -}}"},{"line_number":27,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fce034c_980a5288","line":26,"updated":"2019-04-11 13:53:11.000000000","message":"I think job is failing due to this not using `| indent 4`.\n\nI think you can run `helm install --dry-run --debug sonobuoy` on your local to verify change will work.","commit_id":"fbe1e2758b26d5e1f4ea6d4ea15344df64ac135e"}],"sonobuoy/values.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"9b9596e2adf272866f8381f1d6061d22ba99c999","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  pod_api: true"},{"line_number":98,"context_line":"  secret_etc: true"},{"line_number":99,"context_line":"  secret_plugin_values: true"},{"line_number":100,"context_line":"  secret_keystone: true"},{"line_number":101,"context_line":"  serviceaccount_readonly: false"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"conf:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_19b77723","line":100,"updated":"2019-04-10 18:06:20.000000000","message":"nit: alphabetize","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"9b9596e2adf272866f8381f1d6061d22ba99c999","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"conf:"},{"line_number":104,"context_line":"  publish_results: true"},{"line_number":105,"context_line":"  # Injected values root used by (some of) the plugins. This `plugin_values`"},{"line_number":106,"context_line":"  # root is the parent for all yaml that will be placed into the"},{"line_number":107,"context_line":"  # `plugin-values.yaml`. This will be mounted as /etc/test/plugin-values.yaml"},{"line_number":108,"context_line":"  # to the plugin container."},{"line_number":109,"context_line":"  # A default value will be supplied, but is expected to be overridden by"},{"line_number":110,"context_line":"  # deployment."},{"line_number":111,"context_line":"  plugin_values:"},{"line_number":112,"context_line":"    no_configuration_provided: true"},{"line_number":113,"context_line":"  swift:"},{"line_number":114,"context_line":"    container_name: sonobuoy"},{"line_number":115,"context_line":"    # delete objects after 1 month (60 * 60 * 24 * 30 seconds)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_19e8d7dc","line":112,"range":{"start_line":105,"start_character":0,"end_line":112,"end_character":35},"updated":"2019-04-10 18:06:20.000000000","message":"I like where this is headed.","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"9b9596e2adf272866f8381f1d6061d22ba99c999","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            name: configured-values"},{"line_number":178,"context_line":"        extra-volumes:"},{"line_number":179,"context_line":"        - name: configured-values"},{"line_number":180,"context_line":"          secretName: plugin-values"},{"line_number":181,"context_line":"          defaultMode: 440"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_79ef9b1c","line":181,"range":{"start_line":180,"start_character":10,"end_line":181,"end_character":26},"updated":"2019-04-10 18:06:20.000000000","message":"These should belong to secret key like: \n\nsecret:\n      secretName: plugin-values\n      defaultMode: 0444\n\nhttps://github.com/openstack/openstack-helm-addons/blob/master/sonobuoy/templates/pod-api.yaml#L118\n\nAlso, I don\u0027t know why 0444 vs 440.","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"c7e185156a7540588356119b208d6848ee635385","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            name: configured-values"},{"line_number":178,"context_line":"        extra-volumes:"},{"line_number":179,"context_line":"        - name: configured-values"},{"line_number":180,"context_line":"          secretName: plugin-values"},{"line_number":181,"context_line":"          defaultMode: 440"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_79aebb81","line":181,"range":{"start_line":180,"start_character":10,"end_line":181,"end_character":26},"in_reply_to":"5fc1f717_79ef9b1c","updated":"2019-04-10 18:11:34.000000000","message":"Done","commit_id":"86e8f226a9ff18483cdb8852a476b7d518ffaca0"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"f228f3e4597b78ca95e203d9e72266b6e9c13f27","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # `plugin-values.yaml`. This will be mounted as /etc/test/plugin-values.yaml"},{"line_number":108,"context_line":"  # to the plugin container."},{"line_number":109,"context_line":"  # A default value will be supplied, but is expected to be overridden by"},{"line_number":110,"context_line":"  # deployment."},{"line_number":111,"context_line":"  plugin_values:"},{"line_number":112,"context_line":"    no_configuration_provided: true"},{"line_number":113,"context_line":"  swift:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fce034c_0f3aa9e6","line":110,"updated":"2019-04-10 20:32:55.000000000","message":"nit: We might want to add a note that this will need to be included in plugin conf for the mount to work.\n\nOr were you thinking of having the chart always add this mount?","commit_id":"db60a0bedf671f7b974a63831e6cc182be9537e4"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"9841792d6ce108426ea42b5191986b353552486b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # `plugin-values.yaml`. This will be mounted as /etc/test/plugin-values.yaml"},{"line_number":108,"context_line":"  # to the plugin container."},{"line_number":109,"context_line":"  # A default value will be supplied, but is expected to be overridden by"},{"line_number":110,"context_line":"  # deployment."},{"line_number":111,"context_line":"  plugin_values:"},{"line_number":112,"context_line":"    no_configuration_provided: true"},{"line_number":113,"context_line":"  swift:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fce034c_e6c42295","line":110,"in_reply_to":"3fce034c_0f3aa9e6","updated":"2019-04-11 01:21:20.000000000","message":"I can add verbiage if it helps, but I don\u0027t understand the comment/question fully. Is what you\u0027re saying different than what\u0027s been done below on line 176+ ?","commit_id":"db60a0bedf671f7b974a63831e6cc182be9537e4"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"bf5f2edce423ce09dcff407f1bf26f29582dc848","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # `plugin-values.yaml`. This will be mounted as /etc/test/plugin-values.yaml"},{"line_number":108,"context_line":"  # to the plugin container."},{"line_number":109,"context_line":"  # A default value will be supplied, but is expected to be overridden by"},{"line_number":110,"context_line":"  # deployment."},{"line_number":111,"context_line":"  plugin_values:"},{"line_number":112,"context_line":"    no_configuration_provided: true"},{"line_number":113,"context_line":"  swift:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fce034c_782a06e8","line":110,"in_reply_to":"3fce034c_e6c42295","updated":"2019-04-11 13:53:11.000000000","message":"I like what you added - thank you. Just like it being clearer for future readers. I don\u0027t think it\u0027s obvious that by setting plugin_values that additional work is required by the operator, but this comment helps a bunch in my opinion.","commit_id":"db60a0bedf671f7b974a63831e6cc182be9537e4"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"6412e38b2517adda26dca7045e524376485842a3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # `plugin-values.yaml`. This will be mounted as /etc/test/plugin-values.yaml"},{"line_number":108,"context_line":"  # to the plugin container."},{"line_number":109,"context_line":"  # A default value will be supplied, but is expected to be overridden by"},{"line_number":110,"context_line":"  # deployment."},{"line_number":111,"context_line":"  plugin_values:"},{"line_number":112,"context_line":"    no_configuration_provided: true"},{"line_number":113,"context_line":"  swift:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fce034c_c64486ba","line":110,"in_reply_to":"3fce034c_e6c42295","updated":"2019-04-22 18:17:16.000000000","message":"I think I get it... if the plugins are overridden, of course they must then declare the extras. I will add more docs here.","commit_id":"db60a0bedf671f7b974a63831e6cc182be9537e4"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"39f0bb846c03827ebf4bcb4fb591e5de96c045d5","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        - name: configured-values"},{"line_number":189,"context_line":"          secret:"},{"line_number":190,"context_line":"            secretName: plugin-values"},{"line_number":191,"context_line":"            defaultMode: 0444"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fce034c_77e290a2","line":191,"range":{"start_line":191,"start_character":25,"end_line":191,"end_character":26},"updated":"2019-04-18 15:22:32.000000000","message":"I don\u0027t know why, but this 0 is why the config map is getting generated weird. If we delete the 0 the config map is rendered correctly.\n\nAdditional weird thing: if you wish to leave the 0 here, you can move defaultMode above secretName and the config map will render correctly. Only causes a problem when this 0444 is the last thing.","commit_id":"1cb598d543cf4828eabfe7216e588b23e454272f"},{"author":{"_account_id":26365,"name":"Bryan Strassner","email":"strassner.bryan@gmail.com","username":"bryan-strassner"},"change_message_id":"6412e38b2517adda26dca7045e524376485842a3","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        - name: configured-values"},{"line_number":189,"context_line":"          secret:"},{"line_number":190,"context_line":"            secretName: plugin-values"},{"line_number":191,"context_line":"            defaultMode: 0444"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffb9cba7_d87d24e8","line":191,"range":{"start_line":191,"start_character":25,"end_line":191,"end_character":26},"in_reply_to":"3fce034c_77e290a2","updated":"2019-04-22 18:17:16.000000000","message":"neato. Thanks. Wonder if it is the lack of a newline at the end too.","commit_id":"1cb598d543cf4828eabfe7216e588b23e454272f"}]}