)]}'
{"ranger-agent/templates/bin/_ranger-agent-test.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"de961efe982264263b9afdf096562ae5dac8f040","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"expected_on_execution\u003d\"$expected_end_status_key\""},{"line_number":63,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":64,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7faddb67_7cc0dd7c","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":40},"updated":"2019-09-05 14:24:19.000000000","message":"why not just use $expected_end_status_key here instead of using another variable/","commit_id":"4c5c28614780c13bdc28bdc9282dc783c68a90f6"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"987fd0537824b1a1236ed6026428c512b5f0ecc8","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"expected_on_execution\u003d\"$expected_end_status_key\""},{"line_number":63,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":64,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"5faad753_2238ced1","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":40},"in_reply_to":"5faad753_1c973b93","updated":"2019-09-06 17:46:05.000000000","message":"I am not questioning the ability to override the variable. I am asking if the variable expected_on_execution is needed, it seems to be just $expected_end_status_key (L62), why not just use $expected_end_status_key instead of assigning it to a different variable and use that as-is only once?  But that\u0027s more stylistic quip on my part.","commit_id":"4c5c28614780c13bdc28bdc9282dc783c68a90f6"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"383aadf5859fb843d507aa450509a269aa6f071c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"expected_on_execution\u003d\"$expected_end_status_key\""},{"line_number":63,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":64,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"5faad753_028832c4","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":40},"in_reply_to":"5faad753_2238ced1","updated":"2019-09-06 18:40:01.000000000","message":"ok I will remove extra variable","commit_id":"4c5c28614780c13bdc28bdc9282dc783c68a90f6"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"6e5846bce71459d8ceaf3f4d403a4e748bd3c952","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"expected_on_execution\u003d\"$expected_end_status_key\""},{"line_number":63,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":64,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"5faad753_1c973b93","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":40},"in_reply_to":"7faddb67_7cc0dd7c","updated":"2019-09-06 15:53:31.000000000","message":"ranger agent does not work alone, it needed a sample template created by ranger. in upstream we have uploaded a sample template in github test repo to validate success but in specific internal site, git repo will not be having sample file. so we are going to expect ORD_025 code in internal site helm test.\nWe are going to override expected status for internal site","commit_id":"4c5c28614780c13bdc28bdc9282dc783c68a90f6"}]}