)]}'
{"ranger-agent/templates/bin/_ranger-agent-test.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ec545cad5e5330a59f3f916335069db4c64f6aeb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"function assertContains()"},{"line_number":39,"context_line":" {"},{"line_number":40,"context_line":"   expected\u003d$1"},{"line_number":41,"context_line":"   until [ $n -ge 5 ]"},{"line_number":42,"context_line":"   do"},{"line_number":43,"context_line":"     if [ \"$expected\" \u003d\u003d \"Submitted\" ]; then"},{"line_number":44,"context_line":"       msg\u003d\"$(curl -i -X POST -d \"${PAYLOAD}\"  $url --header \"Content-type:application/json\")\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_6a97ac3b","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":14},"updated":"2019-09-30 02:35:40.000000000","message":"this is undefined at this point, it will spit out a warning/error","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"72edb738410e32e3744aadc7d185857220b5217e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"function assertContains()"},{"line_number":39,"context_line":" {"},{"line_number":40,"context_line":"   expected\u003d$1"},{"line_number":41,"context_line":"   until [ $n -ge 5 ]"},{"line_number":42,"context_line":"   do"},{"line_number":43,"context_line":"     if [ \"$expected\" \u003d\u003d \"Submitted\" ]; then"},{"line_number":44,"context_line":"       msg\u003d\"$(curl -i -X POST -d \"${PAYLOAD}\"  $url --header \"Content-type:application/json\")\""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_f2970a44","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":14},"in_reply_to":"3fa7e38b_6a97ac3b","updated":"2019-09-30 13:47:04.000000000","message":"thanks define in new patch","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ec545cad5e5330a59f3f916335069db4c64f6aeb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"       msg\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":47,"context_line":"     fi"},{"line_number":48,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":49,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\" \u0026\u0026 break"},{"line_number":50,"context_line":"     else"},{"line_number":51,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":52,"context_line":"         exit 1"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_aaa364b1","line":49,"range":{"start_line":49,"start_character":67,"end_line":49,"end_character":75},"updated":"2019-09-30 02:35:40.000000000","message":"why not have break in a separate line? This break doesn\u0027t depend on the true/false value of the echo. Also can this just be exit 0?","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"72edb738410e32e3744aadc7d185857220b5217e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"       msg\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":47,"context_line":"     fi"},{"line_number":48,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":49,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\" \u0026\u0026 break"},{"line_number":50,"context_line":"     else"},{"line_number":51,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":52,"context_line":"         exit 1"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_72855a06","line":49,"range":{"start_line":49,"start_character":67,"end_line":49,"end_character":75},"in_reply_to":"3fa7e38b_aaa364b1","updated":"2019-09-30 13:47:04.000000000","message":"replacing break by  exit 0 (should be fine)we want to indicate test pass","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ec545cad5e5330a59f3f916335069db4c64f6aeb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":49,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\" \u0026\u0026 break"},{"line_number":50,"context_line":"     else"},{"line_number":51,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":52,"context_line":"         exit 1"},{"line_number":53,"context_line":"       fi"},{"line_number":54,"context_line":"       echo \"***FAILED: EXPECTED\u003d$expected in Responce\""},{"line_number":55,"context_line":"       n\u003d$[$n+1]"},{"line_number":56,"context_line":"       sleep 15"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_8a854809","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":9},"updated":"2019-09-30 02:35:40.000000000","message":"Why check $n \u003d\u003d 5 within the loop when the loops stops when $n -ge 5?","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"72edb738410e32e3744aadc7d185857220b5217e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":49,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\" \u0026\u0026 break"},{"line_number":50,"context_line":"     else"},{"line_number":51,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":52,"context_line":"         exit 1"},{"line_number":53,"context_line":"       fi"},{"line_number":54,"context_line":"       echo \"***FAILED: EXPECTED\u003d$expected in Responce\""},{"line_number":55,"context_line":"       n\u003d$[$n+1]"},{"line_number":56,"context_line":"       sleep 15"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_5297fe3a","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":9},"in_reply_to":"3fa7e38b_8a854809","updated":"2019-09-30 13:47:04.000000000","message":"on #5 we indicate test fail by exit 1, that is why we have that check","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ec545cad5e5330a59f3f916335069db4c64f6aeb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# once request submitted openstack take some time to synchronize."},{"line_number":65,"context_line":"# we are pulling status for testing purpose by sleeping thread for 15 sec"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"assertContains \"${END_STATUS_KEY}\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_2aa534a2","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":34},"updated":"2019-09-30 02:35:40.000000000","message":"is this declared elsewhere?","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"72edb738410e32e3744aadc7d185857220b5217e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# once request submitted openstack take some time to synchronize."},{"line_number":65,"context_line":"# we are pulling status for testing purpose by sleeping thread for 15 sec"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"assertContains \"${END_STATUS_KEY}\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3fa7e38b_32a04290","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":34},"in_reply_to":"3fa7e38b_2aa534a2","updated":"2019-09-30 13:47:04.000000000","message":"it is coming from override value","commit_id":"dd5ec611dfbdb2dcb76e25284ea7e992f0efae93"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"429572c506d92ee95a1a6c03b82aafc2f1a8083e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     fi"},{"line_number":49,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":50,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\""},{"line_number":51,"context_line":"       exit 0"},{"line_number":52,"context_line":"     else"},{"line_number":53,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":54,"context_line":"         echo \"***FAILED: EXPECTED\u003d$expected in Responce\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_8da9c925","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":13},"updated":"2019-10-01 13:04:35.000000000","message":"My apology, looking at this, it probably should be a break and not exit as this is a function and you are calling this twice - you do not want the script to exit after the first success on L63 - unless that\u0027s the intend.","commit_id":"bd774b0df9c6c5758eae9196610722d61f8747d7"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"cf6b5903ad60d031b127361d416f578f00ec11b6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"     fi"},{"line_number":49,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":50,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\""},{"line_number":51,"context_line":"       exit 0"},{"line_number":52,"context_line":"     else"},{"line_number":53,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":54,"context_line":"         echo \"***FAILED: EXPECTED\u003d$expected in Responce\""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_936b2684","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":13},"in_reply_to":"3fa7e38b_8da9c925","updated":"2019-10-01 14:25:50.000000000","message":"Oh yes, It would have fail test again Thank you","commit_id":"bd774b0df9c6c5758eae9196610722d61f8747d7"}]}