)]}'
{"ranger-agent/templates/bin/_health-probe.py.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"14ba4b27c2bd0ee0313a02666a97ceac60ddbbba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2019 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_7453146c","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"updated":"2019-09-28 14:00:25.000000000","message":"py2 is sunsetting Jan 2020. Make sure this is py2 and py3 compatible.","commit_id":"a002644d071d315d3529abf4db839071df751ffe"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"14ba4b27c2bd0ee0313a02666a97ceac60ddbbba","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import socket"},{"line_number":38,"context_line":"import sys"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from ConfigParser import ConfigParser"},{"line_number":41,"context_line":"from oslo_config import cfg"},{"line_number":42,"context_line":"from oslo_context import context"},{"line_number":43,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_144e60c0","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":37},"updated":"2019-09-28 14:00:25.000000000","message":"likely need to change for py3","commit_id":"a002644d071d315d3529abf4db839071df751ffe"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"try:"},{"line_number":46,"context_line":"    from configparser import ConfigParser"},{"line_number":47,"context_line":"except ImportError:"},{"line_number":48,"context_line":"    from ConfigParser import ConfigParser"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"tcp_established \u003d \"ESTABLISHED\""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_5fda1ee9","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":41},"updated":"2019-10-09 03:37:00.000000000","message":"I do not believe there is a ConfigParser.ConfigPaser, or is the try-except reversed?","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":45,"context_line":"try:"},{"line_number":46,"context_line":"    from configparser import ConfigParser"},{"line_number":47,"context_line":"except ImportError:"},{"line_number":48,"context_line":"    from ConfigParser import ConfigParser"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"tcp_established \u003d \"ESTABLISHED\""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_fd650bb6","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":41},"in_reply_to":"3fa7e38b_5fda1ee9","updated":"2019-10-09 14:25:49.000000000","message":"Yes.  There is ConfigParser.ConfigParser.  This is well tested code already. The try-except is not reversed.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    except oslo_messaging.exceptions.MessageDeliveryFailure:"},{"line_number":76,"context_line":"        # Log to pod events"},{"line_number":77,"context_line":"        sys.stderr.write(\"Health probe unable to reach message bus\\n\")"},{"line_number":78,"context_line":"        sys.exit(0)  # return success"},{"line_number":79,"context_line":"    except oslo_messaging.rpc.client.RemoteError as re:"},{"line_number":80,"context_line":"        message \u003d getattr(re, \"message\", str(re))"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_1fe4a6ab","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":24},"updated":"2019-10-09 03:37:00.000000000","message":"can these be just stdout or print()?","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    except oslo_messaging.exceptions.MessageDeliveryFailure:"},{"line_number":76,"context_line":"        # Log to pod events"},{"line_number":77,"context_line":"        sys.stderr.write(\"Health probe unable to reach message bus\\n\")"},{"line_number":78,"context_line":"        sys.exit(0)  # return success"},{"line_number":79,"context_line":"    except oslo_messaging.rpc.client.RemoteError as re:"},{"line_number":80,"context_line":"        message \u003d getattr(re, \"message\", str(re))"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_9d241762","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":24},"in_reply_to":"3fa7e38b_1fe4a6ab","updated":"2019-10-09 14:25:49.000000000","message":"I rather keep this as error.  Please see the template I have been following in this patch https://review.opendev.org/#/c/666193/3/nova/templates/bin/_health-probe.py.tpl","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        sys.stderr.write(\"Health probe caught exception sending message to \""},{"line_number":94,"context_line":"                         \"service: %s\\n\" % message)"},{"line_number":95,"context_line":"        sys.exit(0)"},{"line_number":96,"context_line":"    except:"},{"line_number":97,"context_line":"        sys.stderr.write(\"Health probe caught exception sending message to\""},{"line_number":98,"context_line":"                         \" service\\n\")"},{"line_number":99,"context_line":"        if service_error:"},{"line_number":100,"context_line":"            sys.exit(1)"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            sys.exit(0)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def tcp_socket_status(process, ports):"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_3fdf22d7","line":102,"range":{"start_line":96,"start_character":0,"end_line":102,"end_character":23},"updated":"2019-10-09 03:37:00.000000000","message":"what can cause this to run that is not already caught by L91?","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        sys.stderr.write(\"Health probe caught exception sending message to \""},{"line_number":94,"context_line":"                         \"service: %s\\n\" % message)"},{"line_number":95,"context_line":"        sys.exit(0)"},{"line_number":96,"context_line":"    except:"},{"line_number":97,"context_line":"        sys.stderr.write(\"Health probe caught exception sending message to\""},{"line_number":98,"context_line":"                         \" service\\n\")"},{"line_number":99,"context_line":"        if service_error:"},{"line_number":100,"context_line":"            sys.exit(1)"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            sys.exit(0)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def tcp_socket_status(process, ports):"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_bddeb33b","line":102,"range":{"start_line":96,"start_character":0,"end_line":102,"end_character":23},"in_reply_to":"3fa7e38b_3fdf22d7","updated":"2019-10-09 14:25:49.000000000","message":"This will caught L72, and re-throw here. Otherwise, this will exit without error. This has been tested well.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                    except IndexError:"},{"line_number":124,"context_line":"                        continue"},{"line_number":125,"context_line":"                    if rport in ports and status \u003d\u003d tcp_established:"},{"line_number":126,"context_line":"                        sock_count \u003d sock_count + 1"},{"line_number":127,"context_line":"        except psutil.NoSuchProcess:"},{"line_number":128,"context_line":"            continue"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_dfefee84","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":51},"updated":"2019-10-09 03:37:00.000000000","message":"this function returns 1 if sock_count !\u003d 0, why not just return 1 here instead of continuing the loop?","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                    except IndexError:"},{"line_number":124,"context_line":"                        continue"},{"line_number":125,"context_line":"                    if rport in ports and status \u003d\u003d tcp_established:"},{"line_number":126,"context_line":"                        sock_count \u003d sock_count + 1"},{"line_number":127,"context_line":"        except psutil.NoSuchProcess:"},{"line_number":128,"context_line":"            continue"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"3fa7e38b_9de3b7d8","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":51},"in_reply_to":"3fa7e38b_dfefee84","updated":"2019-10-09 14:25:49.000000000","message":"I have also asked the same question before from this patch   https://review.opendev.org/#/c/666193/3/nova/templates/bin/_health-probe.py.tpl.  There can be multiple processes with different pid but the same parent pid.  I left the code as is for easier maintenance purpose with what nova and neutron is doing.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"}],"ranger-agent/templates/bin/_ranger-agent-test.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bd9f1f9786028a955d68ec92cdd9bb4e2ed2dcaa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"       msg\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":48,"context_line":"     fi"},{"line_number":49,"context_line":"     if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":50,"context_line":"       echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\""},{"line_number":51,"context_line":"       break"},{"line_number":52,"context_line":"     else"},{"line_number":53,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3fa7e38b_cb86addc","line":50,"range":{"start_line":50,"start_character":57,"end_line":50,"end_character":65},"updated":"2019-10-02 23:22:16.000000000","message":"Response","commit_id":"0cac39e5744279dd6f4572788fe01c53f89a440a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bd9f1f9786028a955d68ec92cdd9bb4e2ed2dcaa","unresolved":false,"context_lines":[{"line_number":51,"context_line":"       break"},{"line_number":52,"context_line":"     else"},{"line_number":53,"context_line":"       if [ \"$n\" \u003d\u003d \"5\" ]; then"},{"line_number":54,"context_line":"         echo \"***FAILED: EXPECTED\u003d$expected in Responce\""},{"line_number":55,"context_line":"         exit 1"},{"line_number":56,"context_line":"       fi"},{"line_number":57,"context_line":"       n\u003d$[$n+1]"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3fa7e38b_8b68b521","line":54,"range":{"start_line":54,"start_character":48,"end_line":54,"end_character":56},"updated":"2019-10-02 23:22:16.000000000","message":"Response","commit_id":"0cac39e5744279dd6f4572788fe01c53f89a440a"}],"ranger-agent/templates/deployment-ranger-agent-api.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"776c296ab6a1496b4bd2d16c17c2e3a513de948e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            initialDelaySeconds: 120"},{"line_number":85,"context_line":"            periodSeconds: 95"},{"line_number":86,"context_line":"            timeoutSeconds: 85"},{"line_number":87,"context_line":"          readinessProbe:"},{"line_number":88,"context_line":"            exec:"},{"line_number":89,"context_line":"              command:"},{"line_number":90,"context_line":"              - python"},{"line_number":91,"context_line":"              - /tmp/health-probe.py"},{"line_number":92,"context_line":"              - --config-file"},{"line_number":93,"context_line":"              - /etc/ranger-agent/ranger-agent.conf"},{"line_number":94,"context_line":"              - --service-name"},{"line_number":95,"context_line":"              - ranger-agent-api"},{"line_number":96,"context_line":"            initialDelaySeconds: 80"},{"line_number":97,"context_line":"            periodSeconds: 95"},{"line_number":98,"context_line":"            timeoutSeconds: 85"},{"line_number":99,"context_line":"          volumeMounts:"},{"line_number":100,"context_line":"            - name: pod-etc-ranger-agent"},{"line_number":101,"context_line":"              mountPath: /etc/ranger-agent"},{"line_number":102,"context_line":"            - name: ranger-agent-bin"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_ad15f74a","line":99,"range":{"start_line":87,"start_character":0,"end_line":99,"end_character":23},"updated":"2019-10-11 17:57:51.000000000","message":"Can we leverage: https://github.com/openstack/openstack-helm-infra/blob/master/helm-toolkit/templates/snippets/_kubernetes_probes.tpl","commit_id":"7b77ed2764d7d055a22648937a4f43e21b240f9a"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"51313b4fa30c8230ee62939b3388a22194cd7661","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            initialDelaySeconds: 120"},{"line_number":85,"context_line":"            periodSeconds: 95"},{"line_number":86,"context_line":"            timeoutSeconds: 85"},{"line_number":87,"context_line":"          readinessProbe:"},{"line_number":88,"context_line":"            exec:"},{"line_number":89,"context_line":"              command:"},{"line_number":90,"context_line":"              - python"},{"line_number":91,"context_line":"              - /tmp/health-probe.py"},{"line_number":92,"context_line":"              - --config-file"},{"line_number":93,"context_line":"              - /etc/ranger-agent/ranger-agent.conf"},{"line_number":94,"context_line":"              - --service-name"},{"line_number":95,"context_line":"              - ranger-agent-api"},{"line_number":96,"context_line":"            initialDelaySeconds: 80"},{"line_number":97,"context_line":"            periodSeconds: 95"},{"line_number":98,"context_line":"            timeoutSeconds: 85"},{"line_number":99,"context_line":"          volumeMounts:"},{"line_number":100,"context_line":"            - name: pod-etc-ranger-agent"},{"line_number":101,"context_line":"              mountPath: /etc/ranger-agent"},{"line_number":102,"context_line":"            - name: ranger-agent-bin"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_939b7815","line":99,"range":{"start_line":87,"start_character":0,"end_line":99,"end_character":23},"in_reply_to":"3fa7e38b_ad15f74a","updated":"2019-10-11 20:01:23.000000000","message":"Will update in next patch","commit_id":"7b77ed2764d7d055a22648937a4f43e21b240f9a"}],"ranger-agent/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"      api_paste_config: /etc/ranger-agent/api-paste.ini"},{"line_number":518,"context_line":"      local_repo: ranger_repo"},{"line_number":519,"context_line":"      resource_status_check_wait: 15"},{"line_number":520,"context_line":"      enable_heat_health_check: true"},{"line_number":521,"context_line":"    api:"},{"line_number":522,"context_line":"      host: 0.0.0.0"},{"line_number":523,"context_line":"    database:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_ffc98a24","line":520,"range":{"start_line":520,"start_character":6,"end_line":520,"end_character":30},"updated":"2019-10-09 03:37:00.000000000","message":"I cannot find where this key is being used: [0]\n\n[0] http://paste.openstack.org/show/782280/","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":517,"context_line":"      api_paste_config: /etc/ranger-agent/api-paste.ini"},{"line_number":518,"context_line":"      local_repo: ranger_repo"},{"line_number":519,"context_line":"      resource_status_check_wait: 15"},{"line_number":520,"context_line":"      enable_heat_health_check: true"},{"line_number":521,"context_line":"    api:"},{"line_number":522,"context_line":"      host: 0.0.0.0"},{"line_number":523,"context_line":"    database:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_fd674b4c","line":520,"range":{"start_line":520,"start_character":6,"end_line":520,"end_character":30},"in_reply_to":"3fa7e38b_ffc98a24","updated":"2019-10-09 14:25:49.000000000","message":"This will go to the /etc/ranger-agent/ranger-agent.conf, used by the ranger-agent application.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"}],"tools/gate/scripts/070-deploy-ranger-agent.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conf:"},{"line_number":8,"context_line":"  ranger_agent:"},{"line_number":9,"context_line":"    DEFAULT:"},{"line_number":10,"context_line":"      enable_rds_callback_check: False"},{"line_number":11,"context_line":"      enable_heat_health_check: False"},{"line_number":12,"context_line":"  ssh:"},{"line_number":13,"context_line":"    ssh_key: null"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3fa7e38b_9f5bb685","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":38},"updated":"2019-10-09 03:37:00.000000000","message":"s/F/f/","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conf:"},{"line_number":8,"context_line":"  ranger_agent:"},{"line_number":9,"context_line":"    DEFAULT:"},{"line_number":10,"context_line":"      enable_rds_callback_check: False"},{"line_number":11,"context_line":"      enable_heat_health_check: False"},{"line_number":12,"context_line":"  ssh:"},{"line_number":13,"context_line":"    ssh_key: null"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3fa7e38b_1dfa6742","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":38},"in_reply_to":"3fa7e38b_9f5bb685","updated":"2019-10-09 14:25:49.000000000","message":"will change to lower case in next patch.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aba98d62cae7c7cf84dde0b2a541a183c811469f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  ranger_agent:"},{"line_number":9,"context_line":"    DEFAULT:"},{"line_number":10,"context_line":"      enable_rds_callback_check: False"},{"line_number":11,"context_line":"      enable_heat_health_check: False"},{"line_number":12,"context_line":"  ssh:"},{"line_number":13,"context_line":"    ssh_key: null"},{"line_number":14,"context_line":"    ssh_config: null"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3fa7e38b_ff642a4b","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":37},"updated":"2019-10-09 03:37:00.000000000","message":"s/F/f/","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"bafc211ac37ff6e8d58a20461228e83b6f2dcc76","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  ranger_agent:"},{"line_number":9,"context_line":"    DEFAULT:"},{"line_number":10,"context_line":"      enable_rds_callback_check: False"},{"line_number":11,"context_line":"      enable_heat_health_check: False"},{"line_number":12,"context_line":"  ssh:"},{"line_number":13,"context_line":"    ssh_key: null"},{"line_number":14,"context_line":"    ssh_config: null"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3fa7e38b_dd95afe5","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":37},"in_reply_to":"3fa7e38b_ff642a4b","updated":"2019-10-09 14:25:49.000000000","message":"will change to lower case in next patch.","commit_id":"325ef5e04c5fd4a06ac4a01074dec73ab35805cf"}]}