)]}'
{"ranger-agent/templates/pod-test.yaml":[{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"6852cf1865785f4b6aa9aafd9859dab068e1dfe0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":31,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ranger-engine-test\" \"containerNames\" (list \"init\" \"ranger-engine-test\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":32,"context_line":"  labels:"},{"line_number":33,"context_line":"{{ tuple $envAll \"ranger-agent\" \"test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":34,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"ff570b3c_64e8e8b2","line":31,"updated":"2020-06-11 18:55:09.000000000","message":"looks like podName should be ranger-agent-test not ranger-engine-test.\nIsn\u0027t it?","commit_id":"0bf814a690458124a680c707c3846c6e66f9e075"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"b6d09d012f1917e1e3c1acd7e29ced9bf63841a8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":31,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ranger-engine-test\" \"containerNames\" (list \"init\" \"ranger-engine-test\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":32,"context_line":"  labels:"},{"line_number":33,"context_line":"{{ tuple $envAll \"ranger-agent\" \"test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":34,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"ff570b3c_e46fd825","line":31,"in_reply_to":"ff570b3c_64e8e8b2","updated":"2020-06-11 19:01:08.000000000","message":"- name: ranger-engine-test line 42","commit_id":"0bf814a690458124a680c707c3846c6e66f9e075"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"36afb04981cf1b9e983d8376198a387cc284b24a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":31,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ranger-engine-test\" \"containerNames\" (list \"init\" \"ranger-engine-test\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":32,"context_line":"  labels:"},{"line_number":33,"context_line":"{{ tuple $envAll \"ranger-agent\" \"test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":34,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"ff570b3c_e4dd18de","line":31,"in_reply_to":"ff570b3c_e46fd825","updated":"2020-06-11 19:04:27.000000000","message":"thats the container name @Andrii","commit_id":"0bf814a690458124a680c707c3846c6e66f9e075"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"b36a5cf95fd3479302f50c8e3fd3c6bbca93911e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":31,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"ranger-engine-test\" \"containerNames\" (list \"init\" \"ranger-engine-test\") | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":32,"context_line":"  labels:"},{"line_number":33,"context_line":"{{ tuple $envAll \"ranger-agent\" \"test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":34,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"ff570b3c_64d2a8d3","line":31,"in_reply_to":"ff570b3c_e46fd825","updated":"2020-06-11 19:05:29.000000000","message":"yes I think Luna is right","commit_id":"0bf814a690458124a680c707c3846c6e66f9e075"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"79ae6d31204b1a77aea0e9dabaa2c6fd8edb31a1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"apiVersion: v1"},{"line_number":25,"context_line":"kind: Pod"},{"line_number":26,"context_line":"metadata:"},{"line_number":27,"context_line":"  name: \"{{$envAll.Release.Name}}-test\""},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"}],"source_content_type":"text/x-yaml","patch_set":55,"id":"bf51134e_1214e3f4","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":18},"updated":"2020-06-17 15:29:41.000000000","message":"pls remove this one. also for consistency with other code pls use spaces after and before curved brackets","commit_id":"9220a33723e54c9ef88f579a675c7fef33b43640"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"79ae6d31204b1a77aea0e9dabaa2c6fd8edb31a1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  name: \"{{$envAll.Release.Name}}-test\""},{"line_number":28,"context_line":"  annotations:"},{"line_number":29,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":30,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":31,"context_line":"  labels:"},{"line_number":32,"context_line":"{{ tuple $envAll \"ranger-agent\" \"test\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":33,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":55,"id":"bf51134e_52cc9b88","line":30,"updated":"2020-06-17 15:29:41.000000000","message":"despite we don\u0027t run test currently here, still please add apparmor here as well","commit_id":"9220a33723e54c9ef88f579a675c7fef33b43640"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"79ae6d31204b1a77aea0e9dabaa2c6fd8edb31a1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  initContainers:"},{"line_number":39,"context_line":"{{ tuple $envAll \"tests\" $mounts_tests_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 4 }}"},{"line_number":40,"context_line":"  containers:"},{"line_number":41,"context_line":"    - name: {{.Release.Name}}-test"},{"line_number":42,"context_line":"      image: {{ .Values.images.tags.scripted_test }}"},{"line_number":43,"context_line":"      env:"},{"line_number":44,"context_line":"        - name: RANGER_SERVICE_URL"}],"source_content_type":"text/x-yaml","patch_set":55,"id":"bf51134e_12e22304","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":29},"updated":"2020-06-17 15:29:41.000000000","message":"ditto","commit_id":"9220a33723e54c9ef88f579a675c7fef33b43640"}],"ranger-agent/values_overrides/apparmor.yaml":[{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"6852cf1865785f4b6aa9aafd9859dab068e1dfe0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    ranger-agent:"},{"line_number":9,"context_line":"      ranger-agent-engine: runtime/default"},{"line_number":10,"context_line":"      init: runtime/default"},{"line_number":11,"context_line":"    ranger-engine-test:"},{"line_number":12,"context_line":"      ranger-engine-test: runtime/default"},{"line_number":13,"context_line":"      init: runtime/default"},{"line_number":14,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"ff570b3c_c4f7348c","line":11,"updated":"2020-06-11 18:55:09.000000000","message":"ditto, no pod exists of this name ranger-engine-test,\n\nshould be ranger-agent-test","commit_id":"0bf814a690458124a680c707c3846c6e66f9e075"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"79ae6d31204b1a77aea0e9dabaa2c6fd8edb31a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      init: runtime/default"},{"line_number":7,"context_line":"      ranger-agent-api: runtime/default"},{"line_number":8,"context_line":"    ranger-agent-engine:"},{"line_number":9,"context_line":"      ranger-agent-engine: runtime/default"},{"line_number":10,"context_line":"      init: runtime/default"},{"line_number":11,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":55,"id":"bf51134e_b277f73a","line":9,"updated":"2020-06-17 15:29:41.000000000","message":"pls bring back test pod apparmor here overrides","commit_id":"9220a33723e54c9ef88f579a675c7fef33b43640"}],"sonobuoy/templates/pod-api.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"b2007142d99ec6983bd82eefba92cd5549c3e66a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  name: sonobuoy"},{"line_number":56,"context_line":"  annotations:"},{"line_number":57,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_287a57b9","line":61,"range":{"start_line":58,"start_character":0,"end_line":61,"end_character":72},"updated":"2020-06-10 22:04:09.000000000","message":"does not make much sense for me. could you clarify please why you define the same list in a different order.","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"e04fd0786f3f23d7d2b9123643d7aca6dea91fb3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_a8b307e9","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":72},"updated":"2020-06-10 21:49:47.000000000","message":"why duplicate? line #59","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"9bc5fa07de2004c0bfec4b2a36469b30d35e9542","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  name: sonobuoy"},{"line_number":56,"context_line":"  annotations:"},{"line_number":57,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_aba6610e","line":61,"range":{"start_line":58,"start_character":0,"end_line":61,"end_character":72},"in_reply_to":"ff570b3c_287a57b9","updated":"2020-06-10 22:16:16.000000000","message":"thanks Andrii for Reviewing,If i don\u0027t keep the second line (i.e Line 61), it does not take any containers at all.","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"e296160db20ddc966a9b73e0262de51294ee0488","unresolved":false,"context_lines":[{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_e81dff77","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":72},"in_reply_to":"ff570b3c_4847cbbd","updated":"2020-06-10 22:05:46.000000000","message":"This change makes the if statement useless, the lists contain the same values.\n\nAlso that list is overriden even if publish_results is true.","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"771467e168f2de70509872fc9cedb189c87e06a1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_4847cbbd","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":72},"in_reply_to":"ff570b3c_a8b307e9","updated":"2020-06-10 21:52:25.000000000","message":"Please check the if statement in L58.","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1b8a53d4cf6085ff8dad75cbb795d7dbbee0ad1e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  name: sonobuoy"},{"line_number":56,"context_line":"  annotations:"},{"line_number":57,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_4bbea5ff","line":61,"range":{"start_line":58,"start_character":0,"end_line":61,"end_character":72},"in_reply_to":"ff570b3c_aba6610e","updated":"2020-06-10 22:23:23.000000000","message":"that does not address issue Andrii raised, why does the order of $containers list matter? what does that publish_results do that require the order to change?","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"9bc5fa07de2004c0bfec4b2a36469b30d35e9542","unresolved":false,"context_lines":[{"line_number":58,"context_line":"{{- if $envAll.Values.conf.publish_results }}"},{"line_number":59,"context_line":"{{- $containers :\u003d (list \"results-publisher\" \"init\" \"kube-sonobuoy\") }}"},{"line_number":60,"context_line":"{{- end }}"},{"line_number":61,"context_line":"{{- $containers :\u003d (list \"init\" \"kube-sonobuoy\" \"results-publisher\" ) }}"},{"line_number":62,"context_line":"{{ dict \"envAll\" . \"podName\" \"sonobuoy\" \"containerNames\" $containers | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 4 }}"},{"line_number":63,"context_line":"spec:"},{"line_number":64,"context_line":"  nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff570b3c_0b3aedcb","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":72},"in_reply_to":"ff570b3c_e81dff77","updated":"2020-06-10 22:16:16.000000000","message":"if i don\u0027t keep the second line (i.e Line 61), it does not take any containers at all.","commit_id":"acc828565c2b59055dd7db9c4a5c9d062dd5983e"}],"sonobuoy/values.yaml":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"57e8ab2c4e8a3c784e51bddbae4445a5063408ac","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        limits:"},{"line_number":55,"context_line":"          memory: \"128Mi\""},{"line_number":56,"context_line":"          cpu: \"2000m\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"secrets:"},{"line_number":59,"context_line":"  identity:"},{"line_number":60,"context_line":"    admin: sonobuoy-keystone-admin"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"ff570b3c_71d43a20","side":"PARENT","line":57,"updated":"2020-06-11 01:58:36.000000000","message":"I think this empty line should stay here for consistency","commit_id":"ce635602ea8244bb4b1a500c47f324baf499fd90"}],"tools/deployment/common/install-packages.sh":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"34ec8c65fead4468e9217da2c94f706e9e3aa41f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -xe"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CURRENT_DIR\u003d\"$(pwd)\""},{"line_number":5,"context_line":"\"${INSTALL_PATH:\u003d\"../\"}\""},{"line_number":6,"context_line":"cd ${INSTALL_PATH}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Clone dependencies"},{"line_number":9,"context_line":" git clone https://opendev.org/openstack/openstack-helm-infra.git"},{"line_number":10,"context_line":" cd openstack-helm-infra"},{"line_number":11,"context_line":" git checkout \"${OSH_INFRA_COMMIT}\""}],"source_content_type":"text/x-sh","patch_set":56,"id":"bf51134e_0322d852","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":35},"updated":"2020-06-17 16:33:16.000000000","message":"i don\u0027t see you\u0027re actually invoking anything here. since openstack-helm-infra is already available in jobs, pls don\u0027t clone anything, just invoke an available script \n../openstack-helm-infra/tools/deployment/common/000-install-packages.sh\nThough this script lacks uuid-runtime package available in osh-addons","commit_id":"8ed2ca1a76c02284cacdca968b59beb1d96a6a6c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"bcdb78dde00d3c5a225d89a74f83ea6125e61473","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -xe"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CURRENT_DIR\u003d\"$(pwd)\""},{"line_number":5,"context_line":"\"${INSTALL_PATH:\u003d\"../\"}\""},{"line_number":6,"context_line":"cd ${INSTALL_PATH}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Clone dependencies"},{"line_number":9,"context_line":" git clone https://opendev.org/openstack/openstack-helm-infra.git"},{"line_number":10,"context_line":" cd openstack-helm-infra"},{"line_number":11,"context_line":" git checkout \"${OSH_INFRA_COMMIT}\""}],"source_content_type":"text/x-sh","patch_set":56,"id":"bf51134e_66bf62d0","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":35},"in_reply_to":"bf51134e_0322d852","updated":"2020-06-17 17:19:06.000000000","message":"Do not reclone the repo, each job should have the repo there automatically via zuul.\n\nAlso if you wanted to replace this script, just call the infra one in the zuul check instead of manually calling it here. Otherwise just leave the script as-is and update it here.","commit_id":"8ed2ca1a76c02284cacdca968b59beb1d96a6a6c"}],"tools/deployment/component/sonobuoy/sonobuoy.sh":[{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"96182c99d0f4f00f9603e3105e51fb74cfa77201","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#NOTE: Get the over-rides to use"},{"line_number":18,"context_line":": ${OSH_EXTRA_HELM_ARGS_SONOBUOY:\u003d\"$(./tools/deployment/common/get-values-overrides.sh sonobuoy)\"}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"helm dependency update sonobuoy"}],"source_content_type":"text/x-sh","patch_set":38,"id":"ff570b3c_c2b0dae0","line":17,"updated":"2020-06-10 20:37:35.000000000","message":"remove the - between over and rides","commit_id":"11cc88032163fe05082136aba45a9d933b8e663f"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"96182c99d0f4f00f9603e3105e51fb74cfa77201","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        - ./tools/deployment/common/setup-client.sh"},{"line_number":98,"context_line":"        - ./tools/deployment/component/mini-mirror/mini-mirror.sh"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- job:"},{"line_number":101,"context_line":"    name: osh-addons-ranger-apparmor"},{"line_number":102,"context_line":"    parent: osh-addons-base"},{"line_number":103,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"ff570b3c_c2fe1a6a","line":100,"updated":"2020-06-10 20:37:35.000000000","message":"Do we need to create three jobs for testing apparmor for three components thrice?","commit_id":"11cc88032163fe05082136aba45a9d933b8e663f"},{"author":{"_account_id":29131,"name":"diwakar thyagaraj","email":"diwakar.chitoor.thyagaraj@att.com","username":"dt241s@att.com"},"change_message_id":"c5a44cc5e904c0f7e1296ac157f48f324f99464f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        - ./tools/deployment/common/setup-client.sh"},{"line_number":98,"context_line":"        - ./tools/deployment/component/mini-mirror/mini-mirror.sh"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- job:"},{"line_number":101,"context_line":"    name: osh-addons-ranger-apparmor"},{"line_number":102,"context_line":"    parent: osh-addons-base"},{"line_number":103,"context_line":"    run: tools/gate/playbooks/osh-gate-runner.yaml"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"ff570b3c_c29d7a0b","line":100,"in_reply_to":"ff570b3c_c2fe1a6a","updated":"2020-06-10 20:53:59.000000000","message":"Yes since three separate components to be pre-deployed to function properly.","commit_id":"11cc88032163fe05082136aba45a9d933b8e663f"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"79ae6d31204b1a77aea0e9dabaa2c6fd8edb31a1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":78,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":79,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":80,"context_line":"        - ./tools/deployment/component/heat/heat.sh"},{"line_number":81,"context_line":"        - ./tools/deployment/component/ranger/ranger.sh"},{"line_number":82,"context_line":"        - ./tools/deployment/component/ranger/ranger-agent.sh"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":55,"id":"bf51134e_72dc3f74","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":51},"updated":"2020-06-17 15:29:41.000000000","message":"why do we add heat deployment in scope of this task","commit_id":"9220a33723e54c9ef88f579a675c7fef33b43640"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d2033f4d1d8386a90e6d435bea5dedc081bbb4e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- project:"},{"line_number":15,"context_line":"    check:"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - openstack-helm-lint"},{"line_number":18,"context_line":"        - osh-addons-sonobuoy"},{"line_number":19,"context_line":"        - osh-addons-ranger"},{"line_number":20,"context_line":"        - osh-addons-mini-mirror"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-helm-lint"},{"line_number":24,"context_line":"        - osh-addons-sonobuoy"},{"line_number":25,"context_line":"        - osh-addons-ranger"},{"line_number":26,"context_line":"        - osh-addons-mini-mirror"},{"line_number":27,"context_line":"    experimental:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - openstack-helm-lint"},{"line_number":30,"context_line":"        - osh-addons-ranger-apparmor"},{"line_number":31,"context_line":"        - osh-addons-sonobuoy-apparmor"},{"line_number":32,"context_line":"        - osh-addons-mini-mirror-apparmor"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"ff570b3c_1126b769","line":32,"range":{"start_line":14,"start_character":2,"end_line":32,"end_character":0},"updated":"2020-06-09 21:24:51.000000000","message":"Job osh-addons-ranger-apparmor not defined","commit_id":"d69dccfff33b989cf40db131db17a8710bbf04f9"},{"author":{"_account_id":31482,"name":"Luna Das","email":"cse2013luna@gmail.com","username":"codebind-luna"},"change_message_id":"96182c99d0f4f00f9603e3105e51fb74cfa77201","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        - osh-addons-sonobuoy"},{"line_number":25,"context_line":"        - osh-addons-ranger"},{"line_number":26,"context_line":"        - osh-addons-mini-mirror"},{"line_number":27,"context_line":"    experimental:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - openstack-helm-lint"},{"line_number":30,"context_line":"        - osh-addons-ranger-apparmor"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"ff570b3c_a2368650","line":27,"updated":"2020-06-10 20:37:35.000000000","message":"ditto, three separate jobs are necessary to check the same feature ?","commit_id":"11cc88032163fe05082136aba45a9d933b8e663f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0146be61693dc4822e43670510c25abfeca1868b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- project:"},{"line_number":15,"context_line":"    check:"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - openstack-helm-lint"},{"line_number":18,"context_line":"        - osh-addons-sonobuoy"},{"line_number":19,"context_line":"        - osh-addons-ranger"},{"line_number":20,"context_line":"        - osh-addons-mini-mirror"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-helm-lint"},{"line_number":24,"context_line":"        - osh-addons-sonobuoy"},{"line_number":25,"context_line":"        - osh-addons-ranger"},{"line_number":26,"context_line":"        - osh-addons-mini-mirror"},{"line_number":27,"context_line":"    experimental:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - openstack-helm-lint"},{"line_number":30,"context_line":"        - osh-addons-ranger-apparmor"},{"line_number":31,"context_line":"        - osh-addons-sonobuoy-apparmor"},{"line_number":32,"context_line":"        - osh-addons-minimirror-ranger-apparmor"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"ff570b3c_824a6280","line":32,"range":{"start_line":14,"start_character":2,"end_line":32,"end_character":0},"updated":"2020-06-10 20:52:13.000000000","message":"Job osh-addons-ranger-apparmor not defined","commit_id":"fe86fd174ef193b8d0b2e3ed3ef0d9e4706f80ea"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6129809a57ac860dfe155eeb6f4061ef1bca95d2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        - osh-addons-mini-mirror"},{"line_number":27,"context_line":"    experimental:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - openstack-helm-lint"},{"line_number":30,"context_line":"        - osh-addons-sonobuoy-apparmor"},{"line_number":31,"context_line":"        - osh-addons-minimirror-ranger-apparmor"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"ff570b3c_91610e15","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":29},"updated":"2020-06-11 02:59:19.000000000","message":"should not be an experimental job.","commit_id":"10c489013125864345e53074cd27cb1689d1e290"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"0fcca29a891d69711e0ebdbeeee29d93a54f013b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        - osh-addons-mini-mirror"},{"line_number":27,"context_line":"    experimental:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        - openstack-helm-lint"},{"line_number":30,"context_line":"        - osh-addons-sonobuoy-apparmor"},{"line_number":31,"context_line":"        - osh-addons-minimirror-ranger-apparmor"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"ff570b3c_d139c6f2","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":29},"updated":"2020-06-11 03:08:16.000000000","message":"yes. please just delete it. we already have it for check and gate jobs.\n\nDo you find a sense to add experimental ranger apparmor job as well?","commit_id":"10c489013125864345e53074cd27cb1689d1e290"}]}