)]}'
{"manifests/site/test-site/metadata.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":1,"context_line":"phase:"},{"line_number":2,"context_line":"  path: ../openstack-helm-deployments/manifests/site/test-site/phases"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_9eb15ae5","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":37},"updated":"2020-10-21 14:21:28.000000000","message":"This path actually links to the repository defined as the PrimaryPhaseRepository in metadata.yaml [0]. Since we haven\u0027t defined one yet, airshipctl is choosing a repository named \"primary\" as the default option.\n\nSince this repo is openstack-helm-deployments, and we only want to borrow phases from airshipctl, openstack-helm-deployments is really our primary repository. We want the path to look like:\n\n  path: manifests/site/test-site/phases\n\nIn order to make that work, we just need to use the relative path, ../airshipctl, when we patch the phases we borrow from airshipctl [1]. There aren\u0027t any Kustomize patches in master yet, but this [2] is what we need to do to accomplish that in this change.\n\n[0] https://opendev.org/openstack/openstack-helm-deployments/src/branch/master/manifests/site/test-site/metadata.yaml\n\n[1] https://opendev.org/airship/airshipctl/src/branch/master/manifests/phases/phases.yaml\n\n[2] https://review.opendev.org/#/c/756401/38/manifests/site/test-site/phases/patch_phases.yaml","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"phase:"},{"line_number":2,"context_line":"  path: ../openstack-helm-deployments/manifests/site/test-site/phases"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_4a66dc53","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":37},"in_reply_to":"3f65232a_9eb15ae5","updated":"2020-10-21 17:06:20.000000000","message":"Done","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"}],"manifests/site/test-site/phases/ci-infra-phases.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    apiVersion: airshipit.org/v1alpha1"},{"line_number":12,"context_line":"    kind: KubernetesApply"},{"line_number":13,"context_line":"    name: kubernetes-apply"},{"line_number":14,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/ci/docker-registry"},{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"apiVersion: airshipit.org/v1alpha1"},{"line_number":17,"context_line":"kind: Phase"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_9ee67ae8","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":102},"updated":"2020-10-21 14:21:28.000000000","message":"Should be:\n\n  documentEntryPoint: manifests/site/test-site/target/ci/docker-registry\n\nafter updating the primary repository.","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    apiVersion: airshipit.org/v1alpha1"},{"line_number":12,"context_line":"    kind: KubernetesApply"},{"line_number":13,"context_line":"    name: kubernetes-apply"},{"line_number":14,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/ci/docker-registry"},{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"apiVersion: airshipit.org/v1alpha1"},{"line_number":17,"context_line":"kind: Phase"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_aa5b3085","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":102},"in_reply_to":"3f65232a_9ee67ae8","updated":"2020-10-21 17:06:20.000000000","message":"Done","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    apiVersion: airshipit.org/v1alpha1"},{"line_number":24,"context_line":"    kind: KubernetesApply"},{"line_number":25,"context_line":"    name: kubernetes-apply"},{"line_number":26,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/ci/helm-chart-collator"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_decf5255","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":106},"updated":"2020-10-21 14:21:28.000000000","message":"Should be:\n\n  documentEntryPoint: manifests/site/test-site/target/ci/helm-chart-collator\n\nafter updating the primary repository.","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    apiVersion: airshipit.org/v1alpha1"},{"line_number":24,"context_line":"    kind: KubernetesApply"},{"line_number":25,"context_line":"    name: kubernetes-apply"},{"line_number":26,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/ci/helm-chart-collator"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_ea540857","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":106},"in_reply_to":"3f65232a_decf5255","updated":"2020-10-21 17:06:20.000000000","message":"Done","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"}],"manifests/site/test-site/phases/patch_phases.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  name: workload-target"},{"line_number":10,"context_line":"  clusterName: target-cluster"},{"line_number":11,"context_line":"config:"},{"line_number":12,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/workload"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_1eda6a16","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":92},"updated":"2020-10-21 14:21:28.000000000","message":"Should be:\n\n  documentEntryPoint: manifests/site/test-site/target/workload\n\nafter updating the primary repository.","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  name: workload-target"},{"line_number":10,"context_line":"  clusterName: target-cluster"},{"line_number":11,"context_line":"config:"},{"line_number":12,"context_line":"  documentEntryPoint: ../openstack-helm-deployments/manifests/site/test-site/target/workload"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_6ac63819","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":92},"in_reply_to":"3f65232a_1eda6a16","updated":"2020-10-21 17:06:20.000000000","message":"Done","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"}],"playbooks/openstack-helm-deployments-gate-runner.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"5a897ab161c674df161231dd8949d7023670b3aa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      vars:"},{"line_number":45,"context_line":"        airshipctl_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/airship/airshipctl\u0027].src_dir }}\""},{"line_number":46,"context_line":"        gate_script_path: \"{{ item }}\""},{"line_number":47,"context_line":"        metadata_path: \"../openstack-helm-deployments/manifests/site/test-site/metadata.yaml\""},{"line_number":48,"context_line":"        osh_deployments_path: \"{{ ansible_user_dir }}/{{ zuul.project.src_dir }}\""},{"line_number":49,"context_line":"      with_items: \"{{ gate_scripts | default(gate_scripts_default) }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f65232a_eab0888e","line":47,"range":{"start_line":47,"start_character":24,"end_line":47,"end_character":93},"updated":"2020-10-21 17:10:21.000000000","message":"This needs to be:\n\n  manifests/site/test-site/metadata.yaml\n\nright? I didn\u0027t see any transition between airshipctl and osh-deployments as the primary repo.","commit_id":"88683a9ac032f320fc65c1428b668b429b007b78"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"3f35ef27c3ce335d770525527e9208ece4fc9d48","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      vars:"},{"line_number":45,"context_line":"        airshipctl_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/airship/airshipctl\u0027].src_dir }}\""},{"line_number":46,"context_line":"        gate_script_path: \"{{ item }}\""},{"line_number":47,"context_line":"        metadata_path: \"../openstack-helm-deployments/manifests/site/test-site/metadata.yaml\""},{"line_number":48,"context_line":"        osh_deployments_path: \"{{ ansible_user_dir }}/{{ zuul.project.src_dir }}\""},{"line_number":49,"context_line":"      with_items: \"{{ gate_scripts | default(gate_scripts_default) }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f65232a_ea5ec843","line":47,"range":{"start_line":47,"start_character":24,"end_line":47,"end_character":93},"in_reply_to":"3f65232a_eab0888e","updated":"2020-10-21 17:14:32.000000000","message":"Ah. Needed because of the chdir on L43","commit_id":"88683a9ac032f320fc65c1428b668b429b007b78"}],"tools/helm-chart-collator/01-build-hcc.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":": \"${AIRSHIP_IMAGES_PATH:\u003d\"$(mktemp -d)\"}\""},{"line_number":18,"context_line":": \"${OSH_DEPLOYMENTS_PATH:\u003d\"$(pwd)\"}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"git clone https://opendev.org/airship/images.git \"${AIRSHIP_IMAGES_PATH}\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f65232a_3e2f66f7","side":"PARENT","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":37},"updated":"2020-10-21 14:21:28.000000000","message":"We probably want to leave these so the script can be used outside of a Zuul environment.","commit_id":"c027ee24e177774fcbfacf0fa1a1fbe5d98e59db"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -xe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":": \"${AIRSHIP_IMAGES_PATH:\u003d\"$(mktemp -d)\"}\""},{"line_number":18,"context_line":": \"${OSH_DEPLOYMENTS_PATH:\u003d\"$(pwd)\"}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"git clone https://opendev.org/airship/images.git \"${AIRSHIP_IMAGES_PATH}\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f65232a_0ae1849b","side":"PARENT","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"3f65232a_3e2f66f7","updated":"2020-10-21 17:06:20.000000000","message":"this will be done after commit that introduces collator","commit_id":"c027ee24e177774fcbfacf0fa1a1fbe5d98e59db"}],"tools/patch-airship-config.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"daab37694012cfb3788bd955d922793617562593","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"airshipctl config set-manifest dummy_manifest \\"},{"line_number":12,"context_line":"        --branch master \\"},{"line_number":13,"context_line":"        --repo primary \\"},{"line_number":14,"context_line":"        --url \"${AIRSHIPCTL_PATH}\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f65232a_9e0dda92","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":24},"updated":"2020-10-21 14:21:28.000000000","message":"Our primary repository is this repository, openstack-helm-deployments. This repository just borrows a few phases from openstack-helm-deployments.\n\nThe reason the \"primary\" name is special is because that is the default PrimaryPhaseRepository. If we want to retain the name primary, we should assign it to openstack-helm-deployments, and make airshipctl the auxiliary repository. \n\nThat will also change the paths in the phase documents. I left an earlier comment that explains how we will need to patch those going forward.","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"82157ddca797549d0345f25cb01565fd82dc3ed2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"airshipctl config set-manifest dummy_manifest \\"},{"line_number":12,"context_line":"        --branch master \\"},{"line_number":13,"context_line":"        --repo primary \\"},{"line_number":14,"context_line":"        --url \"${AIRSHIPCTL_PATH}\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f65232a_6aef5887","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":24},"in_reply_to":"3f65232a_9e0dda92","updated":"2020-10-21 17:06:20.000000000","message":"Done","commit_id":"a6231d594f3779b4af760e7157cad56afc4dfb78"}]}
