)]}'
{"ceph-daemon/Makefile":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"5f2d0e3bc21f6e7ea848676271a21dd59d9f3a4c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"build_$(IMAGE_NAME):"},{"line_number":37,"context_line":"\tdocker build -f Dockerfile.ubuntu_xenial \\"},{"line_number":38,"context_line":"\t--network host \\"},{"line_number":39,"context_line":"\t--build-arg KUBE_VERSION\u003d$(KUBE_VERSION) \\"},{"line_number":40,"context_line":"        --build-arg CEPH_RELEASE\u003d$(CEPH_RELEASE) \\"},{"line_number":41,"context_line":"        --build-arg ETCDCTL_VERSION\u003d$(ETCDCTL_VERSION) \\"},{"line_number":42,"context_line":"\t--build-arg CONFD_VERSION\u003d$(CONFD_VERSION) \\"},{"line_number":43,"context_line":"        -t $(IMAGE) \\"},{"line_number":44,"context_line":"\t--label $(LABEL) --label CEPH_RELEASE\u003d$(CEPH_RELEASE) \\"},{"line_number":45,"context_line":"\t."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"dfd5e7cf_7ee98a7e","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":12},"updated":"2019-01-07 18:54:57.000000000","message":"mixed ws style","commit_id":"35c45a4eb47d5b9bdfc753bd26bba16b776d2c37"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f9974e1d1f06edbb50efaa6ee004c1200b70264f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfd5e7cf_eb7dbae7","updated":"2019-01-07 17:40:14.000000000","message":"The idea was to create a Makefile at the root of the openstack-helm-images repo, so this seems a little bit redundant. But I am fine with this in the meantime.","commit_id":"2ba8d3c097e60dc99c0c9fb69cb97a5b0a03ca5d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f9974e1d1f06edbb50efaa6ee004c1200b70264f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Make targets intended for use by the primary targets above."},{"line_number":35,"context_line":".PHONY: build_$(IMAGE_NAME)"},{"line_number":36,"context_line":"build_$(IMAGE_NAME):"},{"line_number":37,"context_line":"\tdocker build -f Dockerfile.ubuntu_xenial \\"},{"line_number":38,"context_line":"\t\t--network host \\"},{"line_number":39,"context_line":"\t\t--build-arg KUBE_VERSION\u003d$(KUBE_VERSION) \\"},{"line_number":40,"context_line":"\t\t--build-arg CEPH_RELEASE\u003d$(CEPH_RELEASE) \\"},{"line_number":41,"context_line":"\t\t--build-arg ETCDCTL_VERSION\u003d$(ETCDCTL_VERSION) \\"},{"line_number":42,"context_line":"\t\t--build-arg CONFD_VERSION\u003d$(CONFD_VERSION) \\"},{"line_number":43,"context_line":"\t\t-t $(IMAGE) \\"},{"line_number":44,"context_line":"\t\t--label $(LABEL) --label CEPH_RELEASE\u003d$(CEPH_RELEASE) \\"},{"line_number":45,"context_line":"\t\t."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfd5e7cf_0b76fe07","line":45,"range":{"start_line":37,"start_character":0,"end_line":45,"end_character":3},"updated":"2019-01-07 17:40:14.000000000","message":"nit: Please replace tabs with spaces, and trigger the build script instead.\n\n-1: The reason is that in the previous repositories setup, there were discrepencies between Makefiles and build scripts. We should rely on the lowest common factor (the shell scripts), and use them in the Makefiles.\n\nAlternatively, write code to detect discrepencies, but it sounds more complex to maintain over time.","commit_id":"2ba8d3c097e60dc99c0c9fb69cb97a5b0a03ca5d"}],"doc/source/ceph-daemon.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f9974e1d1f06edbb50efaa6ee004c1200b70264f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfd5e7cf_eb185ad4","updated":"2019-01-07 17:40:14.000000000","message":"-1: You should link this file from the main docs.","commit_id":"2ba8d3c097e60dc99c0c9fb69cb97a5b0a03ca5d"}],"zuul.d/ceph-daemon.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"10ab7980245700a238bb8f5cbdd444d58c143578","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- project:"},{"line_number":17,"context_line":"    check:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - openstack-helm-images-ceph-daemon-ubunu_xenial:"},{"line_number":20,"context_line":"            files: \u0026ceph-ubuntuxenial-files"},{"line_number":21,"context_line":"              - ^ceph-daemon/build.sh"},{"line_number":22,"context_line":"              - ^ceph-daemon/Dockerfile.ubuntu_xenial$"},{"line_number":23,"context_line":"              - ^zuul.d/ceph-daemon.yaml"},{"line_number":24,"context_line":"    gate:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-helm-images-ceph-daemon-ubuntu_xenial:"},{"line_number":27,"context_line":"            files: *ceph-ubuntuxenial-files"},{"line_number":28,"context_line":"    periodic:"},{"line_number":29,"context_line":"      jobs:"},{"line_number":30,"context_line":"        - openstack-helm-images-ceph-daemon-ubuntu_xenial"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- job:"},{"line_number":33,"context_line":"    name: openstack-helm-images-ceph-daemon"},{"line_number":34,"context_line":"    parent: openstack-helm-images-base"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd5e7cf_284c28c6","line":31,"range":{"start_line":16,"start_character":2,"end_line":31,"end_character":0},"updated":"2019-01-07 16:42:13.000000000","message":"Job openstack-helm-images-ceph-daemon-ubunu_xenial not defined","commit_id":"6efc0819e4e147b4f6ff06fc29650e1d3f85fde8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f9974e1d1f06edbb50efaa6ee004c1200b70264f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, SUSE LINUX GmbH."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_cb1316b8","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":34},"updated":"2019-01-07 17:40:14.000000000","message":"Author is incorrect. That\u0027s probably AT\u0026T, right?","commit_id":"2ba8d3c097e60dc99c0c9fb69cb97a5b0a03ca5d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"440d78a490c77f51f14b3f777973b69787cfbe72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfd5e7cf_3c77813d","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":44},"updated":"2019-01-08 09:34:23.000000000","message":"You should write the company you work for :)","commit_id":"febeef3f608ad2164027f01c0c5bbc0a6a0c0edb"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"0dee93e27d4a192ebb5db2b7394bca1857815315","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfd5e7cf_1bf39aa0","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":44},"in_reply_to":"dfd5e7cf_3c77813d","updated":"2019-01-08 16:32:44.000000000","message":"And if I\u0027m not working for any company? I can just own the code myself then or list it as Openstack-Helm authors.","commit_id":"febeef3f608ad2164027f01c0c5bbc0a6a0c0edb"}]}