)]}'
{"mini-mirror/Dockerfile.ubuntu":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"127a05bdf8ac3c25107af365d390d76ed901b5bb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"RUN apt-get install -y aptly wget"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN /opt/publish_snapshots.sh"},{"line_number":32,"context_line":"RUN aptly publish snapshot -batch\u003dtrue \\"},{"line_number":33,"context_line":"      -passphrase\u003d\"${RELEASE_SIGN_KEY_PASSPHRASE}\" minimirror"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FROM nginx"},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"bfdaf3ff_d3e189d2","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":61},"updated":"2019-01-11 23:07:38.000000000","message":"as running with bash, lets make this a conditional, then you dont need the demo image.","commit_id":"4fa09f70ee97fbccbff6c155d3c480b0e75a95c1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1cb5b724fd23b1bc62fc0d076411cfca3e3aef66","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN /opt/publish_snapshots.sh \"${DEMO_IMAGE}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN if [ -z \"${DEMO_IMAGE}\" ]; then aptly publish snapshot minimirror  ; else \\"},{"line_number":36,"context_line":"      aptly publish snapshot -batch\u003dtrue \\"},{"line_number":37,"context_line":"          -passphrase\u003d\"${RELEASE_SIGN_KEY_PASSPHRASE}\" minimirror ; fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bfdaf3ff_2c6d1798","line":35,"range":{"start_line":35,"start_character":13,"end_line":35,"end_character":26},"updated":"2019-01-12 02:42:16.000000000","message":"if you used RELEASE_SIGN_KEY_PASSPHRASE here then you could swap the conditional around and drop the DEMO_IMAGE arg.","commit_id":"147c0658a3d16d4248d807086c4bac7b632351a5"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"057c670cdd26633682150de0f308d06dac3cebc5","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN /opt/publish_snapshots.sh \"${DEMO_IMAGE}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN if [ -z \"${DEMO_IMAGE}\" ]; then aptly publish snapshot minimirror  ; else \\"},{"line_number":36,"context_line":"      aptly publish snapshot -batch\u003dtrue \\"},{"line_number":37,"context_line":"          -passphrase\u003d\"${RELEASE_SIGN_KEY_PASSPHRASE}\" minimirror ; fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bfdaf3ff_f5190e88","line":35,"range":{"start_line":35,"start_character":13,"end_line":35,"end_character":26},"in_reply_to":"bfdaf3ff_2c6d1798","updated":"2019-01-12 17:21:28.000000000","message":"\u003e if you used RELEASE_SIGN_KEY_PASSPHRASE here then you could swap\n \u003e the conditional around and drop the DEMO_IMAGE arg.\n\nThanks for the feedback, Pete! I have moved this additional build step to the build script and updated the script to use the $RELEASE_SIGN_KEY_PASSPHRASE arg as a conditional for repository signing.","commit_id":"147c0658a3d16d4248d807086c4bac7b632351a5"}],"mini-mirror/etc/aptly.conf":[{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"2d330ddb4d12ce587045f311906d7bd415f9ac31","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  \"dependencyFollowAllVariants\": false,"},{"line_number":9,"context_line":"  \"dependencyFollowSource\": false,"},{"line_number":10,"context_line":"  \"dependencyVerboseResolve\": false,"},{"line_number":11,"context_line":"  \"gpgDisableSign\": true,"},{"line_number":12,"context_line":"  \"gpgDisableVerify\": true,"},{"line_number":13,"context_line":"  \"gpgProvider\": \"gpg\","},{"line_number":14,"context_line":"  \"downloadSourcePackages\": false,"},{"line_number":15,"context_line":"  \"skipLegacyPool\": true,"}],"source_content_type":"text/plain","patch_set":3,"id":"bfdaf3ff_26d9c782","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":27},"updated":"2019-01-11 10:02:28.000000000","message":"Add sed replace to \u0027false\u0027 in Dockerfile if this is a non-demo image build.","commit_id":"5b4fe94f8920185442ff82a6436d313cee266cba"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"edd39e367cb98592a49c63d2ca4ccca9e08aba05","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  \"dependencyFollowAllVariants\": false,"},{"line_number":9,"context_line":"  \"dependencyFollowSource\": false,"},{"line_number":10,"context_line":"  \"dependencyVerboseResolve\": false,"},{"line_number":11,"context_line":"  \"gpgDisableSign\": true,"},{"line_number":12,"context_line":"  \"gpgDisableVerify\": true,"},{"line_number":13,"context_line":"  \"gpgProvider\": \"gpg\","},{"line_number":14,"context_line":"  \"downloadSourcePackages\": false,"},{"line_number":15,"context_line":"  \"skipLegacyPool\": true,"}],"source_content_type":"text/plain","patch_set":3,"id":"bfdaf3ff_d7e5fc39","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":27},"in_reply_to":"bfdaf3ff_26d9c782","updated":"2019-01-11 16:33:01.000000000","message":"\u003e Add sed replace to \u0027false\u0027 in Dockerfile if this is a non-demo\n \u003e image build.\n\nI added a blip in the documentation about generating a proper GPG key and updating the aptly config file. My concern with updating this value with sed is that it will leave to unexpected consequences when users build their own images.","commit_id":"5b4fe94f8920185442ff82a6436d313cee266cba"}],"mini-mirror/etc/release.gpg":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8a6a5dd7713de3a63c5536a1f548aee106288ae2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dfd5e7cf_403eeada","updated":"2019-01-10 02:06:45.000000000","message":"where does this pgp key come from? and should this be version controlled?","commit_id":"7a8c4dea1dc6b5f88795f102f2796a29d2ff12e4"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"51ceacb142e07ec2ddd61c98439e88ce8c4ab04a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dfd5e7cf_6a4c209e","in_reply_to":"dfd5e7cf_403eeada","updated":"2019-01-10 15:13:16.000000000","message":"\u003e where does this pgp key come from? and should this be version\n \u003e controlled?\n\nThis is an example GPG key provided for demonstration purposes/building the image.\n\nSince the image will have to be re-built by the user to make mini-mirror useful (outside of just providing a mirror of an aptly repository), this key should be discarded.\n\nI understand that there is a negative association with adding private keys to publicly available repositories; I can remove if we want to disable signing for the default image.","commit_id":"7a8c4dea1dc6b5f88795f102f2796a29d2ff12e4"}]}