)]}'
{"Makefile":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e16ae3db0b0a2d9b6f4e31dea65303615e099d7a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"LABEL                      ?\u003d mimic"},{"line_number":29,"context_line":"UBUNTU_BASE_IMAGE          ?\u003d ubuntu:xenial"},{"line_number":30,"context_line":"PUSH_IMAGE                 ?\u003d false"},{"line_number":31,"context_line":"UBUNTU_RELEASE             ?\u003d xenial"},{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_17c7c147","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":17},"updated":"2019-01-15 21:51:14.000000000","message":"Why?","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b74cf557add363001af5ae137d357d6c3a3b9d48","unresolved":false,"context_lines":[{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"LABEL                      ?\u003d mimic"},{"line_number":29,"context_line":"UBUNTU_BASE_IMAGE          ?\u003d ubuntu:xenial"},{"line_number":30,"context_line":"PUSH_IMAGE                 ?\u003d false"},{"line_number":31,"context_line":"UBUNTU_RELEASE             ?\u003d xenial"},{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_d57b71bb","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":17},"in_reply_to":"bfdaf3ff_17c7c147","updated":"2019-01-16 00:37:56.000000000","message":"Done","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e16ae3db0b0a2d9b6f4e31dea65303615e099d7a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LABEL                      ?\u003d mimic"},{"line_number":29,"context_line":"UBUNTU_BASE_IMAGE          ?\u003d ubuntu:xenial"},{"line_number":30,"context_line":"PUSH_IMAGE                 ?\u003d false"},{"line_number":31,"context_line":"UBUNTU_RELEASE             ?\u003d xenial"},{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"},{"line_number":33,"context_line":"OS_RELEASE                 ?\u003d ubuntu"},{"line_number":34,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_b7c5953e","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":14},"updated":"2019-01-15 21:51:14.000000000","message":"Why?","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b74cf557add363001af5ae137d357d6c3a3b9d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LABEL                      ?\u003d mimic"},{"line_number":29,"context_line":"UBUNTU_BASE_IMAGE          ?\u003d ubuntu:xenial"},{"line_number":30,"context_line":"PUSH_IMAGE                 ?\u003d false"},{"line_number":31,"context_line":"UBUNTU_RELEASE             ?\u003d xenial"},{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"},{"line_number":33,"context_line":"OS_RELEASE                 ?\u003d ubuntu"},{"line_number":34,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_954f2991","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":14},"in_reply_to":"bfdaf3ff_b7c5953e","updated":"2019-01-16 00:37:56.000000000","message":"Done","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e16ae3db0b0a2d9b6f4e31dea65303615e099d7a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"},{"line_number":33,"context_line":"OS_RELEASE                 ?\u003d ubuntu"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}-${OS_RELEASE}-${UBUNTU_RELEASE}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Build ceph-utility Docker image for this project"},{"line_number":38,"context_line":".PHONY: images"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_d7c0592d","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":102},"updated":"2019-01-15 21:51:14.000000000","message":"I don\u0027t see how this results in a generic Makefile that doesn\u0027t introduce opinions into what we\u0027re looking to do.","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"b74cf557add363001af5ae137d357d6c3a3b9d48","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CEPH_RELEASE               ?\u003d mimic"},{"line_number":33,"context_line":"OS_RELEASE                 ?\u003d ubuntu"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}-${OS_RELEASE}-${UBUNTU_RELEASE}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Build ceph-utility Docker image for this project"},{"line_number":38,"context_line":".PHONY: images"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"bfdaf3ff_30a52b05","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":102},"in_reply_to":"bfdaf3ff_d7c0592d","updated":"2019-01-16 00:37:56.000000000","message":"Done","commit_id":"b0421cde574ba0e92ec95721f76961bd2b0a4933"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"2a36053fcdd3ccc00a38108c96854d8bcc3e14fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"SHELL :\u003d /bin/bash"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DOCKER_REGISTRY            ?\u003d quay.io"},{"line_number":25,"context_line":"IMAGE_NAME                 ?\u003d ceph-config-helper"},{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"OS_RELEASE                 ?\u003d ubuntu_xenial"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_75b4f335","line":25,"updated":"2019-01-16 18:26:43.000000000","message":"This isn\u0027t needed.","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"bcc200878c3ac884db0e7dd7a3dd8de97c8b35ac","unresolved":false,"context_lines":[{"line_number":22,"context_line":"SHELL :\u003d /bin/bash"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DOCKER_REGISTRY            ?\u003d quay.io"},{"line_number":25,"context_line":"IMAGE_NAME                 ?\u003d ceph-config-helper"},{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"OS_RELEASE                 ?\u003d ubuntu_xenial"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_9013a55c","line":25,"in_reply_to":"bfdaf3ff_75b4f335","updated":"2019-01-16 19:02:35.000000000","message":"Done","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"2a36053fcdd3ccc00a38108c96854d8bcc3e14fa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"IMAGE_NAME                 ?\u003d ceph-config-helper"},{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"OS_RELEASE                 ?\u003d ubuntu_xenial"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Set the image"},{"line_number":31,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_1585675a","line":28,"updated":"2019-01-16 18:26:43.000000000","message":"Likewise for this.","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"bcc200878c3ac884db0e7dd7a3dd8de97c8b35ac","unresolved":false,"context_lines":[{"line_number":25,"context_line":"IMAGE_NAME                 ?\u003d ceph-config-helper"},{"line_number":26,"context_line":"IMAGE_PREFIX               ?\u003d att-comdev"},{"line_number":27,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":28,"context_line":"OS_RELEASE                 ?\u003d ubuntu_xenial"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Set the image"},{"line_number":31,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_b00ee92f","line":28,"in_reply_to":"bfdaf3ff_1585675a","updated":"2019-01-16 19:02:35.000000000","message":"Done","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"f6f0b063287b0ef370c42fd0a0f1e03cdfd4f2ec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"},{"line_number":30,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Build ceph-utility Docker image for this project"},{"line_number":33,"context_line":".PHONY: images"},{"line_number":34,"context_line":"images: build_$(IMAGE_NAME)"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":27,"id":"bfdaf3ff_b03ca9bf","line":32,"updated":"2019-01-16 19:07:29.000000000","message":"Sice this is building all images in the repo, I\u0027m pretty sure we don\u0027t need to label it as ceph-utility specific.","commit_id":"7cbf6ddc0429c1286cb605275be247adda4f4ac0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"abab3b85ee7243cc55e0096c0c80e44060d3f4f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"},{"line_number":30,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Build ceph-utility Docker image for this project"},{"line_number":33,"context_line":".PHONY: images"},{"line_number":34,"context_line":"images: build_$(IMAGE_NAME)"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":27,"id":"bfdaf3ff_50e77d41","line":32,"in_reply_to":"bfdaf3ff_b03ca9bf","updated":"2019-01-16 19:10:50.000000000","message":"Done","commit_id":"7cbf6ddc0429c1286cb605275be247adda4f4ac0"}],"README_MAKEFILE":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"52907ab8ec71adf8a4ecb9c41251f6a58d245ebb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  make IMAGE_NAME\u003dceph-utility OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  make IMAGE_NAME\u003dceph-daemon  OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":15,"context_line":"  "},{"line_number":16,"context_line":"  make IMAGE_NAME\u003dceph-config-helper  OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Create docker image for ceph mimic release on suse"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"bfdaf3ff_17f4a1ce","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"updated":"2019-01-15 21:39:09.000000000","message":"remove this whitespace","commit_id":"7a1df3db16c60db9241e3747c6cf4a25ff41710d"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"e5ba81537df822ae5f9be7e657c010d67b222941","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  make IMAGE_NAME\u003dceph-utility OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  make IMAGE_NAME\u003dceph-daemon  OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":15,"context_line":"  "},{"line_number":16,"context_line":"  make IMAGE_NAME\u003dceph-config-helper  OS_RELEASE\u003dubuntu CEPH_RELEASE\u003dmimic"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Create docker image for ceph mimic release on suse"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"bfdaf3ff_97d65127","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"in_reply_to":"bfdaf3ff_17f4a1ce","updated":"2019-01-15 21:41:47.000000000","message":"Done","commit_id":"7a1df3db16c60db9241e3747c6cf4a25ff41710d"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"e80c50e9fd43ef7ca46af055c11c7d4e39260d4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Makefile For Ceph images"},{"line_number":2,"context_line":"------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is a  make and dockerfile for ceph container. This can be used to create docker images using different ceph releases and os releases"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Usage:"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"bfdaf3ff_eb97b88f","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":39},"updated":"2019-01-16 02:17:46.000000000","message":"please remove ceph here since it works for all images","commit_id":"15dbaa4a893c37f4b343985648011a4b2ab656f8"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"1d2ef0686506a4a073d5d609efb42105ba93d380","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Makefile For Ceph images"},{"line_number":2,"context_line":"------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is a  make and dockerfile for ceph container. This can be used to create docker images using different ceph releases and os releases"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Usage:"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"bfdaf3ff_4b5fe471","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":39},"in_reply_to":"bfdaf3ff_eb97b88f","updated":"2019-01-16 03:06:59.000000000","message":"Done","commit_id":"15dbaa4a893c37f4b343985648011a4b2ab656f8"}],"ceph-config-helper/Dockerfile.suse_15":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"a2abda64202f85706d90732e6dd42fec142bffe0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainers\u003dstephane@alum.mit.edu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":6,"context_line":"ARG CEPH_RELEASE\u003dmimic"},{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bfdaf3ff_4fe4f0ac","line":6,"updated":"2019-01-14 20:23:52.000000000","message":"I\u0027m fairly certain that just changing this won\u0027t install mimic binaries. We are missing the proper repo.","commit_id":"553084a06e77b5a6ad801ec94a4e5a907d0f6da0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"75b10a6c7a259f711735f5ff6cead0eb8a903892","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainers\u003dstephane@alum.mit.edu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":6,"context_line":"ARG CEPH_RELEASE\u003dmimic"},{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bfdaf3ff_0a84965d","line":6,"in_reply_to":"bfdaf3ff_4fe4f0ac","updated":"2019-01-14 21:16:15.000000000","message":"The image by default come with ceph mimic 13.0.2 dev. i have tested it.\nI have added the repo for mimic stable now.","commit_id":"553084a06e77b5a6ad801ec94a4e5a907d0f6da0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a35fe3ba658dd0d7a4a63f1055c164c8731a3b2c","unresolved":false,"context_lines":[{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"},{"line_number":10,"context_line":"    zypper ar https://download.opensuse.org/repositories/filesystems:/ceph:/mimic/openSUSE_Leap_15.0/ ${CEPH_RELEASE} ;\\"},{"line_number":11,"context_line":"    zypper --gpg-auto-import-keys refresh ;\\"},{"line_number":12,"context_line":"    zypper up -y ;\\"},{"line_number":13,"context_line":"    zypper install -y \\"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_1fb908cb","line":10,"range":{"start_line":10,"start_character":76,"end_line":10,"end_character":81},"updated":"2019-01-16 17:24:09.000000000","message":"should this not also be driven by the ceph_release arg?","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"6e7d49071e4d1823bbc2c14b7bf4b15120fd207b","unresolved":false,"context_lines":[{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"},{"line_number":10,"context_line":"    zypper ar https://download.opensuse.org/repositories/filesystems:/ceph:/mimic/openSUSE_Leap_15.0/ ${CEPH_RELEASE} ;\\"},{"line_number":11,"context_line":"    zypper --gpg-auto-import-keys refresh ;\\"},{"line_number":12,"context_line":"    zypper up -y ;\\"},{"line_number":13,"context_line":"    zypper install -y \\"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_5a9f9e5e","line":10,"range":{"start_line":10,"start_character":76,"end_line":10,"end_character":81},"in_reply_to":"bfdaf3ff_1fb908cb","updated":"2019-01-16 18:57:15.000000000","message":"Done","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"f6f0b063287b0ef370c42fd0a0f1e03cdfd4f2ec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainers\u003dstephane@alum.mit.edu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":6,"context_line":"ARG CEPH_RELEASE\u003dMimic"},{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"bfdaf3ff_70464152","line":6,"updated":"2019-01-16 19:07:29.000000000","message":"lower case?","commit_id":"7cbf6ddc0429c1286cb605275be247adda4f4ac0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"abab3b85ee7243cc55e0096c0c80e44060d3f4f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainers\u003dstephane@alum.mit.edu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":6,"context_line":"ARG CEPH_RELEASE\u003dMimic"},{"line_number":7,"context_line":" RUN set -ex ;\\"},{"line_number":8,"context_line":"    TMP_DIR\u003d$(mktemp --directory) ;\\"},{"line_number":9,"context_line":"    cd ${TMP_DIR} ;\\"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"bfdaf3ff_10d33562","line":6,"in_reply_to":"bfdaf3ff_70464152","updated":"2019-01-16 19:10:50.000000000","message":"Done","commit_id":"7cbf6ddc0429c1286cb605275be247adda4f4ac0"}],"ceph-config-helper/Dockerfile.ubuntu_xenial":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df963cad458f7e9c8bcf078719668de84503ac12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG UBUNTU_RELEASE\u003dxenial"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"FROM docker.io/ubuntu:${UBUNTU_RELEASE}"},{"line_number":4,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bfdaf3ff_71af8094","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":25},"updated":"2019-01-11 15:34:06.000000000","message":"Duplicate, can be removed","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"d8db987e7937a80891576f69e23cd8eddac496aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG UBUNTU_RELEASE\u003dxenial"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"FROM docker.io/ubuntu:${UBUNTU_RELEASE}"},{"line_number":4,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bfdaf3ff_f1c13030","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":25},"in_reply_to":"bfdaf3ff_71af8094","updated":"2019-01-11 16:43:04.000000000","message":"This is required if we want to use this same docker file for different ubuntu releases","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"25d82f8e2e36e43938cb16da9c895e1304c4438f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG UBUNTU_RELEASE\u003dxenial"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"FROM docker.io/ubuntu:${UBUNTU_RELEASE}"},{"line_number":4,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bfdaf3ff_4921744d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":25},"in_reply_to":"bfdaf3ff_a9a900e0","updated":"2019-01-11 17:08:03.000000000","message":"Scope of Arg is different in both cases.\n1st ARG is applied only on FROM\n2nd ARG is used on the entry for source.list","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f7f84fa32ec884a5ee7ceb7fb41e72a9bc7363c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG UBUNTU_RELEASE\u003dxenial"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"FROM docker.io/ubuntu:${UBUNTU_RELEASE}"},{"line_number":4,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bfdaf3ff_a9a900e0","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":25},"in_reply_to":"bfdaf3ff_f1c13030","updated":"2019-01-11 16:59:40.000000000","message":"Correct.  You have this defined below however.  We do not need this defined twice","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"ab9c09e98f74dd16d8bf7fb3b80f9605c263194f","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":7,"context_line":"ARG CEPH_RELEASE\u003dmimic"},{"line_number":8,"context_line":"ARG UBUNTU_RELEASE\u003dxenial"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"bfdaf3ff_ffefb6e6","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":25},"updated":"2019-01-11 18:28:53.000000000","message":"changing this to just \u0027ARG UBUNTU_RELEASE\u0027 will allow this value to be set from the previous UBUNTU_RELEASE set before the FROM instruction\n\nSee: https://github.com/docker/cli/pull/333","commit_id":"2ae0cddb20f67b9873e53a31f6cdab095cad4970"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"e7f50eb35a5cf3d1d287472c1b83d264f86019e5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":13,"context_line":"    apt-get update \u0026\u0026 apt-get install -y gnupg ;\\"},{"line_number":14,"context_line":"    apt-key add /etc/apt/ceph-release.asc ;\\"},{"line_number":15,"context_line":"    rm -f /etc/apt/ceph-release.asc ;\\"},{"line_number":16,"context_line":"    echo deb http://download.ceph.com/debian-${CEPH_RELEASE}/ ${UBUNTU_RELEASE} main | tee /etc/apt/sources.list.d/ceph.list ;\\"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"bfdaf3ff_73ac448c","line":13,"updated":"2019-01-14 14:42:14.000000000","message":"This isn\u0027t needed. Just add gnupg to the list of packages below under line 21.","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"7160e9bce780cb16e0a1d3ad5edb51b7fba41f60","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":13,"context_line":"    apt-get update \u0026\u0026 apt-get install -y gnupg ;\\"},{"line_number":14,"context_line":"    apt-key add /etc/apt/ceph-release.asc ;\\"},{"line_number":15,"context_line":"    rm -f /etc/apt/ceph-release.asc ;\\"},{"line_number":16,"context_line":"    echo deb http://download.ceph.com/debian-${CEPH_RELEASE}/ ${UBUNTU_RELEASE} main | tee /etc/apt/sources.list.d/ceph.list ;\\"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"bfdaf3ff_74d747ef","line":13,"in_reply_to":"bfdaf3ff_1bc70e15","updated":"2019-01-14 19:23:16.000000000","message":"We do not need two updates, pick one to keep and drop the other. This adds to the build time and is very inconvienent.","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"434435967b4b9bdd793c76397bfd0de88afc73f5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":13,"context_line":"    apt-get update \u0026\u0026 apt-get install -y gnupg ;\\"},{"line_number":14,"context_line":"    apt-key add /etc/apt/ceph-release.asc ;\\"},{"line_number":15,"context_line":"    rm -f /etc/apt/ceph-release.asc ;\\"},{"line_number":16,"context_line":"    echo deb http://download.ceph.com/debian-${CEPH_RELEASE}/ ${UBUNTU_RELEASE} main | tee /etc/apt/sources.list.d/ceph.list ;\\"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"bfdaf3ff_a8d0faf8","line":13,"in_reply_to":"bfdaf3ff_6580fb8c","updated":"2019-01-14 15:53:44.000000000","message":"That\u0027s fine, then remove L19 from the Dockerfile. Are you making sure that the SuSe docker images are using Mimic too?","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"e96e8facf2c24a7a0c62155f0f30970db2df4474","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":13,"context_line":"    apt-get update \u0026\u0026 apt-get install -y gnupg ;\\"},{"line_number":14,"context_line":"    apt-key add /etc/apt/ceph-release.asc ;\\"},{"line_number":15,"context_line":"    rm -f /etc/apt/ceph-release.asc ;\\"},{"line_number":16,"context_line":"    echo deb http://download.ceph.com/debian-${CEPH_RELEASE}/ ${UBUNTU_RELEASE} main | tee /etc/apt/sources.list.d/ceph.list ;\\"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"bfdaf3ff_6580fb8c","line":13,"in_reply_to":"bfdaf3ff_73ac448c","updated":"2019-01-14 15:30:46.000000000","message":"if we are using same docker file for ubuntu 18.04, then gnupg need to be installed before running apt-key","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"5b8f69eefb49a84f250a89173d61cceb10088dac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ADD https://download.ceph.com/keys/release.asc /etc/apt/ceph-release.asc"},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":13,"context_line":"    apt-get update \u0026\u0026 apt-get install -y gnupg ;\\"},{"line_number":14,"context_line":"    apt-key add /etc/apt/ceph-release.asc ;\\"},{"line_number":15,"context_line":"    rm -f /etc/apt/ceph-release.asc ;\\"},{"line_number":16,"context_line":"    echo deb http://download.ceph.com/debian-${CEPH_RELEASE}/ ${UBUNTU_RELEASE} main | tee /etc/apt/sources.list.d/ceph.list ;\\"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"bfdaf3ff_1bc70e15","line":13,"in_reply_to":"bfdaf3ff_a8d0faf8","updated":"2019-01-14 19:14:01.000000000","message":"Line 19 is needed to update the cache with the newly added ceph repo. if its not there, ceph packages will come from ubuntu repo itself","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a35fe3ba658dd0d7a4a63f1055c164c8731a3b2c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_bfc79c45","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":28},"updated":"2019-01-16 17:24:09.000000000","message":"it would be nice to see this as an arg for consistency - and use within orgs that wish to use their own base images.","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"6e7d49071e4d1823bbc2c14b7bf4b15120fd207b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_1a7a76f0","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":28},"in_reply_to":"bfdaf3ff_bfc79c45","updated":"2019-01-16 18:57:15.000000000","message":"Done","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a35fe3ba658dd0d7a4a63f1055c164c8731a3b2c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":5,"context_line":"ARG CEPH_RELEASE\u003dmimic"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_1fdee810","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"updated":"2019-01-16 17:24:09.000000000","message":"can probably remove my name - this image has changed a lot from the original poc ;)","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"6e7d49071e4d1823bbc2c14b7bf4b15120fd207b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG KUBE_VERSION\u003dv1.10.3"},{"line_number":5,"context_line":"ARG CEPH_RELEASE\u003dmimic"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_3a7dfae6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":38},"in_reply_to":"bfdaf3ff_1fdee810","updated":"2019-01-16 18:57:15.000000000","message":"Done","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"}],"ceph-config-helper/build.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"df963cad458f7e9c8bcf078719668de84503ac12","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"},{"line_number":10,"context_line":"REGISTRY_URI\u003d${REGISTRY_URI:-\"openstackhelm/\"}"},{"line_number":11,"context_line":"EXTRA_TAG_INFO\u003d${EXTRA_TAG_INFO:-\"\"}"},{"line_number":12,"context_line":"UBUNTU_RELEASE\u003d${UBUNTU_RELEASE:-xenial}"},{"line_number":13,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} --build-arg UBUNTU_RELEASE\u003d$(UBUNTU_RELEASE) --network\u003dhost -t ${REGISTRY_URI}${IMAGE}:${VERSION}-${DISTRO}${EXTRA_TAG_INFO} ${extra_build_args} ${IMAGE}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cd -"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bfdaf3ff_d19d0c67","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":40},"updated":"2019-01-11 15:34:06.000000000","message":"Don\u0027t we also need an entry for CEPH_RELEASE?","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"d8db987e7937a80891576f69e23cd8eddac496aa","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"},{"line_number":10,"context_line":"REGISTRY_URI\u003d${REGISTRY_URI:-\"openstackhelm/\"}"},{"line_number":11,"context_line":"EXTRA_TAG_INFO\u003d${EXTRA_TAG_INFO:-\"\"}"},{"line_number":12,"context_line":"UBUNTU_RELEASE\u003d${UBUNTU_RELEASE:-xenial}"},{"line_number":13,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} --build-arg UBUNTU_RELEASE\u003d$(UBUNTU_RELEASE) --network\u003dhost -t ${REGISTRY_URI}${IMAGE}:${VERSION}-${DISTRO}${EXTRA_TAG_INFO} ${extra_build_args} ${IMAGE}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cd -"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bfdaf3ff_9161c43c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":40},"in_reply_to":"bfdaf3ff_d19d0c67","updated":"2019-01-11 16:43:04.000000000","message":"Done","commit_id":"d60d65b392ad9c2958c7b921eb3e82b4c12e2a1d"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"e7f50eb35a5cf3d1d287472c1b83d264f86019e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_93a9a87c","line":7,"updated":"2019-01-14 14:42:14.000000000","message":"This should be ceph-config-helper.","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"e96e8facf2c24a7a0c62155f0f30970db2df4474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_a55fc33f","line":7,"in_reply_to":"bfdaf3ff_93a9a87c","updated":"2019-01-14 15:30:46.000000000","message":"Done","commit_id":"7da4a86d869717e37da42039fce65042741384c0"}],"ceph-daemon/build.sh":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"e7f50eb35a5cf3d1d287472c1b83d264f86019e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_d3c89056","line":7,"updated":"2019-01-14 14:42:14.000000000","message":"this should be ceph-daemon, not sure what the purpose of changing the build.sh files were.","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"e96e8facf2c24a7a0c62155f0f30970db2df4474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_c55c474d","line":7,"in_reply_to":"bfdaf3ff_d3c89056","updated":"2019-01-14 15:30:46.000000000","message":"Done","commit_id":"7da4a86d869717e37da42039fce65042741384c0"}],"ceph-utility/Dockerfile.ubuntu_xenial":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a35fe3ba658dd0d7a4a63f1055c164c8731a3b2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"ARG CEPH_RELEASE\u003dmimic"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN set -xe \\"},{"line_number":7,"context_line":"    \u0026\u0026 echo \u0027#!/bin/sh\u0027 \u003e /usr/sbin/policy-rc.d \\"},{"line_number":8,"context_line":"    \u0026\u0026 echo \u0027exit 101\u0027 \u003e\u003e /usr/sbin/policy-rc.d \\"},{"line_number":9,"context_line":"    \u0026\u0026 chmod +x /usr/sbin/policy-rc.d \\"},{"line_number":10,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":11,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg-divert --local --rename --add /sbin/initctl \\"},{"line_number":13,"context_line":"    \u0026\u0026 cp -a /usr/sbin/policy-rc.d /sbin/initctl \\"},{"line_number":14,"context_line":"    \u0026\u0026 sed -i \u0027s/^exit.*/exit 0/\u0027 /sbin/initctl \\"},{"line_number":15,"context_line":"    \u0026\u0026 apt-get update \u0026\u0026 apt-get install -y wget curl apt-transport-https gnupg\\"},{"line_number":16,"context_line":"    \u0026\u0026 wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | apt-key add - \\"},{"line_number":17,"context_line":"    \u0026\u0026 echo deb https://download.ceph.com/debian-${CEPH_RELEASE}/ xenial main | tee /etc/apt/sources.list.d/ceph.list \\"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_bfcc7c61","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":49},"updated":"2019-01-16 17:24:09.000000000","message":"why do all this?","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"6e7d49071e4d1823bbc2c14b7bf4b15120fd207b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"ARG CEPH_RELEASE\u003dmimic"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN set -xe \\"},{"line_number":7,"context_line":"    \u0026\u0026 echo \u0027#!/bin/sh\u0027 \u003e /usr/sbin/policy-rc.d \\"},{"line_number":8,"context_line":"    \u0026\u0026 echo \u0027exit 101\u0027 \u003e\u003e /usr/sbin/policy-rc.d \\"},{"line_number":9,"context_line":"    \u0026\u0026 chmod +x /usr/sbin/policy-rc.d \\"},{"line_number":10,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":11,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg-divert --local --rename --add /sbin/initctl \\"},{"line_number":13,"context_line":"    \u0026\u0026 cp -a /usr/sbin/policy-rc.d /sbin/initctl \\"},{"line_number":14,"context_line":"    \u0026\u0026 sed -i \u0027s/^exit.*/exit 0/\u0027 /sbin/initctl \\"},{"line_number":15,"context_line":"    \u0026\u0026 apt-get update \u0026\u0026 apt-get install -y wget curl apt-transport-https gnupg\\"},{"line_number":16,"context_line":"    \u0026\u0026 wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | apt-key add - \\"},{"line_number":17,"context_line":"    \u0026\u0026 echo deb https://download.ceph.com/debian-${CEPH_RELEASE}/ xenial main | tee /etc/apt/sources.list.d/ceph.list \\"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"bfdaf3ff_5a779e03","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":49},"in_reply_to":"bfdaf3ff_bfcc7c61","updated":"2019-01-16 18:57:15.000000000","message":"nobody user is need for ceph utility container. remaining have been removed.","commit_id":"4ef78eb56037767d9c71d87f366dc2b22b7eafbc"}],"ceph-utility/build.sh":[{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"e7f50eb35a5cf3d1d287472c1b83d264f86019e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_33dd5c14","line":7,"updated":"2019-01-14 14:42:14.000000000","message":"This should be ceph-utility","commit_id":"7da4a86d869717e37da42039fce65042741384c0"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"e96e8facf2c24a7a0c62155f0f30970db2df4474","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## Only build from main folder"},{"line_number":5,"context_line":"cd ${SCRIPT_DIR}/.."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IMAGENAME\u003d$(find . -type d -iname \"*ceph*\"| sed \"s|^\\./||\")"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VERSION\u003d${VERSION:-latest}"},{"line_number":10,"context_line":"DISTRO\u003d${DISTRO:-ubuntu_xenial}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfdaf3ff_2531930c","line":7,"in_reply_to":"bfdaf3ff_33dd5c14","updated":"2019-01-14 15:30:46.000000000","message":"Done","commit_id":"7da4a86d869717e37da42039fce65042741384c0"}]}