)]}'
{"mini-mirror/tools/publish_snapshots.sh":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"0fffc42c5d9203fbd46d173ff18c403cb991b134","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    if [ -f \"${source}\"/aptly.conf ]; then"},{"line_number":33,"context_line":"      conf\u003d\"${source}\"/aptly.conf"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      conf\u003d/etc/aptly.conf"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Create package query from well-defined package list."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_4d30b908","line":35,"updated":"2019-03-05 17:51:08.000000000","message":"The doc you added says that the file will be taken from APTLY_CONFIG_PATH, but here it\u0027s hardcoded to `/etc/aptly.conf`.  Should we modify the doc, or should we make this configurable?","commit_id":"e83bc85d4447d393dfb32b0bf508eeec4c044080"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"2fdc196c16d1ac498ff2a1b031378f21ad8c2822","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    if [ -f \"${source}\"/aptly.conf ]; then"},{"line_number":33,"context_line":"      conf\u003d\"${source}\"/aptly.conf"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      conf\u003d/etc/aptly.conf"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Create package query from well-defined package list."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_90e55a3b","line":35,"in_reply_to":"5fc1f717_4d30b908","updated":"2019-03-05 18:00:52.000000000","message":"\u003e The doc you added says that the file will be taken from\n \u003e APTLY_CONFIG_PATH, but here it\u0027s hardcoded to `/etc/aptly.conf`. \n \u003e Should we modify the doc, or should we make this configurable?\n\nThis build script executes during the container build process. Before this build script runs, the Aptly config file at APTLY_CONFIG_PATH is copied into the container to the /etc/aptly.conf path [0]. So the config file specified through APTLY_CONFIG_PATH is still used/configurable.\n\n[0] https://git.openstack.org/cgit/openstack/openstack-helm-images/tree/mini-mirror/Dockerfile.ubuntu_xenial#n22","commit_id":"e83bc85d4447d393dfb32b0bf508eeec4c044080"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"9bcc2c5a0169556ea36762ed78d0c7f80052769f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    if [ -f \"${source}\"/aptly.conf ]; then"},{"line_number":33,"context_line":"      conf\u003d\"${source}\"/aptly.conf"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      conf\u003d/etc/aptly.conf"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Create package query from well-defined package list."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_b0c5f65d","line":35,"in_reply_to":"5fc1f717_90e55a3b","updated":"2019-03-05 18:09:05.000000000","message":"Ahh, gotcha.","commit_id":"e83bc85d4447d393dfb32b0bf508eeec4c044080"}]}
