)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2650d967f3cc5acde454b90eec56d127f3d7b2cb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Deepak Tiwari \u003cdeepak.tiwari@aricent.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-04 11:24:52 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Makefile and Docker file for calicoctl-utility containers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia3442e3b5b89bf27e30c1f524dca8e63c4e3cea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_9a73a380","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":58},"updated":"2019-04-07 19:10:38.000000000","message":"nit, remove","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"}],"Makefile":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2650d967f3cc5acde454b90eec56d127f3d7b2cb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"DOCKER_REGISTRY            ?\u003d docker.io"},{"line_number":25,"context_line":"IMAGE_PREFIX               ?\u003d openstackhelm"},{"line_number":26,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":27,"context_line":"CALICOCTL_VERSION          ?\u003d v3.4.0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Set the image"},{"line_number":30,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_ba70df73","line":27,"range":{"start_line":27,"start_character":31,"end_line":27,"end_character":36},"updated":"2019-04-07 19:10:38.000000000","message":"prob bump to 3.4.4 if you get the chance","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":24,"context_line":"DOCKER_REGISTRY            ?\u003d docker.io"},{"line_number":25,"context_line":"IMAGE_PREFIX               ?\u003d openstackhelm"},{"line_number":26,"context_line":"IMAGE_TAG                  ?\u003d latest"},{"line_number":27,"context_line":"CALICOCTL_VERSION          ?\u003d v3.4.0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Set the image"},{"line_number":30,"context_line":"# eg: quay.io/att-comdev/ceph-config-helper:latest"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_e46fa05d","line":27,"range":{"start_line":27,"start_character":31,"end_line":27,"end_character":36},"in_reply_to":"5fc1f717_ba70df73","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"14624b9c773d9bd23dfcae04157c2baf64cc8c36","unresolved":false,"context_lines":[{"line_number":42,"context_line":".PHONY: build_$(IMAGE_NAME)"},{"line_number":43,"context_line":"build_$(IMAGE_NAME):"},{"line_number":44,"context_line":"ifeq ($(OS_RELEASE), ubuntu_xenial)"},{"line_number":45,"context_line":"    docker build -f $(IMAGE_NAME)/Dockerfile.$(OS_RELEASE) \\"},{"line_number":46,"context_line":"    --network host \\"},{"line_number":47,"context_line":"    $(EXTRA_BUILD_ARGS) \\"},{"line_number":48,"context_line":"    -t $(IMAGE) \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_fa84270d","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":4},"updated":"2019-04-07 20:07:24.000000000","message":"does changing all these tab characters to spaces not break the make for you?","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":42,"context_line":".PHONY: build_$(IMAGE_NAME)"},{"line_number":43,"context_line":"build_$(IMAGE_NAME):"},{"line_number":44,"context_line":"ifeq ($(OS_RELEASE), ubuntu_xenial)"},{"line_number":45,"context_line":"    docker build -f $(IMAGE_NAME)/Dockerfile.$(OS_RELEASE) \\"},{"line_number":46,"context_line":"    --network host \\"},{"line_number":47,"context_line":"    $(EXTRA_BUILD_ARGS) \\"},{"line_number":48,"context_line":"    -t $(IMAGE) \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_84bb3ce3","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":4},"in_reply_to":"5fc1f717_fa84270d","updated":"2019-04-08 14:06:42.000000000","message":"yes, I forgot about Makefiles. Didn\u0027t use them since long :) will revert it back to tabs","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"}],"README_MAKEFILE":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2650d967f3cc5acde454b90eec56d127f3d7b2cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Makefile For Ceph and Calicoctl images"},{"line_number":2,"context_line":"----------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is a  make and dockerfile for containers. This can be used to create docker images using different releases and os releases"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_7a66f7bd","line":2,"range":{"start_line":2,"start_character":38,"end_line":2,"end_character":40},"updated":"2019-04-07 19:10:38.000000000","message":"rm?","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Makefile For Ceph and Calicoctl images"},{"line_number":2,"context_line":"----------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is a  make and dockerfile for containers. This can be used to create docker images using different releases and os releases"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_04a2ec9a","line":2,"range":{"start_line":2,"start_character":38,"end_line":2,"end_character":40},"in_reply_to":"5fc1f717_7a66f7bd","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"}],"calicoctl-utility/Dockerfile.alpine":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af8ad64d6f980a2c7e5143f06a3f7abe813507cf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ARG FROM\u003dquay.io/calico/ctl:${CALICOCTL_VERSION}"},{"line_number":3,"context_line":"FROM ${FROM}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"LABEL org.opencontainers.image.authors\u003d\u0027Openstack-Helm Authors\u0027"},{"line_number":6,"context_line":"LABEL org.opencontainers.image.url\u003d\u0027https://git.openstack.com/openstack/openstack-helm-images\u0027"},{"line_number":7,"context_line":"LABEL org.opencontainers.image.documentation\u003d\u0027https://git.openstack.com/openstack/openstack-helm-images/blob/master/README_MAKEFILE\u0027"},{"line_number":8,"context_line":"LABEL org.opencontainers.image.source\u003d\u0027https://git.openstack.com/openstack/openstack-helm-images\u0027"},{"line_number":9,"context_line":"LABEL org.opencontainers.image.vendor\u003d\u0027Openstack-Helm Authors\u0027"},{"line_number":10,"context_line":"LABEL org.opencontainers.image.licenses\u003d\u0027BSD-3-Clause\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN set -xe \\"},{"line_number":13,"context_line":"    \u0026\u0026 export DEBIAN_FRONTEND\u003dnoninteractive \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5fc1f717_e9e579dd","line":10,"range":{"start_line":5,"start_character":0,"end_line":10,"end_character":54},"updated":"2019-04-04 07:21:05.000000000","message":"We haven\u0027t been using that everywhere, so it\u0027s great to see that.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2650d967f3cc5acde454b90eec56d127f3d7b2cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG CALICOCTL_VERSION\u003dv3.4.0"},{"line_number":2,"context_line":"ARG FROM\u003dquay.io/calico/ctl:${CALICOCTL_VERSION}"},{"line_number":3,"context_line":"FROM ${FROM}"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_1a0573c2","line":1,"range":{"start_line":1,"start_character":27,"end_line":1,"end_character":28},"updated":"2019-04-07 19:10:38.000000000","message":"4","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG CALICOCTL_VERSION\u003dv3.4.0"},{"line_number":2,"context_line":"ARG FROM\u003dquay.io/calico/ctl:${CALICOCTL_VERSION}"},{"line_number":3,"context_line":"FROM ${FROM}"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_249fe850","line":1,"range":{"start_line":1,"start_character":27,"end_line":1,"end_character":28},"in_reply_to":"5fc1f717_1a0573c2","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0f3e1d353ec51b9cd9e6de627fa14af30a2ddf77","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN set -xe \\"},{"line_number":13,"context_line":"    \u0026\u0026 export DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":14,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":15,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":16,"context_line":"    \u0026\u0026 apk add dpkg --repository\u003dhttp://dl-cdn.alpinelinux.org/alpine/edge/main \\"},{"line_number":17,"context_line":"    \u0026\u0026 apk add --update dpkg \\"},{"line_number":18,"context_line":"    \u0026\u0026 touch /var/lib/dpkg/status \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_3accef33","line":15,"range":{"start_line":14,"start_character":7,"end_line":15,"end_character":79},"updated":"2019-04-07 22:09:43.000000000","message":"why is this needed?","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN set -xe \\"},{"line_number":13,"context_line":"    \u0026\u0026 export DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":14,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":15,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":16,"context_line":"    \u0026\u0026 apk add dpkg --repository\u003dhttp://dl-cdn.alpinelinux.org/alpine/edge/main \\"},{"line_number":17,"context_line":"    \u0026\u0026 apk add --update dpkg \\"},{"line_number":18,"context_line":"    \u0026\u0026 touch /var/lib/dpkg/status \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_e4bd60b1","line":15,"range":{"start_line":14,"start_character":7,"end_line":15,"end_character":79},"in_reply_to":"5fc1f717_3accef33","updated":"2019-04-08 14:06:42.000000000","message":"This is to add a minimum privileges user by name nobody. In helm charts for calicoctl utility container, this user shall be used while deploying it","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"d4c79d25541df634bfdd566498a568e8bfc348ac","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN set -xe \\"},{"line_number":14,"context_line":"    \u0026\u0026 export DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":15,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":16,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":17,"context_line":"    \u0026\u0026 apk add dpkg --repository\u003dhttp://dl-cdn.alpinelinux.org/alpine/edge/main \\"},{"line_number":18,"context_line":"    \u0026\u0026 apk add --update dpkg \\"},{"line_number":19,"context_line":"    \u0026\u0026 touch /var/lib/dpkg/status \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5fc1f717_ea9bc313","line":16,"range":{"start_line":15,"start_character":4,"end_line":16,"end_character":81},"updated":"2019-04-09 20:51:27.000000000","message":"but we have nobody\n\n$ docker run -it --entrypoint\u003d/bin/sh quay.io/calico/ctl:v3.4.4 \n~ # grep nobody /etc/passwd\nnobody:x:65534:65534:nobody:/:/sbin/nologin","commit_id":"a46a320d9277dcd60db2e09c2fd193e8ef168fe3"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"874964bcf50b1216202a5125b628fbd3077ee003","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN set -xe \\"},{"line_number":14,"context_line":"    \u0026\u0026 export DEBIAN_FRONTEND\u003dnoninteractive \\"},{"line_number":15,"context_line":"    \u0026\u0026 sed -i \u0027/nobody/d\u0027 /etc/passwd \\"},{"line_number":16,"context_line":"    \u0026\u0026 echo \"nobody:x:65534:65534:nobody:/nonexistent:/bin/bash\" \u003e\u003e /etc/passwd \\"},{"line_number":17,"context_line":"    \u0026\u0026 apk add dpkg --repository\u003dhttp://dl-cdn.alpinelinux.org/alpine/edge/main \\"},{"line_number":18,"context_line":"    \u0026\u0026 apk add --update dpkg \\"},{"line_number":19,"context_line":"    \u0026\u0026 touch /var/lib/dpkg/status \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5fc1f717_9eb7e421","line":16,"range":{"start_line":15,"start_character":4,"end_line":16,"end_character":81},"in_reply_to":"5fc1f717_ea9bc313","updated":"2019-04-09 21:22:49.000000000","message":"ohk, then I will remove it","commit_id":"a46a320d9277dcd60db2e09c2fd193e8ef168fe3"}],"calicoctl-utility/build.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af8ad64d6f980a2c7e5143f06a3f7abe813507cf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_a9f8d17b","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"updated":"2019-04-04 07:21:05.000000000","message":"For me I would use\nlatest-alpine as tag. If possible I would add the label of calicoctl version in the image, to help debugging. But the rest can be discovered from code version.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af8ad64d6f980a2c7e5143f06a3f7abe813507cf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_49084d90","line":17,"range":{"start_line":17,"start_character":27,"end_line":17,"end_character":36},"updated":"2019-04-04 07:21:05.000000000","message":"no need to repeat this","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"10a3aad071f4ec7c6a8f53244b3ad2f5ebb804fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_7935c0da","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_0878f6f5","updated":"2019-04-05 07:05:44.000000000","message":"we have to stick with the \u003cversion\u003e-\u003cdistro\u003e story.\n\nSo 1) and 2) is missing -alpine.\n\nAfter that, I will let the community decide.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"aa4337589c18665afebde9cab9cbe566ee71c155","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_c970bddd","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_69e3c9a5","updated":"2019-04-04 07:26:54.000000000","message":"I would be okay with a frozen version.\n${CALICOCTL_VERSION}-${DISTRO}","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1d6bd793867fb34f459dfc9abfde7c28d62f4778","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_29306107","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_69e3c9a5","updated":"2019-04-04 07:27:55.000000000","message":"Please note that\u0027s what we decided -- we let deployers be responsible of what they do for their tagging / long term freezing.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_842a5ce4","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_7935c0da","updated":"2019-04-08 14:06:42.000000000","message":"But even other images are not having DISTRO in makefile. It is something like this:-\n\nDOCKER_REGISTRY            ?\u003d docker.io\nIMAGE_PREFIX               ?\u003d openstackhelm\nIMAGE_TAG                  ?\u003d latest\nCALICOCTL_VERSION          ?\u003d v3.4.4\n\nIMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4c4c47abf5a02a4056f838d94c5b6a3dac82d346","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_69e3c9a5","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_a9f8d17b","updated":"2019-04-04 07:25:11.000000000","message":"really should void \u0027latest\u0027 if we can\n3.9 would suffice","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"b7ba8467271effe14d91133e72f36054d133d293","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"},{"line_number":16,"context_line":"--build-arg CALICOCTL_VERSION\u003d${CALICOCTL_VERSION} \\"},{"line_number":17,"context_line":"-t ${REGISTRY_URI}${IMAGE}:calicoctl${CALICOCTL_VERSION}-${VERSION}-${DISTRO}${EXTRA_TAG_INFO} \\"},{"line_number":18,"context_line":"${extra_build_args} \\"},{"line_number":19,"context_line":"${IMAGE}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_0878f6f5","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":57},"in_reply_to":"5fc1f717_c970bddd","updated":"2019-04-04 14:25:19.000000000","message":"So as per comment by Chris and yourself, I\u0027ll update it here to have ${CALICOCTL_VERSION}-${DISTRO} (i.e. v3.4.0-alpine)\n\nHowever, we have something similar in Makefile as well. This is what we actually use in our downstream pipelines. Its like this there:-\n\nIMAGE_TAG                  ?\u003d latest\n${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}\n\nShould I make it like this:-\n\n1. ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${CALICOCTL_VERSION} (i.e. calicoctl-utility:v3.4.0)\n\nor \n\n2. ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${CALICOCTL_VERSION}-${IMAGE_TAG} (i.e. calicoctl-utility:v3.4.0-\n2a37c17207e7de48b812f7f1ed557abeeced209e.2019-03-20_11-57-23)\n\n----\nIn former case, we will not be able to incorporate the gerrit-patchset-revision which is passed as IMAGE_TAG by our downstream pipelines invoking the make command....","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2650d967f3cc5acde454b90eec56d127f3d7b2cb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DISTRO\u003d${DISTRO:-alpine}"},{"line_number":10,"context_line":"REGISTRY_URI\u003d${REGISTRY_URI:-\"openstackhelm/\"}"},{"line_number":11,"context_line":"EXTRA_TAG_INFO\u003d${EXTRA_TAG_INFO:-\"\"}"},{"line_number":12,"context_line":"CALICOCTL_VERSION\u003dv3.4.0"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5fc1f717_3a0aafd1","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":24},"updated":"2019-04-07 19:10:38.000000000","message":"4","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DISTRO\u003d${DISTRO:-alpine}"},{"line_number":10,"context_line":"REGISTRY_URI\u003d${REGISTRY_URI:-\"openstackhelm/\"}"},{"line_number":11,"context_line":"EXTRA_TAG_INFO\u003d${EXTRA_TAG_INFO:-\"\"}"},{"line_number":12,"context_line":"CALICOCTL_VERSION\u003dv3.4.0"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"docker build -f ${IMAGE}/Dockerfile.${DISTRO} \\"},{"line_number":15,"context_line":"--network\u003dhost \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5fc1f717_84dc9c18","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":24},"in_reply_to":"5fc1f717_3a0aafd1","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"}],"doc/source/calicoctl-utility.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af8ad64d6f980a2c7e5143f06a3f7abe813507cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_49ba8dc0","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"updated":"2019-04-04 07:21:05.000000000","message":"This is too short, and breaks docs build.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"b7ba8467271effe14d91133e72f36054d133d293","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_a84f62bc","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"in_reply_to":"5fc1f717_09a1e546","updated":"2019-04-04 14:25:19.000000000","message":"I am not sure how to do that? But that would be good","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3c769dcbc171baf92d655cef43e6bf62514c0530","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_d94b945c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"in_reply_to":"5fc1f717_09a1e546","updated":"2019-04-05 07:07:41.000000000","message":"It\u0027s not valid for doc8. It\u0027s valid rst for sphinx though, but I have seen some failures in the past.\n\nThe idea is to keep the length of the title with the markup below it. I kinda like it, it looks clean.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4c4c47abf5a02a4056f838d94c5b6a3dac82d346","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_09a1e546","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"in_reply_to":"5fc1f717_49ba8dc0","updated":"2019-04-04 07:25:11.000000000","message":"it is valid markdown though\ni wonder if we shouldn\u0027t fix tox to stop being so picky?","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"b7ba8467271effe14d91133e72f36054d133d293","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_f5e8e7b3","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"in_reply_to":"5fc1f717_49ba8dc0","updated":"2019-04-04 14:25:19.000000000","message":"will fix it.","commit_id":"d2199c8d338e7879a2ce4e9080c990e0f826b88b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3c769dcbc171baf92d655cef43e6bf62514c0530","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This container builds a small image with calicoctl-utility service and"},{"line_number":6,"context_line":"some other utilities for use bt the operator."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_f94e906c","line":3,"range":{"start_line":3,"start_character":33,"end_line":3,"end_character":36},"updated":"2019-04-05 07:07:41.000000000","message":"that will then be too long.","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"calicoctl-utility container image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This container builds a small image with calicoctl-utility service and"},{"line_number":6,"context_line":"some other utilities for use bt the operator."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_2447e81f","line":3,"range":{"start_line":3,"start_character":33,"end_line":3,"end_character":36},"in_reply_to":"5fc1f717_f94e906c","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3c769dcbc171baf92d655cef43e6bf62514c0530","unresolved":false,"context_lines":[{"line_number":6,"context_line":"some other utilities for use bt the operator."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Manual build"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Here are the instructions for building the image:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_99550cfd","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":13},"updated":"2019-04-05 07:07:41.000000000","message":"ditto.","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"},{"author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"change_message_id":"f9730ecad447179c919ce5de8b7960b2ac6acc58","unresolved":false,"context_lines":[{"line_number":6,"context_line":"some other utilities for use bt the operator."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Manual build"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Here are the instructions for building the image:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_044aec25","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":13},"in_reply_to":"5fc1f717_99550cfd","updated":"2019-04-08 14:06:42.000000000","message":"Done","commit_id":"3291553b56256d63ccc4288561129eeb38e5e4bc"}]}