)]}'
{"tempest/Dockerfile.opensuse_15":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"606a5eed524bc73381a280dd2b32ab100a946628","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN rm /tmp/${KEYFILE}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5fc1f717_6fb7d222","line":12,"updated":"2019-04-10 13:18:51.000000000","message":"not sure if it is better, but you could just point to the .repo file like:\n\nzypper -n ar https://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/Cloud:OpenStack:Master.repo","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"14b42e54f3cbc7400b83e30631b34a9d7f55f6bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN rm /tmp/${KEYFILE}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fce034c_1d3bb438","line":12,"in_reply_to":"3fce034c_47216d9f","updated":"2019-04-11 12:52:15.000000000","message":"Any gain by pointing it to the repo file instead? should be the same no?","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0a062e2349cd333ac324781f07f0acf53018e3e7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN rm /tmp/${KEYFILE}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN set -ex ;\\"},{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fce034c_47216d9f","line":12,"in_reply_to":"5fc1f717_6fb7d222","updated":"2019-04-11 10:26:06.000000000","message":"I think I would prefer to not point to the .repo, and to use a variable representing the repo, so that this can be set to a different value in infra if necessary.","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"606a5eed524bc73381a280dd2b32ab100a946628","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"},{"line_number":16,"context_line":"                                        python-cinder-tempest-plugin \\"},{"line_number":17,"context_line":"                                        python-heat-tempest-plugin \\"},{"line_number":18,"context_line":"                                        python-keystone-tempest-plugin \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5fc1f717_cf3da68e","line":15,"updated":"2019-04-10 13:18:51.000000000","message":"for what is \"which\" needed?","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"14b42e54f3cbc7400b83e30631b34a9d7f55f6bb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"},{"line_number":16,"context_line":"                                        python-cinder-tempest-plugin \\"},{"line_number":17,"context_line":"                                        python-heat-tempest-plugin \\"},{"line_number":18,"context_line":"                                        python-keystone-tempest-plugin \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fce034c_5d393c3f","line":15,"in_reply_to":"3fce034c_2738e1d1","updated":"2019-04-11 12:52:15.000000000","message":"Good point.\nI discovered that when launching tempest with no arguments it would try to call which and it fail to do so.\n\nI added it in case it was needed, but checking it futher, it seems that its trying to find the shell editor using which, probably to use the tempest shell?\n\nIn our case, we should not be launching the tempest shell so it should be dropped.","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0a062e2349cd333ac324781f07f0acf53018e3e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":13,"context_line":"    zypper --non-interactive refresh ;\\"},{"line_number":14,"context_line":"    zypper --non-interactive up -y ;\\"},{"line_number":15,"context_line":"    zypper --non-interactive install -y which openstack-tempest \\"},{"line_number":16,"context_line":"                                        python-cinder-tempest-plugin \\"},{"line_number":17,"context_line":"                                        python-heat-tempest-plugin \\"},{"line_number":18,"context_line":"                                        python-keystone-tempest-plugin \\"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fce034c_2738e1d1","line":15,"in_reply_to":"5fc1f717_cf3da68e","updated":"2019-04-11 10:26:06.000000000","message":"I am curious too.","commit_id":"4cd4b733db5c6b7b54084ee3e34a2f9233fb8365"}],"tempest/Dockerfile.suse_15":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c91fe461307530142f11e1f5e19140f6a8465863","unresolved":false,"context_lines":[{"line_number":4,"context_line":"RUN set -ex ;\\"},{"line_number":5,"context_line":"    zypper refresh ;\\"},{"line_number":6,"context_line":"    zypper up -y ;\\"},{"line_number":7,"context_line":"    zypper install -y python3-devel git gcc python3-pip ;\\"},{"line_number":8,"context_line":"    git clone https://git.openstack.org/openstack/tempest ;\\"},{"line_number":9,"context_line":"    git clone https://git.openstack.org/openstack/cinder-tempest-plugin ;\\"},{"line_number":10,"context_line":"    git clone https://git.openstack.org/openstack/heat-tempest-plugin ;\\"},{"line_number":11,"context_line":"    git clone https://git.openstack.org/openstack/keystone-tempest-plugin ;\\"},{"line_number":12,"context_line":"    git clone https://git.openstack.org/openstack/neutron-tempest-plugin ;\\"},{"line_number":13,"context_line":"    git clone https://git.openstack.org/openstack/tempest-horizon ;\\"},{"line_number":14,"context_line":"    pip3 install -U setuptools ;\\"},{"line_number":15,"context_line":"    pip3 install wheel ;\\"},{"line_number":16,"context_line":"    pip3 install -e tempest/ \\"},{"line_number":17,"context_line":"                cinder-tempest-plugin/ \\"},{"line_number":18,"context_line":"                heat-tempest-plugin/ \\"},{"line_number":19,"context_line":"                keystone-tempest-plugin/ \\"},{"line_number":20,"context_line":"                neutron-tempest-plugin/ \\"},{"line_number":21,"context_line":"                tempest-horizon/ ;\\"},{"line_number":22,"context_line":"    zypper rm -y --clean-deps python3-devel git gcc ;\\"},{"line_number":23,"context_line":"    zypper clean -a"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5fc1f717_64387ad2","line":21,"range":{"start_line":7,"start_character":4,"end_line":21,"end_character":35},"updated":"2019-04-09 09:50:27.000000000","message":"I think it would be easier to install it from packages. This way we ensure our tempest packages are correctly produced.","commit_id":"c80e50459d8c4569456c00b28711443cfaca0ff8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee61961eb51f2202bd73f7b8473c2a2902dded09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_69603702","line":1,"updated":"2019-04-10 07:23:35.000000000","message":"The filename Dockerfile.suse_15 is not helping imo. It should be Dockerfile.opensuse_leap_15 (that\u0027s what it is based on)","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bd696e35a136e3590f05d96b0fedc98fe483fb5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fce034c_ac06f81f","line":1,"in_reply_to":"5fc1f717_57415638","updated":"2019-04-11 10:24:32.000000000","message":"I decided to go for Dockerfile.suse_15 because it could be used for both SLE and openSUSE in the future, assuming there is a ARG for FROM.","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"72572bcd3c083cf6c23e6eebbf3a86788070eeb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_57415638","line":1,"in_reply_to":"5fc1f717_69603702","updated":"2019-04-10 08:35:54.000000000","message":"while I do agree on this, this is just following the other dockerfiles already in the repo.\n\nits even worst, because the image get pushed as latest-opensuse_15 ¬_¬\n\nIm not sure if there is a spec for that","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee61961eb51f2202bd73f7b8473c2a2902dded09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_e931870c","line":2,"updated":"2019-04-10 07:23:35.000000000","message":"shouldn\u0027t that be cloud-devel@suse.com or something? I don\u0027t think the containers team will maintain theses containers.","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bd696e35a136e3590f05d96b0fedc98fe483fb5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fce034c_670d8936","line":2,"in_reply_to":"5fc1f717_32e858dd","updated":"2019-04-11 10:24:32.000000000","message":"Agreed, should be solved in a different commit.","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"63f8067811bf2a887348b689bcf52828cf43c380","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_32e858dd","line":2,"in_reply_to":"5fc1f717_773c92be","updated":"2019-04-10 09:40:08.000000000","message":"Maybe we could create cleanup patch for later that would take care of this for all the images. Same goes for Dockerfile names","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"72572bcd3c083cf6c23e6eebbf3a86788070eeb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM opensuse/leap:15.0"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"containers@suse.com\""},{"line_number":3,"context_line":"ARG VERSION\u003dMaster"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_773c92be","line":2,"in_reply_to":"5fc1f717_e931870c","updated":"2019-04-10 08:35:54.000000000","message":"this was copied from the other suse images, no idea tbh","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee61961eb51f2202bd73f7b8473c2a2902dded09","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"},{"line_number":6,"context_line":"RUN rpm --import /tmp/suse_leap15_cloud_repo.key"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN set -ex ;\\"},{"line_number":9,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":10,"context_line":"    zypper --non-interactive refresh ;\\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_a937fffd","line":7,"updated":"2019-04-10 07:23:35.000000000","message":"not sure if that happens automatically (via tmpfs or so?) - but the keyfile should be removed","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"72572bcd3c083cf6c23e6eebbf3a86788070eeb3","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"COPY suse_leap15_cloud_repo.key /tmp/"},{"line_number":6,"context_line":"RUN rpm --import /tmp/suse_leap15_cloud_repo.key"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN set -ex ;\\"},{"line_number":9,"context_line":"    zypper --non-interactive addrepo http://download.opensuse.org/repositories/Cloud:/OpenStack:/${VERSION}/openSUSE_Leap_15.0/ openstack-${VERSION} ;\\"},{"line_number":10,"context_line":"    zypper --non-interactive refresh ;\\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5fc1f717_17474e4e","line":7,"in_reply_to":"5fc1f717_a937fffd","updated":"2019-04-10 08:35:54.000000000","message":"good point, it doesnt get removed automatically so I will add that.","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"}],"tempest/suse_leap15_cloud_repo.key":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee61961eb51f2202bd73f7b8473c2a2902dded09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-----BEGIN PGP PUBLIC KEY BLOCK-----"},{"line_number":2,"context_line":"Version: GnuPG v1.4.5 (GNU/Linux)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"mQENBFJUCd0BCADFph1AX+yZq5eKs8t3jRNyP8JDKghPQTTC6/rpPC2cLaSff4zB"}],"source_content_type":"application/pgp-keys","patch_set":4,"id":"5fc1f717_297d4fb1","line":1,"updated":"2019-04-10 07:23:35.000000000","message":"The key is for the buildservice project Cloud:OpenStack:Master and the repository openSUSE_Leap_15.0 . I think that should be reflected in the key filename (like \"Cloud:OpenStack:Master-openSUSE_Leap_15.0.gpgkey\")\n\nAnd if we build other container images which use packages from the same repo, we need the key only once (so adding it to the tempest subdir might not be the best option)","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"72572bcd3c083cf6c23e6eebbf3a86788070eeb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-----BEGIN PGP PUBLIC KEY BLOCK-----"},{"line_number":2,"context_line":"Version: GnuPG v1.4.5 (GNU/Linux)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"mQENBFJUCd0BCADFph1AX+yZq5eKs8t3jRNyP8JDKghPQTTC6/rpPC2cLaSff4zB"}],"source_content_type":"application/pgp-keys","patch_set":4,"id":"5fc1f717_17b50e32","line":1,"in_reply_to":"5fc1f717_297d4fb1","updated":"2019-04-10 08:35:54.000000000","message":"Indeed to the first part. In a perfect world, we would add the key from a URL based on the branch we are using.\n\nFor the second, for the moment is not needed, I guess we can move it to a more generic shared dir if the need arises? Still, this comes as an extension of the first part, we should be able to dynamically add the proper key for the proper repo on container creation based on the cloud version used instead of having the keys here.","commit_id":"876be36a6e031e4fcf2354508b49901c8be24f7d"}]}