)]}'
{"openvswitch/Dockerfile.debian":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"fe20477412b222f78a81b6109642b38ec5fbe043","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG OVS_VERSION\u003d2.10.1"},{"line_number":6,"context_line":"ARG DPDK_VERSION\u003d17.11.5"},{"line_number":7,"context_line":"ARG OPENSTACK_COMPONENT\u003d0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN set -ex ;\\"},{"line_number":10,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3fce034c_bc9b1164","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":25},"updated":"2019-04-17 19:01:27.000000000","message":"why use this var name - its not obvious to me what `OPENSTACK_COMPONENT` means here, does it mean `USE_DIST_PACKAGES` ?","commit_id":"fa88c6743e8c4749d5bfd21fb6b41da9fed8033c"},{"author":{"_account_id":30232,"name":"Prabhjot Singh Sethi","email":"prabhjot@atsgen.com","username":"psethi-ats"},"change_message_id":"7a87f098a052adf8c2bd95a35154f7374c8ecc26","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG OVS_VERSION\u003d2.10.1"},{"line_number":6,"context_line":"ARG DPDK_VERSION\u003d17.11.5"},{"line_number":7,"context_line":"ARG OPENSTACK_COMPONENT\u003d0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN set -ex ;\\"},{"line_number":10,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3fce034c_7c2369be","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":25},"in_reply_to":"3fce034c_bc9b1164","updated":"2019-04-17 19:19:33.000000000","message":"the idea is to indicate that this build is for OpenStack component and it needs to ensure build process for the same, which will be bit different because of the different base image.\n\nit does not mean USE_DIST_PACKAGES as we are doing a source build instead.","commit_id":"fa88c6743e8c4749d5bfd21fb6b41da9fed8033c"}],"zuul.d/openvswitch.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"88f269add9cd4c55a2e8d32bf18e32d0747c08c3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          dockerfile: Dockerfile.debian-dpdk"},{"line_number":51,"context_line":"          tags:"},{"line_number":52,"context_line":"            - latest-debian-dpdk"},{"line_number":53,"context_line":"        - context: openvswitch"},{"line_number":54,"context_line":"          repository: openstackhelm/nova"},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"FROM\u003d\u0027openstackhelm/nova:{{ openstackversion }}\u0027\""},{"line_number":57,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":58,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":59,"context_line":"          tags:"},{"line_number":60,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":61,"context_line":"        - context: openvswitch"},{"line_number":62,"context_line":"          repository: openstackhelm/neutron"},{"line_number":63,"context_line":"          build_args:"},{"line_number":64,"context_line":"            - \"FROM\u003d\u0027openstackhelm/neutron:{{ openstackversion }}\u0027\""},{"line_number":65,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":66,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":67,"context_line":"          tags:"},{"line_number":68,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":69,"context_line":"    files: \u0026openvswitch_files"},{"line_number":70,"context_line":"      - openvswitch/.*"},{"line_number":71,"context_line":"      - zuul.d/openvswitch.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_ae305557","line":68,"range":{"start_line":53,"start_character":0,"end_line":68,"end_character":74},"updated":"2019-05-31 10:08:32.000000000","message":"this is very weird to me. I believe we should instead change the zuul.d/openstack-loci build process to make sure we can pass a certain OVS_VERSION. If necessary we\u0027ll need to update LOCI itself to support that. This looks too hacky to me.","commit_id":"a86a289af97b86273b0bf3bea6f68d6341b85059"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bb855788eef6949e03bcbbba70aa2efc6ea8f737","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          dockerfile: Dockerfile.debian-dpdk"},{"line_number":51,"context_line":"          tags:"},{"line_number":52,"context_line":"            - latest-debian-dpdk"},{"line_number":53,"context_line":"        - context: openvswitch"},{"line_number":54,"context_line":"          repository: openstackhelm/nova"},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"FROM\u003d\u0027openstackhelm/nova:{{ openstackversion }}\u0027\""},{"line_number":57,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":58,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":59,"context_line":"          tags:"},{"line_number":60,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":61,"context_line":"        - context: openvswitch"},{"line_number":62,"context_line":"          repository: openstackhelm/neutron"},{"line_number":63,"context_line":"          build_args:"},{"line_number":64,"context_line":"            - \"FROM\u003d\u0027openstackhelm/neutron:{{ openstackversion }}\u0027\""},{"line_number":65,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":66,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":67,"context_line":"          tags:"},{"line_number":68,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":69,"context_line":"    files: \u0026openvswitch_files"},{"line_number":70,"context_line":"      - openvswitch/.*"},{"line_number":71,"context_line":"      - zuul.d/openvswitch.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_ee9a046d","line":68,"range":{"start_line":53,"start_character":0,"end_line":68,"end_character":74},"in_reply_to":"9fb8cfa7_dc58bf57","updated":"2019-06-27 09:20:07.000000000","message":"Reusing the same components make sense, but then we need to make things right in the first place: Use the same repo at image building of the ovs image and at the loci images. This means that if a change targets both LOCI image build and ovs build, it will lead to inconsistent results, because they will be built in parallel, not in serial, in gates.\n\nWe need to make sure things are properly built in parallel, by not leveraging the other image to hack things on top, but rather make things right in both images by leveraging the same packages.","commit_id":"a86a289af97b86273b0bf3bea6f68d6341b85059"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"39a7ee0d8ac48d32b2d068fdfcbc3759b995ae6c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          dockerfile: Dockerfile.debian-dpdk"},{"line_number":51,"context_line":"          tags:"},{"line_number":52,"context_line":"            - latest-debian-dpdk"},{"line_number":53,"context_line":"        - context: openvswitch"},{"line_number":54,"context_line":"          repository: openstackhelm/nova"},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"FROM\u003d\u0027openstackhelm/nova:{{ openstackversion }}\u0027\""},{"line_number":57,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":58,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":59,"context_line":"          tags:"},{"line_number":60,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":61,"context_line":"        - context: openvswitch"},{"line_number":62,"context_line":"          repository: openstackhelm/neutron"},{"line_number":63,"context_line":"          build_args:"},{"line_number":64,"context_line":"            - \"FROM\u003d\u0027openstackhelm/neutron:{{ openstackversion }}\u0027\""},{"line_number":65,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":66,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":67,"context_line":"          tags:"},{"line_number":68,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":69,"context_line":"    files: \u0026openvswitch_files"},{"line_number":70,"context_line":"      - openvswitch/.*"},{"line_number":71,"context_line":"      - zuul.d/openvswitch.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_ce1fc9b4","line":68,"range":{"start_line":53,"start_character":0,"end_line":68,"end_character":74},"in_reply_to":"bfb3d3c7_ae305557","updated":"2019-05-31 10:13:04.000000000","message":"On top of that the last two will have both the same tag, and the image name is not representative of what\u0027s in it.\n\nDefinitely voting negatively for this.","commit_id":"a86a289af97b86273b0bf3bea6f68d6341b85059"},{"author":{"_account_id":30232,"name":"Prabhjot Singh Sethi","email":"prabhjot@atsgen.com","username":"psethi-ats"},"change_message_id":"b9012a57a386778068a2a82a28f07230dcddf633","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          dockerfile: Dockerfile.debian-dpdk"},{"line_number":51,"context_line":"          tags:"},{"line_number":52,"context_line":"            - latest-debian-dpdk"},{"line_number":53,"context_line":"        - context: openvswitch"},{"line_number":54,"context_line":"          repository: openstackhelm/nova"},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"FROM\u003d\u0027openstackhelm/nova:{{ openstackversion }}\u0027\""},{"line_number":57,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":58,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":59,"context_line":"          tags:"},{"line_number":60,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":61,"context_line":"        - context: openvswitch"},{"line_number":62,"context_line":"          repository: openstackhelm/neutron"},{"line_number":63,"context_line":"          build_args:"},{"line_number":64,"context_line":"            - \"FROM\u003d\u0027openstackhelm/neutron:{{ openstackversion }}\u0027\""},{"line_number":65,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":66,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":67,"context_line":"          tags:"},{"line_number":68,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":69,"context_line":"    files: \u0026openvswitch_files"},{"line_number":70,"context_line":"      - openvswitch/.*"},{"line_number":71,"context_line":"      - zuul.d/openvswitch.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_dc58bf57","line":68,"range":{"start_line":53,"start_character":0,"end_line":68,"end_character":74},"in_reply_to":"bfb3d3c7_ae305557","updated":"2019-06-03 08:49:17.000000000","message":"openstack-loci images today do not use source build binaries for OVS it rather rely on ubuntu distributed debian (2.5.+) for xenial. so tried to have a separate series of build which is based on source built packages.\n\nusing same version of OVS in both nova and neutron components along with openvswitch containers is important, so building them together may make more sense?","commit_id":"a86a289af97b86273b0bf3bea6f68d6341b85059"},{"author":{"_account_id":30232,"name":"Prabhjot Singh Sethi","email":"prabhjot@atsgen.com","username":"psethi-ats"},"change_message_id":"b9012a57a386778068a2a82a28f07230dcddf633","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          dockerfile: Dockerfile.debian-dpdk"},{"line_number":51,"context_line":"          tags:"},{"line_number":52,"context_line":"            - latest-debian-dpdk"},{"line_number":53,"context_line":"        - context: openvswitch"},{"line_number":54,"context_line":"          repository: openstackhelm/nova"},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"FROM\u003d\u0027openstackhelm/nova:{{ openstackversion }}\u0027\""},{"line_number":57,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":58,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":59,"context_line":"          tags:"},{"line_number":60,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":61,"context_line":"        - context: openvswitch"},{"line_number":62,"context_line":"          repository: openstackhelm/neutron"},{"line_number":63,"context_line":"          build_args:"},{"line_number":64,"context_line":"            - \"FROM\u003d\u0027openstackhelm/neutron:{{ openstackversion }}\u0027\""},{"line_number":65,"context_line":"            - \"OVS_VERSION\u003d\u0027{{ openvswitchversion }}\u0027\""},{"line_number":66,"context_line":"          dockerfile: Dockerfile.debian-component"},{"line_number":67,"context_line":"          tags:"},{"line_number":68,"context_line":"            - \"{{ openstackversion }}-ovs-{{ openvswitchversion }}-debian\""},{"line_number":69,"context_line":"    files: \u0026openvswitch_files"},{"line_number":70,"context_line":"      - openvswitch/.*"},{"line_number":71,"context_line":"      - zuul.d/openvswitch.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_dc067f21","line":68,"range":{"start_line":53,"start_character":0,"end_line":68,"end_character":74},"in_reply_to":"bfb3d3c7_ce1fc9b4","updated":"2019-06-03 08:49:17.000000000","message":"from the above i expect following two images to be generated.\n\nopenstackhelm/neutron:ocata-ovs-2.10.1-debian\nopenstackhelm/nova:ocata-ovs-2.10.1-debian","commit_id":"a86a289af97b86273b0bf3bea6f68d6341b85059"}]}