)]}'
{"nagios/plugins/check_exporter_health_metric.py":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"a78d9ad8f847e52da46deccc6082a7bee7ccc052","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    args \u003d parser.parse_args()"},{"line_number":50,"context_line":"    metrics, error_messages \u003d query_exporter_metric("},{"line_number":51,"context_line":"        args.exporter_api, args.health_metric)"},{"line_number":52,"context_line":"    if error_messages:"},{"line_number":53,"context_line":"        print("},{"line_number":54,"context_line":"            \"Unknown: unable to query metrics. {}\".format("},{"line_number":55,"context_line":"                \",\".join(error_messages)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_606cc0cd","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":22},"updated":"2019-07-17 23:40:55.000000000","message":"We could also check for empty metrics here and use the same/similar exit message, but I don\u0027t think there is nothing wrong with the approach you are already taking.\n\nThat would look like this:\n\n  if error_messages or not metrics:\n      # error message code here","commit_id":"3cb31027b9bdd25e707671a616528b272311d477"},{"author":{"_account_id":30582,"name":"RADHIKA PAI","email":"rp592h@att.com","username":"rp592h"},"change_message_id":"0d8cf2f2c1bdaa9192008499018e6ef7e9e950c1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    args \u003d parser.parse_args()"},{"line_number":50,"context_line":"    metrics, error_messages \u003d query_exporter_metric("},{"line_number":51,"context_line":"        args.exporter_api, args.health_metric)"},{"line_number":52,"context_line":"    if error_messages:"},{"line_number":53,"context_line":"        print("},{"line_number":54,"context_line":"            \"Unknown: unable to query metrics. {}\".format("},{"line_number":55,"context_line":"                \",\".join(error_messages)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_782a30db","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":22},"in_reply_to":"7faddb67_606cc0cd","updated":"2019-07-18 14:22:07.000000000","message":"Thank u for review Drew.. I wanted to print a different message for Null metrics from that of error in the query. hence used this method.","commit_id":"3cb31027b9bdd25e707671a616528b272311d477"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"a78d9ad8f847e52da46deccc6082a7bee7ccc052","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \",\".join(error_messages)))"},{"line_number":56,"context_line":"        sys.exit(STATE_UNKNOWN)"},{"line_number":57,"context_line":"    if metrics:"},{"line_number":58,"context_line":"     criticalMessages \u003d []"},{"line_number":59,"context_line":"     warningMessages \u003d []"},{"line_number":60,"context_line":"     for key, value in metrics.iteritems():"},{"line_number":61,"context_line":"         if value \u003d\u003d args.critical:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e078b090","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":5},"updated":"2019-07-17 23:40:55.000000000","message":"I know it\u0027s not gated, but we should try to remain as close to PEP8 compliant as possible. In this case, that means indentation should be 4 spaces [0].\n\n[0] https://www.python.org/dev/peps/pep-0008/#indentation","commit_id":"3cb31027b9bdd25e707671a616528b272311d477"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8f3134e1c201480b5b5998f6564537c1f2ca75bd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"             criticalMessages.append("},{"line_number":63,"context_line":"                 \"Critical: {metric_name} metric is a critical value of {metric_value}({detail})\".format("},{"line_number":64,"context_line":"                     metric_name\u003dargs.health_metric, metric_value\u003dvalue, detail\u003dkey))"},{"line_number":65,"context_line":"         elif args.warning and value \u003d\u003d args.warning:"},{"line_number":66,"context_line":"             warningMessages.append("},{"line_number":67,"context_line":"                 \"Warning: {metric_name} metric is a warning value of {metric_value}({detail})\".format("},{"line_number":68,"context_line":"                     metric_name\u003dargs.health_metric, metric_value\u003dvalue, detail\u003dkey))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_067c0481","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":26},"updated":"2019-07-18 03:44:43.000000000","message":"if warning is required,do we need this check?","commit_id":"3cb31027b9bdd25e707671a616528b272311d477"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"1cfda937df2a2f72fd987568d42655b1f46a75ee","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                         metric_name\u003dargs.health_metric, metric_value\u003dvalue, detail\u003dkey))"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        print(\"Unknown: Query response has Null value({detail})\".format("},{"line_number":69,"context_line":"                     metric_name\u003dargs.health_metric, detail\u003dstr(metrics)))"},{"line_number":70,"context_line":"        sys.exit(STATE_UNKNOWN)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if criticalMessages:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_6be4950d","line":69,"range":{"start_line":69,"start_character":21,"end_line":69,"end_character":51},"updated":"2019-07-18 16:18:22.000000000","message":"This variable is not included in the printed warning message,; it should be removed or included.","commit_id":"2bf58637315213396f107c2d7e114c25887d98d9"}]}