)]}'
{"openstack/loci/build.sh":[{"author":{"_account_id":16353,"name":"Georg Kunz","email":"georg.kunz@ericsson.com","username":"georg-kunz"},"change_message_id":"24c5787dcf344236cf2ee18320ae1d4413cd9519","unresolved":false,"context_lines":[{"line_number":193,"context_line":"cinder_profiles\u003d${cinder_profiles:-\"\u0027fluent lvm ceph qemu\u0027\"}"},{"line_number":194,"context_line":"cinder_pip_packages\u003d${cinder_pip_packages:-\"\u0027pycrypto python-swiftclient\u0027\"}"},{"line_number":195,"context_line":"neutron_profiles\u003d${neutron_profiles:-\"\u0027fluent linuxbridge openvswitch\u0027\"}"},{"line_number":196,"context_line":"neutron_dist_packages\u003d${neutron_sriov_dist_packages:-\"\u0027jq\u0027\"}"},{"line_number":197,"context_line":"neutron_pip_packages\u003d${neutron_pip_packages:-\"pycrypto\"}"},{"line_number":198,"context_line":"nova_profiles\u003d${nova_profiles:-\"\u0027fluent ceph linuxbridge openvswitch configdrive qemu apache\u0027\"}"},{"line_number":199,"context_line":"nova_pip_packages\u003d${nova_pip_packages:-\"pycrypto\"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_2e76a071","line":196,"range":{"start_line":196,"start_character":24,"end_line":196,"end_character":51},"updated":"2019-07-19 10:47:09.000000000","message":"I don\u0027t think the value of neutron_dist_package should be tied to this variable. If neutron_sriov_dist_packages is not null, jq is not added as a dependency.","commit_id":"705805bd4628349296069d4bb8dadd002b6acaf9"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"afdc71d7172339a43f1b26ecfe3be715277325b4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"cinder_profiles\u003d${cinder_profiles:-\"\u0027fluent lvm ceph qemu\u0027\"}"},{"line_number":194,"context_line":"cinder_pip_packages\u003d${cinder_pip_packages:-\"\u0027pycrypto python-swiftclient\u0027\"}"},{"line_number":195,"context_line":"neutron_profiles\u003d${neutron_profiles:-\"\u0027fluent linuxbridge openvswitch\u0027\"}"},{"line_number":196,"context_line":"neutron_dist_packages\u003d${neutron_sriov_dist_packages:-\"\u0027jq\u0027\"}"},{"line_number":197,"context_line":"neutron_pip_packages\u003d${neutron_pip_packages:-\"pycrypto\"}"},{"line_number":198,"context_line":"nova_profiles\u003d${nova_profiles:-\"\u0027fluent ceph linuxbridge openvswitch configdrive qemu apache\u0027\"}"},{"line_number":199,"context_line":"nova_pip_packages\u003d${nova_pip_packages:-\"pycrypto\"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_2ecea062","line":196,"range":{"start_line":196,"start_character":24,"end_line":196,"end_character":51},"in_reply_to":"7faddb67_2e76a071","updated":"2019-07-19 11:18:48.000000000","message":"I copied this from sriov line but forgot to update the later part :(","commit_id":"705805bd4628349296069d4bb8dadd002b6acaf9"}],"zuul.d/openstack-loci.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"bbb4088b2da0ef5845cac04d0ed2be68f070d432","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            - \"PYTHON3\u003d{{ python3 }}\""},{"line_number":160,"context_line":"            - \"PROJECT\u003d\u0027neutron\u0027\""},{"line_number":161,"context_line":"            - \"PROJECT_REF\u003d{{ branchname }}\""},{"line_number":162,"context_line":"            - \"PROFILES\u003d\u0027fluent linuxbridge openvswitch\u0027\""},{"line_number":163,"context_line":"            - \"DIST_PACKAGES\u003d\u0027jq\u0027\""},{"line_number":164,"context_line":"            - \"WHEELS\u003d\u0027{{ wheels_location }}\u0027\""},{"line_number":165,"context_line":"          tags: *imagetag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_3018a81c","line":162,"updated":"2019-07-30 14:48:33.000000000","message":"nit: Would it make sense to also add jq to the sriov images? That would make sense for me for consistency.\n\nHowever, I don\u0027t know your use case.","commit_id":"ab9cc8a78a3f3aeddd0e5daf1be4bd414f30b9f4"},{"author":{"_account_id":29668,"name":"cheng li","email":"cheng1.li@intel.com","username":"chengli3"},"change_message_id":"e358059df148ebaad7738f966af7d2371e3d6a6e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            - \"PYTHON3\u003d{{ python3 }}\""},{"line_number":160,"context_line":"            - \"PROJECT\u003d\u0027neutron\u0027\""},{"line_number":161,"context_line":"            - \"PROJECT_REF\u003d{{ branchname }}\""},{"line_number":162,"context_line":"            - \"PROFILES\u003d\u0027fluent linuxbridge openvswitch\u0027\""},{"line_number":163,"context_line":"            - \"DIST_PACKAGES\u003d\u0027jq\u0027\""},{"line_number":164,"context_line":"            - \"WHEELS\u003d\u0027{{ wheels_location }}\u0027\""},{"line_number":165,"context_line":"          tags: *imagetag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_f01a107b","line":162,"in_reply_to":"7faddb67_3018a81c","updated":"2019-07-30 15:16:03.000000000","message":"The jq is going to be used in the init script[1] which is not executed in sriov.\n\n[1] https://github.com/openstack/openstack-helm/blob/master/neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl","commit_id":"ab9cc8a78a3f3aeddd0e5daf1be4bd414f30b9f4"}]}
