)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c22af4798e9784cd27fa3646a3dc7cc99830e5e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Khare \u003cbk552w@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-02 19:07:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[AICMON-1227] - [WIP] Python 2.7 to 3.x for openstack-exporter"},{"line_number":8,"context_line":"Make required changes in openstack helm image of"},{"line_number":9,"context_line":"Prometheus-openstack-exporter to move from python 2.7 to 3.x"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_b1f15e04","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"updated":"2019-10-03 02:49:06.000000000","message":"should remove these internal tracking bit","commit_id":"f88c24c5e6dcfb8c93c35417c04cd850f4178da5"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c22af4798e9784cd27fa3646a3dc7cc99830e5e8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-10-02 19:07:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[AICMON-1227] - [WIP] Python 2.7 to 3.x for openstack-exporter"},{"line_number":8,"context_line":"Make required changes in openstack helm image of"},{"line_number":9,"context_line":"Prometheus-openstack-exporter to move from python 2.7 to 3.x"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27de3d7f6b6877430751d33b940de3ead7906dc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d1f65afa","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":60},"updated":"2019-10-03 02:49:06.000000000","message":"a blank line should separate the first line from the rest: see [0]\n\n[0] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f88c24c5e6dcfb8c93c35417c04cd850f4178da5"}],"prometheus-openstack-exporter/Dockerfile.ubuntu_bionic":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d75ff410deaf3f9e491a381ef297f59f6eb37353","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"        \u0026\u0026 apt-get -y install python3 python3-pip curl \\"},{"line_number":6,"context_line":"        \u0026\u0026 python3 -m pip install --upgrade pip \\"},{"line_number":7,"context_line":"        \u0026\u0026 python3 -m pip install python-dateutil requests simplejson pyyaml prometheus-client \\"},{"line_number":8,"context_line":"        \u0026\u0026 apt-get clean \\"},{"line_number":9,"context_line":"        \u0026\u0026 rm -rf /var/lib/apt/lists/*"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3fa7e38b_c67177e0","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":25},"updated":"2019-10-08 14:08:39.000000000","message":"should this just be pip3?","commit_id":"0e920e5c6544c8684b8cf279728e5daa36d46ffe"},{"author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"change_message_id":"cce2dd72e2dc6fa9b59b1474f5fe6eed27b21cca","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"        \u0026\u0026 apt-get -y install python3 python3-pip curl \\"},{"line_number":6,"context_line":"        \u0026\u0026 python3 -m pip install --upgrade pip \\"},{"line_number":7,"context_line":"        \u0026\u0026 python3 -m pip install python-dateutil requests simplejson pyyaml prometheus-client \\"},{"line_number":8,"context_line":"        \u0026\u0026 apt-get clean \\"},{"line_number":9,"context_line":"        \u0026\u0026 rm -rf /var/lib/apt/lists/*"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3fa7e38b_0284585d","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":25},"in_reply_to":"3fa7e38b_c67177e0","updated":"2019-10-08 15:25:28.000000000","message":"When using pip3, we encountered the error described here [0]. So instead we are using the syntax described in [1], which is working without error. Is our use of this syntax inappropriate, and/or do you have a suggestion to [0]?\n\n[0] https://github.com/pypa/pip/issues/5599#issue-341052110\n[1] https://docs.python.org/3/installing/index.html#basic-usage","commit_id":"0e920e5c6544c8684b8cf279728e5daa36d46ffe"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d75ff410deaf3f9e491a381ef297f59f6eb37353","unresolved":false,"context_lines":[{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"        \u0026\u0026 apt-get -y install python3 python3-pip curl \\"},{"line_number":6,"context_line":"        \u0026\u0026 python3 -m pip install --upgrade pip \\"},{"line_number":7,"context_line":"        \u0026\u0026 python3 -m pip install python-dateutil requests simplejson pyyaml prometheus-client \\"},{"line_number":8,"context_line":"        \u0026\u0026 apt-get clean \\"},{"line_number":9,"context_line":"        \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":10,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3fa7e38b_867b7fbc","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":25},"updated":"2019-10-08 14:08:39.000000000","message":"ditto","commit_id":"0e920e5c6544c8684b8cf279728e5daa36d46ffe"}],"prometheus-openstack-exporter/exporter/__init__.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c22af4798e9784cd27fa3646a3dc7cc99830e5e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_919302a4","updated":"2019-10-03 02:49:06.000000000","message":"why is this file +x?","commit_id":"f88c24c5e6dcfb8c93c35417c04cd850f4178da5"}],"prometheus-openstack-exporter/exporter/base.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c22af4798e9784cd27fa3646a3dc7cc99830e5e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3\r"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f1e7d645","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2019-10-03 02:49:06.000000000","message":"this can be removed. it is not executable file, it only contains a class.","commit_id":"f88c24c5e6dcfb8c93c35417c04cd850f4178da5"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8b8f0ec72271e973f72a204d8aff94c0f5c3b270","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python\r"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_cc8fd1ca","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"updated":"2019-10-16 20:43:42.000000000","message":"Why remove this? On Bionic, this invokes Python 3.","commit_id":"53cdce9b9e66ee79239c6c5795a52ce424b0a54d"},{"author":{"_account_id":30692,"name":"Bharat Khare","email":"bk552w@att.com","username":"bk552w"},"change_message_id":"3bbafc88b3d47ae3b852dd7e97710cf04205ab92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python\r"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_079942c2","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"in_reply_to":"3fa7e38b_cc8fd1ca","updated":"2019-10-16 21:08:35.000000000","message":"Thanks Drew for suggestion. We removed it as per Tin\u0027s previous comments. Since it is not executable file and it only contains a class hence this header can be removed.","commit_id":"53cdce9b9e66ee79239c6c5795a52ce424b0a54d"}],"prometheus-openstack-exporter/exporter/check_os_api.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c22af4798e9784cd27fa3646a3dc7cc99830e5e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_11edd224","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2019-10-03 02:49:06.000000000","message":"ditto","commit_id":"f88c24c5e6dcfb8c93c35417c04cd850f4178da5"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8b8f0ec72271e973f72a204d8aff94c0f5c3b270","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_4cb5217d","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"updated":"2019-10-16 20:43:42.000000000","message":"Same here.","commit_id":"53cdce9b9e66ee79239c6c5795a52ce424b0a54d"},{"author":{"_account_id":30692,"name":"Bharat Khare","email":"bk552w@att.com","username":"bk552w"},"change_message_id":"3bbafc88b3d47ae3b852dd7e97710cf04205ab92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_e789866e","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"in_reply_to":"3fa7e38b_4cb5217d","updated":"2019-10-16 21:08:35.000000000","message":"We removed it as per Tin\u0027s previous comments. Since it is not executable file and it only contains a class hence this header can be removed.","commit_id":"53cdce9b9e66ee79239c6c5795a52ce424b0a54d"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"d79e001a093d808c8c7eeb3585f78b8c99e57f66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_4d02f1bc","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"in_reply_to":"3fa7e38b_e789866e","updated":"2019-10-17 15:28:31.000000000","message":"\u003e We removed it as per Tin\u0027s previous comments. Since it is not\n \u003e executable file and it only contains a class hence this header can\n \u003e be removed.\n\nTin made a good point. Sorry for not reading ahead!","commit_id":"53cdce9b9e66ee79239c6c5795a52ce424b0a54d"}],"prometheus-openstack-exporter/exporter/main.py":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"8b8f0ec72271e973f72a204d8aff94c0f5c3b270","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ac67f524","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2019-10-16 20:43:42.000000000","message":"If you choose to stick with this header, let\u0027s add it to the other files. Otherwise, this can remain \n\n  #!/usr/bin/env python","commit_id":"fefb87874064e4fcdecdea370e8dd308171d877f"},{"author":{"_account_id":30692,"name":"Bharat Khare","email":"bk552w@att.com","username":"bk552w"},"change_message_id":"3bbafc88b3d47ae3b852dd7e97710cf04205ab92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_a7094edd","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_ac67f524","updated":"2019-10-16 21:08:35.000000000","message":"We removed it in other files as per Tin\u0027s previous comments. Since those were not executable file and only contains a class hence this header can be removed. This main.py is executable file and hence keep it here.","commit_id":"fefb87874064e4fcdecdea370e8dd308171d877f"}]}