)]}'
{"mini-mirror/Dockerfile.ubuntu_bionic":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4efa5117a23f28dfe8a7a6917dbc47fcb7ec43a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"FROM ubuntu:18.04 as aptly"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ARG APTLY_CONFIG_PATH\u003detc/aptly.conf"},{"line_number":18,"context_line":"ARG MIRROR_SOURCE_YAML\u003dmini-mirror-sources.yaml"},{"line_number":19,"context_line":"ARG RELEASE_SIGN_KEY_PATH\u003detc"},{"line_number":20,"context_line":"ARG RELEASE_SIGN_KEY_PASSPHRASE"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa7e38b_3d89636e","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":22},"updated":"2019-11-15 16:49:49.000000000","message":"nit: can we make this file? Since it is a file path.","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":15,"context_line":"FROM ubuntu:18.04 as aptly"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ARG APTLY_CONFIG_PATH\u003detc/aptly.conf"},{"line_number":18,"context_line":"ARG MIRROR_SOURCE_YAML\u003dmini-mirror-sources.yaml"},{"line_number":19,"context_line":"ARG RELEASE_SIGN_KEY_PATH\u003detc"},{"line_number":20,"context_line":"ARG RELEASE_SIGN_KEY_PASSPHRASE"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa7e38b_43b7a022","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":22},"in_reply_to":"3fa7e38b_3d89636e","updated":"2019-11-15 22:26:37.000000000","message":"Done","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"}],"mini-mirror/Dockerfile.ubuntu_xenial":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4efa5117a23f28dfe8a7a6917dbc47fcb7ec43a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"FROM ubuntu:16.04 as aptly"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ARG APTLY_CONFIG_PATH\u003detc/aptly.conf"},{"line_number":18,"context_line":"ARG MIRROR_SOURCE_YAML\u003dmini-mirror-sources.yaml"},{"line_number":19,"context_line":"ARG RELEASE_SIGN_KEY_PATH\u003detc"},{"line_number":20,"context_line":"ARG RELEASE_SIGN_KEY_PASSPHRASE"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa7e38b_3dbde3b0","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":22},"updated":"2019-11-15 16:49:49.000000000","message":"Same request for this Dockerfile.","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":15,"context_line":"FROM ubuntu:16.04 as aptly"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ARG APTLY_CONFIG_PATH\u003detc/aptly.conf"},{"line_number":18,"context_line":"ARG MIRROR_SOURCE_YAML\u003dmini-mirror-sources.yaml"},{"line_number":19,"context_line":"ARG RELEASE_SIGN_KEY_PATH\u003detc"},{"line_number":20,"context_line":"ARG RELEASE_SIGN_KEY_PASSPHRASE"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa7e38b_e3356ca9","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":22},"in_reply_to":"3fa7e38b_3dbde3b0","updated":"2019-11-15 22:26:37.000000000","message":"Done","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"}],"mini-mirror/README.rst":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4efa5117a23f28dfe8a7a6917dbc47fcb7ec43a9","unresolved":false,"context_lines":[{"line_number":79,"context_line":".. NOTE::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    Mini-mirror can be configured on a per-repo basis by adding an Aptly config"},{"line_number":82,"context_line":"    file to the .data.aptly_config key in the YAML document. This overrides"},{"line_number":83,"context_line":"    the Aptly config file taken from ``APTLY_CONFIG_PATH``."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Proxy"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_1deee7b4","line":82,"range":{"start_line":82,"start_character":17,"end_line":82,"end_character":21},"updated":"2019-11-15 16:49:49.000000000","message":"Extra key, should be:\n\n  .aptly_config","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":79,"context_line":".. NOTE::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    Mini-mirror can be configured on a per-repo basis by adding an Aptly config"},{"line_number":82,"context_line":"    file to the .data.aptly_config key in the YAML document. This overrides"},{"line_number":83,"context_line":"    the Aptly config file taken from ``APTLY_CONFIG_PATH``."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Proxy"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_033be89b","line":82,"range":{"start_line":82,"start_character":17,"end_line":82,"end_character":21},"in_reply_to":"3fa7e38b_1deee7b4","updated":"2019-11-15 22:26:37.000000000","message":"Done","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"}],"mini-mirror/build.sh":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"5c46ae6b8a78e6abeedf91818f9e35ecfdcb7605","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  --build-arg https_proxy\u003d\"${HTTPS_PROXY}\" \\"},{"line_number":42,"context_line":"  --build-arg HTTP_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":43,"context_line":"  --build-arg HTTPS_PROXY\u003d\"${HTTPS_PROXY}\" \\"},{"line_number":44,"context_line":"  --build-arg no_proxy\u003d\"${HTTP_PROXY}\" \\"},{"line_number":45,"context_line":"  --build-arg NO_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":46,"context_line":"  --build-arg APTLY_CONFIG_PATH\u003d\"${APTLY_CONFIG_PATH}\" \\"},{"line_number":47,"context_line":"  --build-arg MIRROR_SOURCE_YAML\u003d\"${MIRROR_SOURCE_YAML}\" \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_0393e850","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":36},"updated":"2019-11-15 19:08:03.000000000","message":"Maybe it\u0027s time to fix this? NO_PROXY should be be mapped here","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  --build-arg https_proxy\u003d\"${HTTPS_PROXY}\" \\"},{"line_number":42,"context_line":"  --build-arg HTTP_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":43,"context_line":"  --build-arg HTTPS_PROXY\u003d\"${HTTPS_PROXY}\" \\"},{"line_number":44,"context_line":"  --build-arg no_proxy\u003d\"${HTTP_PROXY}\" \\"},{"line_number":45,"context_line":"  --build-arg NO_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":46,"context_line":"  --build-arg APTLY_CONFIG_PATH\u003d\"${APTLY_CONFIG_PATH}\" \\"},{"line_number":47,"context_line":"  --build-arg MIRROR_SOURCE_YAML\u003d\"${MIRROR_SOURCE_YAML}\" \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_e3b6ccdc","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":36},"in_reply_to":"3fa7e38b_0393e850","updated":"2019-11-15 22:26:37.000000000","message":"Good catch, there were a few other unrelated changes I wanted to make so I made a separate change to address this here: https://review.opendev.org/#/c/694638/","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"5c46ae6b8a78e6abeedf91818f9e35ecfdcb7605","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  --build-arg HTTP_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":43,"context_line":"  --build-arg HTTPS_PROXY\u003d\"${HTTPS_PROXY}\" \\"},{"line_number":44,"context_line":"  --build-arg no_proxy\u003d\"${HTTP_PROXY}\" \\"},{"line_number":45,"context_line":"  --build-arg NO_PROXY\u003d\"${HTTP_PROXY}\" \\"},{"line_number":46,"context_line":"  --build-arg APTLY_CONFIG_PATH\u003d\"${APTLY_CONFIG_PATH}\" \\"},{"line_number":47,"context_line":"  --build-arg MIRROR_SOURCE_YAML\u003d\"${MIRROR_SOURCE_YAML}\" \\"},{"line_number":48,"context_line":"  --build-arg RELEASE_SIGN_KEY_PATH\u003d\"${RELEASE_SIGN_KEY_PATH}\" \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_a393f44d","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":36},"updated":"2019-11-15 19:08:03.000000000","message":"the same","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"8406ac969bd7c3e83a18d7d7c6d2b37e361546c7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  --build-arg APTLY_INSTALL_FROM\u003d\"${APTLY_INSTALL_FROM}\" \\"},{"line_number":58,"context_line":"  --build-arg APTLY_REPO\u003d\"${APTLY_REPO}\" \\"},{"line_number":59,"context_line":"  --build-arg APTLY_REFSPEC\u003d\"${APTLY_REFSPEC}\" \\"},{"line_number":60,"context_line":"  ${extra_build_args} \"${IMAGE}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"cd - || exit"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa7e38b_2a91e253","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":21},"updated":"2020-01-07 08:25:43.000000000","message":"Possibly missing double quotes.","commit_id":"68b0f8a6026277673b9666c80655992a0e08bde0"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"07a4f5bdad367e3bb86c0a9d2e42869bcb9b88de","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  --build-arg APTLY_INSTALL_FROM\u003d\"${APTLY_INSTALL_FROM}\" \\"},{"line_number":58,"context_line":"  --build-arg APTLY_REPO\u003d\"${APTLY_REPO}\" \\"},{"line_number":59,"context_line":"  --build-arg APTLY_REFSPEC\u003d\"${APTLY_REFSPEC}\" \\"},{"line_number":60,"context_line":"  ${extra_build_args} \"${IMAGE}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"cd - || exit"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa7e38b_8b7b1c27","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":21},"in_reply_to":"3fa7e38b_2a91e253","updated":"2020-01-08 20:56:12.000000000","message":"The parameter expansion here is expected I believe, and the build does not function with double quotes here, seems like this is how it is done all over osh-images","commit_id":"68b0f8a6026277673b9666c80655992a0e08bde0"}],"mini-mirror/mini-mirror-sources.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"4efa5117a23f28dfe8a7a6917dbc47fcb7ec43a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#url: https://download.docker.com/linux/ubuntu"},{"line_number":16,"context_line":"#key_url: https://download.docker.com/linux/ubuntu/gpg"},{"line_number":17,"context_line":"#aptly_config: |"},{"line_number":18,"context_line":"#  {"},{"line_number":19,"context_line":"#    \"rootDir\": \"/opt/.aptly\","},{"line_number":20,"context_line":"#    \"downloadConcurrency\": 20,"},{"line_number":21,"context_line":"#    \"downloadSpeedLimit\": 0,"},{"line_number":22,"context_line":"#    \"architectures\": [\"amd64\"],"},{"line_number":23,"context_line":"#    \"dependencyFollowSuggests\": false,"},{"line_number":24,"context_line":"#    \"dependencyFollowRecommends\": false,"},{"line_number":25,"context_line":"#    \"dependencyFollowAllVariants\": false,"},{"line_number":26,"context_line":"#    \"dependencyFollowSource\": false,"},{"line_number":27,"context_line":"#    \"dependencyVerboseResolve\": true,"},{"line_number":28,"context_line":"#    \"gpgDisableSign\": true,"},{"line_number":29,"context_line":"#    \"gpgDisableVerify\": true,"},{"line_number":30,"context_line":"#    \"gpgProvider\": \"gpg\","},{"line_number":31,"context_line":"#    \"downloadSourcePackages\": false,"},{"line_number":32,"context_line":"#    \"skipLegacyPool\": true,"},{"line_number":33,"context_line":"#    \"ppaDistributorID\": \"ubuntu\","},{"line_number":34,"context_line":"#    \"ppaCodename\": \"\""},{"line_number":35,"context_line":"#  }"},{"line_number":36,"context_line":"#components:"},{"line_number":37,"context_line":"#  - stable"},{"line_number":38,"context_line":"#subrepos:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_fdf3cb71","line":35,"range":{"start_line":18,"start_character":0,"end_line":35,"end_character":4},"updated":"2019-11-15 16:49:49.000000000","message":"Are we positive that a partial Aptly config file works?","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#url: https://download.docker.com/linux/ubuntu"},{"line_number":16,"context_line":"#key_url: https://download.docker.com/linux/ubuntu/gpg"},{"line_number":17,"context_line":"#aptly_config: |"},{"line_number":18,"context_line":"#  {"},{"line_number":19,"context_line":"#    \"rootDir\": \"/opt/.aptly\","},{"line_number":20,"context_line":"#    \"downloadConcurrency\": 20,"},{"line_number":21,"context_line":"#    \"downloadSpeedLimit\": 0,"},{"line_number":22,"context_line":"#    \"architectures\": [\"amd64\"],"},{"line_number":23,"context_line":"#    \"dependencyFollowSuggests\": false,"},{"line_number":24,"context_line":"#    \"dependencyFollowRecommends\": false,"},{"line_number":25,"context_line":"#    \"dependencyFollowAllVariants\": false,"},{"line_number":26,"context_line":"#    \"dependencyFollowSource\": false,"},{"line_number":27,"context_line":"#    \"dependencyVerboseResolve\": true,"},{"line_number":28,"context_line":"#    \"gpgDisableSign\": true,"},{"line_number":29,"context_line":"#    \"gpgDisableVerify\": true,"},{"line_number":30,"context_line":"#    \"gpgProvider\": \"gpg\","},{"line_number":31,"context_line":"#    \"downloadSourcePackages\": false,"},{"line_number":32,"context_line":"#    \"skipLegacyPool\": true,"},{"line_number":33,"context_line":"#    \"ppaDistributorID\": \"ubuntu\","},{"line_number":34,"context_line":"#    \"ppaCodename\": \"\""},{"line_number":35,"context_line":"#  }"},{"line_number":36,"context_line":"#components:"},{"line_number":37,"context_line":"#  - stable"},{"line_number":38,"context_line":"#subrepos:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_88237705","line":35,"range":{"start_line":18,"start_character":0,"end_line":35,"end_character":4},"in_reply_to":"3fa7e38b_fdf3cb71","updated":"2019-11-15 22:26:37.000000000","message":"Should be fine: https://www.aptly.info/doc/configuration/\n\nThe docs just specify the original file just contains the defaults, so if we don\u0027t specify an override then it should just take the default.\n\nAlso tested this locally and confirmed that the new configurations are being used.","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"}],"mini-mirror/tools/publish_snapshots.sh":[{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"12c4f216d289509cb2e4621cdace81abc6981774","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"sources\u003d$(yq \".\" /opt/mini-mirror-sources.yaml | jq -s \u0027.\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Loop to iterate over each document in the YAML file"},{"line_number":26,"context_line":"for source in $(echo \"${sources}\" | jq -r \u0027.[] | @base64\u0027 ); do"},{"line_number":27,"context_line":"  _source() {"},{"line_number":28,"context_line":"    echo ${source} | base64 --decode | jq -r \"${*}\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_0851c70e","line":25,"updated":"2019-11-15 17:07:30.000000000","message":"It is not obvious why the jq output is being encoded as base64 and then promptly decoded again when used.  Is this done so that the entire nested structure is encapsulated into a string without spaces?  It would be nice to add an explanatory comment in the script","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"83047f3c4627bc23e7f18988f2c8b408b1df5149","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"sources\u003d$(yq \".\" /opt/mini-mirror-sources.yaml | jq -s \u0027.\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Loop to iterate over each document in the YAML file"},{"line_number":26,"context_line":"for source in $(echo \"${sources}\" | jq -r \u0027.[] | @base64\u0027 ); do"},{"line_number":27,"context_line":"  _source() {"},{"line_number":28,"context_line":"    echo ${source} | base64 --decode | jq -r \"${*}\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_88793730","line":25,"in_reply_to":"3fa7e38b_0851c70e","updated":"2019-11-15 22:26:37.000000000","message":"You hit the nail on the head, I\u0027ll go ahead and put an explanation in a comment though.","commit_id":"08167ea6d13e25b010836e1a9305bf7211e68719"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"16edb55b79d0b442fd95150261f1164ee7cc8954","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    dist\u003d$(_subrepo \u0027.distribution\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    echo ${components} \u003e\u003e components.txt"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Use source specific aptly config when provided"},{"line_number":49,"context_line":"    source_conf\u003d$(_source \u0027.aptly_config\u0027)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_e94e5194","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":40},"updated":"2019-11-22 20:05:14.000000000","message":"what does this do?","commit_id":"be119599625a54970187e8da0c892c3571229e41"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"ce04be7e0f20879f7dc169f68ab874260fa0b97a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    dist\u003d$(_subrepo \u0027.distribution\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    echo ${components} \u003e\u003e components.txt"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Use source specific aptly config when provided"},{"line_number":49,"context_line":"    source_conf\u003d$(_source \u0027.aptly_config\u0027)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_6cb01ddd","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":40},"in_reply_to":"3fa7e38b_e94e5194","updated":"2019-11-25 17:23:34.000000000","message":"Thought I managed to get rid of all the debug parts of this but that got left in, thanks I will clean it up","commit_id":"be119599625a54970187e8da0c892c3571229e41"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"2091dd34ea2faf88539860488cd5c0ad19ac3a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3fa7e38b_2acc8288","updated":"2020-01-07 08:24:21.000000000","message":"Could this file be checked via shellcheck, please (online or via command)? It reports mostly missing double quotes to prevent word splitting, and throws a few other possibly useful warnings.","commit_id":"68b0f8a6026277673b9666c80655992a0e08bde0"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"07a4f5bdad367e3bb86c0a9d2e42869bcb9b88de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3fa7e38b_8be47c0f","in_reply_to":"3fa7e38b_2acc8288","updated":"2020-01-08 20:56:12.000000000","message":"Sorry I missed this at first, went ahead and resolved all the double quotes problems in this file, including modifying commands that were relying on the non-quoted parameter expansion to work","commit_id":"68b0f8a6026277673b9666c80655992a0e08bde0"}]}