)]}'
{"id":"openstack%2Fopenstack-helm-images~706162","triplet_id":"openstack%2Fopenstack-helm-images~master~Iebf1e862cb0a48a5a5eeda6ea0e8df3537eb602b","project":"openstack/openstack-helm-images","branch":"master","hashtags":[],"change_id":"Iebf1e862cb0a48a5a5eeda6ea0e8df3537eb602b","subject":"Fix source publishing and publish logic","status":"MERGED","created":"2020-02-06 01:25:21.000000000","updated":"2020-02-06 22:39:47.000000000","submitted":"2020-02-06 22:37:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"706162-1581028664798-b4850ae3","meta_rev_id":"72a819e1b5320941d75b415e09053ab538ae793d","_number":706162,"virtual_id_number":706162,"owner":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},{"value":0,"date":"2020-02-06 19:16:44.000000000","_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},{"value":0,"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},{"value":0,"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":0,"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-06 22:37:44.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"recommended":{"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},"all":[{"value":1,"date":"2020-02-06 19:31:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},{"value":0,"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},{"value":1,"date":"2020-02-06 19:30:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},{"value":2,"date":"2020-02-06 22:28:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":1,"date":"2020-02-06 19:30:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":1,"date":"2020-02-06 22:23:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-06 21:34:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"all":[{"value":0,"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},{"value":0,"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},{"value":0,"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},{"value":1,"date":"2020-02-06 22:28:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"value":0,"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"value":0,"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},{"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},{"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-06 19:30:17.000000000","updated_by":{"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},"reviewer":{"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},"state":"REVIEWER"},{"updated":"2020-02-06 19:30:52.000000000","updated_by":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"reviewer":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"state":"REVIEWER"},{"updated":"2020-02-06 19:31:47.000000000","updated_by":{"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},"reviewer":{"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},"state":"REVIEWER"},{"updated":"2020-02-06 21:34:26.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2020-02-06 22:23:06.000000000","updated_by":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"reviewer":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"state":"REVIEWER"},{"updated":"2020-02-06 22:28:14.000000000","updated_by":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"reviewer":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"state":"REVIEWER"},{"updated":"2020-02-06 22:37:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e52825d86ca821456d30ab2c6c1669269052bcbb","author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"date":"2020-02-06 01:25:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a3450ac347a2bd908c55b1e78a2ca2656e748a9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 01:34:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/915bbff94a4d441c93202dcb04562be1 : SUCCESS in 3m 28s\n- openstack-helm-images-build-mini-mirror-xenial https://zuul.opendev.org/t/openstack/build/7418e9f7205947659192d18ba4450e1d : SUCCESS in 6m 38s\n- openstack-helm-images-build-mini-mirror-bionic https://zuul.opendev.org/t/openstack/build/cb5a08e2fe484798935abc226e6a6738 : SUCCESS in 5m 03s","accounts_in_message":[],"_revision_number":1},{"id":"d3899b46fd1771bdac42d136551c50aae32ae107","author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"date":"2020-02-06 19:12:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nLGTM. Why turn off error failures? We should keep those on.","accounts_in_message":[],"_revision_number":1},{"id":"fed15b8a7f74443d3b0c71acff7df5b832ce86f4","author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"date":"2020-02-06 19:16:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"202c002a696d50960ca16003f8606b27a2a4305a","author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"date":"2020-02-06 19:16:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f99ce39928f27547344424a049fe6272b027dd2d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 19:26:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/05cf0f31fb834ac1a2feb074245c70e6 : SUCCESS in 3m 33s\n- openstack-helm-images-build-mini-mirror-xenial https://zuul.opendev.org/t/openstack/build/5564a8b2f7374ac989d3ba239189c2e7 : SUCCESS in 5m 11s\n- openstack-helm-images-build-mini-mirror-bionic https://zuul.opendev.org/t/openstack/build/aaa523e2569047448d045e5ea32f289c : SUCCESS in 5m 26s","accounts_in_message":[],"_revision_number":2},{"id":"45d5da935f88909e710d34c0794fc567e2b8d349","author":{"_account_id":31415,"name":"Jim Baresich","email":"jb2592@att.com","username":"jb2592"},"date":"2020-02-06 19:30:17.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"986d31e6064141e361bb879d029c52cd693ca6d6","author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"date":"2020-02-06 19:30:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"75c55f7ec0aca7840cc79df7f9280449d108428c","author":{"_account_id":31362,"name":"Andrew Schiefelbein","email":"as3525@att.com","username":"aschiefe"},"date":"2020-02-06 19:31:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"54eb2d8664aae3b51b151c407e5cef099652b4be","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2020-02-06 21:34:26.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d43953afe5d67e57cb63f4b7e50690ad1b4097fd","author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"date":"2020-02-06 22:23:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"066bde24083411957b5078688e808591fcd743c7","author":{"_account_id":30777,"name":"Steven Fitzpatrick","email":"steven@fitzpatrick.wtf","username":"sf280x"},"date":"2020-02-06 22:28:14.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"64ed3eb01b8297d12fe58bad7188dff682dce21d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 22:28:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"96f6226db1f9d1d37b09caf474a4ec73cc9ac56d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 22:37:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"cc14fa3f8d06ba0d56eb3842f4d8d6610c2ab39e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 22:37:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e577bb6f5cb94afebdfb3723a22fbb61 : SUCCESS in 3m 51s\n- openstack-helm-images-upload-mini-mirror-xenial https://zuul.opendev.org/t/openstack/build/e688fcae412b45f1a8a349a7fe1ce60e : SUCCESS in 8m 14s\n- openstack-helm-images-upload-mini-mirror-bionic https://zuul.opendev.org/t/openstack/build/6310488aadd24937b7bd04ee6e972121 : SUCCESS in 8m 06s","accounts_in_message":[],"_revision_number":2},{"id":"72a819e1b5320941d75b415e09053ab538ae793d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 22:39:47.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5e0813a4ba4b4b2681208be350e9f05e : SUCCESS in 1m 43s\n- openstack-helm-images-promote-mini-mirror-xenial https://zuul.opendev.org/t/openstack/build/ac711c59a4ea44eab489d0770e14d638 : SUCCESS in 1m 00s\n- openstack-helm-images-promote-mini-mirror-bionic https://zuul.opendev.org/t/openstack/build/ce5e4541f1e14277bd40062ba2e97b43 : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e45829dc9e080c079bb155409f6f01aa7824aef8","revisions":{"d0174f55a706c841b169ae56bb36b00b11e58f57":{"kind":"REWORK","_number":1,"created":"2020-02-06 01:25:21.000000000","uploader":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"ref":"refs/changes/62/706162/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-images","ref":"refs/changes/62/706162/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/1"}}},"commit":{"parents":[{"commit":"f80358d3e92f0b960c7bfc75e637dbc869f26283","subject":"Nagios elasticsearch plugin fix for the new version of the easticsearch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/f80358d3e92f0b960c7bfc75e637dbc869f26283"}]}],"author":{"name":"Michael Beaver","email":"michael.beaver@att.com","date":"2020-02-06 01:25:11.000000000","tz":-360},"committer":{"name":"Michael Beaver","email":"michael.beaver@att.com","date":"2020-02-06 01:25:11.000000000","tz":-360},"subject":"Fix source publishing and publish logic","message":"Fix source publishing and publish logic\n\nSometime recently the logic in aptly changed so that even if the\nconfiguration option \"downloadSourcePackages\" is true, the source\npackages will not be published in the resulting mirror unless the\narchitectures list includes \"source\", but adding \"source\" to the\nactual architecture list for a repo will prevent the mirror creation\nfrom functioning as most repos don\u0027t have a \"source\" architecture.\n\nThis change adds a new check to look at the aptly configuration file to\ndetermine if \"downloadSourcePackages\" is true, and if so then it will\nadd a flag to the publish command with the architectures from the\nconfiguration plus the \"source\" architecture.\n\nI also modified the publish command to bring it into one command while\nstill allowing it to be configurable as it was before.\n\nChange-Id: Iebf1e862cb0a48a5a5eeda6ea0e8df3537eb602b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/d0174f55a706c841b169ae56bb36b00b11e58f57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/d0174f55a706c841b169ae56bb36b00b11e58f57"}]},"branch":"refs/heads/master"},"e45829dc9e080c079bb155409f6f01aa7824aef8":{"kind":"REWORK","_number":2,"created":"2020-02-06 19:16:09.000000000","uploader":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"ref":"refs/changes/62/706162/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-images","ref":"refs/changes/62/706162/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-images refs/changes/62/706162/2"}}},"commit":{"parents":[{"commit":"f80358d3e92f0b960c7bfc75e637dbc869f26283","subject":"Nagios elasticsearch plugin fix for the new version of the easticsearch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/f80358d3e92f0b960c7bfc75e637dbc869f26283"}]}],"author":{"name":"Michael Beaver","email":"michael.beaver@att.com","date":"2020-02-06 01:25:11.000000000","tz":-360},"committer":{"name":"Michael Beaver","email":"michael.beaver@att.com","date":"2020-02-06 19:16:03.000000000","tz":-360},"subject":"Fix source publishing and publish logic","message":"Fix source publishing and publish logic\n\nSometime recently the logic in aptly changed so that even if the\nconfiguration option \"downloadSourcePackages\" is true, the source\npackages will not be published in the resulting mirror unless the\narchitectures list includes \"source\", but adding \"source\" to the\nactual architecture list for a repo will prevent the mirror creation\nfrom functioning as most repos don\u0027t have a \"source\" architecture.\n\nThis change adds a new check to look at the aptly configuration file to\ndetermine if \"downloadSourcePackages\" is true, and if so then it will\nadd a flag to the publish command with the architectures from the\nconfiguration plus the \"source\" architecture.\n\nI also modified the publish command to bring it into one command while\nstill allowing it to be configurable as it was before.\n\nThis also removes the \"set -x\" to limit the excessive output\n\nChange-Id: Iebf1e862cb0a48a5a5eeda6ea0e8df3537eb602b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/e45829dc9e080c079bb155409f6f01aa7824aef8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/e45829dc9e080c079bb155409f6f01aa7824aef8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}