)]}'
{"id":"openstack%2Fopenstack-helm-images~732088","triplet_id":"openstack%2Fopenstack-helm-images~master~I6141712139161a38d16a89ab1ef56009f8635049","project":"openstack/openstack-helm-images","branch":"master","topic":"taas-plugin","hashtags":[],"change_id":"I6141712139161a38d16a89ab1ef56009f8635049","subject":"Add support for tap-as-a-service plugin","status":"ABANDONED","created":"2020-06-01 04:34:53.000000000","updated":"2021-04-15 19:14:15.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0faba95f8c9ff772c250540fd74c374345c62267","_number":732088,"virtual_id_number":732088,"owner":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-01 05:25:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"all":[{"value":-1,"date":"2020-06-05 13:18:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":1,"date":"2020-06-05 03:43:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},{"value":-1,"date":"2020-06-05 16:33:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-06-12 21:28:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-01 05:25:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-05 03:43:11.000000000","updated_by":{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},"reviewer":{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},"state":"REVIEWER"},{"updated":"2020-06-05 13:18:31.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2020-06-05 16:33:57.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2020-06-12 21:28:30.000000000","updated_by":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"reviewer":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"state":"REVIEWER"}],"messages":[{"id":"b0e25222d9076b9d7d3874e95879af4d8b3b9d85","author":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"date":"2020-06-01 04:34:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"29290c291715d14389f2961b1536fb3a37def24d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-01 05:25:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c6690979a4d946c18992a724c4d36d2d : SUCCESS in 3m 35s\n- openstack-helm-images-build-openstack-loci-ocata-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/9d7bf41de0b14eeba48d50886c49f50e : SUCCESS in 44m 37s\n- openstack-helm-images-build-openstack-loci-pike-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/943d7ddc6c8d4c9abcff7e7c5c82a838 : SUCCESS in 37m 07s\n- openstack-helm-images-build-openstack-loci-queens-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/af2982d6534c4bd5bbf8314a3b6fa784 : SUCCESS in 31m 01s\n- openstack-helm-images-build-openstack-loci-rocky-opensuse_15 https://zuul.opendev.org/t/openstack/build/715095eb2baa4b6e8be4e51575782bca : FAILURE in 2m 27s (non-voting)\n- openstack-helm-images-build-openstack-loci-rocky-ubuntu_xenial https://zuul.opendev.org/t/openstack/build/8f3d660df75743859ba4c9dab7e3cf23 : SUCCESS in 30m 55s\n- openstack-helm-images-build-openstack-loci-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/3813acd827ca49d4be911894bc5359ac : SUCCESS in 29m 18s\n- openstack-helm-images-build-openstack-loci-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/abf214e827c146f7a0fc27359f864a2b : SUCCESS in 50m 02s\n- openstack-helm-images-build-openstack-loci-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/c7ed245c51cd4400bf8d2e3f574c07da : SUCCESS in 32m 33s\n- openstack-helm-images-build-openstack-loci-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/92679710bcf94f098b00f7dbdc0585e4 : SUCCESS in 39m 41s\n- openstack-helm-images-build-openstack-loci-master-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/91507091447c410292b11a7503c927bb : SUCCESS in 29m 59s","accounts_in_message":[],"_revision_number":1},{"id":"aa4e2b15fb5305e597d3f7095cf19a112f75795d","author":{"_account_id":17305,"name":"Arijit Bose","email":"imarijitbose@gmail.com","username":"imarijitbose"},"date":"2020-06-05 03:43:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"42ed38ffc2aa3827a2492f0891ce812b13d2dc12","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2020-06-05 13:18:31.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"613dc4dfefeb89c4181fd9fc65127567ccd5d67d","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-06-05 16:33:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d947ace1980a25086c9da0e2aff47298f6b91d91","author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"date":"2020-06-12 21:28:30.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think this is the right approach. You may want to reuse native loci functionality to add required software you your existing images. E.g. to include taas to an image you just do:\ndocker build . --build-arg PROJECT\u003dtap-as-a-service --build-arg PROJECT_REPO\u003dhttps://opendev.org/x/tap-as-a-service --build-arg PLUGIN\u003dneutron --build-arg FROM\u003dopenstackhelm/neutron:stein-ubuntu_bionic --build-arg WHEELS\u003d/opt/loci/wheels.tar --build-arg PYTHON3\u003dyes\n(add profiles, dist and pip packages if you need on top)\n\nThis functionality is currently slightly flawed for your case, but issue will be addressed here:\nhttps://review.opendev.org/#/c/735394\n\nTo have it included to neutron-sriov image you\u0027ll need to implement it as a job and have 2 stage build.\nPlease reach me if you need more details.","accounts_in_message":[],"_revision_number":1},{"id":"0faba95f8c9ff772c250540fd74c374345c62267","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-04-15 19:14:15.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"473fbba778f7b994f33c423effc6220b646aa204","revisions":{"473fbba778f7b994f33c423effc6220b646aa204":{"kind":"REWORK","_number":1,"created":"2020-06-01 04:34:53.000000000","uploader":{"_account_id":27589,"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","username":"deepak.tiwari"},"ref":"refs/changes/88/732088/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-images","ref":"refs/changes/88/732088/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/88/732088/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/88/732088/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-images refs/changes/88/732088/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-images refs/changes/88/732088/1"}}},"commit":{"parents":[{"commit":"0c6b0b534aa8045cc7d0134948ddbe2af6c5b508","subject":"Merge \"Add Ussuri set of LOCI images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/0c6b0b534aa8045cc7d0134948ddbe2af6c5b508"}]}],"author":{"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","date":"2020-06-01 04:28:15.000000000","tz":0},"committer":{"name":"Deepak Tiwari","email":"deepak.tiwari@aricent.com","date":"2020-06-01 04:28:15.000000000","tz":0},"subject":"Add support for tap-as-a-service plugin","message":"Add support for tap-as-a-service plugin\n\nAdd tap-as-a-service plugin and custom python-neutronclient to\nneutron and heat loci images.\n\nChange-Id: I6141712139161a38d16a89ab1ef56009f8635049\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/473fbba778f7b994f33c423effc6220b646aa204"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-images/commit/473fbba778f7b994f33c423effc6220b646aa204"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
