)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"b84fe09aabaead2360c1afef53669790cdbb8290","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitrii Kabanov \u003cdmitrii.kabanov@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-15 05:48:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[libvirt] Update Ceph to 14.2.9"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PS updates Ceph in libvirt image to 14.2.9 version."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bf51134e_2eb8bf74","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":22},"updated":"2020-06-16 15:03:48.000000000","message":"ceph client","commit_id":"ea5b1e1bec9433107b4673852056d60211eff911"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"b84fe09aabaead2360c1afef53669790cdbb8290","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[libvirt] Update Ceph to 14.2.9"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PS updates Ceph in libvirt image to 14.2.9 version."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I99ba8f37574b39eb986acc4dd1d01922f393e0fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bf51134e_4eaed32e","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":19},"updated":"2020-06-16 15:03:48.000000000","message":"ceph client","commit_id":"ea5b1e1bec9433107b4673852056d60211eff911"}],"libvirt/Dockerfile.ubuntu_bionic":[{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"5c50250275804d04bac1c7528a6f63792b150494","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG UBUNTU_RELEASE\u003dbionic"},{"line_number":6,"context_line":"ARG CEPH_RELEASE\u003dnautilus"},{"line_number":7,"context_line":"ARG CEPH_RELEASE_TAG\u003d\"\""},{"line_number":8,"context_line":"ARG PROJECT\u003dnova"},{"line_number":9,"context_line":"ARG UID\u003d42424"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"bf51134e_3332f8f2","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":25},"updated":"2020-06-15 16:54:02.000000000","message":"this is misleading. nautilus is not available from default bionic repos. Please keep mimic and pass nautilus from job definitions","commit_id":"ea5b1e1bec9433107b4673852056d60211eff911"}],"libvirt/ubuntu-install-libvirt.sh":[{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"101668b3c698566b3a9e8b48e08fd9fe057e4fd6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_ebeb440f","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":4},"updated":"2020-06-10 14:03:41.000000000","message":"Double brackets for opening and closing is better [[   ]]","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"101668b3c698566b3a9e8b48e08fd9fe057e4fd6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_abe14c2d","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":26},"updated":"2020-06-10 14:03:41.000000000","message":"enclose in curly braces ${CEPH_RELEASE_TAG}","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"ad1b1d87364e971a960609f22fdfb3cf69523fa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_da4e0895","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":26},"in_reply_to":"ff570b3c_abe14c2d","updated":"2020-06-10 17:55:50.000000000","message":"Since I\u0027m not extending the string inside the quotes I don\u0027t need curly braces here.","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"13693cac2ee08fb38c6ba54bbb7e2f3aaff8a0ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_9529019d","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":26},"in_reply_to":"ff570b3c_da4e0895","updated":"2020-06-10 18:52:42.000000000","message":"I would still enclose in curly braces for consistency as there are other places in the script where extension isn\u0027t occurring and curly braces are used.","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"},{"author":{"_account_id":17119,"name":"Dmitrii Kabanov","email":"dmitrii.kabanov@att.com","username":"dk370c"},"change_message_id":"ad1b1d87364e971a960609f22fdfb3cf69523fa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_9aa65053","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":4},"in_reply_to":"ff570b3c_ebeb440f","updated":"2020-06-10 17:55:50.000000000","message":"Double brackets is an enhanced version. I\u0027m not using shell globbing here and other staff allowed by \"[[ ]]\". The single square brackets are just enough here.","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"13693cac2ee08fb38c6ba54bbb7e2f3aaff8a0ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"apt-key add /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":5,"context_line":"rm -f /etc/apt/ceph-${CEPH_RELEASE}.key ;\\"},{"line_number":6,"context_line":"echo \"deb ${CEPH_REPO} ${UBUNTU_RELEASE} main\" | tee /etc/apt/sources.list.d/ceph.list ;\\"},{"line_number":7,"context_line":"if [ -z \"$CEPH_RELEASE_TAG\" ]; then ceph\u003d\"ceph-common\"; else ceph\u003d\"ceph-common\u003d${CEPH_RELEASE_TAG}\"; fi ;\\"},{"line_number":8,"context_line":"apt-get update ;\\"},{"line_number":9,"context_line":"apt-get upgrade -y ;\\"},{"line_number":10,"context_line":"apt-get install --no-install-recommends -y \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_353915f2","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":4},"in_reply_to":"ff570b3c_ebeb440f","updated":"2020-06-10 18:52:42.000000000","message":"you can forgo the double brackets.","commit_id":"ed0b7dfce083eb0c0d532d3cfb4cd5bc57bf8311"}],"zuul.d/libvirt.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"cab06de8e2a51dab5c990f17581f99fb65e394b8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          tags:"},{"line_number":53,"context_line":"            - latest-ubuntu_bionic"},{"line_number":54,"context_line":"            - \"ubuntu_bionic-{{ currentdate }}\""},{"line_number":55,"context_line":"          build_args:"},{"line_number":56,"context_line":"            - \"CEPH_REPO\u003dhttps://mirror.mirantis.com/testing/ceph-nautilus/bionic/\""},{"line_number":57,"context_line":"            - \"CEPH_KEY\u003dhttps://mirror.mirantis.com/testing/ceph-nautilus/bionic/archive-ceph-nautilus.key\""},{"line_number":58,"context_line":"            - \"CEPH_RELEASE_TAG\u003d14.2.9-1.0~bionic\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_c42fdf85","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":21},"updated":"2020-06-23 17:47:11.000000000","message":"Should CEPH_RELEASE\u003dnautilus be supplied as a build-arg?","commit_id":"4179761efe4de74a7d41a33348a4a8918d872687"}]}