)]}'
{"libvirt/Dockerfile.ubuntu_bionic":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"429f933d44a38cd73d7a91f2970db3b700548524","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      apt-transport-https \\"},{"line_number":24,"context_line":"      ca-certificates \\"},{"line_number":25,"context_line":"      gnupg ;\\"},{"line_number":26,"context_line":"    /tmp/ubuntu-install-libvirt.sh ;\\"},{"line_number":27,"context_line":"    rm -rf /tmp/*"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN set -ex ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9f560f44_fa5d9cec","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":37},"updated":"2020-09-18 18:53:08.000000000","message":"i think you should have the add-apt-repository here so it happens before the installation","commit_id":"a61baa8b71d877de43277c8a1ea858793b5cb0e4"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"429f933d44a38cd73d7a91f2970db3b700548524","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    apt-get update ;\\"},{"line_number":32,"context_line":"    apt-get upgrade -y ;\\"},{"line_number":33,"context_line":"    apt-get install --no-install-recommends -y \\"},{"line_number":34,"context_line":"    build-essential \\"},{"line_number":35,"context_line":"    software-properties-common ;\\"},{"line_number":36,"context_line":"    add-apt-repository -y cloud-archive:${UCA_RELEASE} ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9f560f44_da6098a7","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":19},"updated":"2020-09-18 18:53:08.000000000","message":"build-essential will add a lot of things to the docker image which we don\u0027t need","commit_id":"a61baa8b71d877de43277c8a1ea858793b5cb0e4"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"429f933d44a38cd73d7a91f2970db3b700548524","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    apt-get upgrade -y ;\\"},{"line_number":33,"context_line":"    apt-get install --no-install-recommends -y \\"},{"line_number":34,"context_line":"    build-essential \\"},{"line_number":35,"context_line":"    software-properties-common ;\\"},{"line_number":36,"context_line":"    add-apt-repository -y cloud-archive:${UCA_RELEASE} ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9f560f44_1a5b30f6","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":30},"updated":"2020-09-18 18:53:08.000000000","message":"we can probably add this one though","commit_id":"a61baa8b71d877de43277c8a1ea858793b5cb0e4"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"FROM ${FROM}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"pete.birley@att.com\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG UBUNTU_URL\u003dhttp://archive.ubuntu.com/ubuntu/"},{"line_number":6,"context_line":"ARG CLOUD_ARCHIVE_URL\u003dhttp://ubuntu-cloud.archive.canonical.com/ubuntu/"},{"line_number":7,"context_line":"ARG ALLOW_UNAUTHENTICATED\u003dfalse"},{"line_number":8,"context_line":"ARG UBUNTU_RELEASE\u003dbionic"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_fdb596d1","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2020-09-18 20:04:21.000000000","message":"this is not really needed that much tbh","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ARG UBUNTU_URL\u003dhttp://archive.ubuntu.com/ubuntu/"},{"line_number":6,"context_line":"ARG CLOUD_ARCHIVE_URL\u003dhttp://ubuntu-cloud.archive.canonical.com/ubuntu/"},{"line_number":7,"context_line":"ARG ALLOW_UNAUTHENTICATED\u003dfalse"},{"line_number":8,"context_line":"ARG UBUNTU_RELEASE\u003dbionic"},{"line_number":9,"context_line":"ARG CEPH_RELEASE\u003dnautilus"},{"line_number":10,"context_line":"ARG UCA_RELEASE\u003dussuri"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_3db0aedd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2020-09-18 20:04:21.000000000","message":"and lets drop this, we dont want to play around with this","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ADD ${CEPH_KEY} /etc/apt/ceph-${CEPH_RELEASE}.key"},{"line_number":20,"context_line":"COPY ./ubuntu-install-libvirt.sh /tmp/ubuntu-install-libvirt.sh"},{"line_number":21,"context_line":"RUN set -ex ;\\"},{"line_number":22,"context_line":"    export DEBIAN_FRONTEND\u003dnoninteractive ;\\"},{"line_number":23,"context_line":"    apt-get update ;\\"},{"line_number":24,"context_line":"    apt-get upgrade -y ;\\"},{"line_number":25,"context_line":"    apt-get install --no-install-recommends -y \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_5dc48241","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":44},"updated":"2020-09-18 20:04:21.000000000","message":"i would do the addition of the repo here as an echo directly to the file :)","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"24995f3059d81ccf945c7970a0ac3dd52153d200","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    /tmp/ubuntu-install-libvirt.sh ;\\"},{"line_number":30,"context_line":"    rm -rf /tmp/*"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"COPY ./cloud-archive.list /etc/apt/sources.list.d/"},{"line_number":33,"context_line":"COPY cloud-archive.gpg /etc/apt/trusted.gpg.d/"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN sed -i \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_fd1116b1","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":50},"updated":"2020-09-18 20:06:32.000000000","message":"and this is just gonna be removed by an echo \"...\" \u003e /etc/apt/sources.list.d/cloud-archive.list","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"24995f3059d81ccf945c7970a0ac3dd52153d200","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rm -rf /tmp/*"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"COPY ./cloud-archive.list /etc/apt/sources.list.d/"},{"line_number":33,"context_line":"COPY cloud-archive.gpg /etc/apt/trusted.gpg.d/"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN sed -i \\"},{"line_number":36,"context_line":"        -e \"s|%%UBUNTU_URL%%|${UBUNTU_URL}|g\" \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_3d338e64","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":46},"updated":"2020-09-18 20:06:32.000000000","message":"i would move this to after the COPY above","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"24995f3059d81ccf945c7970a0ac3dd52153d200","unresolved":false,"context_lines":[{"line_number":32,"context_line":"COPY ./cloud-archive.list /etc/apt/sources.list.d/"},{"line_number":33,"context_line":"COPY cloud-archive.gpg /etc/apt/trusted.gpg.d/"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN sed -i \\"},{"line_number":36,"context_line":"        -e \"s|%%UBUNTU_URL%%|${UBUNTU_URL}|g\" \\"},{"line_number":37,"context_line":"        -e \"s|%%CLOUD_ARCHIVE_URL%%|${CLOUD_ARCHIVE_URL}|g\" \\"},{"line_number":38,"context_line":"        /etc/apt/sources.list.d/cloud-archive.list"},{"line_number":39,"context_line":"RUN echo \"APT::Get::AllowUnauthenticated \\\"${ALLOW_UNAUTHENTICATED}\\\";\\n\\"},{"line_number":40,"context_line":"Acquire::AllowInsecureRepositories \\\"${ALLOW_UNAUTHENTICATED}\\\";\\n\\"},{"line_number":41,"context_line":"Acquire::AllowDowngradeToInsecureRepositories \\\"${ALLOW_UNAUTHENTICATED}\\\";\" \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_1d016a6b","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":50},"updated":"2020-09-18 20:06:32.000000000","message":"this is also not needed anymore","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        -e \"s|%%UBUNTU_URL%%|${UBUNTU_URL}|g\" \\"},{"line_number":37,"context_line":"        -e \"s|%%CLOUD_ARCHIVE_URL%%|${CLOUD_ARCHIVE_URL}|g\" \\"},{"line_number":38,"context_line":"        /etc/apt/sources.list.d/cloud-archive.list"},{"line_number":39,"context_line":"RUN echo \"APT::Get::AllowUnauthenticated \\\"${ALLOW_UNAUTHENTICATED}\\\";\\n\\"},{"line_number":40,"context_line":"Acquire::AllowInsecureRepositories \\\"${ALLOW_UNAUTHENTICATED}\\\";\\n\\"},{"line_number":41,"context_line":"Acquire::AllowDowngradeToInsecureRepositories \\\"${ALLOW_UNAUTHENTICATED}\\\";\" \\"},{"line_number":42,"context_line":"    \u003e\u003e /etc/apt/apt.conf.d/allow-unathenticated"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_ddb892c8","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":47},"updated":"2020-09-18 20:04:21.000000000","message":"which means this isn\u0027t needed","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"}],"libvirt/cloud-archive.gpg":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_1db32aeb","line":1,"updated":"2020-09-18 20:04:21.000000000","message":"i think you wget the file instead of the raw file ;)","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"}],"libvirt/cloud-archive.list":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4e8fded43d4d085c6beec62e563d99ea76eb19c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"deb %%CLOUD_ARCHIVE_URL%% bionic-updates/ussuri main"}],"source_content_type":"text/plain","patch_set":4,"id":"9f560f44_7dc98658","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":52},"updated":"2020-09-18 20:04:21.000000000","message":"instead of this file, i would do something like use an echo directly in the Dockerfile","commit_id":"4a33b6d63bddc49c1c8fe79e501f5468f5b108c3"}]}