)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33330,"name":"Karl Kloppenborg","email":"k@rl.ag","username":"karl_kloppenborg"},"change_message_id":"33b28b6994705662de0b469b5b1163925772e39e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7aeb5c38_58e28068","updated":"2023-05-10 04:43:39.000000000","message":"recheck","commit_id":"7e20cd721bdc6d22888b95cea8466729ef155934"}],"openvswitch/Dockerfile.ubuntu_bionic-dpdk":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"77492a114961ebcdf9492a915b8d9cf7e0481945","unresolved":true,"context_lines":[{"line_number":1,"context_line":"ARG FROM\u003ddocker.io/ubuntu:focal"},{"line_number":2,"context_line":"FROM ${FROM}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"cheng1.li@intel.com\""},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f86f949_9367a085","line":1,"updated":"2023-04-11 17:12:14.000000000","message":"If you change base image I would say you\u0027d better rename the Dockerfile as well\nNow it is Dockerfile.ubutnu_bionic-dpdk","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":33330,"name":"Karl Kloppenborg","email":"k@rl.ag","username":"karl_kloppenborg"},"change_message_id":"6d141e6c890bc9209ad8f24c05138901d96b778a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG FROM\u003ddocker.io/ubuntu:focal"},{"line_number":2,"context_line":"FROM ${FROM}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"cheng1.li@intel.com\""},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4dd393f5_8ab40e55","line":1,"in_reply_to":"1f86f949_9367a085","updated":"2023-04-12 23:39:53.000000000","message":"Ack","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"77492a114961ebcdf9492a915b8d9cf7e0481945","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# Any extra compile-time flags for DPDK"},{"line_number":29,"context_line":"ARG DPDK_EXTRA_COMPILE_FLAGS\u003d\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ADD Dockerfile.ubuntu_bionic-dpdk ${OVS_PATCH_FILE_NAME}* ${DPDK_PATCH_FILE_NAME}* ./"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN set -ex;\\"},{"line_number":34,"context_line":"    rm -rf Dockerfile.ubuntu_bionic-dpdk ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6b6ea15a_6a7120c0","line":31,"updated":"2023-04-11 17:12:14.000000000","message":"And here also Dockerfile.ubuntu_focal-dpdk","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"77492a114961ebcdf9492a915b8d9cf7e0481945","unresolved":true,"context_lines":[{"line_number":31,"context_line":"ADD Dockerfile.ubuntu_bionic-dpdk ${OVS_PATCH_FILE_NAME}* ${DPDK_PATCH_FILE_NAME}* ./"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN set -ex;\\"},{"line_number":34,"context_line":"    rm -rf Dockerfile.ubuntu_bionic-dpdk ;\\"},{"line_number":35,"context_line":"    apt-get update; \\"},{"line_number":36,"context_line":"    if [ -n \"$OVS_SRC_COMPILE_VERSION\" -a -n \"$DPDK_SRC_COMPILE_VERSION\" ]; then \\"},{"line_number":37,"context_line":"      if [ -n \"$OVS_PATCH_FILE_NAME\" ]; then \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"74b397c9_e3436396","line":34,"updated":"2023-04-11 17:12:14.000000000","message":"ditto\n\nIMO this is weird when we add Dockerfile into docker image file system and immediately after that we remove it. \n\nAlso it seems there is no python-twisted-conch package in Focal and it is only needed during DPDK compilation. Let\u0027s try to remove it.","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"989a81f2ac9617ce987a1a55492c5d2b120113b9","unresolved":true,"context_lines":[{"line_number":75,"context_line":"      fi ;\\"},{"line_number":76,"context_line":"      export DPDK_TARGET\u003dx86_64-native-linuxapp-gcc ;\\"},{"line_number":77,"context_line":"      export DPDK_BUILD\u003d${DPDK_DIR}/build ;\\"},{"line_number":78,"context_line":"      make config T\u003d${DPDK_TARGET} ;\\"},{"line_number":79,"context_line":"      cd ${DPDK_BUILD} ;\\"},{"line_number":80,"context_line":"      sed -i \u0027s/CONFIG_RTE_KNI_KMOD\u003d.*$/CONFIG_RTE_KNI_KMOD\u003dn/\u0027 .config ;\\"},{"line_number":81,"context_line":"      sed -i \u0027s/CONFIG_RTE_LIBRTE_KNI\u003d.*$/CONFIG_RTE_LIBRTE_KNI\u003dn/\u0027 .config ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"21f3b4e3_fc514d49","line":78,"updated":"2023-04-11 23:20:51.000000000","message":"This is not going to work with this DPDK version 22.11","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":33330,"name":"Karl Kloppenborg","email":"k@rl.ag","username":"karl_kloppenborg"},"change_message_id":"6d141e6c890bc9209ad8f24c05138901d96b778a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"      fi ;\\"},{"line_number":76,"context_line":"      export DPDK_TARGET\u003dx86_64-native-linuxapp-gcc ;\\"},{"line_number":77,"context_line":"      export DPDK_BUILD\u003d${DPDK_DIR}/build ;\\"},{"line_number":78,"context_line":"      make config T\u003d${DPDK_TARGET} ;\\"},{"line_number":79,"context_line":"      cd ${DPDK_BUILD} ;\\"},{"line_number":80,"context_line":"      sed -i \u0027s/CONFIG_RTE_KNI_KMOD\u003d.*$/CONFIG_RTE_KNI_KMOD\u003dn/\u0027 .config ;\\"},{"line_number":81,"context_line":"      sed -i \u0027s/CONFIG_RTE_LIBRTE_KNI\u003d.*$/CONFIG_RTE_LIBRTE_KNI\u003dn/\u0027 .config ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d99cc4c5_817ff168","line":78,"in_reply_to":"21f3b4e3_fc514d49","updated":"2023-04-12 23:39:53.000000000","message":"Can you elaborate on this?","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"9719cfe092e9e74db23bd84725cd05ebf5868893","unresolved":true,"context_lines":[{"line_number":75,"context_line":"      fi ;\\"},{"line_number":76,"context_line":"      export DPDK_TARGET\u003dx86_64-native-linuxapp-gcc ;\\"},{"line_number":77,"context_line":"      export DPDK_BUILD\u003d${DPDK_DIR}/build ;\\"},{"line_number":78,"context_line":"      make config T\u003d${DPDK_TARGET} ;\\"},{"line_number":79,"context_line":"      cd ${DPDK_BUILD} ;\\"},{"line_number":80,"context_line":"      sed -i \u0027s/CONFIG_RTE_KNI_KMOD\u003d.*$/CONFIG_RTE_KNI_KMOD\u003dn/\u0027 .config ;\\"},{"line_number":81,"context_line":"      sed -i \u0027s/CONFIG_RTE_LIBRTE_KNI\u003d.*$/CONFIG_RTE_LIBRTE_KNI\u003dn/\u0027 .config ;\\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"24032a80_722cde8b","line":78,"in_reply_to":"d99cc4c5_817ff168","updated":"2023-04-13 00:36:24.000000000","message":"There is no such target in the Makefile in this version. I tried this and it failed. See for example https://zuul.opendev.org/t/openstack/build/82f43b4df13448198bf955a3c4c2126a","commit_id":"a03ccae9e56446d8ce87b4e9612235479207298b"}]}