)]}'
{"openvswitch/Dockerfile.ubuntu":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"da0cbfa57322f758ac34eb61d353c1628f895f33","unresolved":true,"context_lines":[{"line_number":5,"context_line":"ENV TINI_VERSION v0.19.0"},{"line_number":6,"context_line":"ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini"},{"line_number":7,"context_line":"RUN chmod +x /tini"},{"line_number":8,"context_line":"ENTRYPOINT [\"/tini\", \"--\"]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN set -ex \u0026\u0026 \\"},{"line_number":11,"context_line":"    apt-get update \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1759638a_d4213ba6","line":8,"updated":"2024-05-30 09:58:54.000000000","message":"Do we really need to change the default ubuntu entrypoint? Looks like it is enough to just install the tini binary and then we can use it in the start scripts here https://opendev.org/openstack/openstack-helm-infra/src/branch/master/openvswitch/templates/daemonset.yaml#L135-L136 and https://opendev.org/openstack/openstack-helm-infra/src/branch/master/openvswitch/templates/daemonset.yaml#L172-L173\n\nAnyway this entrypoint will not be used since we redefine it (see above links)","commit_id":"48e457b9140393f537a3ec92c4b09b0db5813062"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8b4c113004fc67fa3a6a81c55a80d72fb79eeff3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"ENV TINI_VERSION v0.19.0"},{"line_number":6,"context_line":"ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini"},{"line_number":7,"context_line":"RUN chmod +x /tini"},{"line_number":8,"context_line":"ENTRYPOINT [\"/tini\", \"--\"]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN set -ex \u0026\u0026 \\"},{"line_number":11,"context_line":"    apt-get update \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8214101a_4322ff3f","line":8,"in_reply_to":"1759638a_d4213ba6","updated":"2024-05-30 10:16:51.000000000","message":"The pod container command field corresponds to the Dockerfile ENTRYPOINT args field corresponds to the Dockerfile CMD. Let\u0027s leave the image entrypoint untouched. And instead in the ovs daemonset define \n```\ncommand:\n  - tini\n  - --\nargs:\n  - /tmp/openvswitch-vswitchd.sh\n  - start\n```","commit_id":"48e457b9140393f537a3ec92c4b09b0db5813062"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"eb8fca4bfc99fa01412d0d8e489b60c480166359","unresolved":false,"context_lines":[{"line_number":5,"context_line":"ENV TINI_VERSION v0.19.0"},{"line_number":6,"context_line":"ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini"},{"line_number":7,"context_line":"RUN chmod +x /tini"},{"line_number":8,"context_line":"ENTRYPOINT [\"/tini\", \"--\"]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN set -ex \u0026\u0026 \\"},{"line_number":11,"context_line":"    apt-get update \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"58414ed4_15531512","line":8,"in_reply_to":"8214101a_4322ff3f","updated":"2024-05-30 16:08:50.000000000","message":"Done","commit_id":"48e457b9140393f537a3ec92c4b09b0db5813062"}]}
