)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"df998e884f92c97d7f2b9f8d97da036f7a046040","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Wilkerson \u003cwilkers.steve@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-16 09:02:16 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":Nagios Chart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the nagios chart to osh-infra to provide additional"},{"line_number":10,"context_line":"monitoring functionality. It uses helper functions to consume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"df7087c5_a13e99b5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2018-03-22 19:24:51.000000000","message":"leading : ?","commit_id":"73599fb562da8fc515c15e828a9d3268d1f88912"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"57d940f68bc7047835c2dfea0706b4648d3e056d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Wilkerson \u003cwilkers.steve@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-16 09:02:16 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":Nagios Chart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds the nagios chart to osh-infra to provide additional"},{"line_number":10,"context_line":"monitoring functionality. It uses helper functions to consume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"df7087c5_997e57e2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"df7087c5_a13e99b5","updated":"2018-03-23 13:46:25.000000000","message":"you dont know about the :Nagios vim command?\n\nJust kidding, done","commit_id":"73599fb562da8fc515c15e828a9d3268d1f88912"}],"nagios/templates/configmap-etc.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7d0eaf864a603347bfa39e13d4716f9b2de0684a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  nagios.cfg: |+"},{"line_number":26,"context_line":"{{- tuple .Values.conf.nagios \"etc/_nagios.cfg.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"},{"line_number":27,"context_line":"  nagios_objects.cfg: |+"},{"line_number":28,"context_line":"{{- tuple \"host\" .Values.conf.nagios.hosts | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":29,"context_line":"{{- tuple \"hostgroup\" .Values.conf.nagios.host_groups | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":30,"context_line":"{{- tuple \"command\" .Values.conf.nagios.commands | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":31,"context_line":"{{- tuple \"service\" .Values.conf.nagios.services | include \"nagios.object_definition\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_8b9f544f","line":28,"updated":"2018-03-01 10:40:14.000000000","message":"Would it make more sense to put walk anything in Values.conf.nagios in a template vs specifically building it here in the configmap so we can future proof the addition of potentially new sections?  In other words treat nagios_objects.cfg like nagios.cfg","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"90279089f6189368e851c3b351ae48c9f19fbdcc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  nagios.cfg: |+"},{"line_number":26,"context_line":"{{- tuple .Values.conf.nagios \"etc/_nagios.cfg.tpl\" . | include \"helm-toolkit.utils.configmap_templater\" }}"},{"line_number":27,"context_line":"  nagios_objects.cfg: |+"},{"line_number":28,"context_line":"{{- tuple \"host\" .Values.conf.nagios.hosts | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":29,"context_line":"{{- tuple \"hostgroup\" .Values.conf.nagios.host_groups | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":30,"context_line":"{{- tuple \"command\" .Values.conf.nagios.commands | include \"nagios.object_definition\" | indent 4 }}"},{"line_number":31,"context_line":"{{- tuple \"service\" .Values.conf.nagios.services | include \"nagios.object_definition\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_d10d063f","line":28,"in_reply_to":"1f9dbf25_8b9f544f","updated":"2018-03-01 16:09:23.000000000","message":"I can see value in both.  If we want to statically define Nagios\u0027s host groups, services and commands, then a template makes sense.  If we want to provide the ability to dynamically generate those objects, then driving them with values and a helper function makes sense. I\u0027m open to either approach here.","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"}],"nagios/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7d0eaf864a603347bfa39e13d4716f9b2de0684a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":23,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":24,"context_line":"  pull_policy: IfNotPresent"},{"line_number":25,"context_line":"  local_registry:"},{"line_number":26,"context_line":"    active: false"},{"line_number":27,"context_line":"    exclude:"},{"line_number":28,"context_line":"      - dep_check"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_4b04ec17","line":25,"updated":"2018-03-01 10:40:14.000000000","message":"This seems to be a new paradigm? I don\u0027t see this in any existing chart.","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"3d9a68f050a4da2bcc2ed1f042cb56e0fb8de777","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":23,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":24,"context_line":"  pull_policy: IfNotPresent"},{"line_number":25,"context_line":"  local_registry:"},{"line_number":26,"context_line":"    active: false"},{"line_number":27,"context_line":"    exclude:"},{"line_number":28,"context_line":"      - dep_check"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_9e59d0ff","line":25,"in_reply_to":"1f9dbf25_4b04ec17","updated":"2018-03-01 10:44:49.000000000","message":"This appears to be common in infra but not in openstack-helm proper.  Just a divergence nit but not the nagios charts fault.","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"90279089f6189368e851c3b351ae48c9f19fbdcc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":23,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":24,"context_line":"  pull_policy: IfNotPresent"},{"line_number":25,"context_line":"  local_registry:"},{"line_number":26,"context_line":"    active: false"},{"line_number":27,"context_line":"    exclude:"},{"line_number":28,"context_line":"      - dep_check"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_d1dae6e7","line":25,"in_reply_to":"1f9dbf25_9e59d0ff","updated":"2018-03-01 16:09:23.000000000","message":"Yeah, this is a divergence I\u0027d hope will be resolved when we standardize on a single helm-toolkit version, as deltas still exist between osh and osh-infra\u0027s versions","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7d0eaf864a603347bfa39e13d4716f9b2de0684a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  node_selector_key: openstack-control-plane"},{"line_number":33,"context_line":"  node_selector_value: enabled"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"dependencies:"},{"line_number":36,"context_line":"  dynamic:"},{"line_number":37,"context_line":"    common:"},{"line_number":38,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_de2758b6","line":35,"updated":"2018-03-01 10:40:14.000000000","message":"I\u0027m not quite sure how this would work - the repo sync job is dynamic, but image_repo_sync services are static? Maybe I\u0027m misreading.","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"90279089f6189368e851c3b351ae48c9f19fbdcc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  node_selector_key: openstack-control-plane"},{"line_number":33,"context_line":"  node_selector_value: enabled"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"dependencies:"},{"line_number":36,"context_line":"  dynamic:"},{"line_number":37,"context_line":"    common:"},{"line_number":38,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_91fd3e3c","line":35,"in_reply_to":"1f9dbf25_de2758b6","updated":"2018-03-01 16:09:23.000000000","message":"This is a bit confusing to me as well, but falls in line with the standard set in the other osh-infra charts. It would be good to address this as part of the values.yaml standardization discussions","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7d0eaf864a603347bfa39e13d4716f9b2de0684a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        service_description: \"Check Alertmanager replicas\""},{"line_number":177,"context_line":"        check_command: check_prometheus_extra_info!kube_statefulset_status_replicas{namespace\u003d\"openstack\",statefulset\u003d\"alertmanager\"}!3!2!alertmanager_replicas!lt"},{"line_number":178,"context_line":"        check_interval: 1"},{"line_number":179,"context_line":"    cfg: |-"},{"line_number":180,"context_line":"      ##############################################################################"},{"line_number":181,"context_line":"      #"},{"line_number":182,"context_line":"      # NAGIOS.CFG - Sample Main Config File for Nagios 4.3.2"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_be74cc9a","line":179,"updated":"2018-03-01 10:40:14.000000000","message":"We can\u0027t use our to_ini helm toolkit function here? Would make this all key,values in values.yaml vs a large blob.  The problem with large blobs is you can\u0027t really add/override/merge, you need to take ownership of the whole blob.","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"90279089f6189368e851c3b351ae48c9f19fbdcc","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        service_description: \"Check Alertmanager replicas\""},{"line_number":177,"context_line":"        check_command: check_prometheus_extra_info!kube_statefulset_status_replicas{namespace\u003d\"openstack\",statefulset\u003d\"alertmanager\"}!3!2!alertmanager_replicas!lt"},{"line_number":178,"context_line":"        check_interval: 1"},{"line_number":179,"context_line":"    cfg: |-"},{"line_number":180,"context_line":"      ##############################################################################"},{"line_number":181,"context_line":"      #"},{"line_number":182,"context_line":"      # NAGIOS.CFG - Sample Main Config File for Nagios 4.3.2"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_519576e3","line":179,"in_reply_to":"1f9dbf25_be74cc9a","updated":"2018-03-01 16:09:23.000000000","message":"Done. Nobody likes blobs","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"}],"tools/gate/chart-deploys/default.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7d0eaf864a603347bfa39e13d4716f9b2de0684a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  nagios:"},{"line_number":141,"context_line":"    chart_name: nagios"},{"line_number":142,"context_line":"    release: prometheus-nagios"},{"line_number":143,"context_line":"    namespace: openstack"},{"line_number":144,"context_line":"    values:"},{"line_number":145,"context_line":"      network:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_5e97c891","line":142,"updated":"2018-03-01 10:40:14.000000000","message":"I assume this stems from our discussion of having this interact predominately with prometheus to alert, but I think we\u0027ve already discovered cases where it may do a few things beyond that (e.g. check ceph for disaster recovery via more traditional nagios checks, as the LMA infra rides on top of ceph).  Simply put, it may not be correct to call this solely a \"prometheus-nagios\" ?","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"90279089f6189368e851c3b351ae48c9f19fbdcc","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  nagios:"},{"line_number":141,"context_line":"    chart_name: nagios"},{"line_number":142,"context_line":"    release: prometheus-nagios"},{"line_number":143,"context_line":"    namespace: openstack"},{"line_number":144,"context_line":"    values:"},{"line_number":145,"context_line":"      network:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f9dbf25_51bed665","line":142,"in_reply_to":"1f9dbf25_5e97c891","updated":"2018-03-01 16:09:23.000000000","message":"This was mostly just a result of tying the other monitoring services in osh-infra to prometheus. I\u0027ll change the name for clarity","commit_id":"40abf8532a635c9af6167e6a2711b9fc0c9180f3"}]}