)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bfe5419e27658b292e371c90d4e78e5a9f527434","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Provide additional flexibility for the calico chart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Ingests the bird templates so that we can override them"},{"line_number":10,"context_line":"to support things such as custom BGP ports (listen) and"},{"line_number":11,"context_line":"neighbors (remote)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Supports announcing addresses that are within the"},{"line_number":14,"context_line":".Values.networking.bgp.ipv4|6.additional_cidrs list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f96bb07_d5f7c258","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":18},"updated":"2018-01-16 21:02:11.000000000","message":"nit, formatting/indenting","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"}],"calico/templates/bin/_calico-settings.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# update if necessary"},{"line_number":18,"context_line":"if [ \"$MESH_VALUE\" !\u003d \"{{.Values.networking.settings.mesh}}\" ];"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"\t$CALICOCTL config set nodeToNodeMesh {{.Values.networking.settings.mesh}}"},{"line_number":21,"context_line":"fi;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# get asnumber value"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_7803ba43","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"updated":"2018-01-12 02:33:53.000000000","message":"Nit: tabs","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# update if necessary"},{"line_number":18,"context_line":"if [ \"$MESH_VALUE\" !\u003d \"{{.Values.networking.settings.mesh}}\" ];"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"\t$CALICOCTL config set nodeToNodeMesh {{.Values.networking.settings.mesh}}"},{"line_number":21,"context_line":"fi;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# get asnumber value"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_7123b706","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"7f96bb07_7803ba43","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bfe5419e27658b292e371c90d4e78e5a9f527434","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{{ set .Values.conf.node \"CALICO_IPV4POOL_CIDR\" .Values.networking.podSubnet | quote | trunc 0 }}"},{"line_number":7,"context_line":"{{ end }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# An idempotent script for interacting with calicoctl to instantiate peers, and manipulate calico settings"},{"line_number":10,"context_line":"# that we must perform post-deployment."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"CALICOCTL\u003d/calicoctl"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_359ce60c","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":4},"updated":"2018-01-16 21:02:11.000000000","message":"nit; wrap","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"99d00859420cbe482dca37dd503b71a194ca6de1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{{ set .Values.conf.node \"CALICO_IPV4POOL_CIDR\" .Values.networking.podSubnet | quote | trunc 0 }}"},{"line_number":7,"context_line":"{{ end }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# An idempotent script for interacting with calicoctl to instantiate "},{"line_number":10,"context_line":"# peers, and manipulate calico settings that we must perform "},{"line_number":11,"context_line":"# post-deployment."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":12,"id":"7f96bb07_cd0b9227","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":69},"updated":"2018-01-17 20:29:06.000000000","message":"nit; trailing ws","commit_id":"b2aedd8df37ff093e30ba617ffc1aa9643beed78"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"99d00859420cbe482dca37dd503b71a194ca6de1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{{ end }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# An idempotent script for interacting with calicoctl to instantiate "},{"line_number":10,"context_line":"# peers, and manipulate calico settings that we must perform "},{"line_number":11,"context_line":"# post-deployment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"CALICOCTL\u003d/calicoctl"}],"source_content_type":"text/x-smarty","patch_set":12,"id":"7f96bb07_30028d0b","line":10,"range":{"start_line":10,"start_character":60,"end_line":10,"end_character":61},"updated":"2018-01-17 20:29:06.000000000","message":"also","commit_id":"b2aedd8df37ff093e30ba617ffc1aa9643beed78"}],"calico/templates/bin/_install-calicoctl.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# instantiate calicoctl in /opt/bin/cni, including"},{"line_number":4,"context_line":"# a wrapper around the bin that points to the correct"},{"line_number":5,"context_line":"# etcd endpoint and etcd certificate data"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_186876f3","line":2,"updated":"2018-01-12 02:33:53.000000000","message":"set -e","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# instantiate calicoctl in /opt/bin/cni, including"},{"line_number":4,"context_line":"# a wrapper around the bin that points to the correct"},{"line_number":5,"context_line":"# etcd endpoint and etcd certificate data"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_311d2fbd","line":2,"in_reply_to":"7f96bb07_186876f3","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bfe5419e27658b292e371c90d4e78e5a9f527434","unresolved":false,"context_lines":[{"line_number":19,"context_line":"chmod +x /host/opt/cni/bin/calicoctl"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# sleep forever"},{"line_number":22,"context_line":"while [ 1 ]; do sleep 86400; done;"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_d58ca2d8","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":27},"updated":"2018-01-16 21:02:11.000000000","message":"sleep infinity?","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2ff407d53161a2e55ad07d0e41592f758f9ed688","unresolved":false,"context_lines":[{"line_number":19,"context_line":"chmod +x /host/opt/cni/bin/calicoctl"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# sleep forever"},{"line_number":22,"context_line":"while [ 1 ]; do sleep 86400; done;"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_cd5dd247","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":27},"in_reply_to":"7f96bb07_4df6a265","updated":"2018-01-17 20:28:03.000000000","message":"Done","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"da36c695620350e57f560d802eb12cab8e586e66","unresolved":false,"context_lines":[{"line_number":19,"context_line":"chmod +x /host/opt/cni/bin/calicoctl"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# sleep forever"},{"line_number":22,"context_line":"while [ 1 ]; do sleep 86400; done;"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_4df6a265","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":27},"in_reply_to":"7f96bb07_d58ca2d8","updated":"2018-01-17 20:24:24.000000000","message":"doesnt work with /bin/sh","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":25907,"name":"Mark Burnett","email":"mark.m.burnett@gmail.com","username":"mark-burnett"},"change_message_id":"3d5b0b8a41238128f89c48cab3e7b2758691d46b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# etcd endpoint and etcd certificate data"},{"line_number":8,"context_line":"cp /calicoctl /host/opt/cni/bin/calicoctl.bin"},{"line_number":9,"context_line":"chmod +x /host/opt/cni/bin/calicoctl.bin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"cat \u003c\u003cEOF\u003e/host/opt/cni/bin/calicoctl"},{"line_number":12,"context_line":"export ETCD_ENDPOINTS\u003d$ETCD_ENDPOINTS"},{"line_number":13,"context_line":"export ETCD_KEY_FILE\u003d$ETCD_KEY_FILE"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"5f93b717_fb7a02ef","line":10,"updated":"2018-01-30 13:56:04.000000000","message":"The certificates need to be copied to the host either here or in the install-cni container.","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7a6d8af36bced8c96373fca0621d9815bc1efce0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# etcd endpoint and etcd certificate data"},{"line_number":8,"context_line":"cp /calicoctl /host/opt/cni/bin/calicoctl.bin"},{"line_number":9,"context_line":"chmod +x /host/opt/cni/bin/calicoctl.bin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"cat \u003c\u003cEOF\u003e/host/opt/cni/bin/calicoctl"},{"line_number":12,"context_line":"export ETCD_ENDPOINTS\u003d$ETCD_ENDPOINTS"},{"line_number":13,"context_line":"export ETCD_KEY_FILE\u003d$ETCD_KEY_FILE"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"5f93b717_afe50f0b","line":10,"in_reply_to":"5f93b717_fb7a02ef","updated":"2018-01-30 16:32:10.000000000","message":"Done","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"},{"author":{"_account_id":25907,"name":"Mark Burnett","email":"mark.m.burnett@gmail.com","username":"mark-burnett"},"change_message_id":"3d5b0b8a41238128f89c48cab3e7b2758691d46b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"export ETCD_ENDPOINTS\u003d$ETCD_ENDPOINTS"},{"line_number":13,"context_line":"export ETCD_KEY_FILE\u003d$ETCD_KEY_FILE"},{"line_number":14,"context_line":"export ETCD_CERT_FILE\u003d$ETCD_CERT_FILE"},{"line_number":15,"context_line":"export ETCD_CA_CERT_FILE\u003d$ETCD_CA_CERT"},{"line_number":16,"context_line":"exec /opt/cni/bin/calicoctl.bin \\$*"},{"line_number":17,"context_line":"EOF"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":23,"id":"5f93b717_9b265e15","line":15,"updated":"2018-01-30 13:56:04.000000000","message":"Should be:\n\nETCD_CA_CERT_FILE\u003d$ETCD_CA_CERT_FILE","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7a6d8af36bced8c96373fca0621d9815bc1efce0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"export ETCD_ENDPOINTS\u003d$ETCD_ENDPOINTS"},{"line_number":13,"context_line":"export ETCD_KEY_FILE\u003d$ETCD_KEY_FILE"},{"line_number":14,"context_line":"export ETCD_CERT_FILE\u003d$ETCD_CERT_FILE"},{"line_number":15,"context_line":"export ETCD_CA_CERT_FILE\u003d$ETCD_CA_CERT"},{"line_number":16,"context_line":"exec /opt/cni/bin/calicoctl.bin \\$*"},{"line_number":17,"context_line":"EOF"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":23,"id":"5f93b717_6feb87db","line":15,"in_reply_to":"5f93b717_9b265e15","updated":"2018-01-30 16:32:10.000000000","message":"Done","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"}],"calico/templates/daemonset-calico-etcd.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      labels:"},{"line_number":42,"context_line":"        k8s-app: calico-etcd"},{"line_number":43,"context_line":"{{ tuple $envAll \"calico\" \"etcd\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"        # Mark this pod as a critical add-on; when enabled, the critical add-on scheduler"},{"line_number":47,"context_line":"        # reserves resources for critical add-on pods so that they can be rescheduled after"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_d871aee2","line":44,"updated":"2018-01-12 02:33:53.000000000","message":"ws","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      labels:"},{"line_number":42,"context_line":"        k8s-app: calico-etcd"},{"line_number":43,"context_line":"{{ tuple $envAll \"calico\" \"etcd\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"        # Mark this pod as a critical add-on; when enabled, the critical add-on scheduler"},{"line_number":47,"context_line":"        # reserves resources for critical add-on pods so that they can be rescheduled after"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_d1796bfc","line":44,"in_reply_to":"7f96bb07_d871aee2","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"}],"calico/templates/daemonset-calico-node.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":105,"context_line":"          operator: Exists"},{"line_number":106,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":107,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.node.timeout | default \"30\" }}      "},{"line_number":108,"context_line":"      initContainers:"},{"line_number":109,"context_line":"{{ tuple $envAll .Values.pod_dependency list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":110,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_d84a0e7f","line":107,"range":{"start_line":107,"start_character":117,"end_line":107,"end_character":123},"updated":"2018-01-12 02:33:53.000000000","message":"ws","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":105,"context_line":"          operator: Exists"},{"line_number":106,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":107,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.node.timeout | default \"30\" }}      "},{"line_number":108,"context_line":"      initContainers:"},{"line_number":109,"context_line":"{{ tuple $envAll .Values.pod_dependency list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":110,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_9183e3cc","line":107,"range":{"start_line":107,"start_character":117,"end_line":107,"end_character":123},"in_reply_to":"7f96bb07_d84a0e7f","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"              name: calico-etc"},{"line_number":180,"context_line":"              subPath: tunl-ip.template"},{"line_number":181,"context_line":"            - name: calico-certificates"},{"line_number":182,"context_line":"              mountPath: /etcd-ca"},{"line_number":183,"context_line":"              subPath: ca"},{"line_number":184,"context_line":"              readOnly: true"},{"line_number":185,"context_line":"            - name: calico-certificates"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b3a4030a","line":182,"range":{"start_line":182,"start_character":25,"end_line":182,"end_character":33},"updated":"2018-01-12 02:33:53.000000000","message":"can we put these somewhere sane? eg: /etc/calico/pki/* my OCD is triggered.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"830159d08526e113123e8b247355f4859f78c15b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"              name: calico-etc"},{"line_number":180,"context_line":"              subPath: tunl-ip.template"},{"line_number":181,"context_line":"            - name: calico-certificates"},{"line_number":182,"context_line":"              mountPath: /etcd-ca"},{"line_number":183,"context_line":"              subPath: ca"},{"line_number":184,"context_line":"              readOnly: true"},{"line_number":185,"context_line":"            - name: calico-certificates"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_6eb506cd","line":182,"range":{"start_line":182,"start_character":25,"end_line":182,"end_character":33},"in_reply_to":"7f96bb07_4b3b5cea","updated":"2018-01-14 16:30:01.000000000","message":"Now that makes sense.  Intuitively I respect paths where I anticipate SELinux/AppArmor, and ignore it where its likely not to have an impact.  It may be wiser to adopt a more \"forward looking\" approach.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ee2f7eb3e4fda0f4baa477b596b66ad17c4d9ac1","unresolved":false,"context_lines":[{"line_number":179,"context_line":"              name: calico-etc"},{"line_number":180,"context_line":"              subPath: tunl-ip.template"},{"line_number":181,"context_line":"            - name: calico-certificates"},{"line_number":182,"context_line":"              mountPath: /etcd-ca"},{"line_number":183,"context_line":"              subPath: ca"},{"line_number":184,"context_line":"              readOnly: true"},{"line_number":185,"context_line":"            - name: calico-certificates"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_4b3b5cea","line":182,"range":{"start_line":182,"start_character":25,"end_line":182,"end_character":33},"in_reply_to":"7f96bb07_71689720","updated":"2018-01-14 14:34:05.000000000","message":"here probably not, but (for example) SELinux doesn\u0027t care about cgroups - which has caught me out on enforcing systems with apache config files...","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"              name: calico-etc"},{"line_number":180,"context_line":"              subPath: tunl-ip.template"},{"line_number":181,"context_line":"            - name: calico-certificates"},{"line_number":182,"context_line":"              mountPath: /etcd-ca"},{"line_number":183,"context_line":"              subPath: ca"},{"line_number":184,"context_line":"              readOnly: true"},{"line_number":185,"context_line":"            - name: calico-certificates"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_71689720","line":182,"range":{"start_line":182,"start_character":25,"end_line":182,"end_character":33},"in_reply_to":"7f96bb07_b3a4030a","updated":"2018-01-13 00:42:37.000000000","message":"I guess. Moved.  Does it really matter in a container world?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # and CNI network config file on each node."},{"line_number":195,"context_line":"        - name: install-cni"},{"line_number":196,"context_line":"{{ tuple $envAll \"calico_cni\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":197,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_cni | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":198,"context_line":"          command: [\"/install-cni.sh\"]"},{"line_number":199,"context_line":"          env:"},{"line_number":200,"context_line":"            # The location of the Calico etcd cluster."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b83aa2e4","line":197,"range":{"start_line":197,"start_character":126,"end_line":197,"end_character":136},"updated":"2018-01-12 02:33:53.000000000","message":"ws","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # and CNI network config file on each node."},{"line_number":195,"context_line":"        - name: install-cni"},{"line_number":196,"context_line":"{{ tuple $envAll \"calico_cni\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":197,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_cni | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":198,"context_line":"          command: [\"/install-cni.sh\"]"},{"line_number":199,"context_line":"          env:"},{"line_number":200,"context_line":"            # The location of the Calico etcd cluster."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_f1ca6718","line":197,"range":{"start_line":197,"start_character":126,"end_line":197,"end_character":136},"in_reply_to":"7f96bb07_b83aa2e4","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"              name: cni-bin-dir"},{"line_number":215,"context_line":"            - mountPath: /host/etc/cni/net.d"},{"line_number":216,"context_line":"              name: cni-net-dir"},{"line_number":217,"context_line":"        - name: install-calicoctl"},{"line_number":218,"context_line":"{{ tuple $envAll \"calico_ctl\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":219,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_ctl | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":220,"context_line":"          command:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_f8190a88","line":217,"updated":"2018-01-12 02:33:53.000000000","message":"Can we make this optional?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"              name: cni-bin-dir"},{"line_number":215,"context_line":"            - mountPath: /host/etc/cni/net.d"},{"line_number":216,"context_line":"              name: cni-net-dir"},{"line_number":217,"context_line":"        - name: install-calicoctl"},{"line_number":218,"context_line":"{{ tuple $envAll \"calico_ctl\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":219,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_ctl | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":220,"context_line":"          command:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_91d1a3d0","line":217,"in_reply_to":"7f96bb07_f8190a88","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"              name: cni-net-dir"},{"line_number":217,"context_line":"        - name: install-calicoctl"},{"line_number":218,"context_line":"{{ tuple $envAll \"calico_ctl\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":219,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_ctl | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":220,"context_line":"          command:"},{"line_number":221,"context_line":"            - /tmp/install-calicoctl.sh"},{"line_number":222,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_9821e6b7","line":219,"range":{"start_line":219,"start_character":126,"end_line":219,"end_character":136},"updated":"2018-01-12 02:33:53.000000000","message":"ws","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"              name: cni-net-dir"},{"line_number":217,"context_line":"        - name: install-calicoctl"},{"line_number":218,"context_line":"{{ tuple $envAll \"calico_ctl\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":219,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_ctl | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}          "},{"line_number":220,"context_line":"          command:"},{"line_number":221,"context_line":"            - /tmp/install-calicoctl.sh"},{"line_number":222,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b1d4dfbe","line":219,"range":{"start_line":219,"start_character":126,"end_line":219,"end_character":136},"in_reply_to":"7f96bb07_9821e6b7","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bfe5419e27658b292e371c90d4e78e5a9f527434","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":105,"context_line":"          operator: Exists"},{"line_number":106,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":107,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.node.timeout | default \"30\" }}"},{"line_number":108,"context_line":"      initContainers:"},{"line_number":109,"context_line":"{{ tuple $envAll .Values.pod_dependency list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":110,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_15b0ca89","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":35},"updated":"2018-01-16 21:02:11.000000000","message":"needed?","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2ff407d53161a2e55ad07d0e41592f758f9ed688","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":105,"context_line":"          operator: Exists"},{"line_number":106,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":107,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.node.timeout | default \"30\" }}"},{"line_number":108,"context_line":"      initContainers:"},{"line_number":109,"context_line":"{{ tuple $envAll .Values.pod_dependency list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":110,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_cd74f2d1","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":35},"in_reply_to":"7f96bb07_0dec1a8d","updated":"2018-01-17 20:28:03.000000000","message":"maybe remove it then?\n\ni also see calico (helm chart) take a long time to delete, this looks to be helm cleaning up resources in a serialize manner and blocking until things are done\n\ndeleting calico from k8s directly (kubectl delete -f ... ) is pretty fast","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"da36c695620350e57f560d802eb12cab8e586e66","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":105,"context_line":"          operator: Exists"},{"line_number":106,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":107,"context_line":"      terminationGracePeriodSeconds: {{ .Values.pod.lifecycle.termination_grace_period.node.timeout | default \"30\" }}"},{"line_number":108,"context_line":"      initContainers:"},{"line_number":109,"context_line":"{{ tuple $envAll .Values.pod_dependency list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":110,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_0dec1a8d","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":35},"in_reply_to":"7f96bb07_15b0ca89","updated":"2018-01-17 20:24:24.000000000","message":"Added because calico takes years to delete.  This didn\u0027t solve it.","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":25907,"name":"Mark Burnett","email":"mark.m.burnett@gmail.com","username":"mark-burnett"},"change_message_id":"3d5b0b8a41238128f89c48cab3e7b2758691d46b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        - name: install-cni"},{"line_number":200,"context_line":"{{ tuple $envAll \"calico_cni\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":201,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.calico_cni | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":202,"context_line":"          command: [\"/install-cni.sh\"]"},{"line_number":203,"context_line":"          env:"},{"line_number":204,"context_line":"            # The location of the Calico etcd cluster."},{"line_number":205,"context_line":"            - name: ETCD_ENDPOINTS"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f93b717_5b71b60b","line":202,"updated":"2018-01-30 13:56:04.000000000","message":"Repeated comment:\n\nEither this or install-calicoctl need to copy the certs into place on the host.","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"}],"calico/templates/deployment-calico-kube-controllers.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  replicas: 1"},{"line_number":71,"context_line":"  strategy:"},{"line_number":72,"context_line":"    type: Recreate"},{"line_number":73,"context_line":"  # The policy controller can only have a single active instance."},{"line_number":74,"context_line":"  replicas: {{ .Values.pod.replicas.policy_controller }}"},{"line_number":75,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"},{"line_number":76,"context_line":"  template:"},{"line_number":77,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_13893774","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":56},"updated":"2018-01-12 02:33:53.000000000","message":"do we need to expose this knob?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  replicas: 1"},{"line_number":71,"context_line":"  strategy:"},{"line_number":72,"context_line":"    type: Recreate"},{"line_number":73,"context_line":"  # The policy controller can only have a single active instance."},{"line_number":74,"context_line":"  replicas: {{ .Values.pod.replicas.policy_controller }}"},{"line_number":75,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"},{"line_number":76,"context_line":"  template:"},{"line_number":77,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b1113faf","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":56},"in_reply_to":"7f96bb07_13893774","updated":"2018-01-13 00:42:37.000000000","message":"Removed","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":25907,"name":"Mark Burnett","email":"mark.m.burnett@gmail.com","username":"mark-burnett"},"change_message_id":"3d5b0b8a41238128f89c48cab3e7b2758691d46b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":118,"context_line":"            # service for API access."},{"line_number":119,"context_line":"            - name: K8S_API"},{"line_number":120,"context_line":"              value: \"https://kubernetes.default:443\""},{"line_number":121,"context_line":"            # Choose which controllers to run."},{"line_number":122,"context_line":"            - name: ENABLED_CONTROLLERS"},{"line_number":123,"context_line":"              value: policy,profile,workloadendpoint,node"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f93b717_9bf89e7b","line":120,"updated":"2018-01-30 13:56:04.000000000","message":"I know this is unchanged in here, but it would be nice to be able to configure this.  Since the controller is running in host network mode, this value relies on host DNS being configured to resolve short cluster names.\n\nI presume it\u0027s considered OK for this controller to fail until cluster DNS is available.","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"7a6d8af36bced8c96373fca0621d9815bc1efce0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":118,"context_line":"            # service for API access."},{"line_number":119,"context_line":"            - name: K8S_API"},{"line_number":120,"context_line":"              value: \"https://kubernetes.default:443\""},{"line_number":121,"context_line":"            # Choose which controllers to run."},{"line_number":122,"context_line":"            - name: ENABLED_CONTROLLERS"},{"line_number":123,"context_line":"              value: policy,profile,workloadendpoint,node"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f93b717_8fd13326","line":120,"in_reply_to":"5f93b717_9bf89e7b","updated":"2018-01-30 16:32:10.000000000","message":"Done","commit_id":"60c762bfc03e1e048d1824093d9bb876d5953702"}],"calico/templates/etc/bird/_bird.cfg.mesh.template.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bfe5419e27658b292e371c90d4e78e5a9f527434","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Configure synchronization between routing tables and kernel."},{"line_number":21,"context_line":"protocol kernel {"},{"line_number":22,"context_line":"  learn;             # Learn all alien routes from the kernel"},{"line_number":23,"context_line":"  persist;           # Don\u0027t remove routes on bird shutdown"},{"line_number":24,"context_line":"  scan time 2;       # Scan kernel routing table every 2 seconds"},{"line_number":25,"context_line":"  import all;"},{"line_number":26,"context_line":"  export filter calico_ipip; # Default is export none"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_d57a62b8","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":9},"updated":"2018-01-16 21:02:11.000000000","message":"is the logic here that on upgrade/changes we keep networking as stable as possible?","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2ff407d53161a2e55ad07d0e41592f758f9ed688","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Configure synchronization between routing tables and kernel."},{"line_number":21,"context_line":"protocol kernel {"},{"line_number":22,"context_line":"  learn;             # Learn all alien routes from the kernel"},{"line_number":23,"context_line":"  persist;           # Don\u0027t remove routes on bird shutdown"},{"line_number":24,"context_line":"  scan time 2;       # Scan kernel routing table every 2 seconds"},{"line_number":25,"context_line":"  import all;"},{"line_number":26,"context_line":"  export filter calico_ipip; # Default is export none"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_ed444e76","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":9},"in_reply_to":"7f96bb07_6dfcbe3d","updated":"2018-01-17 20:28:03.000000000","message":"Done","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"da36c695620350e57f560d802eb12cab8e586e66","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Configure synchronization between routing tables and kernel."},{"line_number":21,"context_line":"protocol kernel {"},{"line_number":22,"context_line":"  learn;             # Learn all alien routes from the kernel"},{"line_number":23,"context_line":"  persist;           # Don\u0027t remove routes on bird shutdown"},{"line_number":24,"context_line":"  scan time 2;       # Scan kernel routing table every 2 seconds"},{"line_number":25,"context_line":"  import all;"},{"line_number":26,"context_line":"  export filter calico_ipip; # Default is export none"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"7f96bb07_6dfcbe3d","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":9},"in_reply_to":"7f96bb07_d57a62b8","updated":"2018-01-17 20:24:24.000000000","message":"Yes, and this is a calico default","commit_id":"55abf23784eff774fc123d0adfa8e5bb2dc3b689"}],"calico/templates/secret-certificates.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b01c15f86d731aac11adf2fcdb51791836f72488","unresolved":false,"context_lines":[{"line_number":21,"context_line":"kind: Secret"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-certificates"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b39e4305","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":12},"updated":"2018-01-12 02:54:45.000000000","message":"kubernetes.io/tls","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"kind: Secret"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-certificates"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_114913cf","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":12},"in_reply_to":"7f96bb07_b39e4305","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b01c15f86d731aac11adf2fcdb51791836f72488","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: calico-certificates"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_53a81f1e","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":4},"updated":"2018-01-12 02:54:45.000000000","message":"though not specced, would it make sense to use \u0027tls.key\u0027 here?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: calico-certificates"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_d1140ba3","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":4},"in_reply_to":"7f96bb07_53a81f1e","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b01c15f86d731aac11adf2fcdb51791836f72488","unresolved":false,"context_lines":[{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_b3b72387","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":5},"updated":"2018-01-12 02:54:45.000000000","message":"tls.key","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_f117c7a2","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":5},"in_reply_to":"7f96bb07_b3b72387","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: calico-certificates"},{"line_number":24,"context_line":"type: Opaque"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_13ee1722","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":61},"updated":"2018-01-12 02:33:53.000000000","message":"in all other charts we have kept credentials in the endpoint section to separate concerns - would it be possible to do the same here?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b01c15f86d731aac11adf2fcdb51791836f72488","unresolved":false,"context_lines":[{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_938547b0","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":13},"updated":"2018-01-12 02:54:45.000000000","message":"tls.crt","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  ca: {{ .Values.conf.etcd.credentials.ca}}"},{"line_number":27,"context_line":"  key: {{ .Values.conf.etcd.credentials.key}}"},{"line_number":28,"context_line":"  certificate: {{ .Values.conf.etcd.credentials.certificate}}"},{"line_number":29,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_910e838b","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":13},"in_reply_to":"7f96bb07_938547b0","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"99d00859420cbe482dca37dd503b71a194ca6de1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  tls.crt: |+"},{"line_number":32,"context_line":"{{ .Values.endpoints.etcd.auth.client.tls.crt | indent 4 }}"},{"line_number":33,"context_line":"{{ end }}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f96bb07_d0100951","line":34,"updated":"2018-01-17 20:29:06.000000000","message":"ws","commit_id":"b2aedd8df37ff093e30ba617ffc1aa9643beed78"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"90bdc6013d15606dc1d25a9c0d78f41f7fecfe22","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  name: calico-certificates"},{"line_number":25,"context_line":"type: kubernetes.io/tls"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"  tls.ca: {{ .Values.endpoints.etcd.auth.client.tls.ca | b64enc }}"},{"line_number":28,"context_line":"  tls.key: {{ .Values.endpoints.etcd.auth.client.tls.key | b64enc }}"},{"line_number":29,"context_line":"  tls.crt: {{ .Values.endpoints.etcd.auth.client.tls.crt | b64enc }}"},{"line_number":30,"context_line":"{{ end }}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7f96bb07_c667efe8","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":66},"updated":"2018-01-17 21:53:50.000000000","message":"as mentioned before, unclear if values should have b64 data in which case this is indent or if it\u0027s bin and needs it\n\ni have \"\" and using b64enc now to get it working\n\n@alan; values.yaml has null - do you want to {{ if }} {{ end }} and elide in that case?","commit_id":"59eeee317049775421e655d8e89ff838cb70a9b3"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"eb34b2b60d57eec854deeae6f19774f0d46e56fe","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  name: calico-certificates"},{"line_number":25,"context_line":"type: kubernetes.io/tls"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"  tls.ca: |+"},{"line_number":28,"context_line":"{{ .Values.endpoints.etcd.auth.client.tls.ca | default \"\" | b64enc | indent 4 }}"},{"line_number":29,"context_line":"  tls.key: |+"},{"line_number":30,"context_line":"{{ .Values.endpoints.etcd.auth.client.tls.key | default \"\" | b64enc | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f96bb07_9dcfa6af","line":27,"updated":"2018-01-20 17:47:50.000000000","message":"in k8s \u003e\u003d 1.8 it often balks at multiline secrets :(","commit_id":"0a9d22210a9c4cb87baa90f41561dd04288052a7"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ca0a5d97ea6e3487e187e03d399969ba6d1b383d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"type: kubernetes.io/tls"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"  tls.ca: |+"},{"line_number":28,"context_line":"{{ .Values.endpoints.etcd.auth.client.tls.ca | default \"\" | b64enc | indent 4 }}"},{"line_number":29,"context_line":"  tls.key: |+"},{"line_number":30,"context_line":"{{ .Values.endpoints.etcd.auth.client.tls.key | default \"\" | b64enc | indent 4 }}"},{"line_number":31,"context_line":"  tls.crt: |+"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f96bb07_d209a695","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":80},"updated":"2018-01-19 18:55:07.000000000","message":"it\u0027s not clear to me that b64enc is needed\n\nsurely if we give certs in values.yaml ... the cleanest way to specify those will be to have them base64 encoded already?  this would be useful if they weren\u0027t","commit_id":"0a9d22210a9c4cb87baa90f41561dd04288052a7"}],"calico/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        limits:"},{"line_number":63,"context_line":"          memory: \"1024Mi\""},{"line_number":64,"context_line":"          cpu: \"2000m\""},{"line_number":65,"context_line":"      calico_settingsgcx z:"},{"line_number":66,"context_line":"        requests:"},{"line_number":67,"context_line":"          memory: \"128Mi\""},{"line_number":68,"context_line":"          cpu: \"100m\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_73dc3b74","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":26},"updated":"2018-01-12 02:33:53.000000000","message":"typo?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        limits:"},{"line_number":63,"context_line":"          memory: \"1024Mi\""},{"line_number":64,"context_line":"          cpu: \"2000m\""},{"line_number":65,"context_line":"      calico_settingsgcx z:"},{"line_number":66,"context_line":"        requests:"},{"line_number":67,"context_line":"          memory: \"128Mi\""},{"line_number":68,"context_line":"          cpu: \"100m\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_91352349","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":26},"in_reply_to":"7f96bb07_73dc3b74","updated":"2018-01-13 00:42:37.000000000","message":"Angry typing.  Removed.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          cpu: \"2000m\""},{"line_number":107,"context_line":"  replicas:"},{"line_number":108,"context_line":"    policy_controller: 1"},{"line_number":109,"context_line":"    etcd: 3"},{"line_number":110,"context_line":"  lifecycle:"},{"line_number":111,"context_line":"    upgrades:"},{"line_number":112,"context_line":"      deployments:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_13529714","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":11},"updated":"2018-01-12 02:33:53.000000000","message":"is this used?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          cpu: \"2000m\""},{"line_number":107,"context_line":"  replicas:"},{"line_number":108,"context_line":"    policy_controller: 1"},{"line_number":109,"context_line":"    etcd: 3"},{"line_number":110,"context_line":"  lifecycle:"},{"line_number":111,"context_line":"    upgrades:"},{"line_number":112,"context_line":"      deployments:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_f12ee7f8","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":11},"in_reply_to":"7f96bb07_13529714","updated":"2018-01-13 00:42:37.000000000","message":"Clearly not with a daemonset, removed.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    scheme:"},{"line_number":167,"context_line":"      default: http"},{"line_number":168,"context_line":"    path:"},{"line_number":169,"context_line":"      default: \u0027 \u0027"},{"line_number":170,"context_line":"    hosts:"},{"line_number":171,"context_line":"      default: 10.96.232.136"},{"line_number":172,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_5319ff76","line":169,"range":{"start_line":169,"start_character":15,"end_line":169,"end_character":18},"updated":"2018-01-12 02:33:53.000000000","message":"`null` should work here","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    scheme:"},{"line_number":167,"context_line":"      default: http"},{"line_number":168,"context_line":"    path:"},{"line_number":169,"context_line":"      default: \u0027 \u0027"},{"line_number":170,"context_line":"    hosts:"},{"line_number":171,"context_line":"      default: 10.96.232.136"},{"line_number":172,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_d12babe8","line":169,"range":{"start_line":169,"start_character":15,"end_line":169,"end_character":18},"in_reply_to":"7f96bb07_5319ff76","updated":"2018-01-13 00:42:37.000000000","message":"This is actually required because of the layers of | default \u0027/\u0027 that come into play.  I want a truly \u0027empty\u0027 or null path and this is the only approach.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"conf:"},{"line_number":253,"context_line":"  etcd:"},{"line_number":254,"context_line":"    credentials:"},{"line_number":255,"context_line":"      ca: null"},{"line_number":256,"context_line":"      key: null"},{"line_number":257,"context_line":"      certificate: null"},{"line_number":258,"context_line":"  cni_network_config:"},{"line_number":259,"context_line":"    name: k8s-pod-network"},{"line_number":260,"context_line":"    cniVersion: 0.1.0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_53e33f34","line":257,"range":{"start_line":255,"start_character":0,"end_line":257,"end_character":23},"updated":"2018-01-12 02:33:53.000000000","message":"could we move these to the endpoints section?","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"conf:"},{"line_number":253,"context_line":"  etcd:"},{"line_number":254,"context_line":"    credentials:"},{"line_number":255,"context_line":"      ca: null"},{"line_number":256,"context_line":"      key: null"},{"line_number":257,"context_line":"      certificate: null"},{"line_number":258,"context_line":"  cni_network_config:"},{"line_number":259,"context_line":"    name: k8s-pod-network"},{"line_number":260,"context_line":"    cniVersion: 0.1.0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_513f9b24","line":257,"range":{"start_line":255,"start_character":0,"end_line":257,"end_character":23},"in_reply_to":"7f96bb07_53e33f34","updated":"2018-01-13 00:42:37.000000000","message":"Moved.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"      - kubeadm"},{"line_number":277,"context_line":"      - bgp"},{"line_number":278,"context_line":"    # Describes which BGP networking backend to use gobgp, bird, none.  Default is bird."},{"line_number":279,"context_line":"    # NOTE(alanmeadows) today this chart only supports applying the bgp customizations to "},{"line_number":280,"context_line":"    # bird templates - in the future we may support gobgp as well"},{"line_number":281,"context_line":"    CALICO_NETWORKING_BACKEND: bird"},{"line_number":282,"context_line":"    # Location of the CA certificate for etcd."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_f3fe0b04","line":279,"range":{"start_line":279,"start_character":89,"end_line":279,"end_character":90},"updated":"2018-01-12 02:33:53.000000000","message":"ws","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"      - kubeadm"},{"line_number":277,"context_line":"      - bgp"},{"line_number":278,"context_line":"    # Describes which BGP networking backend to use gobgp, bird, none.  Default is bird."},{"line_number":279,"context_line":"    # NOTE(alanmeadows) today this chart only supports applying the bgp customizations to "},{"line_number":280,"context_line":"    # bird templates - in the future we may support gobgp as well"},{"line_number":281,"context_line":"    CALICO_NETWORKING_BACKEND: bird"},{"line_number":282,"context_line":"    # Location of the CA certificate for etcd."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_713ad734","line":279,"range":{"start_line":279,"start_character":89,"end_line":279,"end_character":90},"in_reply_to":"7f96bb07_f3fe0b04","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"645131dc13df83f8c1d92368c723df155716e545","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    ippool:"},{"line_number":194,"context_line":"      ipip:"},{"line_number":195,"context_line":"        enabled: \"true\""},{"line_number":196,"context_line":"        mode: \"cross-subnet\""},{"line_number":197,"context_line":"      nat_outgoing: \"true\""},{"line_number":198,"context_line":"      disabled: \"false\""},{"line_number":199,"context_line":"  bgp:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_b8291b9c","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":28},"updated":"2018-01-14 03:41:10.000000000","message":"in infra I suspect this will need to be \u0027always\u0027 :(","commit_id":"f1e77773e7794fb6e95fb3ba5689dd109d2162b4"}],"helm-toolkit/templates/endpoints/_keystone_endpoint_scheme_lookup.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3fa135d1aaa8c3cf12bca2ca366023da1d18358f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- define \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" -}}"},{"line_number":2,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":3,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":4,"context_line":"{{- $port :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_734afb27","line":1,"updated":"2018-01-12 02:33:53.000000000","message":"can we add a brief description of how this is used - and a (c) header, to be consistent with the other endpoint functions.\n\nSidenote: I\u0027m gonna rip the \u0027keystone\u0027 prefix out of these soon as we have consolidated on a single helm-toolkit - its a horrible hangover from the 1st one we wrote.","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"397a7729cd6ec6307dde299f6dbf8cff1114c56b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- define \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" -}}"},{"line_number":2,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":3,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":4,"context_line":"{{- $port :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_71d657c6","line":1,"in_reply_to":"7f96bb07_734afb27","updated":"2018-01-13 00:42:37.000000000","message":"Done","commit_id":"48093a067782e4a9fc4be251876a0ca8237a9753"}]}