)]}'
{"maker.sh":[{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"6e951c462fb2510fc9c7ade8567ce76aab75d3a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -xe"},{"line_number":3,"context_line":": ${OSH_INFRA_PATH:\u003d\"../openstack-helm-infra\"}"},{"line_number":4,"context_line":"cd ${OSH_INFRA_PATH}"},{"line_number":5,"context_line":"#make dev-deploy setup-host"},{"line_number":6,"context_line":"#make dev-deploy k8s"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"5f93b717_d0f477f3","line":4,"updated":"2018-02-09 00:27:06.000000000","message":"Is this file by any chance your test file and shouldn\u0027t be part of the patch?","commit_id":"8fda13140962776c5782eada75bc720b34cd6755"}],"tools/gate/devel/start.sh":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"22c67ad6e0ecf0c5e7bd7886666517ec8d30dcac","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  PLAYBOOKS\u003d\"osh-infra-collect-logs\""},{"line_number":85,"context_line":"elif [ \"x${DEPLOY}\" \u003d\u003d \"xfull\" ]; then"},{"line_number":86,"context_line":"  ansible_install"},{"line_number":87,"context_line":"  PLAYBOOKS\u003d\"osh-infra-docker loopback-devices-remove loopback-devices-create loopback-devices-validate osh-infra-build osh-infra-deploy-k8s osh-infra-deploy-charts osh-infra-collect-logs\""},{"line_number":88,"context_line":"else"},{"line_number":89,"context_line":"  echo \"Unknown Deploy Option Selected\""},{"line_number":90,"context_line":"  exit 1"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5f93b717_5d293bf0","line":87,"updated":"2018-02-03 17:45:59.000000000","message":"The \"loopback-devices-*\" are the roles, need to put the playbook names here, e.g. osh-infra-loopback-remove-devices","commit_id":"556d0f02b21f9e3ab07a7001e0ae8ba1f55689a9"}],"tools/gate/playbooks/loopback-devices-create/tasks/output_result.yaml":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"0db090c66021bc8bce9ed93cf94f20325c7b6e44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: build block_devices values section"},{"line_number":2,"context_line":"  become: true"},{"line_number":3,"context_line":"  become_user: root"},{"line_number":4,"context_line":"  shell: |-"},{"line_number":5,"context_line":"    set -xe;"},{"line_number":6,"context_line":"    tools/gate/playbooks/loopback-devices-create/templates/loopback-device-functions.sh \\"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f93b717_a17cfb71","line":3,"updated":"2018-02-01 21:50:50.000000000","message":"this shouldn\u0027t be necessary — you should only need to be root to create the disks.  merging the output should work fine as a non-root user.  you probably want to make sure the created files have permissions that allow them to be read by someone other than root, though.","commit_id":"c1eb42cfbe081d86c617ae6e6dab786b8614ae2d"}],"tools/gate/playbooks/loopback-devices-create/templates/loopback-device-functions.sh":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"0db090c66021bc8bce9ed93cf94f20325c7b6e44","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  # Need to find out how to pass below variables from playbook to script."},{"line_number":39,"context_line":"  LOOPBACK_DIR\u003d${LOOPBACK_DIR:-/var/lib/iscsi-loopback}"},{"line_number":40,"context_line":"  HOST_OS\u003d\"Ubuntu\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  if [ ! -d \"${LOOPBACK_DIR}\" ]; then"},{"line_number":43,"context_line":"    mkdir -p ${LOOPBACK_DIR}"}],"source_content_type":"text/x-sh","patch_set":17,"id":"5f93b717_100bbfd5","line":40,"updated":"2018-02-01 21:50:50.000000000","message":"probably don\u0027t want this hardcoded.","commit_id":"8fda13140962776c5782eada75bc720b34cd6755"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"6e951c462fb2510fc9c7ade8567ce76aab75d3a9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"function assemble_device_values {"},{"line_number":120,"context_line":"  # The create loopback would not have assembled the data from each host. We"},{"line_number":121,"context_line":"  # will go ahead and tie them allb ased on the hostname"},{"line_number":122,"context_line":"  local RAW_INFO_FILE\u003d`expr $1`"},{"line_number":123,"context_line":"  jq -s \u0027{\"hosts\": {\"hostname\":[.[][\"hostname\"]]|unique|add, \"conf\": {\"storage\": [.[][\"block_devices\"]]|add}}}\u0027 $1"},{"line_number":124,"context_line":"}"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-sh","patch_set":35,"id":"3fa0c359_7b235bbe","line":122,"updated":"2018-02-09 00:27:06.000000000","message":"Need to remove this. Clearly it is not needed.","commit_id":"bd95fe9bf0b56b40c85cc36aad684e15e4b88e7e"}],"tools/gate/playbooks/vars.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"df5563198197e8507f83daf3f7fcf2afd51b40b0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  block_devices_output: /var/lib/openstack-helm/loopback-devices/block_devices_output.yaml"},{"line_number":64,"context_line":"  devices: #Size in MB"},{"line_number":65,"context_line":"    - application: ceph-osd"},{"line_number":66,"context_line":"      size: 10240"},{"line_number":67,"context_line":"    - application: ceph-osd"},{"line_number":68,"context_line":"      size: 10240"},{"line_number":69,"context_line":"    - application: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa0c359_eec2ef33","line":66,"updated":"2018-02-24 22:33:27.000000000","message":"Just wondering, why did we increase these - were we running out of space @ 5gb?","commit_id":"637f85c29e362e9dd59d7abc44b693aff8f01838"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"25bac6b676aec390d1d47df9a0635f667d6b9843","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  block_devices_output: /var/lib/openstack-helm/loopback-devices/block_devices_output.yaml"},{"line_number":64,"context_line":"  devices: #Size in MB"},{"line_number":65,"context_line":"    - application: ceph-osd"},{"line_number":66,"context_line":"      size: 10240"},{"line_number":67,"context_line":"    - application: ceph-osd"},{"line_number":68,"context_line":"      size: 10240"},{"line_number":69,"context_line":"    - application: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa0c359_ae9627ef","line":66,"in_reply_to":"3fa0c359_8eea4b71","updated":"2018-02-24 23:43:43.000000000","message":"though kinda moot here, as these should def not be enabled by default, we should make the devices small enough to fit on the hosts - its gonna be very hard to triage issues if we are running out of space on the hosts themselves.\n\nIt should also be noted that the disc layout varies by provider, so it may make sense to account for this - and auto format/mount at /var/lib/isici-loopback if required.","commit_id":"637f85c29e362e9dd59d7abc44b693aff8f01838"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"d5a18a177870326dd927b03d4ba964ccb986e445","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  block_devices_output: /var/lib/openstack-helm/loopback-devices/block_devices_output.yaml"},{"line_number":64,"context_line":"  devices: #Size in MB"},{"line_number":65,"context_line":"    - application: ceph-osd"},{"line_number":66,"context_line":"      size: 10240"},{"line_number":67,"context_line":"    - application: ceph-osd"},{"line_number":68,"context_line":"      size: 10240"},{"line_number":69,"context_line":"    - application: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa0c359_51d94280","line":66,"in_reply_to":"3fa0c359_ae9627ef","updated":"2018-02-25 01:37:49.000000000","message":"that\u0027s a good point.  while we need these things to be big enough to store whatever the client subsystem\u0027s tests will put in them, there\u0027s no particular reason for them to be a lot bigger.  in this case, it\u0027s hard to imagine, say, the mariadb databases on the gates reaching 10G, so it should be safe to shrink these way down (though by the same token, it\u0027s hard to imagine a case where they\u0027d be sufficiently allocated to actually fill a gate\u0027s disk.)","commit_id":"637f85c29e362e9dd59d7abc44b693aff8f01838"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"5ccffa3876fcd8be0d3f5c03fb5f4c13326ef192","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  block_devices_output: /var/lib/openstack-helm/loopback-devices/block_devices_output.yaml"},{"line_number":64,"context_line":"  devices: #Size in MB"},{"line_number":65,"context_line":"    - application: ceph-osd"},{"line_number":66,"context_line":"      size: 10240"},{"line_number":67,"context_line":"    - application: ceph-osd"},{"line_number":68,"context_line":"      size: 10240"},{"line_number":69,"context_line":"    - application: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa0c359_8eea4b71","line":66,"in_reply_to":"3fa0c359_eec2ef33","updated":"2018-02-24 23:35:06.000000000","message":"they were actually reduced in v40 because they were running the fedora gates out of space, but that was because of a targetcli bug that was causing the backstores to not be sparsely allocated.  That bug is worked around with this change, so there\u0027s no need to have them be small -- because they\u0027re sparse, the actual disk usage is tiny.","commit_id":"637f85c29e362e9dd59d7abc44b693aff8f01838"}]}