)]}'
{"fluent-logging/templates/monitoring/prometheus/exporter-configmap-bin.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"caa25c7314278b711718a8eb714ccfad6d293c22","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.configmap_bin }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_558819c5","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":60},"updated":"2018-02-05 17:14:09.000000000","message":"should this not also rely on Prometheus monitoring being active?","commit_id":"f1ea1e53dcaa122b559fa7e43a9b8767436dc7e8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fdf2b14aee54908fec34c7656ef61d3ceeecc1b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.configmap_bin }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_d8d22035","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":60},"in_reply_to":"3fa0c359_558819c5","updated":"2018-02-05 17:50:14.000000000","message":"Done","commit_id":"f1ea1e53dcaa122b559fa7e43a9b8767436dc7e8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c69036356edde5a2999d6dfea036093c1cd8d1b5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.configmap_bin }}"},{"line_number":18,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_d8bd4069","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":47},"updated":"2018-02-05 17:45:31.000000000","message":"could use `and` here for a cleaner implementation: eg https://github.com/openstack/openstack-helm/blob/master/ceph/templates/daemonset-mon.yaml#L17","commit_id":"f16045f4262d5782500984dd067a6a8d2a722652"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fdf2b14aee54908fec34c7656ef61d3ceeecc1b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.configmap_bin }}"},{"line_number":18,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_2b32d0f2","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":47},"in_reply_to":"3fa0c359_d8bd4069","updated":"2018-02-05 17:50:14.000000000","message":"I\u0027m personally a fan of doing this via nested `if`s in this manner, as we do it already for ingress. If there\u0027s a strong preference for using the `and` expression, I\u0027ll change it. the long `and` expressions have the potential to quickly expand into long lines that get ugly to read","commit_id":"f16045f4262d5782500984dd067a6a8d2a722652"}],"fluent-logging/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"caa25c7314278b711718a8eb714ccfad6d293c22","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"monitoring:"},{"line_number":231,"context_line":"  prometheus:"},{"line_number":232,"context_line":"    enabled: true"},{"line_number":233,"context_line":"    fluentd_exporter:"},{"line_number":234,"context_line":"      scrape: true"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_35fa2d42","line":232,"range":{"start_line":232,"start_character":13,"end_line":232,"end_character":17},"updated":"2018-02-05 17:14:09.000000000","message":"should this not be false by default, and the manifests true?","commit_id":"f1ea1e53dcaa122b559fa7e43a9b8767436dc7e8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"069040800d87d82b2357a1312d1584eb411613fb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    fluentbit: docker.io/fluent/fluent-bit:0.12.9"},{"line_number":35,"context_line":"    fluentd: docker.io/kolla/ubuntu-source-fluentd:ocata"},{"line_number":36,"context_line":"    prometheus_fluentd_exporter: docker.io/vect0r/fluentd_exporter:latest"},{"line_number":37,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":38,"context_line":"    helm_tests: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":39,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_1a05d1c2","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":73},"updated":"2018-02-06 02:19:53.000000000","message":"we should not use a \u0027latest\u0027 tag - but pin to something stable","commit_id":"f16045f4262d5782500984dd067a6a8d2a722652"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"713f660f7955eca5989485d2622f7b9d645142ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    fluentbit: docker.io/fluent/fluent-bit:0.12.9"},{"line_number":35,"context_line":"    fluentd: docker.io/kolla/ubuntu-source-fluentd:ocata"},{"line_number":36,"context_line":"    prometheus_fluentd_exporter: docker.io/vect0r/fluentd_exporter:latest"},{"line_number":37,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":38,"context_line":"    helm_tests: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":39,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_556d6a96","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":73},"in_reply_to":"3fa0c359_1a05d1c2","updated":"2018-02-06 03:05:08.000000000","message":"We\u0027ll likely need to build and host the image ourselves for the time being -- this is the only tag available for this image","commit_id":"f16045f4262d5782500984dd067a6a8d2a722652"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"416eddb617cf5d99a7bf62d6a9e996fceade153d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    fluentbit: docker.io/fluent/fluent-bit:0.12.9"},{"line_number":35,"context_line":"    fluentd: docker.io/kolla/ubuntu-source-fluentd:ocata"},{"line_number":36,"context_line":"    prometheus_fluentd_exporter: docker.io/vect0r/fluentd_exporter:latest"},{"line_number":37,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":38,"context_line":"    helm_tests: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":39,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_e654dd23","line":36,"range":{"start_line":36,"start_character":67,"end_line":36,"end_character":73},"updated":"2018-02-07 18:35:14.000000000","message":"we cannot use a `latest` image, if there is not stable version available, then we should at least pin to a digest.","commit_id":"79b793ad7c93514b6e23d4819071503151ea40a9"}]}