)]}'
{"id":"openstack%2Fopenstack-helm-infra~577017","triplet_id":"openstack%2Fopenstack-helm-infra~master~I8b1b1efb15352934eb8f2a0b0214e486eea80d46","project":"openstack/openstack-helm-infra","branch":"master","topic":"proxy","hashtags":[],"change_id":"I8b1b1efb15352934eb8f2a0b0214e486eea80d46","subject":"Add proxy environment","status":"MERGED","created":"2018-06-21 00:03:05.000000000","updated":"2018-06-26 02:40:13.000000000","submitted":"2018-06-26 02:40:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"577017-1529980813679-6eb845a6","meta_rev_id":"2896c597c07304a16d47d049fb497aff4b3fc0fc","_number":577017,"virtual_id_number":577017,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},{"value":0,"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2018-06-26 02:40:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"recommended":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"all":[{"value":0,"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},{"value":1,"date":"2018-06-26 00:08:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":2,"date":"2018-06-26 01:10:56.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2018-06-26 00:58:03.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":0,"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},{"value":0,"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":1,"date":"2018-06-26 01:10:56.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-21 00:03:44.000000000","updated_by":{"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},"reviewer":{"_account_id":25731,"name":"Stacey Fletcher","email":"staceylynnfletcher@gmail.com","username":"StaceyFletcher"},"state":"REVIEWER"},{"updated":"2018-06-26 00:08:25.000000000","updated_by":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"reviewer":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"state":"REVIEWER"},{"updated":"2018-06-26 00:58:03.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-06-26 01:10:56.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2018-06-26 02:40:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b2c078b9c5d8b93e776a13b393ce5d8e77770e1a","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-06-21 00:03:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07f3d4e7099cbc77ab0c47a3a17c345e1ba9eee3","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-06-21 00:06:14.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a3d976c27316fac44bcf11b36e0a483aa1a94be7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-21 00:53:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/17/577017/2/check/build-openstack-sphinx-docs/8c0c4d4/html/ : SUCCESS in 3m 48s\n- openstack-helm-infra-linter http://logs.openstack.org/17/577017/2/check/openstack-helm-infra-linter/84f0225/ : SUCCESS in 1m 14s\n- openstack-helm-infra-ubuntu http://logs.openstack.org/17/577017/2/check/openstack-helm-infra-ubuntu/273f1f9/ : SUCCESS in 40m 07s\n- openstack-helm-infra-centos http://logs.openstack.org/17/577017/2/check/openstack-helm-infra-centos/3f2afc9/ : SUCCESS in 46m 27s\n- openstack-helm-infra-dev-deploy http://logs.openstack.org/17/577017/2/check/openstack-helm-infra-dev-deploy/4474a9c/ : SUCCESS in 32m 02s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/17/577017/2/check/openstack-helm-infra-kubernetes-keystone-auth/f63a1cf/ : FAILURE in 17m 58s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"120e1ecbcdb114e7635f0379898a1a5f6d089b54","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-06-22 13:12:17.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"f97bf94012a69f1a199ddb3ca7396b82c2d981b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-22 14:02:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/17/577017/3/check/build-openstack-sphinx-docs/f1613c1/html/ : SUCCESS in 3m 45s\n- openstack-helm-infra-linter http://logs.openstack.org/17/577017/3/check/openstack-helm-infra-linter/e381a33/ : SUCCESS in 1m 34s\n- openstack-helm-infra-ubuntu http://logs.openstack.org/17/577017/3/check/openstack-helm-infra-ubuntu/b00c551/ : SUCCESS in 40m 25s\n- openstack-helm-infra-centos http://logs.openstack.org/17/577017/3/check/openstack-helm-infra-centos/b4897b8/ : SUCCESS in 47m 28s\n- openstack-helm-infra-dev-deploy http://logs.openstack.org/17/577017/3/check/openstack-helm-infra-dev-deploy/6cf6bc5/ : SUCCESS in 36m 01s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/17/577017/3/check/openstack-helm-infra-kubernetes-keystone-auth/c95f8ad/ : SUCCESS in 28m 06s","accounts_in_message":[],"_revision_number":3},{"id":"f99e2f74c39b33be918d7a14a6d7febefcf0fe4b","author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"date":"2018-06-26 00:08:25.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"98c01660cc7dfb20e1370107d49998bcb64c4dba","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-06-26 00:58:03.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"165d391d1b7245bf474a40666d8a4d91fa52f700","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-06-26 01:10:56.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"eac287b76ea5a1377506091a61bb6ead4f03556a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 01:11:08.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c9eb2ddd3b673f81922f117d82fa8093d503ad6c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 02:40:13.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/17/577017/3/gate/build-openstack-sphinx-docs/2333159/html/ : SUCCESS in 3m 58s\n- openstack-helm-infra-linter http://logs.openstack.org/17/577017/3/gate/openstack-helm-infra-linter/dc62af0/ : SUCCESS in 2m 06s\n- openstack-helm-infra-ubuntu http://logs.openstack.org/17/577017/3/gate/openstack-helm-infra-ubuntu/e446ac8/ : SUCCESS in 44m 51s\n- openstack-helm-infra-centos http://logs.openstack.org/17/577017/3/gate/openstack-helm-infra-centos/c9851ba/ : SUCCESS in 52m 26s\n- openstack-helm-infra-dev-deploy http://logs.openstack.org/17/577017/3/gate/openstack-helm-infra-dev-deploy/cb14240/ : SUCCESS in 30m 22s\n- openstack-helm-infra-kubernetes-keystone-auth http://logs.openstack.org/17/577017/3/gate/openstack-helm-infra-kubernetes-keystone-auth/10e4ab2/ : SUCCESS in 27m 55s","accounts_in_message":[],"_revision_number":3},{"id":"92618b15920a6f6880505ce76c43c13533026ab5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 02:40:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cef6dd5a191de777a837f2c5b3b79eb45eb85ad1","revisions":{"6cb2532e539bae51fd6dfb0a78d230a0650528f7":{"kind":"REWORK","_number":1,"created":"2018-06-21 00:03:05.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/17/577017/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/17/577017/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/1"}}},"commit":{"parents":[{"commit":"ad5d4259c45940bf4ddd150aad37c5b8d1aabba6","subject":"Helm-toolkit: Updates manifests to support openstack logging.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ad5d4259c45940bf4ddd150aad37c5b8d1aabba6"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-21 00:00:01.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-21 00:00:01.000000000","tz":-300},"subject":"Add proxy environment","message":"Add proxy environment\n\nThis patch set loads the proxy environment variable when executing helm init\nas it attempts to reach out to an external kubernetes.google address to load\nthe default stable repo. If this is executed with in a normal corporate\nenvironment that requires a proxy, this would fail without the needed envvar.\n\nChange-Id: I8b1b1efb15352934eb8f2a0b0214e486eea80d46\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/6cb2532e539bae51fd6dfb0a78d230a0650528f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/6cb2532e539bae51fd6dfb0a78d230a0650528f7"}]},"branch":"refs/heads/master"},"86c136b105b15da76aa79f30efbaca912d262306":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-06-21 00:06:14.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/17/577017/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/17/577017/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/2"}}},"commit":{"parents":[{"commit":"ad5d4259c45940bf4ddd150aad37c5b8d1aabba6","subject":"Helm-toolkit: Updates manifests to support openstack logging.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/ad5d4259c45940bf4ddd150aad37c5b8d1aabba6"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-21 00:00:01.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-21 00:06:12.000000000","tz":0},"subject":"Add proxy environment","message":"Add proxy environment\n\nThis patch set loads the proxy environment variable when executing helm\ninit as it attempts to reach out to an external address to load the\nstable repo. If this is executed with in a corporate environment that\nrequires a proxy, this would fail without the needed envvars.\n\nChange-Id: I8b1b1efb15352934eb8f2a0b0214e486eea80d46\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/86c136b105b15da76aa79f30efbaca912d262306"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/86c136b105b15da76aa79f30efbaca912d262306"}]},"branch":"refs/heads/master"},"cef6dd5a191de777a837f2c5b3b79eb45eb85ad1":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-06-22 13:12:17.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/17/577017/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm-infra","ref":"refs/changes/17/577017/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm-infra refs/changes/17/577017/3"}}},"commit":{"parents":[{"commit":"42f475133d406606a7b414d73dc1d16f3b50dbdf","subject":"kubernetes-keystone-webook: add missing annotation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/42f475133d406606a7b414d73dc1d16f3b50dbdf"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-21 00:00:01.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-06-22 13:12:17.000000000","tz":0},"subject":"Add proxy environment","message":"Add proxy environment\n\nThis patch set loads the proxy environment variable when executing helm\ninit as it attempts to reach out to an external address to load the\nstable repo. If this is executed with in a corporate environment that\nrequires a proxy, this would fail without the needed envvars.\n\nChange-Id: I8b1b1efb15352934eb8f2a0b0214e486eea80d46\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/cef6dd5a191de777a837f2c5b3b79eb45eb85ad1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm-infra/commit/cef6dd5a191de777a837f2c5b3b79eb45eb85ad1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
