)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9713cd5e5ec497b2faadcd40313f99680cea2d21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Externalize some repo URL vars to allow runtime modification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to be able to use local mirror of certain packages."},{"line_number":10,"context_line":"Note: Google repo URL variable does not contain path, because it\u0027s"},{"line_number":11,"context_line":"short and Google\u0027s repository can be browsed and can be easily mirrored,"},{"line_number":12,"context_line":"in contrast to CNI repo, which is hosted on GitHub\u0027s binary repository,"},{"line_number":13,"context_line":"and it is not browsable and it\u0027s impossible to easily fully mirror it"},{"line_number":14,"context_line":"automatically."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5f7c97a3_ff2126b3","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":71},"updated":"2018-08-01 21:03:01.000000000","message":"for consistency, we prob should include the path.","commit_id":"e4bab9a52e9aa88fc034dc95725c6cf52432b02e"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"7c1d5005f3efad24d7ba9ac8454d169f986195cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Externalize some repo URL vars to allow runtime modification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to be able to use local mirror of certain packages."},{"line_number":10,"context_line":"Note: Google repo URL variable does not contain path, because it\u0027s"},{"line_number":11,"context_line":"short and Google\u0027s repository can be browsed and can be easily mirrored,"},{"line_number":12,"context_line":"in contrast to CNI repo, which is hosted on GitHub\u0027s binary repository,"},{"line_number":13,"context_line":"and it is not browsable and it\u0027s impossible to easily fully mirror it"},{"line_number":14,"context_line":"automatically."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f79a3b5_715de8ea","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":71},"in_reply_to":"5f7c97a3_ff2126b3","updated":"2018-09-13 12:46:38.000000000","message":"Done","commit_id":"e4bab9a52e9aa88fc034dc95725c6cf52432b02e"}],"tools/images/kubeadm-aio/Dockerfile":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ecff5532b2c85cde794bdd265900598119f491c8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      ${GOOGLE_REPO_URL}/kubernetes-release/release/${KUBE_VERSION}/bin/linux/amd64/kubelet ;\\"},{"line_number":93,"context_line":"    chmod +x /opt/assets/usr/bin/kubelet ;\\"},{"line_number":94,"context_line":"    mkdir -p /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":95,"context_line":"    curl -sSL ${CNI_REPO_URL}/containernetworking/plugins/releases/download/$CNI_VERSION/cni-plugins-amd64-$CNI_VERSION.tgz | \\"},{"line_number":96,"context_line":"      tar -zxv --strip-components\u003d1 -C /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":97,"context_line":"    TMP_DIR\u003d$(mktemp -d) ;\\"},{"line_number":98,"context_line":"    curl -sSL ${GOOGLE_REPO_URL}/kubernetes-helm/helm-${HELM_VERSION}-linux-amd64.tar.gz | tar -zxv --strip-components\u003d1 -C ${TMP_DIR} ;\\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_239944ce","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":123},"updated":"2018-07-26 16:47:33.000000000","message":"rather than just pulling github out, we prob want to make this a param, so we can pull the tarball from wherever desired.","commit_id":"b7e62e5f1ff42e484587ce2fd27ca34bb4feed53"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"0e41d5e5d2ec299ea28590c0eb6e8b8c6cb75999","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      ${GOOGLE_REPO_URL}/kubernetes-release/release/${KUBE_VERSION}/bin/linux/amd64/kubelet ;\\"},{"line_number":93,"context_line":"    chmod +x /opt/assets/usr/bin/kubelet ;\\"},{"line_number":94,"context_line":"    mkdir -p /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":95,"context_line":"    curl -sSL ${CNI_REPO_URL}/containernetworking/plugins/releases/download/$CNI_VERSION/cni-plugins-amd64-$CNI_VERSION.tgz | \\"},{"line_number":96,"context_line":"      tar -zxv --strip-components\u003d1 -C /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":97,"context_line":"    TMP_DIR\u003d$(mktemp -d) ;\\"},{"line_number":98,"context_line":"    curl -sSL ${GOOGLE_REPO_URL}/kubernetes-helm/helm-${HELM_VERSION}-linux-amd64.tar.gz | tar -zxv --strip-components\u003d1 -C ${TMP_DIR} ;\\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_43680087","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":123},"in_reply_to":"5f7c97a3_239944ce","updated":"2018-07-26 16:56:14.000000000","message":"But then it would be inconsistent with approach used for GOOGLE_REPO_URL.\nIf I would need to keep a copy of tarball somewhere on my website, I would better keep it under the same URL path as the original one has been kept.","commit_id":"b7e62e5f1ff42e484587ce2fd27ca34bb4feed53"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"6c97c7a31593607eb6e9ceedf89eeaefd05b5a55","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      ${GOOGLE_REPO_URL}/kubernetes-release/release/${KUBE_VERSION}/bin/linux/amd64/kubelet ;\\"},{"line_number":93,"context_line":"    chmod +x /opt/assets/usr/bin/kubelet ;\\"},{"line_number":94,"context_line":"    mkdir -p /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":95,"context_line":"    curl -sSL ${CNI_REPO_URL}/containernetworking/plugins/releases/download/$CNI_VERSION/cni-plugins-amd64-$CNI_VERSION.tgz | \\"},{"line_number":96,"context_line":"      tar -zxv --strip-components\u003d1 -C /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":97,"context_line":"    TMP_DIR\u003d$(mktemp -d) ;\\"},{"line_number":98,"context_line":"    curl -sSL ${GOOGLE_REPO_URL}/kubernetes-helm/helm-${HELM_VERSION}-linux-amd64.tar.gz | tar -zxv --strip-components\u003d1 -C ${TMP_DIR} ;\\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_b437befd","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":123},"in_reply_to":"5f7c97a3_239944ce","updated":"2018-07-27 11:10:26.000000000","message":"Done","commit_id":"b7e62e5f1ff42e484587ce2fd27ca34bb4feed53"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"ec988c58ae3d5d9f597f6a5e771d9481f2d222b5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      ${GOOGLE_REPO_URL}/kubernetes-release/release/${KUBE_VERSION}/bin/linux/amd64/kubelet ;\\"},{"line_number":93,"context_line":"    chmod +x /opt/assets/usr/bin/kubelet ;\\"},{"line_number":94,"context_line":"    mkdir -p /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":95,"context_line":"    curl -sSL ${CNI_REPO_URL}/containernetworking/plugins/releases/download/$CNI_VERSION/cni-plugins-amd64-$CNI_VERSION.tgz | \\"},{"line_number":96,"context_line":"      tar -zxv --strip-components\u003d1 -C /opt/assets${CNI_BIN_DIR} ;\\"},{"line_number":97,"context_line":"    TMP_DIR\u003d$(mktemp -d) ;\\"},{"line_number":98,"context_line":"    curl -sSL ${GOOGLE_REPO_URL}/kubernetes-helm/helm-${HELM_VERSION}-linux-amd64.tar.gz | tar -zxv --strip-components\u003d1 -C ${TMP_DIR} ;\\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_74584656","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":123},"in_reply_to":"5f7c97a3_239944ce","updated":"2018-07-27 11:10:04.000000000","message":"Talked to Kaspars, and he says that there is no (easy) way to mirror github\u0027s binary archive. So that makes not much sense to retain full repository path for cni-plugins. So I\u0027m following your suggestion.","commit_id":"b7e62e5f1ff42e484587ce2fd27ca34bb4feed53"}]}
