)]}'
{"prometheus-node-exporter/templates/bin/_node-exporter.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e2ddea1edaa8e51598800fdd50a06b910d7df00c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"enable_collectors\u003d{{ include \"helm-toolkit.utils.joinListWithSpace\" .Values.conf.collectors.enable | quote }}"},{"line_number":21,"context_line":"disable_collectors\u003d{{ include \"helm-toolkit.utils.joinListWithSpace\" .Values.conf.collectors.disable | quote }}"},{"line_number":22,"context_line":"exec /bin/node_exporter \\"},{"line_number":23,"context_line":"  $(for c in ${enable_collectors}; do echo --collector.${c} ; done) \\"},{"line_number":24,"context_line":"  $(for c in ${disable_collectors}; do echo --no-collector.${c} ; done) \\"},{"line_number":25,"context_line":"  --collector.ntp.server\u003d{{ .Values.conf.ntp_server_ip }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_50a5099e","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":73},"updated":"2018-09-04 15:27:43.000000000","message":"mixing gotpl and bash like this seems a bit messy - could we just use gotpl for this?","commit_id":"72c5f4cd959ac797a7336192b1ba9b9a49f0e292"}],"prometheus-node-exporter/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"3f63f28132afcd5fa0aa99f37cd8fef2c25c957a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"conf:"},{"line_number":141,"context_line":"  ntp_server_ip: 127.0.0.1"},{"line_number":142,"context_line":"  collectors:"},{"line_number":143,"context_line":"    enable:"},{"line_number":144,"context_line":"      - ntp"},{"line_number":145,"context_line":"      - meminfo_numa"},{"line_number":146,"context_line":"      - bonding"},{"line_number":147,"context_line":"      - mountstats"},{"line_number":148,"context_line":"    disable:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7b6473b3","line":148,"range":{"start_line":142,"start_character":0,"end_line":148,"end_character":12},"updated":"2018-09-19 14:57:10.000000000","message":"This seems a sane approach, but would it be possible to address this similar to how we generate command line flags for prometheus?  IE: https://github.com/openstack/openstack-helm-infra/blob/master/prometheus/values.yaml#L434-L452, which gets fed into: https://github.com/openstack/openstack-helm-infra/blob/master/prometheus/templates/utils/_command_line_flags.tpl#L36-L48\n\nThis results in a simplified manner of generating these flags, as this could then become:\n\nconf:\n  command_line_flags:\n    collector.ntp: true\n    collector.meminfo_numa: true\n    collector.bonding: true\n    collector.mountstats:true\n    collector.foo: false\n    logtostderr: true\n\nWe could then just iterate over the map, and if an entry is set to true we can just prepend `--` to the key here to generate the flags.  For any collectors we need to explicitly disable, we can evalute if a value is false and disable it as needed.","commit_id":"d637c0edded34afb0129f79dea07bed387ba5bf7"}]}