)]}'
{"helm-toolkit/templates/snippets/_kubernetes_probes.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ef8408da789157c05228babbffce078b387aca94","unresolved":false,"context_lines":[{"line_number":40,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"readinessProbe\" | toYaml | indent 2 }}"},{"line_number":41,"context_line":"{{- end }}"},{"line_number":42,"context_line":"{{- end -}}"},{"line_number":43,"context_line":"{{- if hasKey $envAll.Values.pod.probes $containerName -}}"},{"line_number":44,"context_line":"{{- if index $envAll.Values.pod.probes $containerName \"liveness\" }}"},{"line_number":45,"context_line":"livenessProbe:"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"livenessProbe\" | toYaml | indent 2 }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_e97b48bb","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":58},"updated":"2018-08-08 23:33:29.000000000","message":"should be consolidated with L37. will fix next patch.","commit_id":"95a2cbf728b0ac3a74a7c810065440872b294f4f"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"81b35bc5129a966c9a503f07c19a04beeaf0aa65","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  tcpSocket:"},{"line_number":32,"context_line":"    port: 11211"},{"line_number":33,"context_line":"*/}}"},{"line_number":34,"context_line":"{{- define \"helm-toolkit.snippets.probes\" -}}"},{"line_number":35,"context_line":"{{- $envAll :\u003d index . \"envAll\" -}}"},{"line_number":36,"context_line":"{{- $containerName :\u003d index . \"name\" -}}"},{"line_number":37,"context_line":"{{- if hasKey $envAll.Values.pod.probes $containerName -}}"},{"line_number":38,"context_line":"{{- if index $envAll.Values.pod.probes $containerName \"readiness\" }}"},{"line_number":39,"context_line":"readinessProbe:"},{"line_number":40,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"readinessProbe\" | toYaml | indent 2 }}"},{"line_number":41,"context_line":"{{- end }}"},{"line_number":42,"context_line":"{{- end -}}"},{"line_number":43,"context_line":"{{- if hasKey $envAll.Values.pod.probes $containerName -}}"},{"line_number":44,"context_line":"{{- if index $envAll.Values.pod.probes $containerName \"liveness\" }}"},{"line_number":45,"context_line":"livenessProbe:"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"livenessProbe\" | toYaml | indent 2 }}"},{"line_number":47,"context_line":"{{- end }}"},{"line_number":48,"context_line":"{{- end -}}"},{"line_number":49,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_5bb9c92b","line":49,"range":{"start_line":34,"start_character":0,"end_line":49,"end_character":11},"updated":"2018-08-09 16:56:45.000000000","message":"If we rip out the enabled flag, could this not just become something like {{ $probes :\u003d index .Values.pod.probes $containerName }}, followed with something as simple as {{ toYaml $probes}}?  I feel something like that removes the multitude of conditional checks here.","commit_id":"95a2cbf728b0ac3a74a7c810065440872b294f4f"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b27f4f2464b838323d049230dff461aee2cc3476","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  tcpSocket:"},{"line_number":32,"context_line":"    port: 11211"},{"line_number":33,"context_line":"*/}}"},{"line_number":34,"context_line":"{{- define \"helm-toolkit.snippets.probes\" -}}"},{"line_number":35,"context_line":"{{- $envAll :\u003d index . \"envAll\" -}}"},{"line_number":36,"context_line":"{{- $containerName :\u003d index . \"name\" -}}"},{"line_number":37,"context_line":"{{- if hasKey $envAll.Values.pod.probes $containerName -}}"},{"line_number":38,"context_line":"{{- if index $envAll.Values.pod.probes $containerName \"readiness\" }}"},{"line_number":39,"context_line":"readinessProbe:"},{"line_number":40,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"readinessProbe\" | toYaml | indent 2 }}"},{"line_number":41,"context_line":"{{- end }}"},{"line_number":42,"context_line":"{{- end -}}"},{"line_number":43,"context_line":"{{- if hasKey $envAll.Values.pod.probes $containerName -}}"},{"line_number":44,"context_line":"{{- if index $envAll.Values.pod.probes $containerName \"liveness\" }}"},{"line_number":45,"context_line":"livenessProbe:"},{"line_number":46,"context_line":"{{ index $envAll.Values.pod.probes $containerName \"livenessProbe\" | toYaml | indent 2 }}"},{"line_number":47,"context_line":"{{- end }}"},{"line_number":48,"context_line":"{{- end -}}"},{"line_number":49,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_f9c77a11","line":49,"range":{"start_line":34,"start_character":0,"end_line":49,"end_character":11},"in_reply_to":"3f79a3b5_5bb9c92b","updated":"2018-08-09 19:56:59.000000000","message":"Agreed.","commit_id":"95a2cbf728b0ac3a74a7c810065440872b294f4f"}],"memcached/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"81b35bc5129a966c9a503f07c19a04beeaf0aa65","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        timeout: 30"},{"line_number":142,"context_line":"      prometheus_memcached_exporter:"},{"line_number":143,"context_line":"        timeout: 30"},{"line_number":144,"context_line":"  probes:"},{"line_number":145,"context_line":"    memcached:"},{"line_number":146,"context_line":"      readiness: True"},{"line_number":147,"context_line":"      readinessProbe:"},{"line_number":148,"context_line":"        tcpSocket:"},{"line_number":149,"context_line":"          port: 11211"},{"line_number":150,"context_line":"  replicas:"},{"line_number":151,"context_line":"    server: 1"},{"line_number":152,"context_line":"    prometheus_memcached_exporter: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_9b3c41c9","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":21},"updated":"2018-08-09 16:56:45.000000000","message":"Do we need to expose a \"True\" flag here?  Can we just add them in the charts that currently have probes, and exclude them where they\u0027re missing currently? Probes are one thing I\u0027m okay with always having a default for.  This also makes the helm-toolkit snippet much cleaner","commit_id":"95a2cbf728b0ac3a74a7c810065440872b294f4f"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b27f4f2464b838323d049230dff461aee2cc3476","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        timeout: 30"},{"line_number":142,"context_line":"      prometheus_memcached_exporter:"},{"line_number":143,"context_line":"        timeout: 30"},{"line_number":144,"context_line":"  probes:"},{"line_number":145,"context_line":"    memcached:"},{"line_number":146,"context_line":"      readiness: True"},{"line_number":147,"context_line":"      readinessProbe:"},{"line_number":148,"context_line":"        tcpSocket:"},{"line_number":149,"context_line":"          port: 11211"},{"line_number":150,"context_line":"  replicas:"},{"line_number":151,"context_line":"    server: 1"},{"line_number":152,"context_line":"    prometheus_memcached_exporter: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_9951a665","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":21},"in_reply_to":"3f79a3b5_9b3c41c9","updated":"2018-08-09 19:56:59.000000000","message":"I agree. That should clean this up a lot.  This is a quick headstart patch on a spec that\u0027s influx.  I (or someone) can change this once that is finalized.","commit_id":"95a2cbf728b0ac3a74a7c810065440872b294f4f"}]}
