)]}'
{"c3/templates/bin/_calico-settings.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{{ if empty .Values.conf.node.CALICO_IPV4POOL_CIDR }}"},{"line_number":6,"context_line":"{{ $_ :\u003d set .Values.conf.node \"CALICO_IPV4POOL_CIDR\" .Values.networking.podSubnet }}"},{"line_number":7,"context_line":"{{ end }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# An idempotent script for interacting with calicoctl to instantiate"},{"line_number":10,"context_line":"# peers, and manipulate calico settings that we must perform"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_a8f89cc0","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":9},"updated":"2018-10-01 12:55:33.000000000","message":"This should probably be set in configmap-etc instead","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: default"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  logSeverityScreen: Info"},{"line_number":26,"context_line":"  nodeToNodeMeshEnabled: {{ .Values.networking.settings.mesh }}"},{"line_number":27,"context_line":"  asNumber: {{ .Values.networking.bgp.asnumber }}"},{"line_number":28,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_a8117cfa","line":25,"range":{"start_line":25,"start_character":21,"end_line":25,"end_character":25},"updated":"2018-10-01 12:55:33.000000000","message":"Do we want this to be configurable, or is Info the only level supported for the community version?  Generally curious.  If we want the ability to change this severity level, we should expose this knob through values","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: default"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  logSeverityScreen: Info"},{"line_number":26,"context_line":"  nodeToNodeMeshEnabled: {{ .Values.networking.settings.mesh }}"},{"line_number":27,"context_line":"  asNumber: {{ .Values.networking.bgp.asnumber }}"},{"line_number":28,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_b4f3116d","line":25,"range":{"start_line":25,"start_character":21,"end_line":25,"end_character":25},"in_reply_to":"3f79a3b5_a8117cfa","updated":"2018-10-01 16:01:29.000000000","message":"it is via calicoctl","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: default"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  logSeverityScreen: Info"},{"line_number":26,"context_line":"  nodeToNodeMeshEnabled: {{ .Values.networking.settings.mesh }}"},{"line_number":27,"context_line":"  asNumber: {{ .Values.networking.bgp.asnumber }}"},{"line_number":28,"context_line":"EOF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# FelixConfiguration: ipipEnabled"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_48b9c8e9","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":49},"updated":"2018-10-01 12:55:33.000000000","message":"Could we possible place the networking settings under a the Values.conf key? This helps us stay aligned with the spec for values ordering that\u0027s in review currently.  It\u0027ll make the transition after that specs approved easier","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: default"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  logSeverityScreen: Info"},{"line_number":26,"context_line":"  nodeToNodeMeshEnabled: {{ .Values.networking.settings.mesh }}"},{"line_number":27,"context_line":"  asNumber: {{ .Values.networking.bgp.asnumber }}"},{"line_number":28,"context_line":"EOF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# FelixConfiguration: ipipEnabled"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_14668529","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":49},"in_reply_to":"3f79a3b5_48b9c8e9","updated":"2018-10-01 16:01:29.000000000","message":"i\u0027m supporting what was there\nif values.conf is preferred then it\u0027s a matter of do we do that now or later?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  name: default"},{"line_number":36,"context_line":"spec:"},{"line_number":37,"context_line":"  ipipEnabled: {{ .Values.networking.settings.ippool.ipip.enabled }}"},{"line_number":38,"context_line":"  logSeverityScreen: Info"},{"line_number":39,"context_line":"EOF"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# ipPool - https://docs.projectcalico.org/v3.2/reference/calicoctl/resources/ippool"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_c8ccf88b","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":25},"updated":"2018-10-01 12:55:33.000000000","message":"Do we want this configurable?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  name: default-ipv4-ippool"},{"line_number":47,"context_line":"spec:"},{"line_number":48,"context_line":"  cidr: {{ .Values.conf.node.CALICO_IPV4POOL_CIDR }}"},{"line_number":49,"context_line":"  ipipMode: {{ .Values.networking.settings.ippool.ipip.mode }}"},{"line_number":50,"context_line":"  natOutgoing: {{ .Values.networking.settings.ippool.nat_outgoing }}"},{"line_number":51,"context_line":"  disabled: {{ .Values.networking.settings.ippool.disabled }}"},{"line_number":52,"context_line":"EOF"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_e8c9b478","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":61},"updated":"2018-10-01 12:55:33.000000000","message":"Can we move these under the .Values.conf tree for the same reasons as above?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# IPv4 peers"},{"line_number":56,"context_line":"{{ if .Values.networking.bgp.ipv4.peers }}"},{"line_number":57,"context_line":"$CTL apply -f - \u003c\u003cEOF"},{"line_number":58,"context_line":"{{ .Values.networking.bgp.ipv4.peers | toYaml }}"},{"line_number":59,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_88c28053","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":42},"updated":"2018-10-01 12:55:33.000000000","message":"Ditto","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# IPv4 peers"},{"line_number":56,"context_line":"{{ if .Values.networking.bgp.ipv4.peers }}"},{"line_number":57,"context_line":"$CTL apply -f - \u003c\u003cEOF"},{"line_number":58,"context_line":"{{ .Values.networking.bgp.ipv4.peers | toYaml }}"},{"line_number":59,"context_line":"EOF"},{"line_number":60,"context_line":"{{ end }}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_a8bf3cc8","line":58,"range":{"start_line":58,"start_character":3,"end_line":58,"end_character":36},"updated":"2018-10-01 12:55:33.000000000","message":"Ditto","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{{ end }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# IPv6 peers"},{"line_number":63,"context_line":"{{ if .Values.networking.bgp.ipv6.peers }}"},{"line_number":64,"context_line":"$CTL apply -f - \u003c\u003cEOF"},{"line_number":65,"context_line":"{{ .Values.networking.bgp.ipv6.peers | toYaml }}"},{"line_number":66,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_68a364b2","line":63,"range":{"start_line":63,"start_character":6,"end_line":63,"end_character":39},"updated":"2018-10-01 12:55:33.000000000","message":"Ditto","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# IPv6 peers"},{"line_number":63,"context_line":"{{ if .Values.networking.bgp.ipv6.peers }}"},{"line_number":64,"context_line":"$CTL apply -f - \u003c\u003cEOF"},{"line_number":65,"context_line":"{{ .Values.networking.bgp.ipv6.peers | toYaml }}"},{"line_number":66,"context_line":"EOF"},{"line_number":67,"context_line":"{{ end }}"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":27,"id":"3f79a3b5_28a9ec8d","line":65,"range":{"start_line":65,"start_character":3,"end_line":65,"end_character":36},"updated":"2018-10-01 12:55:33.000000000","message":"Ditto","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/c3-kube-controllers-serviceaccount.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3f79a3b5_d711faf9","updated":"2018-10-01 05:08:55.000000000","message":"not required, should be defined in the calico-kube-controlers chart.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/c3-node-serviceaccount.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3f79a3b5_77d0262c","updated":"2018-10-01 05:08:55.000000000","message":"not required, should be defined in the calico-node template","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/configmap-bin.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"kind: ConfigMap"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-bin"},{"line_number":24,"context_line":"  namespace: kube-system"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  image-repo-sync.sh: |"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.scripts.image_repo_sync\" . | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_c852b868","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":24},"updated":"2018-10-01 12:55:33.000000000","message":"Is this required?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":21,"context_line":"kind: ConfigMap"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-bin"},{"line_number":24,"context_line":"  namespace: kube-system"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  image-repo-sync.sh: |"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.scripts.image_repo_sync\" . | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_74333914","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":24},"in_reply_to":"3f79a3b5_c852b868","updated":"2018-10-01 16:01:29.000000000","message":"it\u0027s the only ns that will work","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/configmap-bird.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  # FIXME: badly named ... once we have a working implementation"},{"line_number":25,"context_line":"  # rename appropriately"},{"line_number":26,"context_line":"  name: calico-bird"},{"line_number":27,"context_line":"  namespace: kube-system"},{"line_number":28,"context_line":"data:"},{"line_number":29,"context_line":"  # we overlay templates found natively in the calico-node container"},{"line_number":30,"context_line":"  # so that we may override bgp configuration"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_97d5c21d","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"should not be defined most likely - if required we should have a not here as to why.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":36,"context_line":"{{ tuple \"bird/_bird6.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":37,"context_line":"  bird6_ipam.cfg.template: |"},{"line_number":38,"context_line":"{{ tuple \"bird/_bird6_ipam.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":39,"context_line":"---"},{"line_number":40,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_37d62e28","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":3},"updated":"2018-10-01 05:08:55.000000000","message":"not required.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_bird }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"kind: ConfigMap"},{"line_number":22,"context_line":"apiVersion: v1"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  # FIXME: badly named ... once we have a working implementation"},{"line_number":25,"context_line":"  # rename appropriately"},{"line_number":26,"context_line":"  name: calico-bird"},{"line_number":27,"context_line":"  namespace: kube-system"},{"line_number":28,"context_line":"data:"},{"line_number":29,"context_line":"  # we overlay templates found natively in the calico-node container"},{"line_number":30,"context_line":"  # so that we may override bgp configuration"},{"line_number":31,"context_line":"  bird.cfg.template: |"},{"line_number":32,"context_line":"{{ tuple \"bird/_bird.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":33,"context_line":"  bird_ipam.cfg.template: |"},{"line_number":34,"context_line":"{{ tuple \"bird/_bird_ipam.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":35,"context_line":"  bird6.cfg.template: |"},{"line_number":36,"context_line":"{{ tuple \"bird/_bird6.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":37,"context_line":"  bird6_ipam.cfg.template: |"},{"line_number":38,"context_line":"{{ tuple \"bird/_bird6_ipam.cfg.template.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":39,"context_line":"---"},{"line_number":40,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_a8dadce2","line":40,"range":{"start_line":1,"start_character":0,"end_line":40,"end_character":10},"updated":"2018-10-01 12:55:33.000000000","message":"Should this be defined as a secret instead?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-etc"},{"line_number":24,"context_line":"  namespace: kube-system"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  # The location of your etcd cluster.  This uses the Service clusterIP"},{"line_number":27,"context_line":"  # defined below."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_57dbaa4c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"not required","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-etc"},{"line_number":24,"context_line":"  namespace: kube-system"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  # The location of your etcd cluster.  This uses the Service clusterIP"},{"line_number":27,"context_line":"  # defined below."},{"line_number":28,"context_line":"  etcd_endpoints: {{ tuple \"etcd\" \"internal\" \"client\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  # If you\u0027re using TLS enabled etcd uncomment the following."},{"line_number":31,"context_line":"  # You must also populate the Secret below with these files."},{"line_number":32,"context_line":"  etcd_ca: \"\"   # \"/calico-secrets/etcd-ca\""},{"line_number":33,"context_line":"  etcd_cert: \"\" # \"/calico-secrets/etcd-cert\""},{"line_number":34,"context_line":"  etcd_key: \"\"  # \"/calico-secrets/etcd-key\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # The CNI network configuration to install on each node, generated"},{"line_number":37,"context_line":"  # from (Values.)conf.cni_network_config"},{"line_number":38,"context_line":"  cni_network_config: |-"},{"line_number":39,"context_line":"{{ toJson $envAll.Values.conf.cni_network_config | indent 4 }}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_88dda0df","line":41,"range":{"start_line":1,"start_character":0,"end_line":41,"end_character":10},"updated":"2018-10-01 12:55:33.000000000","message":"Should this not be defined as a secret instead?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"---"},{"line_number":20,"context_line":"kind: ConfigMap"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: calico-etc"},{"line_number":24,"context_line":"  namespace: kube-system"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  # The location of your etcd cluster.  This uses the Service clusterIP"},{"line_number":27,"context_line":"  # defined below."},{"line_number":28,"context_line":"  etcd_endpoints: {{ tuple \"etcd\" \"internal\" \"client\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  # If you\u0027re using TLS enabled etcd uncomment the following."},{"line_number":31,"context_line":"  # You must also populate the Secret below with these files."},{"line_number":32,"context_line":"  etcd_ca: \"\"   # \"/calico-secrets/etcd-ca\""},{"line_number":33,"context_line":"  etcd_cert: \"\" # \"/calico-secrets/etcd-cert\""},{"line_number":34,"context_line":"  etcd_key: \"\"  # \"/calico-secrets/etcd-key\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # The CNI network configuration to install on each node, generated"},{"line_number":37,"context_line":"  # from (Values.)conf.cni_network_config"},{"line_number":38,"context_line":"  cni_network_config: |-"},{"line_number":39,"context_line":"{{ toJson $envAll.Values.conf.cni_network_config | indent 4 }}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9a071f18","line":41,"range":{"start_line":1,"start_character":0,"end_line":41,"end_character":10},"in_reply_to":"3f79a3b5_88dda0df","updated":"2018-10-01 16:01:29.000000000","message":"stuff left over from upstream, will be removed","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/daemonset-c3-etcd.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"calico-etcd\"}}"},{"line_number":21,"context_line":"{{/* tuple $envAll \"etcd\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" */}}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":24,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_b7e9dee4","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":4},"updated":"2018-10-01 05:08:55.000000000","message":"should be uncommented to allow deps to work if specified.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"calico-etcd\"}}"},{"line_number":21,"context_line":"{{/* tuple $envAll \"etcd\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" */}}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":24,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7ad6c328","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":4},"in_reply_to":"3f79a3b5_b7e9dee4","updated":"2018-10-01 16:18:23.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":27,"context_line":"kind: DaemonSet"},{"line_number":28,"context_line":"metadata:"},{"line_number":29,"context_line":"  name: calico-etcd"},{"line_number":30,"context_line":"  namespace: kube-system"},{"line_number":31,"context_line":"  annotations:"},{"line_number":32,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":33,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_f7e3d604","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"not required.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"kind: DaemonSet"},{"line_number":28,"context_line":"metadata:"},{"line_number":29,"context_line":"  name: calico-etcd"},{"line_number":30,"context_line":"  namespace: kube-system"},{"line_number":31,"context_line":"  annotations:"},{"line_number":32,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":33,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9adb9f4c","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":24},"in_reply_to":"3f79a3b5_f7e3d604","updated":"2018-10-01 16:18:23.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59bf3de9f697ef034b23d753383b155117dbae3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.daemonset_calico_etcd }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":22,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_8f9d9b0a","line":19,"updated":"2018-10-01 21:59:10.000000000","message":"you should include the service account name here, and then bind it to the pod.","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"507bb15dbf6ef7f48dfe1390c2c8dc6fd148e100","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.daemonset_calico_etcd }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":22,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_81b00fde","line":19,"in_reply_to":"3f79a3b5_8f9d9b0a","updated":"2018-10-01 22:52:20.000000000","message":"it has a name below","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"}],"c3/templates/daemonset-c3-node.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- if empty .Values.conf.node.CALICO_IPV4POOL_CIDR -}}"},{"line_number":23,"context_line":"{{- $_ :\u003d set .Values.conf.node \"CALICO_IPV4POOL_CIDR\" .Values.networking.podSubnet -}}"},{"line_number":24,"context_line":"# DEPRECATION WARNING: using networking.podSubnet"},{"line_number":25,"context_line":"{{- end -}}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{- if empty .Values.conf.node.FELIX_IPINIPMTU -}}"},{"line_number":28,"context_line":"{{- $_ :\u003d set .Values.conf.node \"FELIX_IPINIPMTU\" .Values.networking.mtu -}}"},{"line_number":29,"context_line":"# DEPRECATION WARNING: using networking.mtu"},{"line_number":30,"context_line":"{{- end -}}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_0898b017","line":30,"range":{"start_line":22,"start_character":0,"end_line":30,"end_character":11},"updated":"2018-10-01 12:55:33.000000000","message":"Can these be set in the configmap instead?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1a1d145d08e6c96f1cd26b7d399a6c64fbf908b7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"was not valid and should be removed entirely"},{"line_number":38,"context_line":"*/}}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{{- if gt (int .Values.conf.node.FELIX_IPINIPMTU) 1440 -}}"},{"line_number":41,"context_line":"{{- $_ :\u003d set .Values.conf.node \"FELIX_IPINIPMTU\" (sub .Values.conf.node.FELIX_IPINIPMTU 60) -}}"},{"line_number":42,"context_line":"{{- end -}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{{- if empty .Values.conf.node.CNI_MTU -}}"},{"line_number":45,"context_line":"{{- $_ :\u003d set .Values.conf.node \"CNI_MTU\" .Values.conf.node.FELIX_IPINIPMTU -}}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_5cf191ff","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":11},"updated":"2018-09-30 22:54:27.000000000","message":"this does not account for when the fabric can support greater mtu\u0027s. Additionally altering params like this on the fly when explicitly set is a bit sketchy. Would it not make more sense to bring in the existing logic here, that subtracted the encap overhead from the physical if not explicitly defined: https://github.com/openstack/openstack-helm-infra/blob/master/calico/templates/daemonset-calico-node.yaml#L24-L35","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      labels:"},{"line_number":104,"context_line":"        k8s-app: calico-node"},{"line_number":105,"context_line":"{{ tuple $envAll \"calico\" \"node\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":106,"context_line":"      annotations:"},{"line_number":107,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":108,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":109,"context_line":"        configmap-bird-hash: {{ tuple \"configmap-bird.yaml\" . | include \"helm-toolkit.utils.hash\" }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_832a617b","line":106,"range":{"start_line":106,"start_character":6,"end_line":106,"end_character":17},"updated":"2018-10-01 12:55:33.000000000","message":"We need to include the Prometheus annotations here so we can monitor the calico nodes: https://github.com/openstack/openstack-helm-infra/blob/master/calico/templates/daemonset-calico-node.yaml#L94-L96","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0a24e167e2601ae540f3cad09fca64505a08ae11","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      labels:"},{"line_number":104,"context_line":"        k8s-app: calico-node"},{"line_number":105,"context_line":"{{ tuple $envAll \"calico\" \"node\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":106,"context_line":"      annotations:"},{"line_number":107,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":108,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":109,"context_line":"        configmap-bird-hash: {{ tuple \"configmap-bird.yaml\" . | include \"helm-toolkit.utils.hash\" }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_401f5808","line":106,"range":{"start_line":106,"start_character":6,"end_line":106,"end_character":17},"in_reply_to":"3f79a3b5_832a617b","updated":"2018-10-01 17:26:22.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      labels:"},{"line_number":104,"context_line":"        k8s-app: calico-node"},{"line_number":105,"context_line":"{{ tuple $envAll \"calico\" \"node\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":106,"context_line":"      annotations:"},{"line_number":107,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":108,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":109,"context_line":"        configmap-bird-hash: {{ tuple \"configmap-bird.yaml\" . | include \"helm-toolkit.utils.hash\" }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_fa15f33e","line":106,"range":{"start_line":106,"start_character":6,"end_line":106,"end_character":17},"in_reply_to":"3f79a3b5_832a617b","updated":"2018-10-01 16:01:29.000000000","message":"will add those soon","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"          securityContext:"},{"line_number":240,"context_line":"            privileged: true"},{"line_number":241,"context_line":"          resources:"},{"line_number":242,"context_line":"            requests:"},{"line_number":243,"context_line":"              cpu: 250m"},{"line_number":244,"context_line":"          livenessProbe:"},{"line_number":245,"context_line":"            httpGet:"},{"line_number":246,"context_line":"              path: /liveness"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_c8ae382e","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":23},"updated":"2018-10-01 12:55:33.000000000","message":"should be handled via helm-toolkit","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"          securityContext:"},{"line_number":240,"context_line":"            privileged: true"},{"line_number":241,"context_line":"          resources:"},{"line_number":242,"context_line":"            requests:"},{"line_number":243,"context_line":"              cpu: 250m"},{"line_number":244,"context_line":"          livenessProbe:"},{"line_number":245,"context_line":"            httpGet:"},{"line_number":246,"context_line":"              path: /liveness"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_1a2c6f91","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":23},"in_reply_to":"3f79a3b5_c8ae382e","updated":"2018-10-01 16:01:29.000000000","message":"why?  it diverges from upstream, i would prefer to leave as-is unless we\u0027re sure we need to change these (we never have before)","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/deployment-c3-kube-controllers.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":63,"context_line":"kind: Deployment"},{"line_number":64,"context_line":"metadata:"},{"line_number":65,"context_line":"  name: calico-kube-controllers"},{"line_number":66,"context_line":"  namespace: kube-system"},{"line_number":67,"context_line":"  labels:"},{"line_number":68,"context_line":"    k8s-app: calico-kube-controllers"},{"line_number":69,"context_line":"{{ tuple $envAll \"calico\" \"kube-controllers\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_77b906ea","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"not required","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"kind: Deployment"},{"line_number":64,"context_line":"metadata:"},{"line_number":65,"context_line":"  name: calico-kube-controllers"},{"line_number":66,"context_line":"  namespace: kube-system"},{"line_number":67,"context_line":"  labels:"},{"line_number":68,"context_line":"    k8s-app: calico-kube-controllers"},{"line_number":69,"context_line":"{{ tuple $envAll \"calico\" \"kube-controllers\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9ab4fff2","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":24},"in_reply_to":"3f79a3b5_77b906ea","updated":"2018-10-01 16:18:23.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            secretName: calico-etcd-secrets"},{"line_number":164,"context_line":"            defaultMode: 0400"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"---"},{"line_number":167,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_b7c23e53","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":3},"updated":"2018-10-01 05:08:55.000000000","message":"not required","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/job-calico-settings.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.job_calico_settings }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{/* uses the same sa as the node pods and to install the cni */}}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- $serviceAccountName :\u003d \"calico-node\"}}"},{"line_number":23,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_779ee669","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":66},"updated":"2018-10-01 05:08:55.000000000","message":"we should give it its own, more limited sa.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59bf3de9f697ef034b23d753383b155117dbae3c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.job_calico_settings }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{/* uses the same sa as the node pods and to install the cni */}}"},{"line_number":21,"context_line":"{{- $serviceAccountName :\u003d \"calico-node\"}}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: batch/v1"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_ef8befbd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":66},"updated":"2018-10-01 21:59:10.000000000","message":"this should use its own service account.","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"507bb15dbf6ef7f48dfe1390c2c8dc6fd148e100","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.job_calico_settings }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{/* uses the same sa as the node pods and to install the cni */}}"},{"line_number":21,"context_line":"{{- $serviceAccountName :\u003d \"calico-node\"}}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: batch/v1"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_41c6774b","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":66},"in_reply_to":"3f79a3b5_ef8befbd","updated":"2018-10-01 22:52:20.000000000","message":"why?","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"}],"c3/templates/pod-calicoctl.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3f79a3b5_57a96a8c","updated":"2018-10-01 05:08:55.000000000","message":"we should probably remove this for now, while developing a more robust method for utility containers.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/secret-etcd-certificates.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":23,"context_line":"type: kubernetes.io/tls"},{"line_number":24,"context_line":"metadata:"},{"line_number":25,"context_line":"  name: calico-etcd-secrets"},{"line_number":26,"context_line":"  namespace: kube-system"},{"line_number":27,"context_line":"data:"},{"line_number":28,"context_line":"  tls.ca: {{ .Values.endpoints.etcd.auth.client.tls.ca | default \"\" | b64enc }}"},{"line_number":29,"context_line":"  tls.key: {{ .Values.endpoints.etcd.auth.client.tls.key | default \"\" | b64enc }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_f7919654","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"not required.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/templates/service-c3-etcd.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# etcd."},{"line_number":22,"context_line":"apiVersion: v1"},{"line_number":23,"context_line":"kind: Service"},{"line_number":24,"context_line":"metadata:"},{"line_number":25,"context_line":"  labels:"},{"line_number":26,"context_line":"    k8s-app: calico-etcd"},{"line_number":27,"context_line":"  name: calico-etcd"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_23026d09","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":9},"updated":"2018-10-01 12:55:33.000000000","message":"We\u0027ll also want to add the Prometheus annotations so we can effectively monitor the calico etcd instances","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  labels:"},{"line_number":26,"context_line":"    k8s-app: calico-etcd"},{"line_number":27,"context_line":"  name: calico-etcd"},{"line_number":28,"context_line":"  namespace: kube-system"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  # Select the calico-etcd pod running on the master."},{"line_number":31,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_178f722e","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":24},"updated":"2018-10-01 05:08:55.000000000","message":"not required.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"c3/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"labels:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"images:"},{"line_number":18,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_4849c88b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"updated":"2018-10-01 12:55:33.000000000","message":"We should either add the jobs key to this to maintain consistency with the current chart, or remove this if not required","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"5e6dc2ddad522de20ea72a65adbda5964336e73c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"labels:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"images:"},{"line_number":18,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7ae323a1","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"3f79a3b5_3a67ebec","updated":"2018-10-01 16:30:06.000000000","message":"Agree on jobs key - calico-settings can run anywhere right now IIRC.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0a6b37400ff4d5270872a791a651ac2780b5339","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"labels:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"images:"},{"line_number":18,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_3a67ebec","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"3f79a3b5_4849c88b","updated":"2018-10-01 16:01:29.000000000","message":"it was there to make context diffing work better\nprobably we just make us of it","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"136945b3ecf844aecdd8522b17ee1bd2a3e05764","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"labels:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"images:"},{"line_number":18,"context_line":"  tags:"},{"line_number":19,"context_line":"    calico_etcd: quay.io/coreos/etcd:v3.3.9"},{"line_number":20,"context_line":"    calico_node: quay.io/calico/node:v3.2.1"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_bd0215b9","line":17,"updated":"2018-10-01 16:44:05.000000000","message":"I think a comment on the minimum version supported may be relevant here. When the final v3 patch is submitted, presumably, we will be doing v3 only things within calico-settings, and you wouldn\u0027t, for example, be able to use v2 images with this chart.  Worth pointing out to end users.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0f793d34d3e099c124a746f233d36f33ee9d57c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"labels:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"images:"},{"line_number":18,"context_line":"  tags:"},{"line_number":19,"context_line":"    calico_etcd: quay.io/coreos/etcd:v3.3.9"},{"line_number":20,"context_line":"    calico_node: quay.io/calico/node:v3.2.1"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_fdd3ad00","line":17,"in_reply_to":"3f79a3b5_bd0215b9","updated":"2018-10-01 16:51:34.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - calico_cni"},{"line_number":37,"context_line":"      - calico_kube_controllers"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"dependencies:"},{"line_number":42,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_b7979e46","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":4},"updated":"2018-10-01 05:08:55.000000000","message":"extra key?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - calico_cni"},{"line_number":37,"context_line":"      - calico_kube_controllers"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"pod:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"dependencies:"},{"line_number":42,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7a7d631c","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":4},"in_reply_to":"3f79a3b5_b7979e46","updated":"2018-10-01 16:18:23.000000000","message":"sentinel for context diffing\n\nwill fix","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"54b02184cdb2b1e7854efb9020dc3a67bc4a106e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      peer:"},{"line_number":110,"context_line":"        default: 6667"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"monitoring:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"networking:"},{"line_number":115,"context_line":"  # podSubnet is deprecated, please use conf.node.CALICO_IPV4POOL_CIDR"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_28448c72","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":11},"updated":"2018-10-01 12:55:33.000000000","message":"We should be sure to add the prometheus bits here, and likely add the annotations to the calico etcd service.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"0a24e167e2601ae540f3cad09fca64505a08ae11","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      peer:"},{"line_number":110,"context_line":"        default: 6667"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"monitoring:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"networking:"},{"line_number":115,"context_line":"  # podSubnet is deprecated, please use conf.node.CALICO_IPV4POOL_CIDR"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_601cd412","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":11},"in_reply_to":"3f79a3b5_28448c72","updated":"2018-10-01 17:26:22.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7b6baa7622dff79a66aa4b8d0746a09937320998","unresolved":false,"context_lines":[{"line_number":112,"context_line":"monitoring:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"networking:"},{"line_number":115,"context_line":"  # podSubnet is deprecated, please use conf.node.CALICO_IPV4POOL_CIDR"},{"line_number":116,"context_line":"  podSubnet: 10.24.0.0/16"},{"line_number":117,"context_line":"  # mtu is deprecated, please use FELIX_IPINIPMTU"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_3792ae4b","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":70},"updated":"2018-10-01 05:12:49.000000000","message":"why? we use this in other cni charts, eg flannel - is ther a reason to change this?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"monitoring:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"networking:"},{"line_number":115,"context_line":"  # podSubnet is deprecated, please use conf.node.CALICO_IPV4POOL_CIDR"},{"line_number":116,"context_line":"  podSubnet: 10.24.0.0/16"},{"line_number":117,"context_line":"  # mtu is deprecated, please use FELIX_IPINIPMTU"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_3ac92b59","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":70},"in_reply_to":"3f79a3b5_3792ae4b","updated":"2018-10-01 16:18:23.000000000","message":"talk to steve, decide which you want","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7b6baa7622dff79a66aa4b8d0746a09937320998","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  podSubnet: 10.24.0.0/16"},{"line_number":117,"context_line":"  # mtu is deprecated, please use FELIX_IPINIPMTU"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # NOTE: 1420 is used here very deliberately so then when looking at"},{"line_number":120,"context_line":"  # the rendered charts or a running system it can be distinguished"},{"line_number":121,"context_line":"  # from the 1440 value below (both will work)"},{"line_number":122,"context_line":"  mtu: 1420"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  # FIXME: consider splitting this to top-level/global configuration"},{"line_number":125,"context_line":"  # (felix and bgp) and replacing ippool with an embedded ippoollist"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_f79f564e","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":11},"updated":"2018-10-01 05:12:49.000000000","message":"as discussed, we will use the same values as the v2 calico chart here.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  podSubnet: 10.24.0.0/16"},{"line_number":117,"context_line":"  # mtu is deprecated, please use FELIX_IPINIPMTU"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # NOTE: 1420 is used here very deliberately so then when looking at"},{"line_number":120,"context_line":"  # the rendered charts or a running system it can be distinguished"},{"line_number":121,"context_line":"  # from the 1440 value below (both will work)"},{"line_number":122,"context_line":"  mtu: 1420"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  # FIXME: consider splitting this to top-level/global configuration"},{"line_number":125,"context_line":"  # (felix and bgp) and replacing ippool with an embedded ippoollist"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_fabe53ad","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":11},"in_reply_to":"3f79a3b5_f79f564e","updated":"2018-10-01 16:18:23.000000000","message":"will fix soon","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"5e6dc2ddad522de20ea72a65adbda5964336e73c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      # this is a list of additional IPv4 cidrs that if we discover"},{"line_number":159,"context_line":"      # IPs within them on a host, we will announce the address in"},{"line_number":160,"context_line":"      # addition to traditional pod workloads"},{"line_number":161,"context_line":"      additional_cidrs: [ \"10.11.0.0/16\" ]"},{"line_number":162,"context_line":"      # FIXME; this distinction isn\u0027t needed, consolidate"},{"line_number":163,"context_line":"      mesh:"},{"line_number":164,"context_line":"        port:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_fa8bb3bd","line":161,"updated":"2018-10-01 16:30:06.000000000","message":"Presumably this was just for testing - I imagine real values this will remain []","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"942f7f9c04292e9c42157f511b80d20407d24408","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  controllers:"},{"line_number":238,"context_line":"    # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":239,"context_line":"    # service for API access."},{"line_number":240,"context_line":"    K8S_API: \"https://kubernetes.default:443\""},{"line_number":241,"context_line":"    # Choose which controllers to run."},{"line_number":242,"context_line":"    ENABLED_CONTROLLERS: \"policy,profile,workloadendpoint,node\""},{"line_number":243,"context_line":"    # Since we\u0027re running in the host namespace and might not have KubeDNS"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_377dce1d","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":45},"updated":"2018-10-01 05:08:55.000000000","message":"can we use the following here?`https://__KUBERNETES_SERVICE_HOST__:__KUBERNETES_SERVICE_PORT__` alternatively, we should probably populate this from the endpoints section.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7b6baa7622dff79a66aa4b8d0746a09937320998","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  controllers:"},{"line_number":238,"context_line":"    # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":239,"context_line":"    # service for API access."},{"line_number":240,"context_line":"    K8S_API: \"https://kubernetes.default:443\""},{"line_number":241,"context_line":"    # Choose which controllers to run."},{"line_number":242,"context_line":"    ENABLED_CONTROLLERS: \"policy,profile,workloadendpoint,node\""},{"line_number":243,"context_line":"    # Since we\u0027re running in the host namespace and might not have KubeDNS"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_b770fe42","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":45},"in_reply_to":"3f79a3b5_377dce1d","updated":"2018-10-01 05:12:49.000000000","message":"looks like we cant, let\u0027s do this in a follow on ps.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  controllers:"},{"line_number":238,"context_line":"    # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":239,"context_line":"    # service for API access."},{"line_number":240,"context_line":"    K8S_API: \"https://kubernetes.default:443\""},{"line_number":241,"context_line":"    # Choose which controllers to run."},{"line_number":242,"context_line":"    ENABLED_CONTROLLERS: \"policy,profile,workloadendpoint,node\""},{"line_number":243,"context_line":"    # Since we\u0027re running in the host namespace and might not have KubeDNS"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9a971f3a","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":45},"in_reply_to":"3f79a3b5_377dce1d","updated":"2018-10-01 16:18:23.000000000","message":"not as is","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  controllers:"},{"line_number":238,"context_line":"    # The location of the Kubernetes API.  Use the default Kubernetes"},{"line_number":239,"context_line":"    # service for API access."},{"line_number":240,"context_line":"    K8S_API: \"https://kubernetes.default:443\""},{"line_number":241,"context_line":"    # Choose which controllers to run."},{"line_number":242,"context_line":"    ENABLED_CONTROLLERS: \"policy,profile,workloadendpoint,node\""},{"line_number":243,"context_line":"    # Since we\u0027re running in the host namespace and might not have KubeDNS"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_3aa04b91","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":45},"in_reply_to":"3f79a3b5_b770fe42","updated":"2018-10-01 16:18:23.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7b6baa7622dff79a66aa4b8d0746a09937320998","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    # Set Felix endpoint to host default action to ACCEPT."},{"line_number":273,"context_line":"    FELIX_DEFAULTENDPOINTTOHOSTACTION: \"ACCEPT\""},{"line_number":274,"context_line":"    # Configure the IP Pool from which Pod IPs will be chosen."},{"line_number":275,"context_line":"    CALICO_IPV4POOL_CIDR: 192.168.0.0/16"},{"line_number":276,"context_line":"    # Change this to \u0027off\u0027 in environments with direct L2 communication"},{"line_number":277,"context_line":"    # Titlecase"},{"line_number":278,"context_line":"    CALICO_IPV4POOL_IPIP: \"Always\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_d76d7a67","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":40},"updated":"2018-10-01 05:12:49.000000000","message":"we should take this from:\n```\nnetworking:\n  podSubnet: 192.168.0.0/16\n```","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0f793d34d3e099c124a746f233d36f33ee9d57c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    # Set Felix endpoint to host default action to ACCEPT."},{"line_number":273,"context_line":"    FELIX_DEFAULTENDPOINTTOHOSTACTION: \"ACCEPT\""},{"line_number":274,"context_line":"    # Configure the IP Pool from which Pod IPs will be chosen."},{"line_number":275,"context_line":"    CALICO_IPV4POOL_CIDR: 192.168.0.0/16"},{"line_number":276,"context_line":"    # Change this to \u0027off\u0027 in environments with direct L2 communication"},{"line_number":277,"context_line":"    # Titlecase"},{"line_number":278,"context_line":"    CALICO_IPV4POOL_IPIP: \"Always\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_dd083192","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":40},"in_reply_to":"3f79a3b5_7a0d633e","updated":"2018-10-01 16:51:34.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"5e6dc2ddad522de20ea72a65adbda5964336e73c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    # Set Felix endpoint to host default action to ACCEPT."},{"line_number":273,"context_line":"    FELIX_DEFAULTENDPOINTTOHOSTACTION: \"ACCEPT\""},{"line_number":274,"context_line":"    # Configure the IP Pool from which Pod IPs will be chosen."},{"line_number":275,"context_line":"    CALICO_IPV4POOL_CIDR: 192.168.0.0/16"},{"line_number":276,"context_line":"    # Change this to \u0027off\u0027 in environments with direct L2 communication"},{"line_number":277,"context_line":"    # Titlecase"},{"line_number":278,"context_line":"    CALICO_IPV4POOL_IPIP: \"Always\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7a0d633e","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":40},"in_reply_to":"3f79a3b5_9ae5dfdd","updated":"2018-10-01 16:30:06.000000000","message":"I\u0027m not sure I quite understand the relationship of networking.podSubnet and networking.mtu.  In the original values file they were left as `null` so networking.podSubnet could drive.  Here you\u0027re saying you explicitly need to nullify this default arbitrary subnet value in an override to allow networking.podSubnet to take effect?","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"517d0c714fc1feda0f517ebdb4940013dcff7aa2","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    # Set Felix endpoint to host default action to ACCEPT."},{"line_number":273,"context_line":"    FELIX_DEFAULTENDPOINTTOHOSTACTION: \"ACCEPT\""},{"line_number":274,"context_line":"    # Configure the IP Pool from which Pod IPs will be chosen."},{"line_number":275,"context_line":"    CALICO_IPV4POOL_CIDR: 192.168.0.0/16"},{"line_number":276,"context_line":"    # Change this to \u0027off\u0027 in environments with direct L2 communication"},{"line_number":277,"context_line":"    # Titlecase"},{"line_number":278,"context_line":"    CALICO_IPV4POOL_IPIP: \"Always\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9ae5dfdd","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":40},"in_reply_to":"3f79a3b5_d76d7a67","updated":"2018-10-01 16:18:23.000000000","message":"if it\u0027s null we will\nthe differences here were testing the chart with different/mixed configuration permutations","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"5e6dc2ddad522de20ea72a65adbda5964336e73c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    # Disable IPv6 on Kubernetes."},{"line_number":280,"context_line":"    FELIX_IPV6SUPPORT: \"false\""},{"line_number":281,"context_line":"    # Set MTU for tunnel device used if ipip is enabled"},{"line_number":282,"context_line":"    FELIX_IPINIPMTU: 1440"},{"line_number":283,"context_line":"    # Set Felix logging to \"info\""},{"line_number":284,"context_line":"    FELIX_LOGSEVERITYSCREEN: \"info\""},{"line_number":285,"context_line":"    FELIX_HEALTHENABLED: \"true\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_9a12bf60","line":282,"updated":"2018-10-01 16:30:06.000000000","message":"Same argument as above.","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e0f793d34d3e099c124a746f233d36f33ee9d57c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    # Disable IPv6 on Kubernetes."},{"line_number":280,"context_line":"    FELIX_IPV6SUPPORT: \"false\""},{"line_number":281,"context_line":"    # Set MTU for tunnel device used if ipip is enabled"},{"line_number":282,"context_line":"    FELIX_IPINIPMTU: 1440"},{"line_number":283,"context_line":"    # Set Felix logging to \"info\""},{"line_number":284,"context_line":"    FELIX_LOGSEVERITYSCREEN: \"info\""},{"line_number":285,"context_line":"    FELIX_HEALTHENABLED: \"true\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_7df9dd7f","line":282,"in_reply_to":"3f79a3b5_9a12bf60","updated":"2018-10-01 16:51:34.000000000","message":"Done","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"}],"calico/templates/daemonset-calico-etcd.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59bf3de9f697ef034b23d753383b155117dbae3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"calico-etcd\"}}"},{"line_number":21,"context_line":"{{ tuple $envAll \"calico-etcd\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":24,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_cfc073e3","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":25},"updated":"2018-10-01 21:59:10.000000000","message":"this will need a change to the dependency tree.","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"bc661c7ae9a24f8294e1191379efadfb0ecdcb40","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"calico-etcd\"}}"},{"line_number":21,"context_line":"{{ tuple $envAll \"calico-etcd\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":24,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_61f93380","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":25},"in_reply_to":"3f79a3b5_cfc073e3","updated":"2018-10-01 22:55:05.000000000","message":"Done","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"507bb15dbf6ef7f48dfe1390c2c8dc6fd148e100","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- $serviceAccountName :\u003d \"calico-etcd\"}}"},{"line_number":21,"context_line":"{{ tuple $envAll \"calico-etcd\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"# This manifest installs the Calico etcd on the kubeadm master.  This uses a DaemonSet"},{"line_number":24,"context_line":"# to force it to run on the master even when the master isn\u0027t schedulable, and uses"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3f79a3b5_01bcffb2","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":25},"in_reply_to":"3f79a3b5_cfc073e3","updated":"2018-10-01 22:52:20.000000000","message":"that should be there, i\u0027ll check","commit_id":"21ddd5d8332f445652e5f2e132266e711dece77b"}],"calico/templates/daemonset-calico-node.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59bf3de9f697ef034b23d753383b155117dbae3c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{{- end -}}"},{"line_number":34,"context_line":"{{- end -}}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{- $prometheus_annotations :\u003d $envAll.Values.monitoring.prometheus.calico_node }}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"calico-cni-plugin\"}}"},{"line_number":39,"context_line":"{{ tuple $envAll \"calico_node\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3f79a3b5_8fb6fb88","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":82},"updated":"2018-10-01 21:59:10.000000000","message":"should these be removed?","commit_id":"6160d53ef60e95d21a5584039c0fdbe16173c8bb"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"507bb15dbf6ef7f48dfe1390c2c8dc6fd148e100","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{{- end -}}"},{"line_number":34,"context_line":"{{- end -}}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{- $prometheus_annotations :\u003d $envAll.Values.monitoring.prometheus.calico_node }}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{{- $serviceAccountName :\u003d printf \"%s-%s\" .Release.Name \"calico-cni-plugin\"}}"},{"line_number":39,"context_line":"{{ tuple $envAll \"calico_node\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3f79a3b5_c1dfe709","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":82},"in_reply_to":"3f79a3b5_8fb6fb88","updated":"2018-10-01 22:52:20.000000000","message":"it\u0027s not removed, it\u0027s below where it\u0027s used","commit_id":"6160d53ef60e95d21a5584039c0fdbe16173c8bb"}],"calico/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"136945b3ecf844aecdd8522b17ee1bd2a3e05764","unresolved":false,"context_lines":[{"line_number":223,"context_line":"      # this is a list of additional IPv4 cidrs that if we discover"},{"line_number":224,"context_line":"      # IPs within them on a host, we will announce the address in"},{"line_number":225,"context_line":"      # addition to traditional pod workloads"},{"line_number":226,"context_line":"      additional_cidrs: [ \"10.11.0.0/16\" ]"},{"line_number":227,"context_line":"      # FIXME; this distinction isn\u0027t needed, consolidate"},{"line_number":228,"context_line":"      mesh:"},{"line_number":229,"context_line":"        port:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_5dc0a17c","line":226,"updated":"2018-10-01 16:44:05.000000000","message":"Remember to empty this on the final submission","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"136945b3ecf844aecdd8522b17ee1bd2a3e05764","unresolved":false,"context_lines":[{"line_number":252,"context_line":"      # this is a list of additional IPv6 cidrs that if we discover"},{"line_number":253,"context_line":"      # IPs within them on a host, we will announce them in addition"},{"line_number":254,"context_line":"      # to traditional pod workloads"},{"line_number":255,"context_line":"      additional_cidrs: [ \"2600:9000:5300/48\" ]"},{"line_number":256,"context_line":"      # FIXME; this distinction isn\u0027t needed, consolidate"},{"line_number":257,"context_line":"      mesh:"},{"line_number":258,"context_line":"        port:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f79a3b5_bd3455ad","line":255,"updated":"2018-10-01 16:44:05.000000000","message":"Same","commit_id":"a71869c2f0425e5094f9dbe07941e3fec0a99fc9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e2fb5a5fb87acfc1b54522af48414498a8d4982a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      disabled: \"false\""},{"line_number":197,"context_line":"  bgp:"},{"line_number":198,"context_line":"    # our asnumber for bgp peering"},{"line_number":199,"context_line":"    asnumber: 64671"},{"line_number":200,"context_line":"    ipv4:"},{"line_number":201,"context_line":"      # https://docs.projectcalico.org/v2.0/reference/calicoctl/resources/bgppeer"},{"line_number":202,"context_line":"      #"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_3e949f40","line":199,"range":{"start_line":199,"start_character":14,"end_line":199,"end_character":19},"updated":"2018-10-02 21:22:33.000000000","message":"can we revert to the previous arbitrary value.","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"114625961892f05bb84f0dc1adc892eaeaaa9816","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      disabled: \"false\""},{"line_number":197,"context_line":"  bgp:"},{"line_number":198,"context_line":"    # our asnumber for bgp peering"},{"line_number":199,"context_line":"    asnumber: 64671"},{"line_number":200,"context_line":"    ipv4:"},{"line_number":201,"context_line":"      # https://docs.projectcalico.org/v2.0/reference/calicoctl/resources/bgppeer"},{"line_number":202,"context_line":"      #"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_a19f32b1","line":199,"range":{"start_line":199,"start_character":14,"end_line":199,"end_character":19},"in_reply_to":"3f79a3b5_3e949f40","updated":"2018-10-02 21:50:43.000000000","message":"Done","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e2fb5a5fb87acfc1b54522af48414498a8d4982a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"      # this is a list of additional IPv4 cidrs that if we discover"},{"line_number":217,"context_line":"      # IPs within them on a host, we will announce the address in"},{"line_number":218,"context_line":"      # addition to traditional pod workloads"},{"line_number":219,"context_line":"      additional_cidrs: [ \"10.11.0.0/16\" ]"},{"line_number":220,"context_line":"      mesh:"},{"line_number":221,"context_line":"        port:"},{"line_number":222,"context_line":"          neighbor: 179"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_fea2a7ac","line":219,"range":{"start_line":219,"start_character":26,"end_line":219,"end_character":40},"updated":"2018-10-02 21:22:33.000000000","message":"remove","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"114625961892f05bb84f0dc1adc892eaeaaa9816","unresolved":false,"context_lines":[{"line_number":216,"context_line":"      # this is a list of additional IPv4 cidrs that if we discover"},{"line_number":217,"context_line":"      # IPs within them on a host, we will announce the address in"},{"line_number":218,"context_line":"      # addition to traditional pod workloads"},{"line_number":219,"context_line":"      additional_cidrs: [ \"10.11.0.0/16\" ]"},{"line_number":220,"context_line":"      mesh:"},{"line_number":221,"context_line":"        port:"},{"line_number":222,"context_line":"          neighbor: 179"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_c1a26efb","line":219,"range":{"start_line":219,"start_character":26,"end_line":219,"end_character":40},"in_reply_to":"3f79a3b5_fea2a7ac","updated":"2018-10-02 21:50:43.000000000","message":"Done","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e2fb5a5fb87acfc1b54522af48414498a8d4982a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"      # this is a list of additional IPv6 cidrs that if we discover"},{"line_number":245,"context_line":"      # IPs within them on a host, we will announce them in addition"},{"line_number":246,"context_line":"      # to traditional pod workloads"},{"line_number":247,"context_line":"      additional_cidrs: [ \"2600::/48\" ]"},{"line_number":248,"context_line":"      mesh:"},{"line_number":249,"context_line":"        port:"},{"line_number":250,"context_line":"          neighbor: 179"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_5e939b5c","line":247,"range":{"start_line":247,"start_character":26,"end_line":247,"end_character":37},"updated":"2018-10-02 21:22:33.000000000","message":"remove","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"114625961892f05bb84f0dc1adc892eaeaaa9816","unresolved":false,"context_lines":[{"line_number":244,"context_line":"      # this is a list of additional IPv6 cidrs that if we discover"},{"line_number":245,"context_line":"      # IPs within them on a host, we will announce them in addition"},{"line_number":246,"context_line":"      # to traditional pod workloads"},{"line_number":247,"context_line":"      additional_cidrs: [ \"2600::/48\" ]"},{"line_number":248,"context_line":"      mesh:"},{"line_number":249,"context_line":"        port:"},{"line_number":250,"context_line":"          neighbor: 179"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3f79a3b5_81a8f6d8","line":247,"range":{"start_line":247,"start_character":26,"end_line":247,"end_character":37},"in_reply_to":"3f79a3b5_5e939b5c","updated":"2018-10-02 21:50:43.000000000","message":"Done","commit_id":"8e948347ceb7320be6553334fec2b888e57afd27"}]}