)]}'
{".zuul.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":245,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":246,"context_line":"    vars:"},{"line_number":247,"context_line":"      gate_scripts:"},{"line_number":248,"context_line":"        - ./tools/deployment/osh-infra-logging/000-install-packages.sh"},{"line_number":249,"context_line":"        - ./tools/deployment/osh-infra-logging/005-deploy-k8s.sh"},{"line_number":250,"context_line":"        - ./tools/deployment/osh-infra-logging/010-ingress.sh"},{"line_number":251,"context_line":"        - ./tools/deployment/osh-infra-logging/020-ceph.sh"},{"line_number":252,"context_line":"        - ./tools/deployment/osh-infra-logging/025-ceph-ns-activate.sh"},{"line_number":253,"context_line":"        - ./tools/deployment/osh-infra-logging/030-radosgw-osh-infra.sh"},{"line_number":254,"context_line":"        - ./tools/deployment/osh-infra-logging/040-ldap.sh"},{"line_number":255,"context_line":"        - ./tools/deployment/osh-infra-logging/050-elasticsearch.sh"},{"line_number":256,"context_line":"        - ./tools/deployment/osh-infra-logging/055-elasticsearch-ldap.sh"},{"line_number":257,"context_line":"        - ./tools/deployment/osh-infra-logging/060-fluent-logging.sh"},{"line_number":258,"context_line":"        - ./tools/deployment/osh-infra-logging/070-kibana.sh"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"- job:"},{"line_number":261,"context_line":"    name: openstack-helm-infra-aio-monitoring"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_f10a3bcf","line":258,"range":{"start_line":247,"start_character":18,"end_line":258,"end_character":60},"updated":"2018-10-10 09:54:54.000000000","message":"IMO this is very hard to follow, and would be simpler to follow by using convention over configuration using this: https://review.openstack.org/#/c/608750/ \n\nAs you could simply create a new job named (for example) openstack-helm-logging, and creating a logging folder in tools/deployment/ like you did (just making the folder name shorter), and it would automatically find the scripts in it.\n\nIt\u0027s also clearer to understand","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"475c3ffc4fce710b24ef606627c02648c90fff6c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":245,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":246,"context_line":"    vars:"},{"line_number":247,"context_line":"      gate_scripts:"},{"line_number":248,"context_line":"        - ./tools/deployment/osh-infra-logging/000-install-packages.sh"},{"line_number":249,"context_line":"        - ./tools/deployment/osh-infra-logging/005-deploy-k8s.sh"},{"line_number":250,"context_line":"        - ./tools/deployment/osh-infra-logging/010-ingress.sh"},{"line_number":251,"context_line":"        - ./tools/deployment/osh-infra-logging/020-ceph.sh"},{"line_number":252,"context_line":"        - ./tools/deployment/osh-infra-logging/025-ceph-ns-activate.sh"},{"line_number":253,"context_line":"        - ./tools/deployment/osh-infra-logging/030-radosgw-osh-infra.sh"},{"line_number":254,"context_line":"        - ./tools/deployment/osh-infra-logging/040-ldap.sh"},{"line_number":255,"context_line":"        - ./tools/deployment/osh-infra-logging/050-elasticsearch.sh"},{"line_number":256,"context_line":"        - ./tools/deployment/osh-infra-logging/055-elasticsearch-ldap.sh"},{"line_number":257,"context_line":"        - ./tools/deployment/osh-infra-logging/060-fluent-logging.sh"},{"line_number":258,"context_line":"        - ./tools/deployment/osh-infra-logging/070-kibana.sh"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"- job:"},{"line_number":261,"context_line":"    name: openstack-helm-infra-aio-monitoring"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_46bb300e","line":258,"range":{"start_line":247,"start_character":18,"end_line":258,"end_character":60},"in_reply_to":"3f79a3b5_f10a3bcf","updated":"2018-10-10 13:30:57.000000000","message":"I think this really ties in to the discussion we had with respect to approaching this with multiple steps. I agree with what you\u0027re saying, but I feel that should be part of the improvement work you\u0027re doing. The real goal with this change is to help make our single node jobs more reliable by ultimately reducing the number of services deployed by those jobs.","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":267,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":268,"context_line":"    vars:"},{"line_number":269,"context_line":"      gate_scripts:"},{"line_number":270,"context_line":"        - ./tools/deployment/osh-infra-monitoring/000-install-packages.sh"},{"line_number":271,"context_line":"        - ./tools/deployment/osh-infra-monitoring/005-deploy-k8s.sh"},{"line_number":272,"context_line":"        - ./tools/deployment/osh-infra-monitoring/010-deploy-docker-registry.sh"},{"line_number":273,"context_line":"        - ./tools/deployment/osh-infra-monitoring/020-ingress.sh"},{"line_number":274,"context_line":"        - ./tools/deployment/osh-infra-monitoring/030-nfs-provisioner.sh"},{"line_number":275,"context_line":"        - ./tools/deployment/osh-infra-monitoring/040-ldap.sh"},{"line_number":276,"context_line":"        - ./tools/deployment/osh-infra-monitoring/045-mariadb.sh"},{"line_number":277,"context_line":"        - ./tools/deployment/osh-infra-monitoring/050-prometheus.sh"},{"line_number":278,"context_line":"        - ./tools/deployment/osh-infra-monitoring/060-alertmanager.sh"},{"line_number":279,"context_line":"        - ./tools/deployment/osh-infra-monitoring/070-kube-state-metrics.sh"},{"line_number":280,"context_line":"        - ./tools/deployment/osh-infra-monitoring/080-node-exporter.sh"},{"line_number":281,"context_line":"        - ./tools/deployment/osh-infra-monitoring/090-process-exporter.sh"},{"line_number":282,"context_line":"        - ./tools/deployment/osh-infra-monitoring/100-grafana.sh"},{"line_number":283,"context_line":"        - ./tools/deployment/osh-infra-monitoring/110-nagios.sh"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"- job:"},{"line_number":286,"context_line":"    name: openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_d1effff7","line":283,"range":{"start_line":269,"start_character":15,"end_line":283,"end_character":63},"updated":"2018-10-10 09:54:54.000000000","message":"likewise for \"monitoring\"","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"475c3ffc4fce710b24ef606627c02648c90fff6c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    post-run: playbooks/osh-infra-collect-logs.yaml"},{"line_number":267,"context_line":"    nodeset: openstack-helm-single-node"},{"line_number":268,"context_line":"    vars:"},{"line_number":269,"context_line":"      gate_scripts:"},{"line_number":270,"context_line":"        - ./tools/deployment/osh-infra-monitoring/000-install-packages.sh"},{"line_number":271,"context_line":"        - ./tools/deployment/osh-infra-monitoring/005-deploy-k8s.sh"},{"line_number":272,"context_line":"        - ./tools/deployment/osh-infra-monitoring/010-deploy-docker-registry.sh"},{"line_number":273,"context_line":"        - ./tools/deployment/osh-infra-monitoring/020-ingress.sh"},{"line_number":274,"context_line":"        - ./tools/deployment/osh-infra-monitoring/030-nfs-provisioner.sh"},{"line_number":275,"context_line":"        - ./tools/deployment/osh-infra-monitoring/040-ldap.sh"},{"line_number":276,"context_line":"        - ./tools/deployment/osh-infra-monitoring/045-mariadb.sh"},{"line_number":277,"context_line":"        - ./tools/deployment/osh-infra-monitoring/050-prometheus.sh"},{"line_number":278,"context_line":"        - ./tools/deployment/osh-infra-monitoring/060-alertmanager.sh"},{"line_number":279,"context_line":"        - ./tools/deployment/osh-infra-monitoring/070-kube-state-metrics.sh"},{"line_number":280,"context_line":"        - ./tools/deployment/osh-infra-monitoring/080-node-exporter.sh"},{"line_number":281,"context_line":"        - ./tools/deployment/osh-infra-monitoring/090-process-exporter.sh"},{"line_number":282,"context_line":"        - ./tools/deployment/osh-infra-monitoring/100-grafana.sh"},{"line_number":283,"context_line":"        - ./tools/deployment/osh-infra-monitoring/110-nagios.sh"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"- job:"},{"line_number":286,"context_line":"    name: openstack-helm-infra-openstack-support"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_263634b5","line":283,"range":{"start_line":269,"start_character":15,"end_line":283,"end_character":63},"in_reply_to":"3f79a3b5_d1effff7","updated":"2018-10-10 13:30:57.000000000","message":"See above","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"}],"doc/source/install/multinode.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[{"line_number":79,"context_line":".. code-block:: shell"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  ./tools/deployment/multinode/045-mariadb.sh"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Deploy Prometheus"},{"line_number":84,"context_line":"^^^^^^^^^^^^^^^^^"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_71ecebf3","line":82,"updated":"2018-10-10 09:54:54.000000000","message":"Starting from this, shouldn\u0027t we have a different profile?","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"}],"playbooks/osh-infra-multinode-deploy.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f79a3b5_b1cb6371","updated":"2018-10-10 09:54:54.000000000","message":"I am confused about the purpose of this...","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"475c3ffc4fce710b24ef606627c02648c90fff6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f79a3b5_465010d6","in_reply_to":"3f79a3b5_b1cb6371","updated":"2018-10-10 13:30:57.000000000","message":"This is ultimately not needed, as it was missed after rebasing on the change merged yesterday that introduced the basic script runner playbook.","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_91c0a74c","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":44},"updated":"2018-10-10 09:54:54.000000000","message":"copyright is incorrect, and should be 2018 AT\u0026T.","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"}],"playbooks/osh-infra-openstack-support.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cd90f18cdd1caac57890f7bc37e6db48a9f9965f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_0ca48006","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":44},"updated":"2018-10-10 09:54:54.000000000","message":"Could you update to 2018 AT\u0026T?","commit_id":"c2e2724e4d28eea33bfd1fedded67234b3456aba"}],"tools/deployment/openstack-support/010-rabbitmq.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9bb5ecb8ba629d8e745775d7ed84c0f720f9706b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install rabbitmq ./rabbitmq \\"},{"line_number":25,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"    --set pod.replicas.server\u003d1 \\"},{"line_number":27,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":28,"context_line":"    ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":29,"context_line":"    ${OSH_EXTRA_HELM_ARGS_RABBITMQ}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":20,"id":"3f79a3b5_0eece625","line":27,"updated":"2018-10-17 03:00:21.000000000","message":"why would we want to do this? without a volume backing rabbitmq it would not store users etc on restart.","commit_id":"9a560fd5d5d8e64ccf141b6649049dcd83e57011"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1a7cd9682380d7f103cfc60c29d592b83a2527cf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"helm upgrade --install rabbitmq ./rabbitmq \\"},{"line_number":25,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":26,"context_line":"    --set pod.replicas.server\u003d1 \\"},{"line_number":27,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":28,"context_line":"    ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":29,"context_line":"    ${OSH_EXTRA_HELM_ARGS_RABBITMQ}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":20,"id":"3f79a3b5_ee9aca5d","line":27,"in_reply_to":"3f79a3b5_0eece625","updated":"2018-10-17 03:27:22.000000000","message":"As we’re not really doing much beyond just deploying rabbitmq here to verify the charts working as intended, I’d say that’s fine here. As the keystone-auth gates already checking rabbitmq backed with storage, I don’t necessarily think we need to do it again here just for the sake of doing so if our ultimate goal is to reduce what we’re deploying across jobs (omitting storage here, for example)","commit_id":"9a560fd5d5d8e64ccf141b6649049dcd83e57011"}],"tools/deployment/openstack-support/030-rabbitmq.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e85e021b18d5433e7f10640ede74816af6c96eee","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":"helm upgrade --install rabbitmq ./rabbitmq \\"},{"line_number":25,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":26,"context_line":"    --set pod.replicas.server\u003d1 \\"},{"line_number":27,"context_line":"    ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":28,"context_line":"    ${OSH_EXTRA_HELM_ARGS_RABBITMQ}"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3f79a3b5_4b084924","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":25},"updated":"2018-10-19 16:53:11.000000000","message":"this is the wrong namespace, it should be \u0027openstack\u0027","commit_id":"2479f72a5a0c26563bd5ef6134ecf271ef33b062"}],"tools/deployment/openstack-support/040-memcached.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e85e021b18d5433e7f10640ede74816af6c96eee","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":24,"context_line":"helm upgrade --install memcached ./memcached \\"},{"line_number":25,"context_line":"    --namespace\u003dosh-infra \\"},{"line_number":26,"context_line":"    ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":27,"context_line":"    ${OSH_EXTRA_HELM_ARGS_MEMCACHED}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3f79a3b5_ab223da5","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":24},"updated":"2018-10-19 16:53:11.000000000","message":"this should be \u0027openstack\u0027","commit_id":"2479f72a5a0c26563bd5ef6134ecf271ef33b062"}],"tools/deployment/openstack-support/050-libvirt.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e85e021b18d5433e7f10640ede74816af6c96eee","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#NOTE: Deploy command"},{"line_number":22,"context_line":"helm upgrade --install libvirt ./libvirt \\"},{"line_number":23,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":24,"context_line":"  --set network.backend\u003d\"null\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Validate Deployment info"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3f79a3b5_8b1f4159","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":23},"updated":"2018-10-19 16:53:11.000000000","message":"this should be \u0027openstack\u0027","commit_id":"2479f72a5a0c26563bd5ef6134ecf271ef33b062"}],"tools/deployment/openstack-support/060-openvswitch.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e85e021b18d5433e7f10640ede74816af6c96eee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#NOTE: Deploy command"},{"line_number":19,"context_line":"helm upgrade --install openvswitch ./openvswitch \\"},{"line_number":20,"context_line":"  --namespace\u003dosh-infra \\"},{"line_number":21,"context_line":"  ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":22,"context_line":"  ${OSH_EXTRA_HELM_ARGS_OPENVSWITCH}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3f79a3b5_ab479d52","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":23},"updated":"2018-10-19 16:53:11.000000000","message":"this should be \u0027openstack\u0027","commit_id":"2479f72a5a0c26563bd5ef6134ecf271ef33b062"}]}